GNU bug report logs - #54323
[PATCH] Add font-google-roboto-mono

Previous Next

To reply to this bug, email your comments to 54323 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: remimimimi <valent.xarin <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add font-google-roboto-mono
Date: Thu, 10 Mar 2022 00:02:14 +0300

[Message part 1 (text/plain, inline)]

[Message part 2 (text/html, inline)]

[0001-gnu-Add-font-google-roboto-mono.patch (text/x-patch, attachment)]

Message #8 received at 54323 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 54323 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add font-google-roboto-mono
Date: Fri, 11 Mar 2022 15:57:57 +0100

[Message part 1 (text/plain, inline)]

Hi,

Thanks for working on this patch.

Note that I'm not a Guix maintainer (I only managed to send some patches
and get them accepted), but I've seen several things to fix in this
patch and I've also some questions:
- You used 'license:asl2.0' as the license, while looking rapidly at
  the source I didn't find any license. Do you know where the license
  is stated in the font source code?
- If you really want to fix font-adobe-source-code-pro and font-dseg
  code style, it should be done in one or two separate patches. Two
  patches are probably easier for maintainers to review.
- I've also noticed that this patch lacks any commit message details.
  Something like that should work:
    gnu: Add font-google-roboto-mono
    
    * gnu/packages/fonts.scm (font-google-roboto-mono): New variable.

Also there may or may not be additional issues as I've only looked at
it rapidly.

Denis.

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 54323 <at> debbugs.gnu.org (full text, mbox):

From: remimimimi <valent.xarin <at> gmail.com>
To: 54323 <at> debbugs.gnu.org, GNUtoo <at> cyberdimension.org
Date: Fri, 18 Mar 2022 17:03:50 +0300

[Message part 1 (text/plain, inline)]

Hello, sorry for the late response.

About the license, I saw it at
https://fonts.google.com/specimen/Roboto#license and
https://en.wikipedia.org/wiki/Roboto that license is Apache 2.0. I just
feel more confident about downloading these fonts from github than from
google fonts. Should I download from google fonts because repo has no
license?

I ran auto-format the file and didn't notice any changes, I'll remove it in
the next patch version with all your proposed fixes.

[Message part 2 (text/html, inline)]

Message #14 received at 54323 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: remimimimi <valent.xarin <at> gmail.com>
Cc: 54323 <at> debbugs.gnu.org, GNUtoo <at> cyberdimension.org
Subject: Re: [bug#54323]
Date: Sun, 09 Mar 2025 21:24:25 +0100

Hello,

remimimimi <valent.xarin <at> gmail.com> writes:

> Hello, sorry for the late response.

And sorry for my very late answer!

> About the license, I saw it at
> https://fonts.google.com/specimen/Roboto#license and
> https://en.wikipedia.org/wiki/Roboto that license is Apache 2.0. I just
> feel more confident about downloading these fonts from github than from
> google fonts. Should I download from google fonts because repo has no
> license?

The repository <https://github.com/googlefonts/RobotoMono> now contains
a license (Apache 2.0, unsurprisingly).
>
> I ran auto-format the file and didn't notice any changes, I'll remove it in
> the next patch version with all your proposed fixes.

The description should be much shorter, such as:

  "Roboto Mono is a monospaced addition to the Roboto type family.  Like
the other members of the Roboto family, the fonts are optimized for
readability on screens across a wide variety of devices and reading
environments."

I wonder about the version. How do you know it is 2.136? I don’t see any
reference to that number in the repository.

Also, the commit hash should be let bound around the package.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.