GNU bug report logs - #54307
[PATCH 0/2] Highlight headings showing what to build/download

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Wed, 9 Mar 2022 09:58:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#54307: closed ([PATCH 0/2] Highlight headings showing what to
 build/download)
Date: Fri, 18 Mar 2022 15:11:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 18 Mar 2022 16:10:34 +0100
with message-id <87sfrfpa8l.fsf <at> gnu.org>
and subject line Re: bug#54307: [PATCH 0/2] Highlight headings showing what to build/download
has caused the debbugs.gnu.org bug report #54307,
regarding [PATCH 0/2] Highlight headings showing what to build/download
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
54307: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54307
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH 0/2] Highlight headings showing what to build/download
Date: Wed,  9 Mar 2022 10:57:10 +0100
Hello Guix!

These patches color headings in the output of ‘show-what-to-build’:

  The following derivations will be built:

is now printed in bold magenta, and:

  X MB will be downloaded:

is printed in bold (this message is only visible at ‘-v2’.)

The reason it wasn’t done before is that it invalidates translations.
I think now is a good time as we prepare a release.

Julien, Maxim: WDYT?

Ludo’.

Ludovic Courtès (2):
  ui: 'show-what-to-build' highlights "The following [...] will be
    built".
  ui: 'show-what-to-build' highlights "would be downloaded" headings.

 guix/colors.scm |  4 +-
 guix/ui.scm     | 98 +++++++++++++++++++++++++++++--------------------
 2 files changed, 61 insertions(+), 41 deletions(-)


base-commit: 0d14f8a8702ec8016ac58e5778a754b3105ef418
-- 
2.34.0



[Message part 3 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: 54307-done <at> debbugs.gnu.org
Cc: Julien Lepiller <julien <at> lepiller.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: bug#54307: [PATCH 0/2] Highlight headings showing what to
 build/download
Date: Fri, 18 Mar 2022 16:10:34 +0100
Hi!

Ludovic Courtès <ludo <at> gnu.org> skribis:

>   ui: 'show-what-to-build' highlights "The following [...] will be
>     built".
>   ui: 'show-what-to-build' highlights "would be downloaded" headings.

I went ahead and pushed these as
625fa3cfe8c57cd5624608d2478c8c6be4c69c3b.

Of course we can still discuss color and name choices :-).  The
important part for me was to put the base in place so translations can
be updated before the release.

Ludo’.


This bug report was last modified 3 years and 65 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.