From unknown Fri Jun 20 07:15:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54307 <54307@debbugs.gnu.org> To: bug#54307 <54307@debbugs.gnu.org> Subject: Status: [PATCH 0/2] Highlight headings showing what to build/download Reply-To: bug#54307 <54307@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:15:32 +0000 retitle 54307 [PATCH 0/2] Highlight headings showing what to build/download reassign 54307 guix-patches submitter 54307 Ludovic Court=C3=A8s severity 54307 normal tag 54307 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 09 04:57:21 2022 Received: (at submit) by debbugs.gnu.org; 9 Mar 2022 09:57:21 +0000 Received: from localhost ([127.0.0.1]:58567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRt4L-0002rz-3a for submit@debbugs.gnu.org; Wed, 09 Mar 2022 04:57:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:42524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRt4J-0002rs-Kw for submit@debbugs.gnu.org; Wed, 09 Mar 2022 04:57:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRt4J-0001OF-CH for guix-patches@gnu.org; Wed, 09 Mar 2022 04:57:19 -0500 Received: from [2001:470:142:3::e] (port=32788 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRt4I-0002AK-Nk; Wed, 09 Mar 2022 04:57:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=6x3I07GR/9BfkBQZwRw7PZ4bTmHYEndTEPWZ9NJp22k=; b=ha5IjjxC78p2cX GNUiYWBhESKP75Bk+2G3QQGhy6zA9vEpCn9rcQsWMd+Yj/jhjW7SMiePZrnWvH3RJMelklJVEJdlL NJ1k41u3Gl4ZwEZ/aH8nRri3ebWoYGWHNeo17ynco5VfmF3oMNjVGc3zEhvqud5c7pgpOtdfeAkSm ENsbdA7J6NUd1kyPPgMLMQaQeNHnt8jXRI4Mmkdm9lDcAZnrmWg2KfvK9d/pR+40e+gQSnMhIP9S3 cIrOvXSxBhjRlbS16bsntiS3wfh8zJSdF2xVx5E+TqeJHsUHx8F95d+VLRuCGClXgfjpo8KcJuoVb yZoh/3vMQpT/KHQyxtag==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:57543 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRt4I-0004oz-38; Wed, 09 Mar 2022 04:57:18 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/2] Highlight headings showing what to build/download Date: Wed, 9 Mar 2022 10:57:10 +0100 Message-Id: <20220309095710.23849-1-ludo@gnu.org> X-Mailer: git-send-email 2.34.0 X-Debbugs-Cc: Julien Lepiller , Maxim Cournoyer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Guix! These patches color headings in the output of ‘show-what-to-build’: The following derivations will be built: is now printed in bold magenta, and: X MB will be downloaded: is printed in bold (this message is only visible at ‘-v2’.) The reason it wasn’t done before is that it invalidates translations. I think now is a good time as we prepare a release. Julien, Maxim: WDYT? Ludo’. Ludovic Courtès (2): ui: 'show-what-to-build' highlights "The following [...] will be built". ui: 'show-what-to-build' highlights "would be downloaded" headings. guix/colors.scm | 4 +- guix/ui.scm | 98 +++++++++++++++++++++++++++++-------------------- 2 files changed, 61 insertions(+), 41 deletions(-) base-commit: 0d14f8a8702ec8016ac58e5778a754b3105ef418 -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 09 05:12:58 2022 Received: (at 54307) by debbugs.gnu.org; 9 Mar 2022 10:12:58 +0000 Received: from localhost ([127.0.0.1]:58600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRtJS-0003Iu-D9 for submit@debbugs.gnu.org; Wed, 09 Mar 2022 05:12:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRtJQ-0003IZ-Ua for 54307@debbugs.gnu.org; Wed, 09 Mar 2022 05:12:57 -0500 Received: from [2001:470:142:3::e] (port=32936 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRtJG-0004m5-0I; Wed, 09 Mar 2022 05:12:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=U6C2aisN+Ks3fFBlQfyCGHmpRXc+AmhnMajhgo/Q3bA=; b=T/yTVguf3Rp1aCkJKCEO zjUou6P2EB0+DpXWxf0QJ/sFvTPg+MmQZ9L0yGu6+FqjcZv2IyHKp2bFK3Xrmmen9p8AYe3yecz7C qRESuCtB1DOWlFAk83X2eVkKdk8n29JcVL+O+MifKWlEwt+jr+S3pc4i2GDNzfjaAsHfc/x/wrkoh OtYjypLU5PCBfrLdPl3YbYxYg028GcykTL3HZtPgausgo2YwBK4aAJniFk0sWsWR/8WoZAH3p2XdI 1vgwxl9tVThdCfW7p+qUAa9yhOIx7IQDi7DsgHn3ivU3XCwyx/yA1KqL5yo0vAgvAwvNjqNvyIqg1 U/h5t0KSi5r2Cw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:52476 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRtJE-0002ig-PZ; Wed, 09 Mar 2022 05:12:44 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 54307@debbugs.gnu.org Subject: [PATCH 2/2] ui: 'show-what-to-build' highlights "would be downloaded" headings. Date: Wed, 9 Mar 2022 11:12:34 +0100 Message-Id: <20220309101234.24236-2-ludo@gnu.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20220309101234.24236-1-ludo@gnu.org> References: <20220309101234.24236-1-ludo@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54307 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/ui.scm (show-what-to-build): Highlight "X MB would be downloaded". --- guix/ui.scm | 74 +++++++++++++++++++++++++++++++---------------------- 1 file changed, 44 insertions(+), 30 deletions(-) diff --git a/guix/ui.scm b/guix/ui.scm index 8e4e3e2dfc..6c194eb3c9 100644 --- a/guix/ui.scm +++ b/guix/ui.scm @@ -1041,21 +1041,28 @@ (define display-download-size? (map colorized-store-item build))) (cond ((>= verbosity 2) (if display-download-size? - (format (current-error-port) - ;; TRANSLATORS: "MB" is for "megabyte"; it should be - ;; translated to the corresponding abbreviation. - (G_ "~:[~,1h MB would be downloaded:~%~{ ~a~%~}~;~]") - (null? download) - download-size - (map (compose colorized-store-item substitutable-path) - download)) - (format (current-error-port) - (N_ "~:[The following file would be downloaded:~%~{ ~a~%~}~;~]" - "~:[The following files would be downloaded:~%~{ ~a~%~}~;~]" - (length download)) - (null? download) - (map (compose colorized-store-item substitutable-path) - download))) + (begin + (format (current-error-port) + (highlight + ;; TRANSLATORS: "MB" is for "megabyte"; it + ;; should be translated to the corresponding + ;; abbreviation. + (G_ "~:[~,1h MB would be downloaded:~%~;~]")) + (null? download) + download-size) + (format (current-error-port) "~{ ~a~%~}" + (map (compose colorized-store-item substitutable-path) + download))) + (begin + (format (current-error-port) + (highlight + (N_ "~:[The following file would be downloaded:~%~;~]" + "~:[The following files would be downloaded:~%~;~]" + (length download))) + (null? download)) + (format (current-error-port) "~{ ~a~%~}" + (map (compose colorized-store-item substitutable-path) + download)))) (format (current-error-port) (N_ "~:[The following graft would be made:~%~{ ~a~%~}~;~]" "~:[The following grafts would be made:~%~{ ~a~%~}~;~]" @@ -1094,21 +1101,28 @@ (define display-download-size? (map colorized-store-item build))) (cond ((>= verbosity 2) (if display-download-size? - (format (current-error-port) - ;; TRANSLATORS: "MB" is for "megabyte"; it should be - ;; translated to the corresponding abbreviation. - (G_ "~:[~,1h MB will be downloaded:~%~{ ~a~%~}~;~]") - (null? download) - download-size - (map (compose colorized-store-item substitutable-path) - download)) - (format (current-error-port) - (N_ "~:[The following file will be downloaded:~%~{ ~a~%~}~;~]" - "~:[The following files will be downloaded:~%~{ ~a~%~}~;~]" - (length download)) - (null? download) - (map (compose colorized-store-item substitutable-path) - download))) + (begin + (format (current-error-port) + (highlight + ;; TRANSLATORS: "MB" is for "megabyte"; it + ;; should be translated to the corresponding + ;; abbreviation. + (G_ "~:[~,1h MB will be downloaded:~%~;~]")) + (null? download) + download-size) + (format (current-error-port) "~{ ~a~%~}" + (map (compose colorized-store-item substitutable-path) + download))) + (begin + (format (current-error-port) + (highlight + (N_ "~:[The following file will be downloaded:~%~;~]" + "~:[The following files will be downloaded:~%~;~]" + (length download))) + (null? download)) + (format (current-error-port) "~{ ~a~%~}" + (map (compose colorized-store-item substitutable-path) + download)))) (format (current-error-port) (N_ "~:[The following graft will be made:~%~{ ~a~%~}~;~]" "~:[The following grafts will be made:~%~{ ~a~%~}~;~]" -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 09 05:12:59 2022 Received: (at 54307) by debbugs.gnu.org; 9 Mar 2022 10:12:59 +0000 Received: from localhost ([127.0.0.1]:58602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRtJS-0003Iy-P6 for submit@debbugs.gnu.org; Wed, 09 Mar 2022 05:12:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRtJR-0003Ib-Ab for 54307@debbugs.gnu.org; Wed, 09 Mar 2022 05:12:57 -0500 Received: from [2001:470:142:3::e] (port=32932 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRtJE-0004m4-Jn; Wed, 09 Mar 2022 05:12:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=zLKmOcRNgq0GU66wHrUunL3zB81/QytRUfVTX/Y5AbI=; b=C5dUoJPBTqa4Se CoB9QPK+f1Zi+F7hmb48vEFfjUqUc4O4A9hqcEX3o2HX+5PKBVtNFbOT1weNysxzPA5a8xmwR4IMF NJnJty0eFQALHF/AJgRE7VP31JX04Y/RsHL+azrmjKzK9D3XiFh00N9TDQgwFNnUYQz1RbkmdSgXU tyKJbdn6Ql8KbxLQorIVmwynaOKewJgqc+lPRoAYWEiOyH/YQ0cffxRDZp7e6aeWW3IKxrec3TfG0 5uosHDpSNe+cyjtLEcVZh7wRUTbjpCj2xi1/a9fUtXiFHcsYaM4yfuJ+KFS4K+EmwgP6tDS9+Kgk8 1kh5ehohYUaOsImUMBVQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:52476 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRtJ9-0002ig-SU; Wed, 09 Mar 2022 05:12:41 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 54307@debbugs.gnu.org Subject: [PATCH 1/2] ui: 'show-what-to-build' highlights "The following [...] will be built". Date: Wed, 9 Mar 2022 11:12:33 +0100 Message-Id: <20220309101234.24236-1-ludo@gnu.org> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54307 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/colors.scm (highlight/warn): New procedure. * guix/ui.scm (show-what-to-build): Use 'highlight/warn' when displaying what would/will be built. --- guix/colors.scm | 4 +++- guix/ui.scm | 24 ++++++++++++++---------- 2 files changed, 17 insertions(+), 11 deletions(-) diff --git a/guix/colors.scm b/guix/colors.scm index 3031f54799..ae0a583d94 100644 --- a/guix/colors.scm +++ b/guix/colors.scm @@ -2,7 +2,7 @@ ;;; Copyright © 2013, 2014 Free Software Foundation, Inc. ;;; Copyright © 2018 Sahithi Yarlagadda ;;; Copyright © 2018 Ricardo Wurmus -;;; Copyright © 2017, 2018, 2019 Ludovic Courtès +;;; Copyright © 2017, 2018, 2019, 2022 Ludovic Courtès ;;; ;;; This file is part of GNU Guix. ;;; @@ -31,6 +31,7 @@ (define-module (guix colors) colorize-string highlight + highlight/warn dim color-rules @@ -143,6 +144,7 @@ (define (coloring-procedure color) str))) (define highlight (coloring-procedure (color BOLD))) +(define highlight/warn (coloring-procedure (color BOLD MAGENTA))) (define dim (coloring-procedure (color DARK))) (define (colorize-matches rules) diff --git a/guix/ui.scm b/guix/ui.scm index 238952723e..8e4e3e2dfc 100644 --- a/guix/ui.scm +++ b/guix/ui.scm @@ -1031,12 +1031,14 @@ (define display-download-size? ;; Unfortunately, this is hardly avoidable for proper i18n. (if dry-run? (begin - (unless (zero? verbosity) + (unless (or (zero? verbosity) (null? build)) (format (current-error-port) - (N_ "~:[The following derivation would be built:~%~{ ~a~%~}~;~]" - "~:[The following derivations would be built:~%~{ ~a~%~}~;~]" - (length build)) - (null? build) (map colorized-store-item build))) + (highlight/warn + (N_ "The following derivation would be built:~%" + "The following derivations would be built:~%" + (length build)))) + (format (current-error-port) "~{ ~a~%~}" + (map colorized-store-item build))) (cond ((>= verbosity 2) (if display-download-size? (format (current-error-port) @@ -1082,12 +1084,14 @@ (define display-download-size? (null? download) (length download)))))) (begin - (unless (zero? verbosity) + (unless (or (zero? verbosity) (null? build)) (format (current-error-port) - (N_ "~:[The following derivation will be built:~%~{ ~a~%~}~;~]" - "~:[The following derivations will be built:~%~{ ~a~%~}~;~]" - (length build)) - (null? build) (map colorized-store-item build))) + (highlight/warn + (N_ "The following derivation will be built:~%" + "The following derivations will be built:~%" + (length build)))) + (format (current-error-port) "~{ ~a~%~}" + (map colorized-store-item build))) (cond ((>= verbosity 2) (if display-download-size? (format (current-error-port) -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 09 05:52:54 2022 Received: (at 54307) by debbugs.gnu.org; 9 Mar 2022 10:52:54 +0000 Received: from localhost ([127.0.0.1]:58670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRtw5-0004ON-TZ for submit@debbugs.gnu.org; Wed, 09 Mar 2022 05:52:54 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:37806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRtw4-0004OE-Er for 54307@debbugs.gnu.org; Wed, 09 Mar 2022 05:52:53 -0500 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4KD8DJ6qbFz3wWT; Wed, 9 Mar 2022 11:52:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1646823169; bh=ndYvJTVKdXzOoV9/11mKIZexg3128k0UY1W5HMlXYhw=; h=Subject:From:To:Date:In-Reply-To:References; b=s8uskaUNC+hWoMW1uIY53jPt5bMkUNM4nViXW3FsJ71Ct3NhePe94xJG7iC6B7BhE H/FmOozbqnJYU5ctmzkcdoRuUv0z0kx4tDSk3kX0rSJxvPJb9f54WBDIM9pmYHcbni Rv2GzYBSCvSMwfHxTfXWr54x9jYXLxLipy+wgX/c= Message-ID: <14d71f279ec542fb8fb5557934b6d6ae7f7792b3.camel@ist.tugraz.at> Subject: Re: [PATCH 1/2] ui: 'show-what-to-build' highlights "The following [...] will be built". From: Liliana Marie Prikler To: Ludovic =?ISO-8859-1?Q?Court=E8s?= , 54307@debbugs.gnu.org Date: Wed, 09 Mar 2022 11:52:48 +0100 In-Reply-To: <20220309101234.24236-1-ludo@gnu.org> References: <20220309101234.24236-1-ludo@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54307 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Mittwoch, dem 09.03.2022 um 11:12 +0100 schrieb Ludovic Courtès: > * guix/colors.scm (highlight/warn): New procedure. > * guix/ui.scm (show-what-to-build): Use 'highlight/warn' when > displaying > what would/will be built. highlight/warn sounds somewhat misleading for this use-case. Should this be highlight/info instead? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 10 05:19:21 2022 Received: (at 54307) by debbugs.gnu.org; 10 Mar 2022 10:19:21 +0000 Received: from localhost ([127.0.0.1]:33321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSFtB-0003pM-4V for submit@debbugs.gnu.org; Thu, 10 Mar 2022 05:19:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSFt9-0003p7-BP for 54307@debbugs.gnu.org; Thu, 10 Mar 2022 05:19:19 -0500 Received: from [2001:470:142:3::e] (port=53518 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSFt3-0004TU-2B; Thu, 10 Mar 2022 05:19:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=g4/EUIk8XVo5Gf3E4NLt7z8alCjesJ+kVhUByDIqsTo=; b=OWHJRWbNtRf46KxmzcgS CsG0jo3y89TKTpVYRuRoDBgwUcdslI0LiMwsdxW2drCZwHL2NI5MwkTNCPHNAj5mYOoRuPoZG87QY HlGp/JNKdX7ji3K6szHWrG3+r011rPlmL/Nc5Pt32cxx7OSZs5MPlsKe3B5BXMo4TVdlDr/oI1PEP /bzzkJjGybishnFu/rH+1pKp5h0VWbywQU/f2VWZSJAMSAvIxjipehGrL4gtMFTqwFCwP2vrKpEx5 Uc5aRcqS8Qx0xErgIUqSkTmvkBW0gq6aIrLvPB+nQjsSorLGw9zXo0H3AKoVP8tK/fcNsS/GJ3B9o KcRakLAEcSTS/Q==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:57799 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSFt2-0001mV-K6; Thu, 10 Mar 2022 05:19:12 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Liliana Marie Prikler Subject: Re: bug#54307: [PATCH 0/2] Highlight headings showing what to build/download References: <20220309101234.24236-1-ludo@gnu.org> <14d71f279ec542fb8fb5557934b6d6ae7f7792b3.camel@ist.tugraz.at> Date: Thu, 10 Mar 2022 11:19:10 +0100 In-Reply-To: <14d71f279ec542fb8fb5557934b6d6ae7f7792b3.camel@ist.tugraz.at> (Liliana Marie Prikler's message of "Wed, 09 Mar 2022 11:52:48 +0100") Message-ID: <87mthyyush.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54307 Cc: 54307@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Liliana Marie Prikler skribis: > Am Mittwoch, dem 09.03.2022 um 11:12 +0100 schrieb Ludovic Court=C3=A8s: >> * guix/colors.scm (highlight/warn): New procedure. >> * guix/ui.scm (show-what-to-build): Use 'highlight/warn' when >> displaying >> what would/will be built. > highlight/warn sounds somewhat misleading for this use-case. Should > this be highlight/info instead? I agree =E2=80=9Cwarn=E2=80=9D is misleading, but I don=E2=80=99t find =E2= =80=9Cinfo=E2=80=9D any clearer. :-) Maybe =E2=80=98highlight-more=E2=80=99 or something? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 10 05:46:19 2022 Received: (at 54307) by debbugs.gnu.org; 10 Mar 2022 10:46:19 +0000 Received: from localhost ([127.0.0.1]:33426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSGJH-0004cL-78 for submit@debbugs.gnu.org; Thu, 10 Mar 2022 05:46:19 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:42751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSGJE-0004cA-Og for 54307@debbugs.gnu.org; Thu, 10 Mar 2022 05:46:17 -0500 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4KDm2F2b63z1LZW9; Thu, 10 Mar 2022 11:46:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4KDm2F2b63z1LZW9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1646909173; bh=sukwdfJTCRj30AbpH4QsAvXURz3n2fRoc0AZInvoM2c=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=HFG9zv06BrF14DQ0GxA+c9lGfYY2j8Cmb9d+ghtQ6RsxcPNWp1oj0mJQ2DcdES3sp Nul/MHWlZfHTn7Boj5ojS0JkVv9fFPO7m6qFO+8REdyM1hdAKc6Qi6K+SERVR5WYr4 ZagWq4voWMxtS6I5bVqxudV7HJlbonvbwLdXEjWk= Message-ID: Subject: Re: bug#54307: [PATCH 0/2] Highlight headings showing what to build/download From: Liliana Marie Prikler To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Date: Thu, 10 Mar 2022 11:46:12 +0100 In-Reply-To: <87mthyyush.fsf_-_@gnu.org> References: <20220309101234.24236-1-ludo@gnu.org> <14d71f279ec542fb8fb5557934b6d6ae7f7792b3.camel@ist.tugraz.at> <87mthyyush.fsf_-_@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54307 Cc: 54307@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Donnerstag, dem 10.03.2022 um 11:19 +0100 schrieb Ludovic Courtès: > Hi, > > Liliana Marie Prikler skribis: > > > Am Mittwoch, dem 09.03.2022 um 11:12 +0100 schrieb Ludovic Courtès: > > > * guix/colors.scm (highlight/warn): New procedure. > > > * guix/ui.scm (show-what-to-build): Use 'highlight/warn' when > > > displaying > > > what would/will be built. > > highlight/warn sounds somewhat misleading for this use-case.  > > Should > > this be highlight/info instead? > > I agree “warn” is misleading, but I don’t find “info” any clearer.  > :-) > > Maybe ‘highlight-more’ or something? Highlight more than what? Looking at (guix diagnostics) we currently have merely bold for info, bold magenta for warning and bold red for error. On a related note, (guix diagnostics) appears a little over- engineered; it's mostly there to highlight the diagnostic prefix, but it would also highlight any other non-whitespace argument... is that really useful? Anyway, I would suggest using a less "offensive" colour to indicate how much is being downloaded/built. Using red or magenta in this case would signal an error when that's actually the expected behaviour. My personal colouring bias would tend towards cyan or green here, although green itself is already used to signal success and might not be a good idea either. While highlight/info on its own really doesn't make sense, it'd make more sense if we also defined %warning-color, %info-color, %error-color in colors and simply used them in diagnostics rather than the other way round and also defined highlight/warning and highlight/error to complete the pattern. Once we figure out what we want to do with the diagnostics, we could even drop them from the exports if the coloring procedures can be used in their stead. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 13 18:01:06 2022 Received: (at 54307) by debbugs.gnu.org; 13 Mar 2022 22:01:06 +0000 Received: from localhost ([127.0.0.1]:43477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTWGv-00080L-9v for submit@debbugs.gnu.org; Sun, 13 Mar 2022 18:01:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTWGf-0007zU-Dh for 54307@debbugs.gnu.org; Sun, 13 Mar 2022 18:01:04 -0400 Received: from [2001:470:142:3::e] (port=34882 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTWGY-00088u-Rt; Sun, 13 Mar 2022 18:00:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=sutjrCpZwtblJMr2OgpGW4Nh+MMTiblLcitzVD0gWWI=; b=JZXNeKvNq2w6H9Lvp06s CCH0Du+aa1xjucqQHVWTWzvQGvox+FPLDGRuQ9XELcLn3B/MU0B8fhZuCKVDrjc7Xb3sJPyyF20N9 sESbKHAi6IUkJjb6ikrmBwEh0y7BkRRlHJHh0jdgoXumAbXfiCHaGXO+o1gex3sYiXofAEBxzUlkT PB63hA5aJzF0Bur9O+/fP6L5xiSdsaMcKRROuLJ6NRNbCZULMPTwtv0vhDpJqNJbzyFEg2O75vTw9 tMiZpOK3UFMnMs/35IRUCCiDX02jCxwzhRv5APt8UnI1zvO6GRbkbgb3rYu6iVNBGfm/9/sO4/QKI pZJbkgCxQaXWJA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:57671 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTWGY-0004PM-Ee; Sun, 13 Mar 2022 18:00:42 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Liliana Marie Prikler Subject: Re: bug#54307: [PATCH 0/2] Highlight headings showing what to build/download References: <20220309101234.24236-1-ludo@gnu.org> <14d71f279ec542fb8fb5557934b6d6ae7f7792b3.camel@ist.tugraz.at> <87mthyyush.fsf_-_@gnu.org> Date: Sun, 13 Mar 2022 23:00:39 +0100 In-Reply-To: (Liliana Marie Prikler's message of "Thu, 10 Mar 2022 11:46:12 +0100") Message-ID: <878rtdtsvs.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54307 Cc: 54307@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Liliana Marie Prikler skribis: > Am Donnerstag, dem 10.03.2022 um 11:19 +0100 schrieb Ludovic Court=C3=A8s: >> Hi, >>=20 >> Liliana Marie Prikler skribis: >>=20 >> > Am Mittwoch, dem 09.03.2022 um 11:12 +0100 schrieb Ludovic Court=C3=A8= s: >> > > * guix/colors.scm (highlight/warn): New procedure. >> > > * guix/ui.scm (show-what-to-build): Use 'highlight/warn' when >> > > displaying >> > > what would/will be built. >> > highlight/warn sounds somewhat misleading for this use-case.=C2=A0 >> > Should >> > this be highlight/info instead? >>=20 >> I agree =E2=80=9Cwarn=E2=80=9D is misleading, but I don=E2=80=99t find = =E2=80=9Cinfo=E2=80=9D any clearer.=C2=A0 >> :-) >>=20 >> Maybe =E2=80=98highlight-more=E2=80=99 or something? > Highlight more than what? More than just bold; the goal is to make =E2=80=9CThe following derivations= will be built=E2=80=9D more prominent. [...] > Anyway, I would suggest using a less "offensive" colour to indicate how > much is being downloaded/built. What=E2=80=99s downloaded is still being displayed as bold with the default color (black or white). The only thing that changes colors is the sentence above. Thing is we have few colors at hand (see (guix colors)) and we need one that works well both with a white and with a dark background. So=E2=80=A6 So far magenta is used for warnings, which is consistent with the intent here. WDYT? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 18 11:10:45 2022 Received: (at 54307-done) by debbugs.gnu.org; 18 Mar 2022 15:10:45 +0000 Received: from localhost ([127.0.0.1]:58083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVEFZ-00080E-6N for submit@debbugs.gnu.org; Fri, 18 Mar 2022 11:10:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVEFX-0007zz-QS for 54307-done@debbugs.gnu.org; Fri, 18 Mar 2022 11:10:44 -0400 Received: from [2001:470:142:3::e] (port=49810 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVEFR-0003aS-Th; Fri, 18 Mar 2022 11:10:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Q8IlPx5S6b3mzkWR7RDhMECRT/y+sAxQCiHfqXGMZSU=; b=sdJcN/geFtl5C1o2h6M7 NjYz9n9gwo9EdTcFMesIV/5gkYftPp2kiANodRXFuAXHu1njt+VYpBs7/w43nUIwtJBpAl4Xprz65 o8nIhCfonrMYfHs18XXjV8ngsWKuvWTeOREs6XIqoER7rrghcBd089KWyHCZtJ5ep85llFRQM4veQ tk3woS9Mk+R8lKWFkTsPaxRexxtRwAhu8Bmg5UMMVRxYDFkR6XSWoMS1cdNHsyw3n7cqV7Dsk6HZH d6dqg27wklla/RytFzayNdacbPMMjTob7lRwJneqW2IPoC1PMnpVEiOVSK6/aGPBvPOVt1hafFQ0M W01SmwJo3QcVfw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:58986 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVEFR-0002EM-HT; Fri, 18 Mar 2022 11:10:37 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 54307-done@debbugs.gnu.org Subject: Re: bug#54307: [PATCH 0/2] Highlight headings showing what to build/download References: <20220309095710.23849-1-ludo@gnu.org> Date: Fri, 18 Mar 2022 16:10:34 +0100 In-Reply-To: <20220309095710.23849-1-ludo@gnu.org> ("Ludovic =?utf-8?Q?Cou?= =?utf-8?Q?rt=C3=A8s=22's?= message of "Wed, 9 Mar 2022 10:57:10 +0100") Message-ID: <87sfrfpa8l.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54307-done Cc: Julien Lepiller , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Ludovic Court=C3=A8s skribis: > ui: 'show-what-to-build' highlights "The following [...] will be > built". > ui: 'show-what-to-build' highlights "would be downloaded" headings. I went ahead and pushed these as 625fa3cfe8c57cd5624608d2478c8c6be4c69c3b. Of course we can still discuss color and name choices :-). The important part for me was to put the base in place so translations can be updated before the release. Ludo=E2=80=99. From unknown Fri Jun 20 07:15:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 16 Apr 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator