From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Mar 2022 20:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 54304@debbugs.gnu.org X-Debbugs-Original-To: "guix-patches@gnu.org" Reply-To: Cees de Groot Received: via spool by submit@debbugs.gnu.org id=B.164677273725968 (code B ref -1); Tue, 08 Mar 2022 20:53:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Mar 2022 20:52:17 +0000 Received: from localhost ([127.0.0.1]:58020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRgob-0006km-2E for submit@debbugs.gnu.org; Tue, 08 Mar 2022 15:52:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:36996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRgoZ-0006kf-K8 for submit@debbugs.gnu.org; Tue, 08 Mar 2022 15:52:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRgoZ-00050x-Ct for guix-patches@gnu.org; Tue, 08 Mar 2022 15:52:15 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]:58905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRgoV-00027J-UL for guix-patches@gnu.org; Tue, 08 Mar 2022 15:52:14 -0500 Date: Tue, 08 Mar 2022 20:52:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1646772722; bh=+UJykmJ3PV5R2EtV86yqRtp/UWUCO1WG1pV5QoyPy5U=; h=Date:To:From:Reply-To:Subject:Message-ID:From:To:Cc:Date:Subject: Reply-To:Feedback-ID:Message-ID; b=Q+IDzC0oPCOCrFAK110NItyz9xM3BpF8b+BHt4wMorAG9opz9sKUP2NnNd9QGFY4U Sr7eOt2Lrho94N4C3PjcxNZUloxLlYU2vjPcEorqUjIIV+RpSgYMrxdU5Fkg3dN2Sx WyLgWbLnRbcMnyqLuCqc7mZIyK85DXmyh2AMHDxvZgxWUeB32Ub4Yf37H3/zuoOBQa TFtYfRxr0B5g663VgwNmyNjJzDVX7qf12ZTZFg5w1DN1y/iPZ8tpIc7q5ZFuCuGqwR RXJwCjZfDOFyXTGCM9IRxe37GQQxn2UYqmkRF09WtKnlNwRfAcdDwj0+8Z8Gt1y0Jz WqpAJm9FUXfLw== From: Cees de Groot Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.23; envelope-from=cg@evrl.com; helo=mail-4323.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The removed code below affected two locations where Elixir uses Git: * At build-time, Git is used to see if the build is inside a Git repo and i= f so, git info is added to the build information that Elixir returns with `System.build_= info()`. The code uses PATH + `git` so the Git version from the inputs is used which is jus= t fine. * At run-time, Git is used by Mix if, and only if, there are any Git-based = dependencies. This is not the normal case, and in that sense Git is an optional dependency o= f Elixir - most projects will work just fine without Git being present. Here, too, PATH += `git` is used so if there is a need on a user's system to use Git-based dependencies, t= he user can just add the package to the profile and things will just work. I feel that leaving this alone is cleaner than trying to fix the dependency= (if we want to keep it, it needs to be in propagated-inputs in order to keep Git around; I= stumbled upon this building a project with Git dependencies after doing a `guix gc`. Howe= ver, given that using Git dependencies is the exception and I think that minimizing depende= ncies is nicer I opted to just remove the substition completely). --- gnu/packages/elixir.scm | 5 ----- 1 file changed, 5 deletions(-) diff --git a/gnu/packages/elixir.scm b/gnu/packages/elixir.scm index 55e17f2901..f509c59ee3 100644 --- a/gnu/packages/elixir.scm +++ b/gnu/packages/elixir.scm @@ -60,11 +60,6 @@ (define-public elixir (for-each make-file-writable (find-files ".")))) (add-after 'make-git-checkout-writable 'replace-paths (lambda* (#:key inputs #:allow-other-keys) - (substitute* '("lib/elixir/lib/system.ex" - "lib/mix/lib/mix/scm/git.ex") - (("(cmd\\(['\"])git" _ prefix) - (string-append prefix - (search-input-file inputs "/bin/git")))) (substitute* '("lib/mix/lib/mix/release.ex" "lib/mix/lib/mix/tasks/release.init.ex") (("#!/bin/sh") -- 2.34.0 From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Mar 2022 22:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot , 54304@debbugs.gnu.org Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164677780710302 (code B ref 54304); Tue, 08 Mar 2022 22:17:02 +0000 Received: (at 54304) by debbugs.gnu.org; 8 Mar 2022 22:16:47 +0000 Received: from localhost ([127.0.0.1]:58062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRi8N-0002g6-MT for submit@debbugs.gnu.org; Tue, 08 Mar 2022 17:16:47 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:47436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRi8L-0002fu-7e for 54304@debbugs.gnu.org; Tue, 08 Mar 2022 17:16:46 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id 3yGj270024UW6Th01yGjMk; Tue, 08 Mar 2022 23:16:43 +0100 Message-ID: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> From: Maxime Devos Date: Tue, 08 Mar 2022 23:16:39 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-B173se/SuPuHkm+OXWBt" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646777803; bh=aauHOZDDCDajSwiFkX8qj69ZCftMK3vLwJ4GdYIQkNw=; h=Subject:From:To:Date:In-Reply-To:References; b=KfDB2kDtH6Wu+gFPIvxhCyp6ISro8uTLEsfb6Iu9BojPtcKehQcRdjv1iINIcC4kF wZvNztBqin2DPldxvVVPAnnHun3MDtHNWwhGt0vHME3AtrRq3QKJy48JKKKMfX3VNQ RMpiqmiXzhPU5j065u11vmnyYdx1PBSrQVRWGU2Y7c+tqSxjJ3Mz6WfjYfOf96JHSQ w9zUqVL7/OhsXMew6a0OxFYp72oNWQoMxd37kscVeMdMKMGhRw0+oNO1qZwlL9/H2p 2MHMoaO2Y2PhUBdI73jmOo2H2n1iDR6DEDD+wKFw1jvh3it+fzxB/f1WU1QvPegdte s8W+84iWS+W8g== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-B173se/SuPuHkm+OXWBt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]: > I feel that leaving this alone is cleaner than trying to fix the dependen= cy (if we want to > keep it, it needs to be in propagated-inputs in order to keep Git around; Instead of propagation, I recommend substitution, like done currently. Propagation is not necessary to =E2=80=98keep git around=E2=80=99 (assuming= that the store reference is not obfuscated by gzipping or the like). If it's used at build-time instead of run-time, then git should be moved to native-inputs, for cross-compilation reasons. Greetings, Maxime --=-B173se/SuPuHkm+OXWBt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYifVxxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tv0AQDJoIGfzPsjTnIGId3E+kcY04qZ mk3MxZ8RCkkj0jcN/QD/c9Z/61ESb6clBTp9GPzKT92dtM4LEXEr1gTqRyCMeQc= =P2yc -----END PGP SIGNATURE----- --=-B173se/SuPuHkm+OXWBt-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Mar 2022 22:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot , 54304@debbugs.gnu.org Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164677787010418 (code B ref 54304); Tue, 08 Mar 2022 22:18:01 +0000 Received: (at 54304) by debbugs.gnu.org; 8 Mar 2022 22:17:50 +0000 Received: from localhost ([127.0.0.1]:58067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRi9O-0002hy-0Y for submit@debbugs.gnu.org; Tue, 08 Mar 2022 17:17:50 -0500 Received: from michel.telenet-ops.be ([195.130.137.88]:53776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRi9L-0002hn-M7 for 54304@debbugs.gnu.org; Tue, 08 Mar 2022 17:17:48 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id 3yHm270034UW6Th06yHmeo; Tue, 08 Mar 2022 23:17:46 +0100 Message-ID: From: Maxime Devos Date: Tue, 08 Mar 2022 23:17:46 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-VO3ivcgAnqIhSpvw18kI" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646777866; bh=MtqDbKN9ifoz4jeKyleAIF7z5ENP0369mxnpBfWIjRk=; h=Subject:From:To:Date:In-Reply-To:References; b=hV8jp7EtEyWf10p7GoxOQt/eBOlGAvSAEBPW6JPYNlWh7J1NWlqXQRKlGAa/i6jZ4 bHhSyVF1OvlCnmc8s0QuTveJoGoY5oJ/qdJizCheQIewEwKKJO7cF02elnGKpMKqNk bIcdcpCc64Ucn9XxXxiIaYX2JGta8YK5z24l7BgOMU7IwKqP8DHEwU2ZE4gJdoS9Ln CDxoZlt/ZqFiynLkCN02DSy+HCoszQkC6zlMRXFYCW8WAlZcuFqh5oUZMKA78XYYzo f//+zpI2tdxBG8eL7NAMrv+2UTr8hOmCPFweICmTOd2Z0vsaZ6U9hCx++MHnOGdRLo chKaJkniGTGcg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-VO3ivcgAnqIhSpvw18kI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]: > * At build-time, Git is used to see if the build is inside a Git repo and= if so, git info That cannot ever have worked in the first place, since Guix does not save the '.git' directory when downloading elixir's source code. Greetings, Maxime. --=-VO3ivcgAnqIhSpvw18kI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYifWChccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7vipAP9JudT4J/sNY++GM6xV6EIWpWBg dYT50SRZcvbnMzLFHwEA5quWzqcl7fre9Zlcbsy0ANi7foz+PIiIGFreZ1DDSg4= =1MrM -----END PGP SIGNATURE----- --=-VO3ivcgAnqIhSpvw18kI-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Mar 2022 22:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot , 54304@debbugs.gnu.org Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164677791710510 (code B ref 54304); Tue, 08 Mar 2022 22:19:01 +0000 Received: (at 54304) by debbugs.gnu.org; 8 Mar 2022 22:18:37 +0000 Received: from localhost ([127.0.0.1]:58072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRiA9-0002jR-AY for submit@debbugs.gnu.org; Tue, 08 Mar 2022 17:18:37 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:54684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRiA7-0002jJ-NP for 54304@debbugs.gnu.org; Tue, 08 Mar 2022 17:18:36 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id 3yJa270034UW6Th06yJaEW; Tue, 08 Mar 2022 23:18:34 +0100 Message-ID: From: Maxime Devos Date: Tue, 08 Mar 2022 23:18:34 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-uV+Pi1NA4U+wPeecxnX2" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646777914; bh=b0bWZLqXloiIJh3acWLnEtVvbAvlkcaUVxLVCuYqA/c=; h=Subject:From:To:Date:In-Reply-To:References; b=ViWdRacZoJjKlZSHOCSmuVCbmbyA2UgMv552G+kQA2fCEE5rN2tO62yoc3+sDpmqh J1U/V/AtEuaqV8StKdldB2519xMuBIkRzM6iYULMhle/v58OJGY66GamjxmZR/6kEC 32OYErsx6rYYSgGx5iYsaBypWjRk4NLcZ0asndFwxsYJKZXB7wFYtcfdOwi7YSYvte 1gBZKTfgy6ExzEUWqLB1VYlJCWrnWJZwsQngepJknhq0C+sfTYjkdtcrdcJrRD6RrC WjnqDCCsMy93abt4zmT5PY0YI+pENxvfCWFuLvBTVy9rbtxf3jgxbfvlpbRaLUHivN FdmQxsNw2dvow== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-uV+Pi1NA4U+wPeecxnX2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]: > =C2=A0 uses PATH + `git` so the Git version from the inputs is used which= is just fine. Due to cross-compilation reasons, this is not fine, it should use the git from native-inputs instead. Greetings, Maxime. --=-uV+Pi1NA4U+wPeecxnX2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYifWOhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7nKWAQCylSTfi61xYr9qtawkwphhcC5b eAK6/HwQgIr7Kp/uSgEAl3pcPOJRwgaCa96f1er7efpCfaZLDi7RldnkjQCQ8gM= =HHY0 -----END PGP SIGNATURE----- --=-uV+Pi1NA4U+wPeecxnX2-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Mar 2022 22:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot , 54304@debbugs.gnu.org Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164677816510944 (code B ref 54304); Tue, 08 Mar 2022 22:23:01 +0000 Received: (at 54304) by debbugs.gnu.org; 8 Mar 2022 22:22:45 +0000 Received: from localhost ([127.0.0.1]:58083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRiE9-0002qS-4a for submit@debbugs.gnu.org; Tue, 08 Mar 2022 17:22:45 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:57614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRiE7-0002qK-Mx for 54304@debbugs.gnu.org; Tue, 08 Mar 2022 17:22:44 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id 3yNi2700G4UW6Th06yNiYL; Tue, 08 Mar 2022 23:22:42 +0100 Message-ID: <5f60c94ec46bf7348c3f1906957dc3cbb4d9d395.camel@telenet.be> From: Maxime Devos Date: Tue, 08 Mar 2022 23:22:42 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-mCNYTeeQVIgzg8XAVY+/" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646778163; bh=gz4GAN1uQUApIBWRNc6qrqZchwkcnjMQKd2L2xtWAe0=; h=Subject:From:To:Date:In-Reply-To:References; b=AwtbHOs8OVb4OMYQHxXmjXkZ8yU/qCxDRrNYdOO8o6f6mp+AmlKoReIyQ0VMtJs9n zyyyE5bIvqpGy9scTCN8mLfZ9T6Duh5Jq4Sz6BM+k9jH8Qc4Xmq04uuwdBrO2kHWmf gV2PIXjRmtsJEE1+n1RHXl0blY/k37Y6Zex64qJbvAN90IaIxsFiitG+kve1TgJI1v PiZ0e1EtMYgi5MEaJpB4TzH3cUziKK5/XKrzu0UzAETalPfCoNf5dltZEBvBn6Mv4e OPlN7u24tcGmeILupkoZ/8KX1ma+zjWppypRMPMHYDGQ5meozva+3U2sPyGPjtCjJI ctaK5R/SlV2Lw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-mCNYTeeQVIgzg8XAVY+/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]: > * At run-time, Git is used by Mix if, and only if, there are any Git-base= d dependencies. This > =C2=A0 is not the normal case, and in that sense Git is an optional depen= dency of Elixir - most > =C2=A0 projects will work just fine without Git being present. Here, too,= PATH + `git` is used > =C2=A0 so if there is a need on a user's system to use Git-based dependen= cies, the user can just > =C2=A0 add the package to the profile and things will just work. If it's optional and not used most of the time, removing it seems fine to me, though this seems useful information for the description. Also, it would be nice if 'elixir' were patched to emit a nice message when 'git' is not found. Suggestion: This project required 'git', but it is not in $PATH. It can be installed into the user profile with `guix install git`. You might want to contact whoever added the substitution originally, to see what the original reasons were. Greetings, Maxime. --=-mCNYTeeQVIgzg8XAVY+/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYifXMhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7q7UAP45wDMIM6e9HIRusznaKGZa93bk oP8mUmH8GJiZ7sJBgwEAxYKovszQztu8RTbsQWWOz28xlUMgo+nP7AbZr5caSQA= =cc7j -----END PGP SIGNATURE----- --=-mCNYTeeQVIgzg8XAVY+/-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Mar 2022 07:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot Cc: 54304@debbugs.gnu.org Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164681107729688 (code B ref 54304); Wed, 09 Mar 2022 07:32:01 +0000 Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 07:31:17 +0000 Received: from localhost ([127.0.0.1]:58386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRqmz-0007im-KT for submit@debbugs.gnu.org; Wed, 09 Mar 2022 02:31:17 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:35748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRqmx-0007id-5R for 54304@debbugs.gnu.org; Wed, 09 Mar 2022 02:31:15 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id 47XD2700R4UW6Th017XD66; Wed, 09 Mar 2022 08:31:13 +0100 Message-ID: <090dccee9fc3834656bbe416364a9a337122a2fb.camel@telenet.be> From: Maxime Devos Date: Wed, 09 Mar 2022 08:31:12 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-6H5RtnckZH/ppwALV9SL" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646811073; bh=/lrmVBstLh0F4XjQi0P1wgmI7CNXC091IExl68ugWVk=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=RSleLYEJOh2qCvlScq8BYKXj/LgX1QHMx70K+tKmWxV90ueQJHWinM0HcTA5mnR9X HVPflelgg9DrEsVNaX9z9bqDkR/Vqpmg06GX/oB0Lke0iQsS2FnSGKRny9/McvHFQT ti5bh6ENEEATFoMsX3UXhu97ox+PcihOUoMa5aFSjyR0nnleX0d2tMi/gwKxsf26vK TqEnE4ZanjyUJAyv2lJaWgcuw+zPZz6Uees4PfVHYCSP96zrgxXXrxqIQgYeacH4iB flTBhHItk7kS+71ri84zQhpL5lSmB4g7CNQ76RUxFlfmzSildXrIRHmdS3YRGEGON3 mTN90QEr0+ukA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-6H5RtnckZH/ppwALV9SL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cees de Groot schreef op wo 09-03-2022 om 02:39 [+0000]: > > [...] > > That cannot ever have worked in the first place, since Guix > > does not save the '.git' directory when downloading elixir's source > > code. > That=E2=80=99s correct and fine. The info is informational at most =C2=A0 How can being completely broken be correct and fine? Greetings, Maxime. --=-6H5RtnckZH/ppwALV9SL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYihXwBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7pr1AQDfGqFcumXY6bg7sxxJEQmZXnLm cia/7AbpZo/4wsccOwD/WvE1oQjlzhDIfJk1ufGLBaRSACKFBWU5NFTTnI/zOQo= =WeWl -----END PGP SIGNATURE----- --=-6H5RtnckZH/ppwALV9SL-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Mar 2022 17:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54304@debbugs.gnu.org Reply-To: Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164684697412709 (code B ref 54304); Wed, 09 Mar 2022 17:30:03 +0000 Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 17:29:34 +0000 Received: from localhost ([127.0.0.1]:60630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS07y-0003Iv-4N for submit@debbugs.gnu.org; Wed, 09 Mar 2022 12:29:34 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:17630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS07v-0003Id-FD for 54304@debbugs.gnu.org; Wed, 09 Mar 2022 12:29:32 -0500 Date: Wed, 09 Mar 2022 17:29:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1646846964; bh=mqS784/iozdStffEOVLuCQPXoRJKBAI8XdhoCr8B47c=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=LjA08RKuImhYOrw1s53FJ7qxuMCUkwwSxwc4RqQ605h9DQqnI16VXhpHUWGn/PL1e Ml9GjzU31RZSzsKnKGnuJmKgCKBkhkmxEyekwWEqZNY6d/VydpXHrMEBBrEfTx6jvC jkwY2vD0LR3NoLslhRVo4Ln9P6cD7Jsj4OM+a5UcKXv25a0chOdz47qqUs2ciPM1qM P0BPOrexp3umyXWcy2Ko8gesU1NKR8C9ldT4qdo0rzSEq+bNStSpYhL8t4dEWSXzCM S5bm9oKlf7rih1grT3B+tmn2xhOvNZKNxdlB6VklKAy4XnwwRQhC2HHTbAl3IFjCeU yeg3nDo4KswMw== From: Cees de Groot Message-ID: In-Reply-To: <090dccee9fc3834656bbe416364a9a337122a2fb.camel@telenet.be> References: <090dccee9fc3834656bbe416364a9a337122a2fb.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >From the docs: ":revision - short Git revision hash. If Git was not available at building = time, it is set to """ (https://hexdocs.pm/elixir/System.html#build_info/0) So if git is not available - either because the executable is not there or = because the build checkout is not from Git, the revision hash is set to the= empty string, which is in accordance with the docs and what the Guix build= has been doing all along (because, as you said, at build time, .git isn't = there). So for build time, cross-compiling or not, we don't need Git. ------- Original Message ------- On Wednesday, March 9th, 2022 at 02:31, Maxime Devos wrote: > Cees de Groot schreef op wo 09-03-2022 om 02:39 [+0000]: > > > > [...] > > > > > > That cannot ever have worked in the first place, since Guix > > > > > > does not save the '.git' directory when downloading elixir's source > > > > > > code. > > > That=E2=80=99s correct and fine. The info is informational at most > > How can being completely broken be correct and fine? > > Greetings, > > Maxime. From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Mar 2022 17:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54304@debbugs.gnu.org Reply-To: Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164684710513069 (code B ref 54304); Wed, 09 Mar 2022 17:32:01 +0000 Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 17:31:45 +0000 Received: from localhost ([127.0.0.1]:60647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS0A5-0003Oj-K1 for submit@debbugs.gnu.org; Wed, 09 Mar 2022 12:31:45 -0500 Received: from mail-4022.proton.ch ([185.70.40.22]:62056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS0A4-0003OT-4U for 54304@debbugs.gnu.org; Wed, 09 Mar 2022 12:31:44 -0500 Date: Wed, 09 Mar 2022 17:31:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1646847098; bh=wkN2QYO2RJPiKG5jp3DZ/MApF9qziqilrbIoJ4c61DM=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=fFprEC+a9FnotDPYXrkF/GrsD27CzyieAIdf1ViBLYkB/j5//qzjg7L4ed2nqtMV8 1H5PLH4fpQ6KlDsFo917lRg5Sr+/ji6sINhH7gNtzRtFui0emW06MHb32ffctT9GTu ubHHveKuqibNeSgv5bAAzVfuesHt4YSuQhR9EQpW+Xj/sMnmk6WuVxUFYJCSSQ0CaY YTyP/JBQsGXETbbhPCN0wzo1psTZvvXEl8NRLcihTte6qMkqgaNkPT6lxiPSNjzAX7 NaGkJ5b/dy1z/whhiTJMwH6KfU9KaFypDnR9vz+p7UGZ9KnsGHMlb+c2V38zwrwM50 Sxc/6EvUXc4uw== From: Cees de Groot Message-ID: In-Reply-To: <5f60c94ec46bf7348c3f1906957dc3cbb4d9d395.camel@telenet.be> References: <5f60c94ec46bf7348c3f1906957dc3cbb4d9d395.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I think changing the behaviour of a programming language just to be helpful= to developers is something that one may consider for upstream, but certain= ly not in the context of a packaging system like Guix - that just will bree= d confusion. As it is, the error message thrown by Elixir when Git is not there is very = easy to interpret for developers (and _only_ at development time can this h= appen!), no need to go overboard here. Unless, of course, you think it is u= seful to submit an upstream patch, feel free to do so. ------- Original Message ------- On Tuesday, March 8th, 2022 at 17:22, Maxime Devos = wrote: > Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]: > > > * At run-time, Git is used by Mix if, and only if, there are any Git-ba= sed dependencies. This > > > > =C2=A0 is not the normal case, and in that sense Git is an optional dep= endency of Elixir - most > > > > =C2=A0 projects will work just fine without Git being present. Here, to= o, PATH + `git` is used > > > > =C2=A0 so if there is a need on a user's system to use Git-based depend= encies, the user can just > > > > =C2=A0 add the package to the profile and things will just work. > > If it's optional and not used most of the time, removing > > it seems fine to me, though this seems useful information for the > > description. Also, it would be nice if 'elixir' were patched > > to emit a nice message when 'git' is not found. Suggestion: > > This project required 'git', but it is not in $PATH. It can be > > installed into the user profile with `guix install git`. > > You might want to contact whoever added the substitution originally, > > to see what the original reasons were. > > Greetings, > > Maxime. From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Mar 2022 17:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54304@debbugs.gnu.org Reply-To: Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164684733513486 (code B ref 54304); Wed, 09 Mar 2022 17:36:02 +0000 Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 17:35:35 +0000 Received: from localhost ([127.0.0.1]:60658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS0Dn-0003VS-IL for submit@debbugs.gnu.org; Wed, 09 Mar 2022 12:35:35 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:38619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS0Dm-0003VC-3D for 54304@debbugs.gnu.org; Wed, 09 Mar 2022 12:35:34 -0500 Date: Wed, 09 Mar 2022 17:35:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1646847328; bh=1Nn2/FHVZRMTpesI+X8pMs1XEFNH+9tWi3aszZcae1w=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=jufhLWmm/IFXCsvW9UwipsOAhKTv81Rqd8IdYeLrBJ10Z1LETTI+K6AJ9VuawUau+ R2Yu0dJI7v5DAYYDHA6CEX5EVDZV2PAlLJSc8p1WtdTYNH9K3/puAnNfnZOVStRLgW 7OeSdH8VpLdd90rJ0c/rclOxz6a9Hs2ogavvR4czfQRl8bPLUHdmoY7+KEHjLMlgy0 csHJy3VTRKx0+jiLcZl9ZnXxQ0JfjmcDylmjJl20YB0nNiI13HR6x323PAEcbNdTt/ HSWoUY945oI1arPgdaLdOb9VBqu2ZQo8c612LGYkvqK0cjwhiphSDEeyyjwp1uxec5 haHM1dnC+Bd9Q== From: Cees de Groot Message-ID: In-Reply-To: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Propagation is not necessary to =E2=80=98keep git around=E2=80=99 (assumi= ng that the Well.... the whole reason that I stumbled upon this was that the compile-ti= me substitution referred to a Git version that got GC'd. And I think that t= hat is the different between regular inputs and propagated inputs, whether = inputs become eligible for GC at run-time or not. If I'm misunderstanding s= omething there, something else caused that version of Git to get GC'd and I= 'd be more than happy to be corrected in my assumptions. From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Mar 2022 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot , Maxime Devos Cc: 54304@debbugs.gnu.org Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164684875316068 (code B ref 54304); Wed, 09 Mar 2022 18:00:02 +0000 Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 17:59:13 +0000 Received: from localhost ([127.0.0.1]:60689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS0ad-0004B3-De for submit@debbugs.gnu.org; Wed, 09 Mar 2022 12:59:13 -0500 Received: from tobias.gr ([80.241.217.52]:50988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS0aY-0004Ap-03 for 54304@debbugs.gnu.org; Wed, 09 Mar 2022 12:59:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=gAuX6re861w28 sur5tPUcCuk6zab1xFM7dMygg8D/4U=; h=references:in-reply-to:subject:cc: to:from:date; d=tobias.gr; b=lklNF+H2U0AufxYSQnk0cvD029wIl8JJArTgOmGtY Uq1g1qVONU5Yr2ZpieIz4tc4bTg2xO8tCijn70vrto0PKloEk7wK+xyR2DmUFpAFu75cru DCI2pbe8Umwugk6M7n0LFMh8n1i0DawOB8CzRqRaxvSgDSdQ68rpR6iUWtcgViT23TCOs8 jvsDSP/tDTFgNRzmG/cOr9yz/PX6kUzBVo/d6FPJU1c9MvM1amkco9PiUmZN/FamyR3Xo1 7ORc9Hl0njVVS3n7XuaR6DNAvVAqZdD5vV35LjXESHtM1W8SolN4mvZLCe1dq2WqvCpn++ PCqEDPB4KAsdGUGtBS8xQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 4948aa06 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 9 Mar 2022 17:59:01 +0000 (UTC) Date: Wed, 09 Mar 2022 17:59:03 +0000 From: Tobias Geerinckx-Rice In-Reply-To: References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> Message-ID: <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 9 March 2022 17:35:25 UTC, Cees de Groot wrote: >> Propagation is not necessary to =E2=80=98keep git around=E2=80=99 (assu= ming that the > >Well=2E=2E=2E=2E the whole reason that I stumbled upon this was that the = compile-time substitution referred to a Git version that got GC'd=2E This simply Should Not happen=2E Guix's GC model (inherited from Nix) is = brutally simple: if the raw string /gnu/store/xxx occurs anywhere within a = protected /gnu/store/yyy (e=2Eg=2E in a binary), then xxx is also protected= , recursively=2E Assuming those assumptions hold here it's a 'mystery' why git got GC'd=2E = From experience and for our collective peace of mind I'd say it's more lik= ely that they didn't hold somehow, than that there's a serious GC bug :-) > And I think that that is the different between regular inputs and propag= ated inputs, whether inputs become eligible for GC at run-time or not=2E So, no=2E Completely unrelated=2E The GC has no concept of time at all= =2E This isn't Gentoo=2E Propagated inputs are 'oh, here's this extra thing I was unable to properl= y patch, please add it to the profile and treat it as a GC reference anyway= '=2E This is ugly and regular, non-propagated inputs are always preferred=2E S= ome software just makes them too painful=2E Cees, Kind regards, T G-R Sent on the go=2E Excuse or enjoy my brevity=2E From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Mar 2022 19:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot Cc: 54304@debbugs.gnu.org Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164685514626969 (code B ref 54304); Wed, 09 Mar 2022 19:46:02 +0000 Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 19:45:46 +0000 Received: from localhost ([127.0.0.1]:60769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS2Fm-00070v-GS for submit@debbugs.gnu.org; Wed, 09 Mar 2022 14:45:46 -0500 Received: from andre.telenet-ops.be ([195.130.132.53]:51312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS2Fj-00070j-U0 for 54304@debbugs.gnu.org; Wed, 09 Mar 2022 14:45:45 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by andre.telenet-ops.be with bizsmtp id 4Klh2700E4UW6Th01Klhy1; Wed, 09 Mar 2022 20:45:42 +0100 Message-ID: <919b8ca66b9548aa0e3cf682b9e293f7ed28b2a8.camel@telenet.be> From: Maxime Devos Date: Wed, 09 Mar 2022 20:45:41 +0100 In-Reply-To: References: <5f60c94ec46bf7348c3f1906957dc3cbb4d9d395.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-0hT54dB9YfW6numgs8+V" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646855142; bh=zrxlcvu/v2z8VlWRX4rhIIaN0UROC49OorewclcKGXo=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=GqgiMzDqiT02posWB5xjK5tU6gddlT1qAETwOWiAeGMvUWLiJHlCJYn4lDYjDLCsl eGplgEL2iotNa9kgO6reD/pvSepaHp05GMdhCQBrBtnNlL8siLOl4Hqe+pbSsAADkQ Yx67m/4qrIHAGE5GNqfuzHZHNVkqVKZgM2dSA9oHCqplAbzzwHP9pCHzEeFKkES7Ql zcD3Rlfso1bf87dkian+G/ERqinYcOSqoqcnyKXoNwt2SizrvWjHfd2S12Y6ZmIjzG mUftnUf2/8Q8jFSt4JMPoSWCL6Pa+GnNIXULi7JL7Vqjxzir/ZfsfEB7ufOpmCJR51 qaX/BvJPOr3FQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-0hT54dB9YfW6numgs8+V Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cees de Groot schreef op wo 09-03-2022 om 17:31 [+0000]: > I think changing the behaviour of a programming language just to be helpf= ul to developers Developers are users too and users can be developers. Furthermore, Elixir is an implementation of a programming language, so aren't all users of Elixir automatically developers? I'm not sure how exactly Elixir integrates with git but I assume the integration can be very useful. Also, this does not change the behaviour of the language, it only adjusts a detail of the implementation: the error message for indicating that git is missing is adjusted. > is something that one may consider for upstream, but certainly not in th= e context > of a packaging system like Guix - that just will breed confusion. How could better error messages breed confusion? Also, this seems a change that would absolutely _not_ be considered upstream. Why would upstream have distro-specific error messages? If the new error message is Guix-specific, wouldn't Guix be the logical place to have it? Greetings, Maxime. --=-0hT54dB9YfW6numgs8+V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYikD5RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7gppAP45vq8lFQRRs+nLssm3L7rBLQzZ q0ZPo5RcbDwVwdFssAD/coZUNom2+Cus2qHJ3O/PxMf0t3Z2hiLr4CskcVHNpQ0= =PAGC -----END PGP SIGNATURE----- --=-0hT54dB9YfW6numgs8+V-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Mar 2022 21:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 54304@debbugs.gnu.org, Maxime Devos Reply-To: Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.16468597189318 (code B ref 54304); Wed, 09 Mar 2022 21:02:02 +0000 Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 21:01:58 +0000 Received: from localhost ([127.0.0.1]:60905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS3RV-0002Py-Ny for submit@debbugs.gnu.org; Wed, 09 Mar 2022 16:01:58 -0500 Received: from mail-4022.proton.ch ([185.70.40.22]:54845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS3RS-0002JI-8e for 54304@debbugs.gnu.org; Wed, 09 Mar 2022 16:01:56 -0500 Date: Wed, 09 Mar 2022 21:01:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1646859707; bh=mr3T2WZmjeNBtRtUDukC0fP4URkTPZBjDdzN3OC8PJY=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=tnpRo3kanikcg5JSIDIb5KMy75Cpf0J3v439SzHHXa3W3PYxvQsqdfPJ1AHcp/iwx 4PInO9nO4atkBytfWr39ZaaWnLHLH1AQLqGYHV+CacCahTUZOHbqzSarZ/vVYenomn 9q/kRC4UvenqjrueD13LePcMGDg8JSJX27lWxg8fKBLsISJ4AWF4wC7tXDnQ22Ycd1 qMcZmydIt/OhglXsE6D5roWAqF4sFylEIqq+WkKlBSmkAejcER1xv04By3ZsvptK92 SHspDqNVRZbIPi7vZHwISfuOKqBjMejiizfvWef6Uwft27aSJ0b/9Rm28YUxAfvlXR GEwJfZKQpz+qQ== From: Cees de Groot Message-ID: In-Reply-To: <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wednesday, March 9th, 2022 at 12:59, Tobias Geerinckx-Rice wrote: > This simply Should Not happen. Guix's GC model (inherited from Nix) is br= utally simple: if the raw string /gnu/store/xxx occurs anywhere within a pr= otected /gnu/store/yyy (e.g. in a binary), then xxx is also protected, recu= rsively. So how does Guix figure out what to keep and what not? I mean, in this case= the patched string will land in a compiled .BEAM file which very well may = have the string obfuscated (I need to check how the VM stores strings in bi= naries). From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Mar 2022 21:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot Cc: 54304@debbugs.gnu.org, Maxime Devos Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164686259216255 (code B ref 54304); Wed, 09 Mar 2022 21:50:02 +0000 Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 21:49:52 +0000 Received: from localhost ([127.0.0.1]:60955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS4Bs-0004E6-9o for submit@debbugs.gnu.org; Wed, 09 Mar 2022 16:49:52 -0500 Received: from tobias.gr ([80.241.217.52]:51022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS4Bp-0004Dy-Gs for 54304@debbugs.gnu.org; Wed, 09 Mar 2022 16:49:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=TE7A4A2lcXGzj 0ZZwnysSy+28KyaK8xYOMS6k0lPHIE=; h=references:in-reply-to:subject:cc: to:from:date; d=tobias.gr; b=F9yHGQXAd+3ppuaVzl1F9582BJOjekDklyr3GJDX9 cRMX9zgvBJcSQr8IEYLQ/N35iPc5r5FkakJ5DrH3CiTm2IUHTCNq0UirxD0NMd15NXpTae 7EohUfPP0p38+im5EcS9p6Xh8vt2W/3WKQH4CLhBsvuxtG232QQDQ5QlrXF6vOjmWJ4Ele qxs/zBHZtiaRwI1yLAgO9rPFPrfTnpSNYgMv7U8xYT6Am+x4QvfFXdQiaPOsXnnvWdknHw 22OBaQlyTPRNnz2zKw2W3AGKCX0/O8hjlbwSZgnslOlDx4+M6rtH+aX3UoFbDEBXzOlC20 bmutHFqUvWha2aXczxCQw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id fd466d14 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 9 Mar 2022 21:49:44 +0000 (UTC) Date: Wed, 09 Mar 2022 21:49:46 +0000 From: Tobias Geerinckx-Rice In-Reply-To: References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> Message-ID: <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Cees, Yeah, this happens sometimes and will hide these references from what is a= simple and therefore very fast string search=2E It's why we install uncompressed =2Ejar files and disable an obscure (and = arguably unnoticable) GCC optimisation that hacks strings into incontiguous= chunks=2E If BEAM somehow obfuscates store references we'll have to find = a similar work-around to stop it=2E Let us know what you find=2E Kind regards, T G-R Sent on the go=2E Excuse or enjoy my brevity=2E From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 21:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 54304@debbugs.gnu.org, Maxime Devos Reply-To: Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164703444815503 (code B ref 54304); Fri, 11 Mar 2022 21:35:02 +0000 Received: (at 54304) by debbugs.gnu.org; 11 Mar 2022 21:34:08 +0000 Received: from localhost ([127.0.0.1]:38513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSmtk-00041z-Bu for submit@debbugs.gnu.org; Fri, 11 Mar 2022 16:34:08 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:50819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSmti-00041J-Bk for 54304@debbugs.gnu.org; Fri, 11 Mar 2022 16:34:07 -0500 Date: Fri, 11 Mar 2022 21:33:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1647034439; bh=oCXvLTg9tuv3T3RucLO96v8qod468gzoe8lFvPmjc3E=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=jKtXT3y3pDWNSk1xmS7NkYt7SqM1urcO4QNvMPETUbosG9+BvlCLXFUXA9YS4FyWm u7cX+EZMRJfEsjZJYtGiNMiQzCINfa/k8Fi13IiOJJKu2ZujxuLivDHu+MDZMlhhLj sc1CZH5LsS1tc81YWiTccPmvNhKJnAz7tzlx24lI0IB3pNca+hEzwT+EYE4roUgoib Vq9LyhQ2QePOCE87N37cqHgIq9zoigtoIfOZPVS2qw9+SKddCEl6w7BGifck5gbGeu P/eji3bpII6c49vZenRKWr0GOoTAM45MhaSqW6/xZrBjQB2cZ+VqViWJhSzq1jlBMO 4bL+xOfRmaMcQ== From: Cees de Groot Message-ID: <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> In-Reply-To: <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wednesday, March 9th, 2022 at 16:49, Tobias Geerinckx-Rice wrote: > If BEAM somehow obfuscates store references we'll have to find a similar = work-around to stop it. Let us know what you find. > Yup. BEAM files have literals stored in a single Deflated blob (https://bea= m-wisdoms.clau.se/en/latest/indepth-beam-file.html). So the scanning won't = work. Which means that either my patches should be merged or Git should be propag= ated. I'm not a super big fan of propagating optional dependencies, which i= s why I submitted the patch like this. From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 21:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice , Maxime Devos Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164703553217322 (code B ref 54304); Fri, 11 Mar 2022 21:53:02 +0000 Received: (at 54304) by debbugs.gnu.org; 11 Mar 2022 21:52:12 +0000 Received: from localhost ([127.0.0.1]:38542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnBD-0004VK-NK for submit@debbugs.gnu.org; Fri, 11 Mar 2022 16:52:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnBC-0004V5-2j for 54304@debbugs.gnu.org; Fri, 11 Mar 2022 16:52:11 -0500 Received: from [2001:470:142:3::e] (port=33432 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSnB5-00082z-54; Fri, 11 Mar 2022 16:52:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Ayz1+HNhC/7EmNemXdgsmAgT/oQusKBbSqSpb+QV7mk=; b=gAmsYr26tF7J3CmUFZKy JKdpdAqHc0B7dDmQ1ZhKEd4YxA5sxGeJBmam2/oZnYnZHzthWR6V5tgwvBRZKrNjKzORSBtdI6wyK v1FEVCJKchxHvGhKpMP+QVnBmRVvIF7e3dVZtxqgZ7y/PF767udCjDxCSLUTYW/noYyQmQ3KadM/V OurLpJ802LzUhyA86QdaOK/CDKeHjyjel+f7XFVI9CtXcA86Mwhf3WT/7hltbx/kc/B+LxdNb716N 1/n6OcVqkGFTJ+PV0GwiIBeJ+KcH6t7npiXA7YYPP1ujQwoBrOyMkpkG+xk3HcVQVpSnfxgrDGttw vzULUb2iSyGgXA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54529 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSnB3-0005IS-Nw; Fri, 11 Mar 2022 16:52:02 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> Date: Fri, 11 Mar 2022 22:51:59 +0100 In-Reply-To: <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> (Cees de Groot's message of "Fri, 11 Mar 2022 21:33:57 +0000") Message-ID: <87wnh0w41s.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Cees de Groot skribis: > On Wednesday, March 9th, 2022 at 16:49, Tobias Geerinckx-Rice wrote: >> If BEAM somehow obfuscates store references we'll have to find a similar= work-around to stop it. Let us know what you find. >> > Yup. BEAM files have literals stored in a single Deflated blob (https://b= eam-wisdoms.clau.se/en/latest/indepth-beam-file.html). So the scanning won'= t work. If we know what set of store references go in those blogs, we could create a text file or something in #$output whose sole purpose is to keep a reference to those store items. For example, if we know those BEAM files contain a reference to Git, we can add a phase like: (lambda* (#:key inputs outputs #:allow-other-keys) (symlink (search-input-file inputs "git") (string-append (assoc-ref output "out") "/libexec/elixir/.git"))) That way the GC will keep Git around. Thoughts? Ludo=E2=80=99. From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 21:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Cees de Groot Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164703583217762 (code B ref 54304); Fri, 11 Mar 2022 21:58:01 +0000 Received: (at 54304) by debbugs.gnu.org; 11 Mar 2022 21:57:12 +0000 Received: from localhost ([127.0.0.1]:38547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnG4-0004cQ-BS for submit@debbugs.gnu.org; Fri, 11 Mar 2022 16:57:12 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:55150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnG2-0004cG-0S for 54304@debbugs.gnu.org; Fri, 11 Mar 2022 16:57:10 -0500 Received: from [172.20.10.5] ([188.188.45.72]) by laurent.telenet-ops.be with bizsmtp id 59x7270011ZSGwU019x75N; Fri, 11 Mar 2022 22:57:08 +0100 Message-ID: <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> From: Maxime Devos Date: Fri, 11 Mar 2022 22:57:02 +0100 In-Reply-To: <87wnh0w41s.fsf_-_@gnu.org> References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-xxIDBDr6DNllgrljEoko" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647035828; bh=ADvAMBHZ9yPiFoqmjI1dqwklqb4ZE6DgIZPROhsJI90=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=nUl95+34sZTbptx6Q42A0e9BpzC4PHtJVQdPFnWA6rGBGyYcDUg3ScY/0p7AWA79v cHFP5WS5MUdlIiDW/i9abqUUHO1CDZBQoxmBQn2edhMiKx0AMafB+Iv92NyJQgBY45 +jcX6/QbcBkfMjvLPeUVQRTmpfSITsdxQfL65I1hq6gfjQ+3lKeNLazOhimNqscrbY e3G9L1sLLZX9RZiePzSG7SOsdkr8Wes8loMY6q2YZzPkJ2awldw79oEIqR8t9mZi4+ KQ9v1NJF+qp/md4VnG3VIlFVPqJhwcSXOAAZM1lRqCx/f8yJr605Xv6JG1zVsVEbpc My4iHROXJ8U0A== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-xxIDBDr6DNllgrljEoko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s schreef op vr 11-03-2022 om 22:51 [+0100]: > If we know what set of store references go in those blogs, we could > create a text file or something in #$output whose sole purpose is to > keep a reference to those store items. >=20 > For example, if we know those BEAM files contain a reference to Git, we > can add a phase like: >=20 > =C2=A0 (lambda* (#:key inputs outputs #:allow-other-keys) > =C2=A0=C2=A0=C2=A0 (symlink (search-input-file inputs "git") Doesn't that need to be "bin/git" instead of "git"? > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = (string-append (assoc-ref output "out") > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 "/libexec/elixir/.git"))) >=20 > That way the GC will keep Git around. > > Thoughts? That is not sufficient if git acquires a graft. Can elixir be patched to not compress the literals table (*)? Alternatively, does deflate have some kind of "compression level=3D0" setting -- perhaps we could do the same trick as done for JARs? (*) Preferably submitted upstream in some form, maybe with a configuration flag? Greetings, Maxime. --=-xxIDBDr6DNllgrljEoko Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYivFrhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kQFAQDv0QE3g+zx0/zoD5Tq3+UTeZ0U A0svmRKtHiJ2XDjuJgEApzTC/9Y3SGpZvFMxYXvgsjZwjCNroM6i11ggtK25dQw= =vPIB -----END PGP SIGNATURE----- --=-xxIDBDr6DNllgrljEoko-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 22:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice Reply-To: Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164703608218239 (code B ref 54304); Fri, 11 Mar 2022 22:02:02 +0000 Received: (at 54304) by debbugs.gnu.org; 11 Mar 2022 22:01:22 +0000 Received: from localhost ([127.0.0.1]:38552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnK5-0004k7-Sj for submit@debbugs.gnu.org; Fri, 11 Mar 2022 17:01:22 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:26706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnK2-0004jr-G5 for 54304@debbugs.gnu.org; Fri, 11 Mar 2022 17:01:19 -0500 Date: Fri, 11 Mar 2022 22:01:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1647036071; bh=5oveswrinJl9U8wN8MPMBpF+wVJ5SASn9ICmadXFQKU=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=onIN8QzlX3TLw2asz3DPZTocZOC1YVqHHWFEK8Ph0kRDByq4WAXI2gTu83OKEoijN Z8FAQsWFj+XYXwq8vsNGUqgMpC0+gu3RQmqpZOB0tdLVYYarmYp6SoiPRSmWvE+60h jPuXmo7h/r5C5NEdWK7Xdhemi9mUm9I3QrYchVuaB7jMCnOAK7nT+VS6Um/ESeIT2s fsnzsB+Bp2BUi/qCwawMWQkxWDbvppllDi6iaYZRkhOZxJBIXlx7NOdsEd/gPmKTP4 3fv3Aqs//Mz3ffaLBz97q1BRj6Zi/it/Ciy9twac1acPizqYBO4cikPsAcSotP2tPe 3Ttg8M7POXSDA== From: Cees de Groot Message-ID: In-Reply-To: <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_TiwZrjxJG7ZbwFfWJgkHlt9ptcRnNcfjziD3UNleaM" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_TiwZrjxJG7ZbwFfWJgkHlt9ptcRnNcfjziD3UNleaM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 Q2Fu4oCZdCB3ZSBqdXN0IHJ1biB0aGUgcGF0Y2g/IFRoZW4gZXZlcnl0aGluZyB3b3JrcyBqdXN0 IGZpbmUuIEnigJltIGEgZnVsbCB0aW1lIEVsaXhpciBkZXZlbG9wZXIgYW5kIEkgY2FuIGd1YXJh bnRlZSB5b3UgdGhhdCBub3RoaW5nIHdpbGwgYnJlYWsgOikKClNlbnQgZnJvbSBQcm90b25NYWls IGZvciBpT1MKCk9uIEZyaSwgTWFyIDExLCAyMDIyIGF0IDE2OjU3LCBNYXhpbWUgRGV2b3MgPG1h eGltZWRldm9zQHRlbGVuZXQuYmU+IHdyb3RlOgoKPiBMdWRvdmljIENvdXJ0w6hzIHNjaHJlZWYg b3AgdnIgMTEtMDMtMjAyMiBvbSAyMjo1MSBbKzAxMDBdOgo+PiBJZiB3ZSBrbm93IHdoYXQgc2V0 IG9mIHN0b3JlIHJlZmVyZW5jZXMgZ28gaW4gdGhvc2UgYmxvZ3MsIHdlIGNvdWxkCj4+IGNyZWF0 ZSBhIHRleHQgZmlsZSBvciBzb21ldGhpbmcgaW4gIyRvdXRwdXQgd2hvc2Ugc29sZSBwdXJwb3Nl IGlzIHRvCj4+IGtlZXAgYSByZWZlcmVuY2UgdG8gdGhvc2Ugc3RvcmUgaXRlbXMuCj4+Cj4+IEZv ciBleGFtcGxlLCBpZiB3ZSBrbm93IHRob3NlIEJFQU0gZmlsZXMgY29udGFpbiBhIHJlZmVyZW5j ZSB0byBHaXQsIHdlCj4+IGNhbiBhZGQgYSBwaGFzZSBsaWtlOgo+Pgo+PiAobGFtYmRhKiAoIzpr ZXkgaW5wdXRzIG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQo+PiAoc3ltbGluayAoc2VhcmNo LWlucHV0LWZpbGUgaW5wdXRzICJnaXQiKQo+Cj4gRG9lc24ndCB0aGF0IG5lZWQgdG8gYmUgImJp bi9naXQiIGluc3RlYWQgb2YgImdpdCI/Cj4KPj4gKHN0cmluZy1hcHBlbmQgKGFzc29jLXJlZiBv dXRwdXQgIm91dCIpCj4+ICIvbGliZXhlYy9lbGl4aXIvLmdpdCIpKSkKPj4KPj4gVGhhdCB3YXkg dGhlIEdDIHdpbGwga2VlcCBHaXQgYXJvdW5kLgo+Pgo+PiBUaG91Z2h0cz8KPgo+IFRoYXQgaXMg bm90IHN1ZmZpY2llbnQgaWYgZ2l0IGFjcXVpcmVzIGEgZ3JhZnQuCj4KPiBDYW4gZWxpeGlyIGJl IHBhdGNoZWQgdG8gbm90IGNvbXByZXNzIHRoZSBsaXRlcmFscyB0YWJsZSAoKik/Cj4gQWx0ZXJu YXRpdmVseSwgZG9lcyBkZWZsYXRlIGhhdmUgc29tZSBraW5kIG9mICJjb21wcmVzc2lvbgo+IGxl dmVsPTAiIHNldHRpbmcgLS0gcGVyaGFwcyB3ZSBjb3VsZCBkbyB0aGUgc2FtZSB0cmljayBhcwo+ IGRvbmUgZm9yIEpBUnM/Cj4KPiAoKikgUHJlZmVyYWJseSBzdWJtaXR0ZWQgdXBzdHJlYW0gaW4g c29tZSBmb3JtLCBtYXliZSB3aXRoIGEKPiBjb25maWd1cmF0aW9uIGZsYWc/Cj4KPiBHcmVldGlu Z3MsCj4gTWF4aW1lLg== --b1_TiwZrjxJG7ZbwFfWJgkHlt9ptcRnNcfjziD3UNleaM Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGh0bWw+PGhlYWQ+PC9oZWFkPjxib2R5PiAgIDxkaXY+Q2Fu4oCZdCB3ZSBqdXN0IHJ1biB0aGUg cGF0Y2g/IFRoZW4gZXZlcnl0aGluZyB3b3JrcyBqdXN0IGZpbmUuIEnigJltIGEgZnVsbCB0aW1l IEVsaXhpciBkZXZlbG9wZXIgYW5kIEkgY2FuIGd1YXJhbnRlZSB5b3UgdGhhdCBub3RoaW5nIHdp bGwgYnJlYWsgOik8Y2FyZXQ+PC9jYXJldD48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2IGlkPSJw cm90b25tYWlsX21vYmlsZV9zaWduYXR1cmVfYmxvY2siPjxkaXY+U2VudCBmcm9tIFByb3Rvbk1h aWwgZm9yIGlPUzwvZGl2PjwvZGl2PiA8ZGl2Pjxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj5PbiBG cmksIE1hciAxMSwgMjAyMiBhdCAxNjo1NywgTWF4aW1lIERldm9zICZsdDs8YSBocmVmPSJtYWls dG86bWF4aW1lZGV2b3NAdGVsZW5ldC5iZSIgY2xhc3M9IiI+bWF4aW1lZGV2b3NAdGVsZW5ldC5i ZTwvYT4mZ3Q7IHdyb3RlOjxibG9ja3F1b3RlIGNsYXNzPSJwcm90b25tYWlsX3F1b3RlIiB0eXBl PSJjaXRlIj4gIDxicj48YnI+THVkb3ZpYyBDb3VydMOocyBzY2hyZWVmIG9wIHZyIDExLTAzLTIw MjIgb20gMjI6NTEgWyswMTAwXTo8YnI+Jmd0OyBJZiB3ZSBrbm93IHdoYXQgc2V0IG9mIHN0b3Jl IHJlZmVyZW5jZXMgZ28gaW4gdGhvc2UgYmxvZ3MsIHdlIGNvdWxkPGJyPiZndDsgY3JlYXRlIGEg dGV4dCBmaWxlIG9yIHNvbWV0aGluZyBpbiAjJG91dHB1dCB3aG9zZSBzb2xlIHB1cnBvc2UgaXMg dG88YnI+Jmd0OyBrZWVwIGEgcmVmZXJlbmNlIHRvIHRob3NlIHN0b3JlIGl0ZW1zLjxicj4mZ3Q7 IDxicj4mZ3Q7IEZvciBleGFtcGxlLCBpZiB3ZSBrbm93IHRob3NlIEJFQU0gZmlsZXMgY29udGFp biBhIHJlZmVyZW5jZSB0byBHaXQsIHdlPGJyPiZndDsgY2FuIGFkZCBhIHBoYXNlIGxpa2U6PGJy PiZndDsgPGJyPiZndDsgICAobGFtYmRhKiAoIzprZXkgaW5wdXRzIG91dHB1dHMgIzphbGxvdy1v dGhlci1rZXlzKTxicj4mZ3Q7ICAgICAoc3ltbGluayAoc2VhcmNoLWlucHV0LWZpbGUgaW5wdXRz ICJnaXQiKTxicj48YnI+RG9lc24ndCB0aGF0IG5lZWQgdG8gYmUgImJpbi9naXQiIGluc3RlYWQg b2YgImdpdCI/PGJyPjxicj4mZ3Q7ICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAoYXNzb2Mt cmVmIG91dHB1dCAib3V0Iik8YnI+Jmd0OyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIi9s aWJleGVjL2VsaXhpci8uZ2l0IikpKTxicj4mZ3Q7IDxicj4mZ3Q7IFRoYXQgd2F5IHRoZSBHQyB3 aWxsIGtlZXAgR2l0IGFyb3VuZC48YnI+Jmd0Ozxicj4mZ3Q7IFRob3VnaHRzPzxicj48YnI+VGhh dCBpcyBub3Qgc3VmZmljaWVudCBpZiBnaXQgYWNxdWlyZXMgYSBncmFmdC48YnI+PGJyPkNhbiBl bGl4aXIgYmUgcGF0Y2hlZCB0byBub3QgY29tcHJlc3MgdGhlIGxpdGVyYWxzIHRhYmxlICgqKT88 YnI+QWx0ZXJuYXRpdmVseSwgZG9lcyBkZWZsYXRlIGhhdmUgc29tZSBraW5kIG9mICJjb21wcmVz c2lvbjxicj5sZXZlbD0wIiBzZXR0aW5nIC0tIHBlcmhhcHMgd2UgY291bGQgZG8gdGhlIHNhbWUg dHJpY2sgYXM8YnI+ZG9uZSBmb3IgSkFScz88YnI+PGJyPigqKSBQcmVmZXJhYmx5IHN1Ym1pdHRl ZCB1cHN0cmVhbSBpbiBzb21lIGZvcm0sIG1heWJlIHdpdGggYTxicj5jb25maWd1cmF0aW9uIGZs YWc/PGJyPjxicj5HcmVldGluZ3MsPGJyPk1heGltZS48L2Jsb2NrcXVvdGU+PGRpdj48YnI+PC9k aXY+PGRpdj48YnI+PC9kaXY+PC9ib2R5PjwvaHRtbD4= --b1_TiwZrjxJG7ZbwFfWJgkHlt9ptcRnNcfjziD3UNleaM-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 22:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164703668819255 (code B ref 54304); Fri, 11 Mar 2022 22:12:02 +0000 Received: (at 54304) by debbugs.gnu.org; 11 Mar 2022 22:11:28 +0000 Received: from localhost ([127.0.0.1]:38582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnTs-00050V-Jy for submit@debbugs.gnu.org; Fri, 11 Mar 2022 17:11:28 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:57896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnTq-00050M-Uu for 54304@debbugs.gnu.org; Fri, 11 Mar 2022 17:11:27 -0500 Received: from [172.20.10.5] ([188.188.45.72]) by albert.telenet-ops.be with bizsmtp id 5ABQ2700K1ZSGwU06ABR6z; Fri, 11 Mar 2022 23:11:25 +0100 Message-ID: From: Maxime Devos Date: Fri, 11 Mar 2022 23:11:24 +0100 In-Reply-To: References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-aCP/ccjXBevIayx+BQGq" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647036685; bh=aAogcOfcDsI3719QaCZPxi+f2nSggM60kA3Rd8SouII=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=UBtkoYMnkgem0gs27K/N/c/tHhtYvzFDC2fwgvReOEJ6xxGqhO4fX7nGOvValqVrk 5N7sCoIAuUQNaVRga4Lf2sP4YB38Lt/as7KWzx0wOyKZzE2McY85KdA4gqswKCN9t+ 6Xfe/LYWe/9MhukkofFCwnQtZqBjVEwDp4/oxFgwF+q1b6++s0T4zNCCp734ZYKdaU I5+SeM0JH2o7tUhUdVbhdMrXAoEE7p0dw0fueHR4C8RgSfwzVA048QM6jeLUdskuo+ M7UY7sDD9k3cvpcyLnpLJM6W23WfhOfnyfwnOOzcLRkOEsTFkcNB97Bf/zmN9i7v73 e75o5Hk608ZAw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-aCP/ccjXBevIayx+BQGq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cees de Groot schreef op vr 11-03-2022 om 22:01 [+0000]: > Can=E2=80=99t we just run the patch? Then everything works just fine. I= =E2=80=99m a > full time Elixir developer and I can guarantee you that nothing will > break :) FWIW, I'm not convinced of the value of removing 'git', as I don't expect a significant decrease in closure size and it makes Elixir a little less usable (only a tiny bit because git can be installed manually, but still a bit). The only remaining reasons for removing it, appear to be avoiding having to tackle the reference obfuscating issue -- sooner or later (*), I expect there will eventually be an elixir-build-system and a few elixir packages. These elixir packages might need a few 'substitute*'- style hardcoding. So eventually, I expect the issue will reappear again and frequently at that, so we might as well try to fix it now. (*) Especially since there's an Elixir developer in Guix! Greetings, Maxime. --=-aCP/ccjXBevIayx+BQGq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYivJDBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7uuqAP0T6doKwP5/zl/ETzuDZgSUok/Q Hczbx6sO5EiNetOuGQD+L9YSoyr0/ltHQpZYddoG+2H2+KNqZCZAbeiql9/sWgE= =yyJs -----END PGP SIGNATURE----- --=-aCP/ccjXBevIayx+BQGq-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 22:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice Reply-To: Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164703821630170 (code B ref 54304); Fri, 11 Mar 2022 22:37:02 +0000 Received: (at 54304) by debbugs.gnu.org; 11 Mar 2022 22:36:56 +0000 Received: from localhost ([127.0.0.1]:38632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnsW-0007qY-23 for submit@debbugs.gnu.org; Fri, 11 Mar 2022 17:36:56 -0500 Received: from mail-40136.proton.ch ([185.70.40.136]:58751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnsU-0007qK-Dp for 54304@debbugs.gnu.org; Fri, 11 Mar 2022 17:36:54 -0500 Date: Fri, 11 Mar 2022 22:36:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1647038207; bh=Jos5XE2k91/QRR3Adb4KZ61rFavXvKzUunOc2hyaNnw=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=iwF87fkD/e/zD/fQx0rOsHzc4L9kU+72hQ5VBKLqYqmjzelMf2NgNm0SYOqq7nMS8 RHXiizjJYv25x9olVjqxfapKhIGW7MvLpXzSbGZwJ8t1JG+dbkFhP6717htYrnDftS Sq9RzJ0gKZ8u5beWSgd8gwerthBbnt5z0lY0DS9xTyZ+AUE9edjVgE4pSqeh263P8r gSGNy9RzpANIGNucjJyASi/e4heSAILzgTpB2Jfs0GuYJsDlHjlVlGmFGZzdlB6kEb 0pqmwRjgzShpL0Nzhg8hFMo0qJrrCepYzE/2tlMf3DSNcLorK/KKQVKjF6YnOSjBo3 iU/4Fcq6u95kg== From: Cees de Groot Message-ID: In-Reply-To: References: <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_CLrGvTxJTg0tGBgXUJQV8p0x4pwLZC0IEP7TcQlPwfc" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_CLrGvTxJTg0tGBgXUJQV8p0x4pwLZC0IEP7TcQlPwfc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 V2VsbCwgZmVlbCBmcmVlIHRvIGRvIHRoZSBwYXRjaGluZyB3b3JrLiBSZWFsaXplIHRoYXQgeW91 IGFyZSBnb2luZyB0byBkbyB3b3JrIGZvciBhKSBhIHZlcnkgc21hbGwgZ3JvdXAgb2YgZGV2ZWxv cGVycyAoRWxpeGlyIGlzIGEgc21hbGwgbGFuZ3VhZ2UgYW5kIEd1aXggaXNu4oCZdCBoYXJkbHkg YSB3aWRlbHkgc3ByZWFkIHN5c3RlbSB0byBiZWdpbiB3aXRoKSwgYikgYSBzdWJzZXQgb2YgdGhv c2UgdGhhdCBuZWVkIGdpdCBkZXBlbmRlbmNpZXMsIGFuZCBjKSBhIHN1YnNldCBvZiBfdGhvc2Vf IHRoYXQgbmVlZCB0aGVzZSBkZXBlbmRlbmNpZXMgb24gYSBwcm9qZWN0IHNvdXJjZSB0cmVlIHRo YXQgaXRzZWxmIHdhcyBub3QgY2hlY2tlZCBvdXQgd2l0aCBnaXQgKG90aGVyd2lzZSB0aGUgZ2l0 IGV4ZWN1dGFibGUgd2lsbCBhbHJlYWR5IGJlIGluIHRoZSBlbnZpcm9ubWVudCBhbmQgZXZlcnl0 aGluZyB3aWxsIHdvcmspLgoKUGxlYXNlIGxldCBtZSBrbm93IHdoZW4geW91IGZvdW5kIHRoYXQg dW5pY29ybiBkZXZlbG9wZXIgOikKClNlbnQgZnJvbSBQcm90b25NYWlsIGZvciBpT1MKCk9uIEZy aSwgTWFyIDExLCAyMDIyIGF0IDE3OjExLCBNYXhpbWUgRGV2b3MgPG1heGltZWRldm9zQHRlbGVu ZXQuYmU+IHdyb3RlOgoKPiBDZWVzIGRlIEdyb290IHNjaHJlZWYgb3AgdnIgMTEtMDMtMjAyMiBv bSAyMjowMSBbKzAwMDBdOgo+PiBDYW7igJl0IHdlIGp1c3QgcnVuIHRoZSBwYXRjaD8gVGhlbiBl dmVyeXRoaW5nIHdvcmtzIGp1c3QgZmluZS4gSeKAmW0gYQo+PiBmdWxsIHRpbWUgRWxpeGlyIGRl dmVsb3BlciBhbmQgSSBjYW4gZ3VhcmFudGVlIHlvdSB0aGF0IG5vdGhpbmcgd2lsbAo+PiBicmVh ayA6KQo+Cj4gRldJVywgSSdtIG5vdCBjb252aW5jZWQgb2YgdGhlIHZhbHVlIG9mIHJlbW92aW5n ICdnaXQnLCBhcyBJIGRvbid0Cj4gZXhwZWN0IGEgc2lnbmlmaWNhbnQgZGVjcmVhc2UgaW4gY2xv c3VyZSBzaXplIGFuZCBpdCBtYWtlcyBFbGl4aXIgYQo+IGxpdHRsZSBsZXNzIHVzYWJsZSAob25s eSBhIHRpbnkgYml0IGJlY2F1c2UgZ2l0IGNhbiBiZSBpbnN0YWxsZWQKPiBtYW51YWxseSwgYnV0 IHN0aWxsIGEgYml0KS4KPgo+IFRoZSBvbmx5IHJlbWFpbmluZyByZWFzb25zIGZvciByZW1vdmlu ZyBpdCwgYXBwZWFyIHRvIGJlIGF2b2lkaW5nCj4gaGF2aW5nIHRvIHRhY2tsZSB0aGUgcmVmZXJl bmNlIG9iZnVzY2F0aW5nIGlzc3VlIC0tIHNvb25lciBvciBsYXRlcgo+ICgqKSwgSSBleHBlY3Qg dGhlcmUgd2lsbCBldmVudHVhbGx5IGJlIGFuIGVsaXhpci1idWlsZC1zeXN0ZW0gYW5kIGEgZmV3 Cj4gZWxpeGlyIHBhY2thZ2VzLiBUaGVzZSBlbGl4aXIgcGFja2FnZXMgbWlnaHQgbmVlZCBhIGZl dyAnc3Vic3RpdHV0ZSonLQo+IHN0eWxlIGhhcmRjb2RpbmcuIFNvIGV2ZW50dWFsbHksIEkgZXhw ZWN0IHRoZSBpc3N1ZSB3aWxsIHJlYXBwZWFyCj4gYWdhaW4gYW5kIGZyZXF1ZW50bHkgYXQgdGhh dCwgc28gd2UgbWlnaHQgYXMgd2VsbCB0cnkgdG8gZml4IGl0IG5vdy4KPgo+ICgqKSBFc3BlY2lh bGx5IHNpbmNlIHRoZXJlJ3MgYW4gRWxpeGlyIGRldmVsb3BlciBpbiBHdWl4IQo+Cj4gR3JlZXRp bmdzLAo+IE1heGltZS4= --b1_CLrGvTxJTg0tGBgXUJQV8p0x4pwLZC0IEP7TcQlPwfc Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGh0bWw+PGhlYWQ+PC9oZWFkPjxib2R5PiAgIDxkaXY+V2VsbCwgZmVlbCBmcmVlIHRvIGRvIHRo ZSBwYXRjaGluZyB3b3JrLiBSZWFsaXplIHRoYXQgeW91IGFyZSBnb2luZyB0byBkbyB3b3JrIGZv ciBhKSBhIHZlcnkgc21hbGwgZ3JvdXAgb2YgZGV2ZWxvcGVycyAoRWxpeGlyIGlzIGEgc21hbGwg bGFuZ3VhZ2UgYW5kIEd1aXggaXNu4oCZdCBoYXJkbHkgYSB3aWRlbHkgc3ByZWFkIHN5c3RlbSB0 byBiZWdpbiB3aXRoKSwgYikgYSBzdWJzZXQgb2YgdGhvc2UgdGhhdCBuZWVkIGdpdCBkZXBlbmRl bmNpZXMsIGFuZCBjKSBhIHN1YnNldCBvZiBfdGhvc2VfIHRoYXQgbmVlZCB0aGVzZSBkZXBlbmRl bmNpZXMgb24gYSBwcm9qZWN0IHNvdXJjZSB0cmVlIHRoYXQgaXRzZWxmIHdhcyBub3QgY2hlY2tl ZCBvdXQgd2l0aCBnaXQgKG90aGVyd2lzZSB0aGUgZ2l0IGV4ZWN1dGFibGUgd2lsbCBhbHJlYWR5 IGJlIGluIHRoZSBlbnZpcm9ubWVudCBhbmQgZXZlcnl0aGluZyB3aWxsIHdvcmspLiZuYnNwOzwv ZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+UGxlYXNlIGxldCBtZSBrbm93IHdoZW4geW91IGZvdW5k IHRoYXQgdW5pY29ybiBkZXZlbG9wZXIgOik8L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PjxjYXJl dD48L2NhcmV0Pjxicj48L2Rpdj48ZGl2IGlkPSJwcm90b25tYWlsX21vYmlsZV9zaWduYXR1cmVf YmxvY2siPjxkaXY+U2VudCBmcm9tIFByb3Rvbk1haWwgZm9yIGlPUzwvZGl2PjwvZGl2PiA8ZGl2 Pjxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj5PbiBGcmksIE1hciAxMSwgMjAyMiBhdCAxNzoxMSwg TWF4aW1lIERldm9zICZsdDs8YSBocmVmPSJtYWlsdG86bWF4aW1lZGV2b3NAdGVsZW5ldC5iZSIg Y2xhc3M9IiI+bWF4aW1lZGV2b3NAdGVsZW5ldC5iZTwvYT4mZ3Q7IHdyb3RlOjxibG9ja3F1b3Rl IGNsYXNzPSJwcm90b25tYWlsX3F1b3RlIiB0eXBlPSJjaXRlIj4gIDxicj48YnI+Q2VlcyBkZSBH cm9vdCBzY2hyZWVmIG9wIHZyIDExLTAzLTIwMjIgb20gMjI6MDEgWyswMDAwXTo8YnI+Jmd0OyBD YW7igJl0IHdlIGp1c3QgcnVuIHRoZSBwYXRjaD8gVGhlbiBldmVyeXRoaW5nIHdvcmtzIGp1c3Qg ZmluZS4gSeKAmW0gYTxicj4mZ3Q7IGZ1bGwgdGltZSBFbGl4aXIgZGV2ZWxvcGVyIGFuZCBJIGNh biBndWFyYW50ZWUgeW91IHRoYXQgbm90aGluZyB3aWxsPGJyPiZndDsgYnJlYWsgOik8YnI+PGJy PkZXSVcsIEknbSBub3QgY29udmluY2VkIG9mIHRoZSB2YWx1ZSBvZiByZW1vdmluZyAnZ2l0Jywg YXMgSSBkb24ndDxicj5leHBlY3QgYSBzaWduaWZpY2FudCBkZWNyZWFzZSBpbiBjbG9zdXJlIHNp emUgYW5kIGl0IG1ha2VzIEVsaXhpciBhPGJyPmxpdHRsZSBsZXNzIHVzYWJsZSAob25seSBhIHRp bnkgYml0IGJlY2F1c2UgZ2l0IGNhbiBiZSBpbnN0YWxsZWQ8YnI+bWFudWFsbHksIGJ1dCBzdGls bCBhIGJpdCkuPGJyPjxicj5UaGUgb25seSByZW1haW5pbmcgcmVhc29ucyBmb3IgcmVtb3Zpbmcg aXQsIGFwcGVhciB0byBiZSBhdm9pZGluZzxicj5oYXZpbmcgdG8gdGFja2xlIHRoZSByZWZlcmVu Y2Ugb2JmdXNjYXRpbmcgaXNzdWUgLS0gc29vbmVyIG9yIGxhdGVyPGJyPigqKSwgSSBleHBlY3Qg dGhlcmUgd2lsbCBldmVudHVhbGx5IGJlIGFuIGVsaXhpci1idWlsZC1zeXN0ZW0gYW5kIGEgZmV3 PGJyPmVsaXhpciBwYWNrYWdlcy4gIFRoZXNlIGVsaXhpciBwYWNrYWdlcyBtaWdodCBuZWVkIGEg ZmV3ICdzdWJzdGl0dXRlKictPGJyPnN0eWxlIGhhcmRjb2RpbmcuICBTbyBldmVudHVhbGx5LCBJ IGV4cGVjdCB0aGUgaXNzdWUgd2lsbCByZWFwcGVhcjxicj5hZ2FpbiBhbmQgZnJlcXVlbnRseSBh dCB0aGF0LCBzbyB3ZSBtaWdodCBhcyB3ZWxsIHRyeSB0byBmaXggaXQgbm93Ljxicj48YnI+KCop IEVzcGVjaWFsbHkgc2luY2UgdGhlcmUncyBhbiBFbGl4aXIgZGV2ZWxvcGVyIGluIEd1aXghPGJy Pjxicj5HcmVldGluZ3MsPGJyPk1heGltZS48L2Jsb2NrcXVvdGU+PGRpdj48YnI+PC9kaXY+PGRp dj48YnI+PC9kaXY+PC9ib2R5PjwvaHRtbD4= --b1_CLrGvTxJTg0tGBgXUJQV8p0x4pwLZC0IEP7TcQlPwfc-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 22:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164703875831036 (code B ref 54304); Fri, 11 Mar 2022 22:46:01 +0000 Received: (at 54304) by debbugs.gnu.org; 11 Mar 2022 22:45:58 +0000 Received: from localhost ([127.0.0.1]:38651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSo1F-00084V-SA for submit@debbugs.gnu.org; Fri, 11 Mar 2022 17:45:58 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:33540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSo1E-00084N-6x for 54304@debbugs.gnu.org; Fri, 11 Mar 2022 17:45:56 -0500 Received: from [172.20.10.5] ([188.188.45.72]) by laurent.telenet-ops.be with bizsmtp id 5Alt2700K1ZSGwU01Aluit; Fri, 11 Mar 2022 23:45:54 +0100 Message-ID: <3df7ef98867c4077efc34a335b193a6fda333cb2.camel@telenet.be> From: Maxime Devos Date: Fri, 11 Mar 2022 23:45:53 +0100 In-Reply-To: References: <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-N5FjIaWg6QaHheKB4z2F" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647038754; bh=7OGJwGr0a+vNwFZUzKOJXBVTVfHD7sRN3PCQ8koKcEY=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=KtiKlw0mAWo2uSCQzXddSOASrZkOfheQ4pHNvDugFRoAYuyPmxM/mLLMKpwmNTd9y UGO9tnv1fTzMlBb0uUG9VgLIld/Fo2EGpKuUsWg/720GJDxEQQPJ2YSOsUqLYPcj23 Jxr0IhdCWzcNw+dPCPAU6tIrPA/x7wy0D1QOlFPPpoaIanOvRAig6Yt8qgxM0bcvNu 6oMzCjgqvEClu2r4AXSDuX0tts/XFoluvh3/VFVH0g11bYdctUWjxTqK5KVDKjbXMm yqWs3lVsB7SXJcSXlSAYHN1Vfn+g74xu0V2hwcxrPfoW4PaERQRR+JT4hHHS6ab7EQ jxY7aLbjNxiaQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-N5FjIaWg6QaHheKB4z2F Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cees de Groot schreef op vr 11-03-2022 om 22:36 [+0000]: > Well, feel free to do the patching work. Realize that you are going > to do work for a) a very small group of developers (Elixir is a small > language and Guix isn=E2=80=99t hardly a widely spread system to begin wi= th), > b) a subset of those that need git dependencies, and c) a subset of > _those_ that need these dependencies on a project source tree that > itself was not checked out with git (otherwise the git executable > will already be in the environment and everything will work).=C2=A0 This is not only for the subset that uses git dependencies. It is for anyone writing and using Elixir packages, see my paragraph about reference baking (in general, not git-specific): > The only remaining reasons for removing it, appear to be avoiding > having to tackle the reference obfuscating issue -- sooner or later > (*), I expect there will eventually be an elixir-build-system and a > few elixir packages. These elixir packages might need a few > 'substitute*'- style hardcoding. So eventually, I expect the issue > will reappear again and frequently at that, so we might as well try > to fix it now. More specifically, you could look at how, say, 'info-reader' uses 'substitute*', 'search-input-file', 'gunzip' and 'gzip' Greetings, Maxime. --=-N5FjIaWg6QaHheKB4z2F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYivRIRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7opGAQCCAAUNyCWGHd4XPvnKKtlP3h0W 2iC1voPQRxJ1bpWHjwD+OlMO0b8648Y2DvzND/g2+M2qIReLNRQvfj9XDrcpywc= =HJ63 -----END PGP SIGNATURE----- --=-N5FjIaWg6QaHheKB4z2F-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 22:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice Reply-To: Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164703933732038 (code B ref 54304); Fri, 11 Mar 2022 22:56:02 +0000 Received: (at 54304) by debbugs.gnu.org; 11 Mar 2022 22:55:37 +0000 Received: from localhost ([127.0.0.1]:38656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSoAa-0008Kg-Qr for submit@debbugs.gnu.org; Fri, 11 Mar 2022 17:55:37 -0500 Received: from mail-40136.proton.ch ([185.70.40.136]:55072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSoAZ-0008KS-47 for 54304@debbugs.gnu.org; Fri, 11 Mar 2022 17:55:35 -0500 Date: Fri, 11 Mar 2022 22:55:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1647039328; bh=ZOmLVGG28f6fgjtHyjStsofLb/vgyeT6JGZ2U3gh2T8=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=D2oGq/i9IKCS19ZUEcY82JIArWccgmi34uBV6oRVqOI9yBDFQAPsuWMUFueZxYKMg i0+WkiigzRnEcn19e1lGfE8FvDmP7IczObe51VpWEzeOY2qUWNvJvkZylDPGK8ccUe bE1yzmmRHwwGytAixca3oM7VRmpU7xpfDHKb2VqfMpo9M2i5tS0NPRIoQ5jPsCqadH T67sbrlFzSVPhm4FIStkIDOuKU7d2vie8GGImWt0JIGtLCF/UqS0hldcjU6Uh4RqQ1 nIXGISC2cfsTCLE2cRX52uJ1uDh8SA17XG6IYwlUBz6jxU/uMN3Sp41M8nvawu8Q0h tLFuoAioTylxA== From: Cees de Groot Message-ID: In-Reply-To: <3df7ef98867c4077efc34a335b193a6fda333cb2.camel@telenet.be> References: <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> <3df7ef98867c4077efc34a335b193a6fda333cb2.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_mseCJc9odfuGnN4on0mkHQlWw4gff6jxzeizSN22s" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_mseCJc9odfuGnN4on0mkHQlWw4gff6jxzeizSN22s Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SWYgR3VpeCBldmVyIGdldHMgZWxpeGlyIHBhY2thZ2VzLCB0aGF0IGNhbiBiZSB0YWNrbGVkLgoK SeKAmW0gYm93aW5nIG91dCBvZiB0aGlzIGRpc2N1c3Npb24uIElmIG15IHBhdGNoIGdldHMgYWNj ZXB0ZWQgdGhlbiBhbGwgZ29vZCwgaWYgbm90LCBJ4oCZbGwgbW92ZSBpdCB0byBteSBwcml2YXRl IGNoYW5uZWwgYW5kIGtlZXAgYmVpbmcgaGFwcHkgdGhlcmUuCgpTZW50IGZyb20gUHJvdG9uTWFp bCBmb3IgaU9TCgpPbiBGcmksIE1hciAxMSwgMjAyMiBhdCAxNzo0NSwgTWF4aW1lIERldm9zIDxt YXhpbWVkZXZvc0B0ZWxlbmV0LmJlPiB3cm90ZToKCj4gQ2VlcyBkZSBHcm9vdCBzY2hyZWVmIG9w IHZyIDExLTAzLTIwMjIgb20gMjI6MzYgWyswMDAwXToKPj4gV2VsbCwgZmVlbCBmcmVlIHRvIGRv IHRoZSBwYXRjaGluZyB3b3JrLiBSZWFsaXplIHRoYXQgeW91IGFyZSBnb2luZwo+PiB0byBkbyB3 b3JrIGZvciBhKSBhIHZlcnkgc21hbGwgZ3JvdXAgb2YgZGV2ZWxvcGVycyAoRWxpeGlyIGlzIGEg c21hbGwKPj4gbGFuZ3VhZ2UgYW5kIEd1aXggaXNu4oCZdCBoYXJkbHkgYSB3aWRlbHkgc3ByZWFk IHN5c3RlbSB0byBiZWdpbiB3aXRoKSwKPj4gYikgYSBzdWJzZXQgb2YgdGhvc2UgdGhhdCBuZWVk IGdpdCBkZXBlbmRlbmNpZXMsIGFuZCBjKSBhIHN1YnNldCBvZgo+PiBfdGhvc2VfIHRoYXQgbmVl ZCB0aGVzZSBkZXBlbmRlbmNpZXMgb24gYSBwcm9qZWN0IHNvdXJjZSB0cmVlIHRoYXQKPj4gaXRz ZWxmIHdhcyBub3QgY2hlY2tlZCBvdXQgd2l0aCBnaXQgKG90aGVyd2lzZSB0aGUgZ2l0IGV4ZWN1 dGFibGUKPj4gd2lsbCBhbHJlYWR5IGJlIGluIHRoZSBlbnZpcm9ubWVudCBhbmQgZXZlcnl0aGlu ZyB3aWxsIHdvcmspLgo+Cj4gVGhpcyBpcyBub3Qgb25seSBmb3IgdGhlIHN1YnNldCB0aGF0IHVz ZXMgZ2l0IGRlcGVuZGVuY2llcy4gSXQgaXMgZm9yCj4gYW55b25lIHdyaXRpbmcgYW5kIHVzaW5n IEVsaXhpciBwYWNrYWdlcywgc2VlIG15IHBhcmFncmFwaCBhYm91dAo+IHJlZmVyZW5jZSBiYWtp bmcgKGluIGdlbmVyYWwsIG5vdCBnaXQtc3BlY2lmaWMpOgo+Cj4+IFRoZSBvbmx5IHJlbWFpbmlu ZyByZWFzb25zIGZvciByZW1vdmluZyBpdCwgYXBwZWFyIHRvIGJlIGF2b2lkaW5nCj4+IGhhdmlu ZyB0byB0YWNrbGUgdGhlIHJlZmVyZW5jZSBvYmZ1c2NhdGluZyBpc3N1ZSAtLSBzb29uZXIgb3Ig bGF0ZXIKPj4gKCopLCBJIGV4cGVjdCB0aGVyZSB3aWxsIGV2ZW50dWFsbHkgYmUgYW4gZWxpeGly LWJ1aWxkLXN5c3RlbSBhbmQgYQo+PiBmZXcgZWxpeGlyIHBhY2thZ2VzLiBUaGVzZSBlbGl4aXIg cGFja2FnZXMgbWlnaHQgbmVlZCBhIGZldwo+PiAnc3Vic3RpdHV0ZSonLSBzdHlsZSBoYXJkY29k aW5nLiBTbyBldmVudHVhbGx5LCBJIGV4cGVjdCB0aGUgaXNzdWUKPj4gd2lsbCByZWFwcGVhciBh Z2FpbiBhbmQgZnJlcXVlbnRseSBhdCB0aGF0LCBzbyB3ZSBtaWdodCBhcyB3ZWxsIHRyeQo+PiB0 byBmaXggaXQgbm93Lgo+Cj4gTW9yZSBzcGVjaWZpY2FsbHksIHlvdSBjb3VsZCBsb29rIGF0IGhv dywgc2F5LCAnaW5mby1yZWFkZXInIHVzZXMKPiAnc3Vic3RpdHV0ZSonLCAnc2VhcmNoLWlucHV0 LWZpbGUnLCAnZ3VuemlwJyBhbmQgJ2d6aXAnCj4KPiBHcmVldGluZ3MsCj4gTWF4aW1lLg== --b1_mseCJc9odfuGnN4on0mkHQlWw4gff6jxzeizSN22s Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGh0bWw+PGhlYWQ+PC9oZWFkPjxib2R5PiAgIDxkaXY+SWYgR3VpeCBldmVyIGdldHMgZWxpeGly IHBhY2thZ2VzLCB0aGF0IGNhbiBiZSB0YWNrbGVkLiZuYnNwOzwvZGl2PjxkaXY+PGJyPjwvZGl2 PjxkaXY+SeKAmW0gYm93aW5nIG91dCBvZiB0aGlzIGRpc2N1c3Npb24uIElmIG15IHBhdGNoIGdl dHMgYWNjZXB0ZWQgdGhlbiBhbGwgZ29vZCwgaWYgbm90LCBJ4oCZbGwgbW92ZSBpdCB0byBteSBw cml2YXRlIGNoYW5uZWwgYW5kIGtlZXAgYmVpbmcgaGFwcHkgdGhlcmUuJm5ic3A7PGNhcmV0Pjwv Y2FyZXQ+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdiBpZD0icHJvdG9ubWFpbF9tb2JpbGVfc2ln bmF0dXJlX2Jsb2NrIj48ZGl2PlNlbnQgZnJvbSBQcm90b25NYWlsIGZvciBpT1M8L2Rpdj48L2Rp dj4gPGRpdj48YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+T24gRnJpLCBNYXIgMTEsIDIwMjIgYXQg MTc6NDUsIE1heGltZSBEZXZvcyAmbHQ7PGEgaHJlZj0ibWFpbHRvOm1heGltZWRldm9zQHRlbGVu ZXQuYmUiIGNsYXNzPSIiPm1heGltZWRldm9zQHRlbGVuZXQuYmU8L2E+Jmd0OyB3cm90ZTo8Ymxv Y2txdW90ZSBjbGFzcz0icHJvdG9ubWFpbF9xdW90ZSIgdHlwZT0iY2l0ZSI+ICA8YnI+PGJyPkNl ZXMgZGUgR3Jvb3Qgc2NocmVlZiBvcCB2ciAxMS0wMy0yMDIyIG9tIDIyOjM2IFsrMDAwMF06PGJy PiZndDsgV2VsbCwgZmVlbCBmcmVlIHRvIGRvIHRoZSBwYXRjaGluZyB3b3JrLiBSZWFsaXplIHRo YXQgeW91IGFyZSBnb2luZzxicj4mZ3Q7IHRvIGRvIHdvcmsgZm9yIGEpIGEgdmVyeSBzbWFsbCBn cm91cCBvZiBkZXZlbG9wZXJzIChFbGl4aXIgaXMgYSBzbWFsbDxicj4mZ3Q7IGxhbmd1YWdlIGFu ZCBHdWl4IGlzbuKAmXQgaGFyZGx5IGEgd2lkZWx5IHNwcmVhZCBzeXN0ZW0gdG8gYmVnaW4gd2l0 aCksPGJyPiZndDsgYikgYSBzdWJzZXQgb2YgdGhvc2UgdGhhdCBuZWVkIGdpdCBkZXBlbmRlbmNp ZXMsIGFuZCBjKSBhIHN1YnNldCBvZjxicj4mZ3Q7IF90aG9zZV8gdGhhdCBuZWVkIHRoZXNlIGRl cGVuZGVuY2llcyBvbiBhIHByb2plY3Qgc291cmNlIHRyZWUgdGhhdDxicj4mZ3Q7IGl0c2VsZiB3 YXMgbm90IGNoZWNrZWQgb3V0IHdpdGggZ2l0IChvdGhlcndpc2UgdGhlIGdpdCBleGVjdXRhYmxl PGJyPiZndDsgd2lsbCBhbHJlYWR5IGJlIGluIHRoZSBlbnZpcm9ubWVudCBhbmQgZXZlcnl0aGlu ZyB3aWxsIHdvcmspLiA8YnI+PGJyPlRoaXMgaXMgbm90IG9ubHkgZm9yIHRoZSBzdWJzZXQgdGhh dCB1c2VzIGdpdCBkZXBlbmRlbmNpZXMuICBJdCBpcyBmb3I8YnI+YW55b25lIHdyaXRpbmcgYW5k IHVzaW5nIEVsaXhpciBwYWNrYWdlcywgc2VlIG15IHBhcmFncmFwaCBhYm91dDxicj5yZWZlcmVu Y2UgYmFraW5nIChpbiBnZW5lcmFsLCBub3QgZ2l0LXNwZWNpZmljKTo8YnI+PGJyPiZndDsgVGhl IG9ubHkgcmVtYWluaW5nIHJlYXNvbnMgZm9yIHJlbW92aW5nIGl0LCBhcHBlYXIgdG8gYmUgYXZv aWRpbmc8YnI+Jmd0OyBoYXZpbmcgdG8gdGFja2xlIHRoZSByZWZlcmVuY2Ugb2JmdXNjYXRpbmcg aXNzdWUgLS0gc29vbmVyIG9yIGxhdGVyPGJyPiZndDsgKCopLCBJIGV4cGVjdCB0aGVyZSB3aWxs IGV2ZW50dWFsbHkgYmUgYW4gZWxpeGlyLWJ1aWxkLXN5c3RlbSBhbmQgYTxicj4mZ3Q7IGZldyBl bGl4aXIgcGFja2FnZXMuIFRoZXNlIGVsaXhpciBwYWNrYWdlcyBtaWdodCBuZWVkIGEgZmV3PGJy PiZndDsgJ3N1YnN0aXR1dGUqJy0gc3R5bGUgaGFyZGNvZGluZy4gU28gZXZlbnR1YWxseSwgSSBl eHBlY3QgdGhlIGlzc3VlPGJyPiZndDsgd2lsbCByZWFwcGVhciBhZ2FpbiBhbmQgZnJlcXVlbnRs eSBhdCB0aGF0LCBzbyB3ZSBtaWdodCBhcyB3ZWxsIHRyeTxicj4mZ3Q7IHRvIGZpeCBpdCBub3cu PGJyPjxicj5Nb3JlIHNwZWNpZmljYWxseSwgeW91IGNvdWxkIGxvb2sgYXQgaG93LCBzYXksICdp bmZvLXJlYWRlcicgdXNlczxicj4nc3Vic3RpdHV0ZSonLCAnc2VhcmNoLWlucHV0LWZpbGUnLCAn Z3VuemlwJyBhbmQgJ2d6aXAnPGJyPjxicj5HcmVldGluZ3MsPGJyPk1heGltZS48L2Jsb2NrcXVv dGU+PGRpdj48YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PC9ib2R5PjwvaHRtbD4= --b1_mseCJc9odfuGnN4on0mkHQlWw4gff6jxzeizSN22s-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 23:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.16470405921623 (code B ref 54304); Fri, 11 Mar 2022 23:17:01 +0000 Received: (at 54304) by debbugs.gnu.org; 11 Mar 2022 23:16:32 +0000 Received: from localhost ([127.0.0.1]:38691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSoUq-0000Q6-6b for submit@debbugs.gnu.org; Fri, 11 Mar 2022 18:16:32 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:54306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSoUo-0000Pw-2q for 54304@debbugs.gnu.org; Fri, 11 Mar 2022 18:16:31 -0500 Received: from [172.20.10.5] ([188.188.45.72]) by laurent.telenet-ops.be with bizsmtp id 5BGS2700K1ZSGwU01BGTMR; Sat, 12 Mar 2022 00:16:28 +0100 Message-ID: <13042012c34522fc9ed26746d11cc88b22f1ec6a.camel@telenet.be> From: Maxime Devos Date: Sat, 12 Mar 2022 00:16:18 +0100 In-Reply-To: References: <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-hNPcfrOiY2bT6aO645MV" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647040588; bh=lI0CyoF7r5drNMzgFzJ+5UhsafvZ6oPlkQsLPRN3eCo=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=g+f+kuAUBm78n1OEi6itsy+rizzAXGr0hf62JY+luLFteqe3knbWYtXpkk7iRGeqe xcHDOTMaRxenz89qX8cGzSZzuQ+xmu1nMFJ+WVfpBnKacrml+NR/AuxLIcIqZHOV8E 9qx+jj5B58OsErjEo7WJY3uVPhNdc5+9a9jVZzq5N/NmHkQNDIbR6ySgEu5NqEHEES 3OWmOrOazOxHXcKD10eSjI/w86pyDmk8M9BsWRzhmNYjV/+K7VCKsziTUgTTqUiD9c 1Kvl+UfdyOUam+maxJxM4s24joaEOqCSHAZp+xaGjhK/KePg0rg8/FsGZU+tv+Y8CT aiLyyykgLOyag== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-hNPcfrOiY2bT6aO645MV Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cees de Groot schreef op vr 11-03-2022 om 22:36 [+0000]: > Well, feel free to do the patching work. I'm just here reviewing things, looking for possible better alternatives, etc. > Realize that you are going to do work for a) a very small group of > developers (Elixir is a small language and Guix isn=E2=80=99t hardly a wi= dely > spread system to begin with), b) a subset of those that need git > dependencies, and c) a subset of _those_ that need these dependencies > on a project source tree that itself was not checked out with git > (otherwise the git executable will already be in the environment and > everything will work).=C2=A0 >=20 > Please let me know when you found that unicorn developer :) a) You're an Elixir developer, using Guix, and doing packaging work for Elixir in Guix. Also, how is the popularity of Guix relevant on guix-patches@, and how is the popularity of Elixir relevant when this whole patch is about improving the Elixir package? b) does not seem relevant to me, see other e-mails (about removing a feature not worth the decrease in closure size IMO, and about non-git references) c) It's a bit niche; it would be a very nice thing of Guix to support that niche. Also, being checked out with git does not imply that git is in the environment, it's possible to first set up a git repository and later enter a pure environment for development (guix shell -- pure elixir elixir-foo elixir-bar). I often do this (not with elixir, but with some other packages). TBC, what do you mean with =E2=80=98unicorn developer=E2=80=99 here? a) someone implementing this b) someone in the subset If (a), I was kind of hinting that you seem to be in a perfect position to do so (you're an Elixir developer (*) in Guix and you seem to have some knowledge of the serialisation formats). (*) I'm assuming "Elixir developer" =3D "a developer of the Elixir implementation" here. > If Guix ever gets elixir packages, that can be tackled.=20 >=20 > I=E2=80=99m bowing out of this discussion. If my patch gets accepted then= all > good, if not, I=E2=80=99ll move it to my private channel and keep being h= appy > there.=20 Ok, but I'm a bit confused on why you don't seem interested in fixing the reference issue and why you write =E2=80=98ever=E2=80=99 instead of =E2= =80=98when=E2=80=99 because you're both an Elixir and Guix developer. (You don't have to answer, not answering is fine.) Greetings, Maxime. --=-hNPcfrOiY2bT6aO645MV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYivYQhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7l3pAQDQwm2ZyoKQ5RwJUKB38BiFqHpQ lV7TpJEJISOeZnbNhwD+Nvvh7Lt2vxvygcOF4aB+BnkaYEDSqNpRr8N7WiDgMAE= =riV4 -----END PGP SIGNATURE----- --=-hNPcfrOiY2bT6aO645MV-- From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 23:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54304@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice Reply-To: Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.16470410102276 (code B ref 54304); Fri, 11 Mar 2022 23:24:02 +0000 Received: (at 54304) by debbugs.gnu.org; 11 Mar 2022 23:23:30 +0000 Received: from localhost ([127.0.0.1]:38696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSoba-0000ad-1j for submit@debbugs.gnu.org; Fri, 11 Mar 2022 18:23:30 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]:48592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSobY-0000aQ-8R for 54304@debbugs.gnu.org; Fri, 11 Mar 2022 18:23:28 -0500 Date: Fri, 11 Mar 2022 23:23:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1647041002; bh=q+7YAmG78Zk1+k5RPNqthiwl7TPJNEkBQ9Dgz1en5k8=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=ZtQVMKBBj7jWtnKyfkDNuR1Girq7qaoXvmGiK1aF7wqbbIZ1ro8E24LFeV4vbw2md fQ2xpaiEamGalFrvcCn/mL9igedGHSzmEBfhhon7lo+UmgsXWdyYepcf/AEE2G7Ez1 ZbaTDANKBjg6V2pAG1u5rxKf5nJALcjdwQsd53kzIMXmlOEjChhNmLYQ3B5e6KAKLZ DWerdR6fNA0dnMvKZDfgWcAoNh77KZCEk1iS+wRE7UYOlLwAuOotgnhMsrr3pJCywp P8vfXJhPMSE9wHx7K12QAzEGbl2JDkqexGAJEcDdiVZKSWVhcQJD1Umh4PHTnCh0VG wMnVkr1qmuEhA== From: Cees de Groot Message-ID: In-Reply-To: <13042012c34522fc9ed26746d11cc88b22f1ec6a.camel@telenet.be> References: <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> <13042012c34522fc9ed26746d11cc88b22f1ec6a.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Friday, March 11th, 2022 at 18:16, Maxime Devos = wrote: > Ok, but I'm a bit confused on why you don't seem interested in fixing th= e reference issue [...] I am interested in fixing the bug in the current package. And, I'm quite ho= nest there, I'm in itch-scratching mode so I'm not interested in fixing pot= ential, future, maybe issues :). My patch works, and yes, I'm more than hap= py to improve and iterate on it _if_ - and to me, that's a very big if - mo= re issues appear. From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Mar 2022 22:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice , Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164720967331963 (code B ref 54304); Sun, 13 Mar 2022 22:15:01 +0000 Received: (at 54304) by debbugs.gnu.org; 13 Mar 2022 22:14:33 +0000 Received: from localhost ([127.0.0.1]:43488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTWTx-0008JT-5H for submit@debbugs.gnu.org; Sun, 13 Mar 2022 18:14:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTWTv-0008JG-Kk for 54304@debbugs.gnu.org; Sun, 13 Mar 2022 18:14:31 -0400 Received: from [2001:470:142:3::e] (port=35038 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTWTn-0001Il-TZ; Sun, 13 Mar 2022 18:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=5Jcl4Q7zqWNa2RV+cy8qRCval3OtDe/ROHJHHzUq6eE=; b=eTAlI0tDs3YWm7U1+ILl eAqiKZwHZzlKBypEQM2zlRmtvbDBTLw93OzSPz+ZFSJoDd+tM0wXJdCzAlrt9uEX/z0ZsdikU8618 y2DT55MEWlHU+Ba9WYrZYwVKVkGCyZQ8u9yQKCKVQUtMRdVE7m0XQeAMkcYYOb+exxfWQVwiU5wTK l2MEijJXqWa+jfdFMU8Aq8agnMUG8vT4eVJKhItpGQL5Udku6n8InhQmLQdXR4HT4Bv8eTdEFoZTk DMkKSZS8BKgu0fDzExwm9frNEo1GzgebdbC/K2WQXNWoUHz2BV+87R4rSqdl72Qf1SXRf/DVDUjwY a+rwhfoIFhBwLA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:62142 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTWTl-0001a3-Ur; Sun, 13 Mar 2022 18:14:23 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> Date: Sun, 13 Mar 2022 23:14:19 +0100 In-Reply-To: <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> (Maxime Devos's message of "Fri, 11 Mar 2022 22:57:02 +0100") Message-ID: <8735jlts90.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxime Devos skribis: > Ludovic Court=C3=A8s schreef op vr 11-03-2022 om 22:51 [+0100]: >> If we know what set of store references go in those blogs, we could >> create a text file or something in #$output whose sole purpose is to >> keep a reference to those store items. >>=20 >> For example, if we know those BEAM files contain a reference to Git, we >> can add a phase like: >>=20 >> =C2=A0 (lambda* (#:key inputs outputs #:allow-other-keys) >> =C2=A0=C2=A0=C2=A0 (symlink (search-input-file inputs "git") > > Doesn't that need to be "bin/git" instead of "git"? > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= (string-append (assoc-ref output "out") >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 "/libexec/elixir/.git"))) >>=20 >> That way the GC will keep Git around. >> >> Thoughts? > > That is not sufficient if git acquires a graft. Argh, good point. Now, I agree with Cees that we need to be pragmatic here and opt for a =E2=80=9Cgood enough=E2=80=9D solution. So I went ahead and applied the initial patch that Cees posted. However, that =E2=80=98replace-paths=E2=80=99 phase also touches references= to /bin/sh; are they also a problem after GC? Thanks, Ludo=E2=80=99. From unknown Fri Jun 13 11:28:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Mar 2022 22:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxime Devos Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice Reply-To: Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164720979432249 (code B ref 54304); Sun, 13 Mar 2022 22:17:01 +0000 Received: (at 54304) by debbugs.gnu.org; 13 Mar 2022 22:16:34 +0000 Received: from localhost ([127.0.0.1]:43505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTWVt-0008O5-O1 for submit@debbugs.gnu.org; Sun, 13 Mar 2022 18:16:33 -0400 Received: from mail-40136.proton.ch ([185.70.40.136]:34781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTWVs-0008NP-Iu for 54304@debbugs.gnu.org; Sun, 13 Mar 2022 18:16:33 -0400 Date: Sun, 13 Mar 2022 22:16:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1647209785; bh=ew28E6Q5QCtoIelGa9+cjf0Kn5/8UZEFDhTL1vJEq34=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=nacxCWbrtmjlMMMx0s/eIgb6vjg4sQzjF1Nqp2LFGg5Zza1qjIrpP4UuXvCQ5hK9z NorwqLIDZFFvLF7XaWooifhe/0JepTV8B1foMy9l0nrh3l4e2ukVD1SbzqbJfPIDrL ppDpvh5CNlq/rhEFyT2+5faDRs8M8tSh/M9TGECnLz/xF5yAFP67iNjea2zS4Zst1d eMsqUUV7+x82o+kO2iwsjV9DZeYVGLHkvfhEzHjNHjtkqqSstXM1SLBdh+ThhNLipt vJ2oNAj1HxAy0TTvIT6G23Kx/0vxVFHaPnDbhsuI7lNfIGBEJeZzKCdhtNht3T2zCv 0bUoaSfY0ZvdQ== From: Cees de Groot Message-ID: <05sp-vgNcatmxmXI-wpwB7VDLc4eeac9O3ez4sXrHlWPaiA0OvqlJdeZVfgfOw917PTJ7DQ8-8VZbNJQAZbD_F-RO8w-fEaR52f-Enhh1_8=@evrl.com> In-Reply-To: <8735jlts90.fsf_-_@gnu.org> References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> <8735jlts90.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_BnwLCqvq9amDOiHOB74YBhPwJFj67ey7PNIfaQLJOI" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_BnwLCqvq9amDOiHOB74YBhPwJFj67ey7PNIfaQLJOI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 VGhlc2UgcmVmZXJlbmNlcyBvbmx5IHRvdWNoIHNoZWxsIHNjcmlwdHMgc28gSSB0aGluayB0aGV5 IHNob3VsZCBiZSBqdXN0IGZpbmUuIEnigJlsbCBnaXZlIGl0IGEgbG9vayB3aGVuIEnigJltIGJh Y2sgYXQgd29yayBhZnRlciB0aGUgd2Vla2VuZCB0byBiZSBzdXJlIHRob3VnaC4KClNlbnQgZnJv bSBQcm90b25NYWlsIGZvciBpT1MKCk9uIFN1biwgTWFyIDEzLCAyMDIyIGF0IDE4OjE0LCBMdWRv dmljIENvdXJ0w6hzIDxsdWRvQGdudS5vcmc+IHdyb3RlOgoKPiBIb3dldmVyLCB0aGF0IOKAmHJl cGxhY2UtcGF0aHPigJkgcGhhc2UgYWxzbyB0b3VjaGVzIHJlZmVyZW5jZXMgdG8gL2Jpbi9zaDsK PiBhcmUgdGhleSBhbHNvIGEgcHJvYmxlbSBhZnRlciBHQz8KPgo+IFRoYW5rcywKPiBMdWRv4oCZ Lg== --b1_BnwLCqvq9amDOiHOB74YBhPwJFj67ey7PNIfaQLJOI Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGh0bWw+PGhlYWQ+PC9oZWFkPjxib2R5PiAgIDxkaXY+VGhlc2UgcmVmZXJlbmNlcyBvbmx5IHRv dWNoIHNoZWxsIHNjcmlwdHMgc28gSSB0aGluayB0aGV5IHNob3VsZCBiZSBqdXN0IGZpbmUuIEni gJlsbCBnaXZlIGl0IGEgbG9vayB3aGVuIEnigJltIGJhY2sgYXQgd29yayBhZnRlciB0aGUgd2Vl a2VuZCB0byBiZSBzdXJlIHRob3VnaC4mbmJzcDs8L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2IGlk PSJwcm90b25tYWlsX21vYmlsZV9zaWduYXR1cmVfYmxvY2siPjxkaXY+U2VudCBmcm9tIFByb3Rv bk1haWwgZm9yIGlPUzwvZGl2PjwvZGl2PiA8ZGl2Pjxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj5P biBTdW4sIE1hciAxMywgMjAyMiBhdCAxODoxNCwgTHVkb3ZpYyBDb3VydMOocyAmbHQ7PGEgaHJl Zj0ibWFpbHRvOmx1ZG9AZ251Lm9yZyIgY2xhc3M9IiI+bHVkb0BnbnUub3JnPC9hPiZndDsgd3Jv dGU6PGJsb2NrcXVvdGUgY2xhc3M9InByb3Rvbm1haWxfcXVvdGUiIHR5cGU9ImNpdGUiPjxjYXJl dD48L2NhcmV0Pjxicj48YnI+SG93ZXZlciwgdGhhdCDigJhyZXBsYWNlLXBhdGhz4oCZIHBoYXNl IGFsc28gdG91Y2hlcyByZWZlcmVuY2VzIHRvIC9iaW4vc2g7PGJyPmFyZSB0aGV5IGFsc28gYSBw cm9ibGVtIGFmdGVyIEdDPzxicj48YnI+VGhhbmtzLDxicj5MdWRv4oCZLjxicj48L2Jsb2NrcXVv dGU+PGRpdj48YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PC9ib2R5PjwvaHRtbD4= --b1_BnwLCqvq9amDOiHOB74YBhPwJFj67ey7PNIfaQLJOI--