Subject: Re: bug#54284: [PATCH] gnu: Add python-pytest-pudb.

From: Ludovic Courtès <[email-masked]>
Date: Fri, 18 Mar 2022 23:16:03 +0100

Hi,

jgart <[email-masked]> skribis:

> * gnu/packages/check.scm (python-pytest-pudb): New variable.

[...]

> +(define-public python-pytest-pudb
> +  ;; PyPi does not include tests
> +  (let ((commit "a6b3d2f4d35e558d72bccff472ecde9c9d9c69e5")
> +        (revision "0"))
> +    (package
> +      (name "python-pytest-pudb")
> +      (version "0.7.0")

Could you clarify in a comment how this commit relates to this version
number?  You can remove the ‘revision’ variable, since it’s unused.

> +         (file-name (string-append name "-" commit))

Rather: (file-name (git-file-name name version)).

> +      (synopsis "Pytest PuDB debugger integration")
> +      (description
> +  "@code{python-pytest-pudb} provides PuDB debugger integration based on
> +  pytest PDB integration.")
    ^
Extra space here.

IWBN if you could add a sentence or two explaining what that means.  :-)

Last, please pass it through ‘guix style’.

Could you send an updated patch?

TIA!

Ludo’.