From unknown Sat Jun 14 03:47:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#5428 <5428@debbugs.gnu.org> To: bug#5428 <5428@debbugs.gnu.org> Subject: Status: vc-annotate for Bzr does not show the date Reply-To: bug#5428 <5428@debbugs.gnu.org> Date: Sat, 14 Jun 2025 10:47:35 +0000 retitle 5428 vc-annotate for Bzr does not show the date reassign 5428 emacs submitter 5428 Dan Nicolaescu severity 5428 wishlist tag 5428 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 20 02:28:38 2010 Received: (at submit) by debbugs.gnu.org; 20 Jan 2010 07:28:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXUzW-0002sh-8x for submit@debbugs.gnu.org; Wed, 20 Jan 2010 02:28:38 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXUzT-0002sa-LW for submit@debbugs.gnu.org; Wed, 20 Jan 2010 02:28:35 -0500 Received: from mx10.gnu.org ([199.232.76.166]:50022) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXUzQ-0003MS-JQ for submit@debbugs.gnu.org; Wed, 20 Jan 2010 02:28:32 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NXUzP-000589-B3 for submit@debbugs.gnu.org; Wed, 20 Jan 2010 02:28:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:35698) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NXUzP-00057x-3L for submit@debbugs.gnu.org; Wed, 20 Jan 2010 02:28:31 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXUzO-0006h2-Kg for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2010 02:28:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXUzK-0006go-Kk for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2010 02:28:30 -0500 Received: from [199.232.76.173] (port=35863 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXUzK-0006gl-Fx for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2010 02:28:26 -0500 Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]:41914) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NXUzK-0004y6-28 for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2010 02:28:26 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o0K7QnoI010780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 19 Jan 2010 23:26:49 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o0K7Qn9W013724; Tue, 19 Jan 2010 23:26:49 -0800 (PST) Date: Tue, 19 Jan 2010 23:26:49 -0800 (PST) Message-Id: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: vc-annotate for Bzr does not show the date X-Debbugs-No-Ack: yes Lines: 23 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o0K7QnoI010780 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_BZ 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) The subject says it all, dates are not displayed by vc-annotate for bzr. This is very bad, the date is very useful information. It is available as a tooltip, but one cannot search for the information in the tooltip. What is worse is that this is inconsistent with what vc-annotate does for all other backends, where the date is shown just fine. `vc-bzr-annotate-command' goes through a lot of effort to reformat the vc-annotate buffer with the end result of just hiding the date, and changing the format of "author". The date is in a very compact format YYYYMMDD, so it does not take much screen space. If that is a problem we have the vc-annotate-toggle-annotation-visibility command to hide all the extra information. vc-bzr-annotate-command should just limit itself to run the "bzr annotate" command. Just vc-bzr-annotate-time needs a minor adjustment to make everything work. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 20 11:36:27 2010 Received: (at 5428) by debbugs.gnu.org; 20 Jan 2010 16:36:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXdXe-0008T0-VE for submit@debbugs.gnu.org; Wed, 20 Jan 2010 11:36:27 -0500 Received: from pantheon-po43.its.yale.edu ([130.132.50.104]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXdXd-0008Sa-70 for 5428@debbugs.gnu.org; Wed, 20 Jan 2010 11:36:25 -0500 Received: from furry (dhcp128036014123.central.yale.edu [128.36.14.123]) (authenticated bits=0) by pantheon-po43.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0KGaKum003576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 20 Jan 2010 11:36:20 -0500 Received: by furry (Postfix, from userid 1000) id 681C7C05D; Wed, 20 Jan 2010 09:36:20 -0700 (MST) From: Chong Yidong To: Dan Nicolaescu Subject: Re: vc-annotate for Bzr does not show the date Date: Wed, 20 Jan 2010 11:36:20 -0500 Message-ID: <87ska068e3.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) > The subject says it all, dates are not displayed by vc-annotate for bzr. > > This is very bad, the date is very useful information. > > It is available as a tooltip, but one cannot search for the information > in the tooltip. > > What is worse is that this is inconsistent with what vc-annotate does > for all other backends, where the date is shown just fine. But what's displayed is exactly the same as "bzr annotate" on the tty. I'd agree that vc-annotate should be consistent across backends, except that vc-annotate with the SVN backend doesn't show the date either ("svn annotate" on the tty also does not display the date). From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 20 13:18:56 2010 Received: (at 5428) by debbugs.gnu.org; 20 Jan 2010 18:18:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXf8q-0001Ue-1N for submit@debbugs.gnu.org; Wed, 20 Jan 2010 13:18:56 -0500 Received: from paul-mcgann-v0.ics.uci.edu ([128.195.1.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXf8n-0001UZ-T9 for 5428@debbugs.gnu.org; Wed, 20 Jan 2010 13:18:54 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o0KIIg1t009309 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 20 Jan 2010 10:18:42 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o0KIIgJi007189; Wed, 20 Jan 2010 10:18:42 -0800 (PST) Date: Wed, 20 Jan 2010 10:18:42 -0800 (PST) Message-Id: <201001201818.o0KIIgJi007189@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Chong Yidong Subject: Re: vc-annotate for Bzr does not show the date References: <87ska068e3.fsf@stupidchicken.com> In-Reply-To: <87ska068e3.fsf@stupidchicken.com> (Chong Yidong's message of "Wed, 20 Jan 2010 11:36:20 -0500") Lines: 35 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o0KIIg1t009309 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_SV 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Chong Yidong writes: > > The subject says it all, dates are not displayed by vc-annotate for bzr. > > > > This is very bad, the date is very useful information. > > > > It is available as a tooltip, but one cannot search for the information > > in the tooltip. > > > > What is worse is that this is inconsistent with what vc-annotate does > > for all other backends, where the date is shown just fine. > > But what's displayed is exactly the same as "bzr annotate" on the tty. The problem is that the command that is actually run is: bzr annotate --long --all If you run that from the command line you get the date. You cannot get it at all in vc-annotate. And again this does not change the usefulness of seeing the date. > I'd agree that vc-annotate should be consistent across backends, except > that vc-annotate with the SVN backend doesn't show the date either ("svn > annotate" on the tty also does not display the date). SVN has an incredibly dumb display for the date in the long form: 44 user 2009-10-14 20:48:43 -0700 (Wed, 14 Oct 2009) blah Probably that's what motivated not to display the date. Using svn as an argument is not the best idea. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 20 13:20:46 2010 Received: (at 5428) by debbugs.gnu.org; 20 Jan 2010 18:20:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXfAc-0001Vf-AN for submit@debbugs.gnu.org; Wed, 20 Jan 2010 13:20:46 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXfAa-0001Va-Ax for 5428@debbugs.gnu.org; Wed, 20 Jan 2010 13:20:44 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KWK00D005F6YT00@a-mtaout20.012.net.il> for 5428@debbugs.gnu.org; Wed, 20 Jan 2010 20:19:52 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.14.77]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KWK0090A5L38HE0@a-mtaout20.012.net.il>; Wed, 20 Jan 2010 20:19:52 +0200 (IST) Date: Wed, 20 Jan 2010 20:19:56 +0200 From: Eli Zaretskii Subject: Re: bug#5428: vc-annotate for Bzr does not show the date In-reply-to: <87ska068e3.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il To: Chong Yidong Message-id: <83aaw87i5v.fsf@gnu.org> References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <87ska068e3.fsf@stupidchicken.com> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5428 Cc: dann@ics.uci.edu, 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Chong Yidong > Date: Wed, 20 Jan 2010 11:36:20 -0500 > Cc: 5428@debbugs.gnu.org > > But what's displayed is exactly the same as "bzr annotate" on the tty. There's a switch to `annotate' that does display the date. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 21 07:24:12 2010 Received: (at control) by debbugs.gnu.org; 21 Jan 2010 12:24:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXw56-0000AZ-Dq for submit@debbugs.gnu.org; Thu, 21 Jan 2010 07:24:12 -0500 Received: from mail-bw0-f226.google.com ([209.85.218.226]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXw54-0000AT-6p for control@debbugs.gnu.org; Thu, 21 Jan 2010 07:24:10 -0500 Received: by bwz26 with SMTP id 26so1359474bwz.7 for ; Thu, 21 Jan 2010 04:24:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=h+gJBN5Evcela2x4ePmOrEJ8swFH6FZ1H1SFWCIuy3c=; b=Kvw0yujeQC7j1ATBsF9l+xZdqpIGzVBAU2BjPqVvzKLYkAZvDb5aHHYt7k7mQuZzur Q31Iqzf5CYMJZZ+uxmodMzeIY01QnTVGD182dzVI5v6tYokE7IpmH9VJ+x8I+yH++vUu VAqHwZZCpUgZEP4gUgvnFQGtGrgOR9J2Azfkg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=ZCGZlcuqH9Nec7uKatLyOnzPOUdixh75E+SWMVZOpnwbyN0G4W5VfM7WM+2IcrETgW 2cQd/pHWFTyCTSNFzJswCG8ATk5CPgU3TgrcZ/DMmWuDmK0fAgEK5fyFqMWPRj1TyuCk uEUxEjlSGM00Hg56cLWRfM02UXPe4Yq+ycVRs= MIME-Version: 1.0 Received: by 10.204.49.85 with SMTP id u21mr738739bkf.148.1264076644302; Thu, 21 Jan 2010 04:24:04 -0800 (PST) From: Juanma Barranquero Date: Thu, 21 Jan 2010 13:23:43 +0100 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.8 (-) reassign 5435 emacs,ada-mode reassign 5428 emacs,vc quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 21 09:22:27 2010 Received: (at 5428) by debbugs.gnu.org; 21 Jan 2010 14:22:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXxvW-0002OS-LD for submit@debbugs.gnu.org; Thu, 21 Jan 2010 09:22:26 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXxvV-0002OJ-9s for 5428@debbugs.gnu.org; Thu, 21 Jan 2010 09:22:25 -0500 Received: from ceviche.home (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o0LEMHJw011570; Thu, 21 Jan 2010 09:22:18 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 3841B7002E; Thu, 21 Jan 2010 09:17:16 -0500 (EST) From: Stefan Monnier To: Dan Nicolaescu Subject: Re: bug#5428: vc-annotate for Bzr does not show the date Message-ID: References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> Date: Thu, 21 Jan 2010 09:17:16 -0500 In-Reply-To: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Tue, 19 Jan 2010 23:26:49 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3452=0 X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.7 (-) > The date is in a very compact format YYYYMMDD, so it does not take much > screen space. In vc-annotate, horizontal space is at a premium, since we're adding "margin text" to a file who's content should already be expected to be "using up all space" (e.g. all 80 columns). I'd oppose adding the date until it can be configured away. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 21 10:28:04 2010 Received: (at 5428) by debbugs.gnu.org; 21 Jan 2010 15:28:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXyx2-0002y9-7N for submit@debbugs.gnu.org; Thu, 21 Jan 2010 10:28:04 -0500 Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXyx0-0002xk-3b; Thu, 21 Jan 2010 10:28:03 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o0LFRpKn000661 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 21 Jan 2010 07:27:51 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o0LFRokp021595; Thu, 21 Jan 2010 07:27:50 -0800 (PST) Date: Thu, 21 Jan 2010 07:27:50 -0800 (PST) Message-Id: <201001211527.o0LFRokp021595@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Subject: Re: bug#5428: vc-annotate for Bzr does not show the date References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> In-Reply-To: (Stefan Monnier's message of "Thu, 21 Jan 2010 09:17:16 -0500") Lines: 97 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o0LFRpKn000661 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-0.263, required 5, autolearn=disabled, ALL_TRUSTED -1.44, FM_MULTI_ODD2 1.10, TW_BZ 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) tags 5428 patch quit Stefan Monnier writes: > > The date is in a very compact format YYYYMMDD, so it does not take much > > screen space. > > In vc-annotate, horizontal space is at a premium, since we're adding > "margin text" to a file who's content should already be expected to be > "using up all space" (e.g. all 80 columns). Can you please explain how was this different with CVS (and all other VCs besides svn)? If space is so important why isn't hiding the whole annotation vc-annotate-toggle-annotation-visibility even more useful? > I'd oppose adding the date until it can be configured away. So bzr should be less functional that all other VCs until someone cares to implement a new feature? Meanwhile here's a patch for people that want to be able to fully use of vc-annotate with bzr. Just removes a bunch of code and adjusts 2 regexps. Index: vc-bzr.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/vc-bzr.el,v retrieving revision 1.94 diff -u -3 -p -u -p -r1.94 vc-bzr.el --- vc-bzr.el 9 Dec 2009 06:04:12 -0000 1.94 +++ vc-bzr.el 21 Jan 2010 15:18:51 -0000 @@ -558,57 +585,25 @@ REV non-nil gets an error." Each line is tagged with the revision number, which has a `help-echo' property containing author and date information." (apply #'vc-bzr-command "annotate" buffer 'async file "--long" "--all" - (if revision (list "-r" revision))) - (lexical-let ((table (make-hash-table :test 'equal))) - (set-process-filter - (get-buffer-process buffer) - (lambda (proc string) - (when (process-buffer proc) - (with-current-buffer (process-buffer proc) - (setq string (concat (process-get proc :vc-left-over) string)) - (while (string-match "^\\( *[0-9.]+ *\\) \\([^\n ]+\\) +\\([0-9]\\{8\\}\\)\\( |.*\n\\)" string) - (let* ((rev (match-string 1 string)) - (author (match-string 2 string)) - (date (match-string 3 string)) - (key (substring string (match-beginning 0) - (match-beginning 4))) - (line (match-string 4 string)) - (tag (gethash key table)) - (inhibit-read-only t)) - (setq string (substring string (match-end 0))) - (unless tag - (setq tag - (propertize - (format "%s %-7.7s" rev author) - 'help-echo (format "Revision: %d, author: %s, date: %s" - (string-to-number rev) - author date) - 'mouse-face 'highlight)) - (puthash key tag table)) - (goto-char (process-mark proc)) - (insert tag line) - (move-marker (process-mark proc) (point)))) - (process-put proc :vc-left-over string))))))) + (if revision (list "-r" revision)))) (declare-function vc-annotate-convert-time "vc-annotate" (time)) (defun vc-bzr-annotate-time () - (when (re-search-forward "^ *[0-9.]+ +[^\n ]* +|" nil t) - (let ((prop (get-text-property (line-beginning-position) 'help-echo))) - (string-match "[0-9]+\\'" prop) - (let ((str (match-string-no-properties 0 prop))) + (when (re-search-forward "^[0-9.]+ +[^\n ]* +\\([0-9]\\{8\\}\\) |" nil t) + (let ((str (match-string-no-properties 1))) (vc-annotate-convert-time (encode-time 0 0 0 (string-to-number (substring str 6 8)) (string-to-number (substring str 4 6)) - (string-to-number (substring str 0 4)))))))) + (string-to-number (substring str 0 4))))))) (defun vc-bzr-annotate-extract-revision-at-line () "Return revision for current line of annoation buffer, or nil. Return nil if current line isn't annotated." (save-excursion (beginning-of-line) - (if (looking-at "^ *\\([0-9.]+\\) +[^\n ]* +|") + (if (looking-at "^\\([0-9.]+\\) +[^\n ]* +\\([0-9]\\{8\\}\\) |") (match-string-no-properties 1)))) (defun vc-bzr-command-discarding-stderr (command &rest args) From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 22 10:21:41 2010 Received: (at 5428) by debbugs.gnu.org; 22 Jan 2010 15:21:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYLKO-00075w-3s for submit@debbugs.gnu.org; Fri, 22 Jan 2010 10:21:40 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYLKM-00075m-An for 5428@debbugs.gnu.org; Fri, 22 Jan 2010 10:21:38 -0500 Received: from ceviche.home (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o0MFLTWB007223; Fri, 22 Jan 2010 10:21:30 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 87A2970030; Fri, 22 Jan 2010 10:21:28 -0500 (EST) From: Stefan Monnier To: Dan Nicolaescu Subject: Re: bug#5428: vc-annotate for Bzr does not show the date Message-ID: References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <201001211527.o0LFRokp021595@godzilla.ics.uci.edu> Date: Fri, 22 Jan 2010 10:21:28 -0500 In-Reply-To: <201001211527.o0LFRokp021595@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Thu, 21 Jan 2010 07:27:50 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3453=0 X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.7 (-) > Can you please explain how was this different with CVS (and all other > VCs besides svn)? It wasn't. So it was a problem that wasn't solved for CVS. Doesn't mean it should be re-introduced for Bzr. > If space is so important why isn't hiding the whole annotation > vc-annotate-toggle-annotation-visibility even more useful? That's another option, although some info is useful to know which lines were modified at the same time, and which lines where modified before/after other lines (at least in my experience). >> I'd oppose adding the date until it can be configured away. > So bzr should be less functional that all other VCs until someone cares > to implement a new feature? I find it more functional, so your characterization is not helpful. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 22 14:26:20 2010 Received: (at 5428) by debbugs.gnu.org; 22 Jan 2010 19:26:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYP99-0002Um-Oy for submit@debbugs.gnu.org; Fri, 22 Jan 2010 14:26:20 -0500 Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYP92-0002UX-1b for 5428@debbugs.gnu.org; Fri, 22 Jan 2010 14:26:12 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o0MJQ10a017333 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Jan 2010 11:26:01 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o0MJQ0aN013838; Fri, 22 Jan 2010 11:26:00 -0800 (PST) Date: Fri, 22 Jan 2010 11:26:00 -0800 (PST) Message-Id: <201001221926.o0MJQ0aN013838@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Subject: Re: bug#5428: vc-annotate for Bzr does not show the date References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <201001211527.o0LFRokp021595@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Fri, 22 Jan 2010 10:21:28 -0500") Lines: 28 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o0MJQ10a017333 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_BZ 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Stefan Monnier writes: > > Can you please explain how was this different with CVS (and all other > > VCs besides svn)? > > It wasn't. So it was a problem that wasn't solved for CVS. > Doesn't mean it should be re-introduced for Bzr. Does it mean that your personal preference should make it impossible to do useful searches by date? Why not fix it properly, instead of breaking it? At least don't make it strictly worse. > > If space is so important why isn't hiding the whole annotation > > vc-annotate-toggle-annotation-visibility even more useful? > > That's another option, although some info is useful to know which lines > were modified at the same time, and which lines where modified > before/after other lines (at least in my experience). > > >> I'd oppose adding the date until it can be configured away. > > So bzr should be less functional that all other VCs until someone cares > > to implement a new feature? > > I find it more functional, so your characterization is not helpful. Please explain why is it better not to be able to search by date. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 22 15:21:44 2010 Received: (at 5428) by debbugs.gnu.org; 22 Jan 2010 20:21:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYQ0m-000322-6O for submit@debbugs.gnu.org; Fri, 22 Jan 2010 15:21:44 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYQ0l-00031t-0h for 5428@debbugs.gnu.org; Fri, 22 Jan 2010 15:21:43 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0KWO00I0009DO200@a-mtaout23.012.net.il> for 5428@debbugs.gnu.org; Fri, 22 Jan 2010 22:21:37 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.228.141.118]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KWO00H850K0VS60@a-mtaout23.012.net.il>; Fri, 22 Jan 2010 22:21:37 +0200 (IST) Date: Fri, 22 Jan 2010 22:21:44 +0200 From: Eli Zaretskii Subject: Re: bug#5428: vc-annotate for Bzr does not show the date In-reply-to: <201001221926.o0MJQ0aN013838@godzilla.ics.uci.edu> X-012-Sender: halo1@inter.net.il To: Dan Nicolaescu Message-id: <83636t7uw7.fsf@gnu.org> References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <201001211527.o0LFRokp021595@godzilla.ics.uci.edu> <201001221926.o0MJQ0aN013838@godzilla.ics.uci.edu> X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 5428 Cc: monnier@IRO.UMontreal.CA, 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.8 (-) > Date: Fri, 22 Jan 2010 11:26:00 -0800 (PST) > From: Dan Nicolaescu > Cc: 5428@debbugs.gnu.org > > Please explain why is it better not to be able to search by date. I don't use VC with Bazaar for now, but FWIW I agree with Dan here: the dates are important. I'm always annoyed when I forget to give "bzr annotate" the switches that cause it to display the dates (gotta define an alias for that one of these days), and am punished by annotations that are next to useless. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 23 06:13:59 2010 Received: (at 5428) by debbugs.gnu.org; 23 Jan 2010 11:13:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYdwF-0004XT-Do for submit@debbugs.gnu.org; Sat, 23 Jan 2010 06:13:59 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYdwD-0004XK-KC for 5428@debbugs.gnu.org; Sat, 23 Jan 2010 06:13:57 -0500 Received: from ceviche.home (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o0NBDoaL004431; Sat, 23 Jan 2010 06:13:52 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 79FA370095; Sat, 23 Jan 2010 06:13:47 -0500 (EST) From: Stefan Monnier To: Dan Nicolaescu Subject: Re: bug#5428: vc-annotate for Bzr does not show the date Message-ID: References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <201001211527.o0LFRokp021595@godzilla.ics.uci.edu> <201001221926.o0MJQ0aN013838@godzilla.ics.uci.edu> Date: Sat, 23 Jan 2010 06:13:47 -0500 In-Reply-To: <201001221926.o0MJQ0aN013838@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Fri, 22 Jan 2010 11:26:00 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3454=0 X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.7 (-) >> > Can you please explain how was this different with CVS (and all other >> > VCs besides svn)? >> It wasn't. So it was a problem that wasn't solved for CVS. >> Doesn't mean it should be re-introduced for Bzr. > Does it mean that your personal preference should make it impossible to > do useful searches by date? No, just that the current preference should not simply be replaced by another one, unless we provide a way to configure VC to get the current preference back. FWIW, it's not impossible to do such searches: Use vc-print-log to see which dates corresponds to which revision numbers, and then search by revision number. > Why not fix it properly, instead of breaking it? At least don't make it > strictly worse. That's exactly what I want: to fix it properly, rather than to replace one problem with another. > Please explain why is it better not to be able to search by date. I already explained it. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 23 12:24:49 2010 Received: (at 5428) by debbugs.gnu.org; 23 Jan 2010 17:24:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYjj6-0000iJ-5I for submit@debbugs.gnu.org; Sat, 23 Jan 2010 12:24:48 -0500 Received: from paul-mcgann-v0.ics.uci.edu ([128.195.1.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYjj4-0000iD-5K for 5428@debbugs.gnu.org; Sat, 23 Jan 2010 12:24:46 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o0NHOYHA026728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 23 Jan 2010 09:24:34 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o0NHOYjb024041; Sat, 23 Jan 2010 09:24:34 -0800 (PST) Date: Sat, 23 Jan 2010 09:24:34 -0800 (PST) Message-Id: <201001231724.o0NHOYjb024041@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Subject: Re: bug#5428: vc-annotate for Bzr does not show the date References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <201001211527.o0LFRokp021595@godzilla.ics.uci.edu> <201001221926.o0MJQ0aN013838@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Sat, 23 Jan 2010 06:13:47 -0500") Lines: 33 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o0NHOYHA026728 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Stefan Monnier writes: > >> > Can you please explain how was this different with CVS (and all other > >> > VCs besides svn)? > >> It wasn't. So it was a problem that wasn't solved for CVS. > >> Doesn't mean it should be re-introduced for Bzr. > > Does it mean that your personal preference should make it impossible to > > do useful searches by date? > > No, just that the current preference should not simply be replaced by > another one, unless we provide a way to configure VC to get the current > preference back. Why not first implement whatever configurability YOU want, and then change the default display so that it does not make work harder for other people, instead of just breaking a long time working feature? > FWIW, it's not impossible to do such searches: Use vc-print-log to see > which dates corresponds to which revision numbers, and then search by > revision number. How is this better than just searching in the vc-annotate buffer that has been the normal work flow for years? > > Why not fix it properly, instead of breaking it? At least don't make it > > strictly worse. > > That's exactly what I want: to fix it properly, rather than to replace > one problem with another. Can you please do it in such a way that you don't replace a working (and in use for a very long time) setup with a broken one? From debbugs-submit-bounces@debbugs.gnu.org Fri May 08 17:36:02 2015 Received: (at 5428) by debbugs.gnu.org; 8 May 2015 21:36:02 +0000 Received: from localhost ([127.0.0.1]:39083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yqpw9-0002rl-45 for submit@debbugs.gnu.org; Fri, 08 May 2015 17:36:01 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:36431 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yqpw6-0002ra-LQ for 5428@debbugs.gnu.org; Fri, 08 May 2015 17:35:58 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Yqpw5-0000vD-Q2; Fri, 08 May 2015 17:35:57 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#5428: vc-annotate for Bzr does not show the date References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> X-Spook: David John Oates rs9512c subversive LABLINK global X-Ran: g*rRF*2^A|IvPJ<7LRL{,X8~-M_z{MO=&=rF?<60:x"*;7=gCt=5:3lr~!a~agjBTCRN*< X-Hue: magenta X-Attribution: GM Date: Fri, 08 May 2015 17:35:57 -0400 Message-ID: <8u3836n45e.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Stefan Monnier wrote: > In vc-annotate, horizontal space is at a premium, since we're adding > "margin text" to a file who's content should already be expected to be > "using up all space" (e.g. all 80 columns). It's even worse for Git. Using vc-annotate on a file under Git gives me a buffer where the first 90 columns are taken up with Git output. The actual file itself is pushed completely off the right. e95a67dc lisp/emacs-lisp/syntax.el (Stefan Monnier 2012-04-26 08:43:28 -0400 1) ;;; syntax.el By contrast in bzr only 21 columns are used. The "lisp/emacs-lisp/syntax.el " bit seems useless to me. The bzr version uses a truncated email address rather than a full name. The Git date field seems way too specific. The line numbers are totally unnecessary. From debbugs-submit-bounces@debbugs.gnu.org Sat May 16 19:55:52 2015 Received: (at 5428) by debbugs.gnu.org; 16 May 2015 23:55:52 +0000 Received: from localhost ([127.0.0.1]:47530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ytlvr-0003sl-Ia for submit@debbugs.gnu.org; Sat, 16 May 2015 19:55:52 -0400 Received: from mail-wg0-f65.google.com ([74.125.82.65]:33856) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ytlvo-0003sW-Lk for 5428@debbugs.gnu.org; Sat, 16 May 2015 19:55:49 -0400 Received: by wggx12 with SMTP id x12so12023000wgg.1 for <5428@debbugs.gnu.org>; Sat, 16 May 2015 16:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Q0nEpcv52m2ZE6ig5KfQbQs0i+fxUKyoVrOQ9oYwu4k=; b=TAAS3s7/S/9RaGBeHVHayUf/rNxeEXrf6GFFE3IO4SEmSqr6n8zj640Lb+rzz/1KhP moCT2V8pLfH+w3SLDtZ27nvZ2jmNB9e6r5KF/MhHNJelWSBXPP0dnV/ikdNsdpAP+ESo Y7FAyp/YTTlXNbnVUvdG5JyzQM9eNTn3DDury/ao1bFwzwhY1FBSCCw+AvCBvk0RuiIQ oRpb24J1/iw+FsqU7d6bgzyrxEebPHpPOEpCUs3+0b6G4a17CHsRCTpPi7NtLGxO+hJz mQJiDQC0XMcE6sJqXHdmFIX0rAgnC5X9jIw5NWUvdIZJqJD0aHxPmuxzmWT0c7KDc2jV o7ig== X-Received: by 10.194.23.66 with SMTP id k2mr6496331wjf.18.1431820542802; Sat, 16 May 2015 16:55:42 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id ek10sm5053153wid.1.2015.05.16.16.55.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 May 2015 16:55:42 -0700 (PDT) Subject: Re: bug#5428: vc-annotate for Bzr does not show the date To: Glenn Morris , Stefan Monnier References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <8u3836n45e.fsf@fencepost.gnu.org> From: Dmitry Gutov Message-ID: <5557D8FB.7030105@yandex.ru> Date: Sun, 17 May 2015 02:55:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <8u3836n45e.fsf@fencepost.gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 05/09/2015 12:35 AM, Glenn Morris wrote: > Using vc-annotate on a file under Git gives me a buffer where the first > 90 columns are taken up with Git output. The actual file itself is > pushed completely off the right. I've made the date shorter, it'll save us 15 columns. > The "lisp/emacs-lisp/syntax.el " bit seems useless to me. That's only displayed if the file has been renamed at some point (some revisions are from different paths). But when it is, there's no way to turn it off. Or rather there is: using the -c flag, but then it uses tabs in the output, and they make columns not always line up. Maybe we could remove the file paths in a vc-run-delayed block. Should we worry that someone might find them useful? > The bzr version uses a truncated email address rather than a full name. We could replace the names with full email addresses, but those are even longer, at times. > The line numbers are totally unnecessary. Maybe it is, but it's a minor problem compared to the other fields. Also there's no way to turn it off. From debbugs-submit-bounces@debbugs.gnu.org Sat May 16 21:16:19 2015 Received: (at 5428) by debbugs.gnu.org; 17 May 2015 01:16:19 +0000 Received: from localhost ([127.0.0.1]:47545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtnBi-0005qk-T9 for submit@debbugs.gnu.org; Sat, 16 May 2015 21:16:19 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:3626) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtnBf-0005qT-Ul for 5428@debbugs.gnu.org; Sat, 16 May 2015 21:16:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgUFAGvvdVTO+LMW/2dsb2JhbAA3gVOhb4EIgXYBBVYjEAsOJhIUGA0kqiSMbQMBAoM+AwMGEASDUwSjY4RY X-IPAS-Result: AgUFAGvvdVTO+LMW/2dsb2JhbAA3gVOhb4EIgXYBBVYjEAsOJhIUGA0kqiSMbQMBAoM+AwMGEASDUwSjY4RY X-IronPort-AV: E=Sophos;i="5.11,557,1422939600"; d="scan'208";a="120271079" Received: from 206-248-179-22.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.179.22]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 16 May 2015 21:16:09 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 4C3D7AE122; Sat, 16 May 2015 21:16:09 -0400 (EDT) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#5428: vc-annotate for Bzr does not show the date Message-ID: References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <8u3836n45e.fsf@fencepost.gnu.org> <5557D8FB.7030105@yandex.ru> Date: Sat, 16 May 2015 21:16:09 -0400 In-Reply-To: <5557D8FB.7030105@yandex.ru> (Dmitry Gutov's message of "Sun, 17 May 2015 02:55:39 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 5428 Cc: Glenn Morris , 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) FWIW, I've often wanted for vc-annotate to use a completely different approach, where the buffer's text content is just the actual file's content and the extra annotations are only displayed indirectly (e.g. via a background color, tooltip text, margin text, or in-buffer (but togglable by attribute)). The way I see it working internally is that the process filter adds the line annotations as a text-property to the file's lines, and then a jit-lock-triggered function uses this text-property to change the display as/when needed. Also by using the unannotated file's text in buffer, we could enable the normal font-lock rules, so we as to combine the normal font-lock highlighting with the background-color of vc-annotate. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 16 21:31:01 2015 Received: (at 5428) by debbugs.gnu.org; 17 May 2015 01:31:02 +0000 Received: from localhost ([127.0.0.1]:47549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtnPv-0006Et-OK for submit@debbugs.gnu.org; Sat, 16 May 2015 21:31:00 -0400 Received: from mail-wi0-f194.google.com ([209.85.212.194]:34710) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtnPp-0006Ea-Qw for 5428@debbugs.gnu.org; Sat, 16 May 2015 21:30:54 -0400 Received: by wibbw19 with SMTP id bw19so4473353wib.1 for <5428@debbugs.gnu.org>; Sat, 16 May 2015 18:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=cbEIf7kg+q4/eAsAOiplZIoDMqoQNSo2yRufMMsvuoE=; b=hMuQnHR//+gTtD8k/UFQDYDvsub+g6/a0YVe3lZEnZyt+vMJ+MXBCAwXttOm6bN9lP c4rLkj+SFpmOBi/1L5/WmFxJfGOm4cLJpci4EmigUw9qXhlxmCkUu0UjlubaeG+quMlO 8JdAF30MYmJxrxGuzyhOOrtPMGNtX/Bah4LA3KU+3GNQalNvqecd4i/Xa+QmDxaspJvq Km3tmY08Dp0sGRJAhSiG1urX06WVFmR73hfeGN1cb/3lWdHY8u4iRBTQafXDpauFVl3t UFVEX3IGVHeeXTExUs15fEsjrUEhNStnW/b4Zf85RZFTYPwztW9MGZ4dK0E2hpo/QxIq CaWQ== X-Received: by 10.181.13.113 with SMTP id ex17mr10095057wid.12.1431826248004; Sat, 16 May 2015 18:30:48 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id pz6sm9683852wjc.43.2015.05.16.18.30.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 May 2015 18:30:47 -0700 (PDT) Subject: Re: bug#5428: vc-annotate for Bzr does not show the date To: Stefan Monnier References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <8u3836n45e.fsf@fencepost.gnu.org> <5557D8FB.7030105@yandex.ru> From: Dmitry Gutov Message-ID: <5557EF45.1030508@yandex.ru> Date: Sun, 17 May 2015 04:30:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 05/17/2015 04:16 AM, Stefan Monnier wrote: > > FWIW, I've often wanted for vc-annotate to use a completely different > approach, where the buffer's text content is just the actual file's > content and the extra annotations are only displayed indirectly > (e.g. via a background color, tooltip text, margin text, or in-buffer > (but togglable by attribute)). We already kind of have this possibility, though (via vc-annotate-toggle-annotation-visibility). It's not enough because dates and names are useful, and even having tooltips won't cut it. The main stopper, I think, is the "togglable by attribute" UI (well, and also the implementations for extracting more granular data for each backend). > Also by using the unannotated file's text in buffer, we could enable the > normal font-lock rules, so we as to combine the normal font-lock > highlighting with the background-color of vc-annotate. That would be nice. From debbugs-submit-bounces@debbugs.gnu.org Sat May 16 21:47:52 2015 Received: (at 5428) by debbugs.gnu.org; 17 May 2015 01:47:52 +0000 Received: from localhost ([127.0.0.1]:47553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtngF-0006eU-TW for submit@debbugs.gnu.org; Sat, 16 May 2015 21:47:52 -0400 Received: from mail-wi0-f193.google.com ([209.85.212.193]:35823) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtngD-0006eA-4A for 5428@debbugs.gnu.org; Sat, 16 May 2015 21:47:49 -0400 Received: by wibbw19 with SMTP id bw19so4503652wib.2 for <5428@debbugs.gnu.org>; Sat, 16 May 2015 18:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=LDzzS1dTvU24a7aSKZfeHRjmWv8XiJwlr2OmArCDpTg=; b=DuHyKjv4v/ISsecNFPPLc+vhS9O6EBGCWCkwtB3FNdb5O2nYyMcZRg/LAZk71H4sXw eXjE0a6HLHiKyzCnjY0OMbz5C7d07NDSs+/VWaf/jQjUXdkvbekxphf/HIH5XlH/5FkZ 2eidFQLys9vnEc8dwJN8H218lbrsBV/y57tzpOzfA5tf56s6V+YD4xJoVXsnm9mcYFdN /qitaP5LXBiMZXQ3+RtIGelB3leZ6IapmGng+9Xw5iagUQAQCJowEISKP/tFm5o6HokA wfqsmbmuoJp2pHpmPm3LthO8Y3ZM1IHTU8J72MLKQbf0M8FGMLDzjbCzSV58Sbip04qD PJyw== X-Received: by 10.194.186.145 with SMTP id fk17mr31500950wjc.156.1431827263485; Sat, 16 May 2015 18:47:43 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id ex5sm5352473wib.2.2015.05.16.18.47.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 May 2015 18:47:43 -0700 (PDT) Subject: Re: bug#5428: vc-annotate for Bzr does not show the date To: Stefan Monnier References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <8u3836n45e.fsf@fencepost.gnu.org> <5557D8FB.7030105@yandex.ru> From: Dmitry Gutov Message-ID: <5557F33C.2030409@yandex.ru> Date: Sun, 17 May 2015 04:47:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 05/17/2015 04:16 AM, Stefan Monnier wrote: > The way I see it working internally is that the process filter adds the > line annotations as a text-property to the file's lines, It should still be a different buffer though, mainly because after doing vc-annotate, I usually want to edit the file contents, and the annotation information won't stay up to date. From debbugs-submit-bounces@debbugs.gnu.org Mon May 18 12:05:57 2015 Received: (at 5428) by debbugs.gnu.org; 18 May 2015 16:05:57 +0000 Received: from localhost ([127.0.0.1]:49345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YuNYC-0002M0-E0 for submit@debbugs.gnu.org; Mon, 18 May 2015 12:05:56 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:26145) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YuNY9-0002Lh-6m for 5428@debbugs.gnu.org; Mon, 18 May 2015 12:05:54 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgUFAGvvdVTO+LMW/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMQCw4mEhQYDSSIE6IRjG0BAgECgz4DAwYQBINTBKNjhFg X-IPAS-Result: AgUFAGvvdVTO+LMW/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMQCw4mEhQYDSSIE6IRjG0BAgECgz4DAwYQBINTBKNjhFg X-IronPort-AV: E=Sophos;i="5.11,557,1422939600"; d="scan'208";a="120607984" Received: from 206-248-179-22.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.179.22]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 18 May 2015 12:05:47 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id CBE63AE164; Mon, 18 May 2015 12:05:47 -0400 (EDT) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#5428: vc-annotate for Bzr does not show the date Message-ID: References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <8u3836n45e.fsf@fencepost.gnu.org> <5557D8FB.7030105@yandex.ru> <5557F33C.2030409@yandex.ru> Date: Mon, 18 May 2015 12:05:47 -0400 In-Reply-To: <5557F33C.2030409@yandex.ru> (Dmitry Gutov's message of "Sun, 17 May 2015 04:47:40 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> The way I see it working internally is that the process filter adds the >> line annotations as a text-property to the file's lines, > It should still be a different buffer though, Obviously, yes. Especially because the annotation is in general not a bout the current version of the file. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 28 01:14:44 2016 Received: (at 5428) by debbugs.gnu.org; 28 Feb 2016 06:14:44 +0000 Received: from localhost ([127.0.0.1]:49390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZucu-0001p1-8E for submit@debbugs.gnu.org; Sun, 28 Feb 2016 01:14:44 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:37594) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZuct-0001ot-6T for 5428@debbugs.gnu.org; Sun, 28 Feb 2016 01:14:43 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aZucT-00049i-76; Sun, 28 Feb 2016 07:14:17 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#5428: vc-annotate for Bzr does not show the date References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <8u3836n45e.fsf@fencepost.gnu.org> <5557D8FB.7030105@yandex.ru> Date: Sun, 28 Feb 2016 17:14:12 +1100 In-Reply-To: <5557D8FB.7030105@yandex.ru> (Dmitry Gutov's message of "Sun, 17 May 2015 02:55:39 +0300") Message-ID: <87bn71tl8r.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aZucT-00049i-76 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1457244857.97098@zD2Ps0plRNHlNzorgWGc+A X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5428 Cc: Glenn Morris , Stefan Monnier , 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Dmitry Gutov writes: > On 05/09/2015 12:35 AM, Glenn Morris wrote: > >> Using vc-annotate on a file under Git gives me a buffer where the first >> 90 columns are taken up with Git output. The actual file itself is >> pushed completely off the right. > > I've made the date shorter, it'll save us 15 columns. It looks to me like the vc-annotate output is reasonable now, so I'm closing this bug report. If it's still an issue, please reopen. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 28 01:14:55 2016 Received: (at control) by debbugs.gnu.org; 28 Feb 2016 06:14:55 +0000 Received: from localhost ([127.0.0.1]:49393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZud5-0001pP-F4 for submit@debbugs.gnu.org; Sun, 28 Feb 2016 01:14:55 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:37606) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZud4-0001pH-3h for control@debbugs.gnu.org; Sun, 28 Feb 2016 01:14:54 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aZucf-00049s-BT for control@debbugs.gnu.org; Sun, 28 Feb 2016 07:14:30 +0100 Date: Sun, 28 Feb 2016 17:14:24 +1100 Message-Id: <87a8mltl8f.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #5428 X-MailScanner-ID: 1aZucf-00049s-BT X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1457244871.47242@c9atCRqVYRVOMd5Im770zA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) close 5428 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 28 13:27:37 2016 Received: (at 5428) by debbugs.gnu.org; 28 Feb 2016 18:27:37 +0000 Received: from localhost ([127.0.0.1]:51005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aa649-0008I2-E5 for submit@debbugs.gnu.org; Sun, 28 Feb 2016 13:27:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39951) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aa648-0008Hf-7P for 5428@debbugs.gnu.org; Sun, 28 Feb 2016 13:27:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aa642-00041S-DN for 5428@debbugs.gnu.org; Sun, 28 Feb 2016 13:27:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aa63p-0003wg-Fo; Sun, 28 Feb 2016 13:27:17 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aa63o-0006wh-FT; Sun, 28 Feb 2016 13:27:16 -0500 From: Glenn Morris To: Lars Ingebrigtsen Subject: Re: bug#5428: vc-annotate for Bzr does not show the date References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <8u3836n45e.fsf@fencepost.gnu.org> <5557D8FB.7030105@yandex.ru> <87bn71tl8r.fsf@gnus.org> X-Spook: FTS2000 Body scanner ANZUS Emergency management Delta X-Ran: I"3R8QQ_,4RnW2,*1W+:+nfg"wkhU~=z3qHYZc`U]]OU`ogXR^N>gK3GK.HfB (Lars Ingebrigtsen's message of "Sun, 28 Feb 2016 17:14:12 +1100") Message-ID: <7bio18zo57.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 5428 Cc: 5428@debbugs.gnu.org, Stefan Monnier , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> On 05/09/2015 12:35 AM, Glenn Morris wrote: >> >>> Using vc-annotate on a file under Git gives me a buffer where the first >>> 90 columns are taken up with Git output. The actual file itself is >>> pushed completely off the right. >> >> I've made the date shorter, it'll save us 15 columns. > > It looks to me like the vc-annotate output is reasonable now, so I'm > closing this bug report. If it's still an issue, please reopen. The actual report was that vc-annotate for bzr does not show the date. It still doesn't, so I don't see why you would think this is fixed. The meta-issue was that the various backends display different annotation information. TLDR: reopening. From unknown Sat Jun 14 03:47:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Sun, 28 Feb 2016 18:28:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 13:36:31 2019 Received: (at 5428) by debbugs.gnu.org; 27 Jun 2019 17:36:31 +0000 Received: from localhost ([127.0.0.1]:39518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYJz-000420-2m for submit@debbugs.gnu.org; Thu, 27 Jun 2019 13:36:31 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYJx-00041r-II for 5428@debbugs.gnu.org; Thu, 27 Jun 2019 13:36:30 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgYJl-0008AV-Hr; Thu, 27 Jun 2019 19:36:21 +0200 From: Lars Ingebrigtsen To: Glenn Morris Subject: Re: bug#5428: vc-annotate for Bzr does not show the date References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <8u3836n45e.fsf@fencepost.gnu.org> <5557D8FB.7030105@yandex.ru> <87bn71tl8r.fsf@gnus.org> <7bio18zo57.fsf@fencepost.gnu.org> Date: Thu, 27 Jun 2019 19:36:17 +0200 In-Reply-To: <7bio18zo57.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sun, 28 Feb 2016 13:27:16 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Glenn Morris writes: >> It looks to me like the vc-annotate output is reasonable now, so I'm >> closing this bug report. If it's still an issue, please reopen. > > The actual report was that vc-annotate for bzr does not s [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5428 Cc: Dan Nicolaescu , Dmitry Gutov , Stefan Monnier , 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Glenn Morris writes: >> It looks to me like the vc-annotate output is reasonable now, so I'm >> closing this bug report. If it's still an issue, please reopen. > > The actual report was that vc-annotate for bzr does not show the date. > It still doesn't, so I don't see why you would think this is fixed. > The meta-issue was that the various backends display different > annotation information. Indeed. The bzr output is really, really terse. I've reworked Dan's patch to work apply now, and with that I get lines like 1 larsi@gnus.org 20190627 | Foo which seem nice and terse, but informative. (The current git version, on the other hand, is way overboard in noise.) Does anybody still object to this change? Stefan wanted this to be customisable, and that would be nice, and should probably apply to all backends, but it's a somewhat orthogonal issue... diff --git a/lisp/vc/vc-bzr.el b/lisp/vc/vc-bzr.el index ee1646cae5..89f1fcce37 100644 --- a/lisp/vc/vc-bzr.el +++ b/lisp/vc/vc-bzr.el @@ -869,61 +869,25 @@ vc-bzr-annotate-command property containing author and date information." (apply #'vc-bzr-command "annotate" buffer 'async file "--long" "--all" (append (vc-switches 'bzr 'annotate) - (if revision (list "-r" revision)))) - (let ((table (make-hash-table :test 'equal))) - (set-process-filter - (get-buffer-process buffer) - (lambda (proc string) - (when (process-buffer proc) - (with-current-buffer (process-buffer proc) - (setq string (concat (process-get proc :vc-left-over) string)) - ;; Eg: 102020 Gnus developers 20101020 | regexp." - ;; As of bzr 2.2.2, no email address in whoami (which can - ;; lead to spaces in the author field) is allowed but discouraged. - ;; See bug#7792. - (while (string-match "^\\( *[0-9.]+ *\\) \\(.+?\\) +\\([0-9]\\{8\\}\\)\\( |.*\n\\)" string) - (let* ((rev (match-string 1 string)) - (author (match-string 2 string)) - (date (match-string 3 string)) - (key (substring string (match-beginning 0) - (match-beginning 4))) - (line (match-string 4 string)) - (tag (gethash key table)) - (inhibit-read-only t)) - (setq string (substring string (match-end 0))) - (unless tag - (setq tag - (propertize - (format "%s %-7.7s" rev author) - 'help-echo (format "Revision: %d, author: %s, date: %s" - (string-to-number rev) - author date) - 'mouse-face 'highlight)) - (puthash key tag table)) - (goto-char (process-mark proc)) - (insert tag line) - (move-marker (process-mark proc) (point)))) - (process-put proc :vc-left-over string))))))) + (if revision (list "-r" revision))))) (declare-function vc-annotate-convert-time "vc-annotate" (&optional time)) (defun vc-bzr-annotate-time () - (when (re-search-forward "^ *[0-9.]+ +.+? +|" nil t) - (let ((prop (get-text-property (line-beginning-position) 'help-echo))) - (string-match "[0-9]+\\'" prop) - (let ((str (match-string-no-properties 0 prop))) + (when (re-search-forward "^[0-9.]+ +[^\n ]* +\\([0-9]\\{8\\}\\) |" nil t) + (let ((str (match-string-no-properties 1))) (vc-annotate-convert-time (encode-time 0 0 0 - (string-to-number (substring str 6 8)) - (string-to-number (substring str 4 6)) - (string-to-number (substring str 0 4)))))))) + (string-to-number (substring str 6 8)) + (string-to-number (substring str 4 6)) + (string-to-number (substring str 0 4))))))) (defun vc-bzr-annotate-extract-revision-at-line () "Return revision for current line of annotation buffer, or nil. Return nil if current line isn't annotated." (save-excursion (beginning-of-line) - (if (looking-at "^ *\\([0-9.]+\\) +.* +|") + (if (looking-at "^\\([0-9.]+\\) +[^\n ]* +\\([0-9]\\{8\\}\\) |") (match-string-no-properties 1)))) (defun vc-bzr-command-discarding-stderr (command &rest args) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 14:05:43 2019 Received: (at 5428) by debbugs.gnu.org; 27 Jun 2019 18:05:43 +0000 Received: from localhost ([127.0.0.1]:39577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYmF-00072W-FM for submit@debbugs.gnu.org; Thu, 27 Jun 2019 14:05:43 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYmB-00071y-AX for 5428@debbugs.gnu.org; Thu, 27 Jun 2019 14:05:39 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3A50B81172; Thu, 27 Jun 2019 14:05:33 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1081080D86; Thu, 27 Jun 2019 14:05:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1561658732; bh=UVPp+vdjWCiZZHSe4zYpvwhHMJrSP9sNE+9QsUtx0ew=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DlpgUc8xLX/ugGwmrcsY3UNiE1VdJpCnCRnbfhLOwWv/6IhdgPSDrVqjdy5Ifqmzo FSF7pM8wpJhXhnmq0funuNzIZidk3eoykW98fd8DPjkM/croMJYV9FoNr+IQBoRb1j RUutCupE+S7ipZSiAP0K7ASz6oLWJptBVu0XZCTuHLW8FSzzY++Etqy/F9UML1ck7F mrkpLjTQXCNDVIsR0QHd0CFrxikDIWqs+79Q8C3LRAj7waFaUYMzBnassiHxdFmu6O PzovTH2Xb5QQlUL/ZJok2igw+zduFf1Gqx9UPyuDasHY4i68UarpeEHaDroSHOPD/Z t5bj9i5TNaWFQ== Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 085971206C3; Thu, 27 Jun 2019 14:05:32 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#5428: vc-annotate for Bzr does not show the date Message-ID: References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <8u3836n45e.fsf@fencepost.gnu.org> <5557D8FB.7030105@yandex.ru> <87bn71tl8r.fsf@gnus.org> <7bio18zo57.fsf@fencepost.gnu.org> Date: Thu, 27 Jun 2019 14:05:31 -0400 In-Reply-To: (Lars Ingebrigtsen's message of "Thu, 27 Jun 2019 19:36:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.140 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5428 Cc: Dan Nicolaescu , Glenn Morris , Dmitry Gutov , 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Does anybody still object to this change? Stefan wanted this to be > customisable, and that would be nice, and should probably apply to all > backends, but it's a somewhat orthogonal issue... Last time I used vc-annotate was in 2014, so the need for customization is not very high up in my list. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 14:11:20 2019 Received: (at 5428) by debbugs.gnu.org; 27 Jun 2019 18:11:20 +0000 Received: from localhost ([127.0.0.1]:39604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYrf-0007HT-Oo for submit@debbugs.gnu.org; Thu, 27 Jun 2019 14:11:20 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYre-0007HJ-5X for 5428@debbugs.gnu.org; Thu, 27 Jun 2019 14:11:18 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgYrY-0000HC-2p; Thu, 27 Jun 2019 20:11:14 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#5428: vc-annotate for Bzr does not show the date References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <8u3836n45e.fsf@fencepost.gnu.org> <5557D8FB.7030105@yandex.ru> <87bn71tl8r.fsf@gnus.org> <7bio18zo57.fsf@fencepost.gnu.org> Date: Thu, 27 Jun 2019 20:11:11 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 27 Jun 2019 14:05:31 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> Does anybody still object to this change? Stefan wanted this to be >> customisable, and that would be nice, and should probably apply to all >> backends, but it's a somewhat orthogonal issue... > > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5428 Cc: Glenn Morris , 5428@debbugs.gnu.org, Dan Nicolaescu , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> Does anybody still object to this change? Stefan wanted this to be >> customisable, and that would be nice, and should probably apply to all >> backends, but it's a somewhat orthogonal issue... > > Last time I used vc-annotate was in 2014, so the need for > customization is not very high up in my list. OK; I'll go ahead and apply the patch, because I think the resulting bzr output was nicer... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 14:13:53 2019 Received: (at 5428) by debbugs.gnu.org; 27 Jun 2019 18:13:53 +0000 Received: from localhost ([127.0.0.1]:39609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYu9-0007LR-9V for submit@debbugs.gnu.org; Thu, 27 Jun 2019 14:13:53 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYu6-0007LJ-Kc for 5428@debbugs.gnu.org; Thu, 27 Jun 2019 14:13:51 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgYu3-0000JC-2p; Thu, 27 Jun 2019 20:13:49 +0200 From: Lars Ingebrigtsen To: Dan Nicolaescu Subject: Re: bug#5428: vc-annotate for Bzr does not show the date References: <201001200726.o0K7Qn9W013724@godzilla.ics.uci.edu> <201001211527.o0LFRokp021595@godzilla.ics.uci.edu> Date: Thu, 27 Jun 2019 20:13:46 +0200 In-Reply-To: <201001211527.o0LFRokp021595@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Thu, 21 Jan 2010 07:27:50 -0800 (PST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dan Nicolaescu writes: > Meanwhile here's a patch for people that want to be able to fully use of > vc-annotate with bzr. Just removes a bunch of code and adjusts 2 regexps. I've now applied this to the Emacs trunk. Just took nine years. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5428 Cc: Stefan Monnier , 5428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dan Nicolaescu writes: > Meanwhile here's a patch for people that want to be able to fully use of > vc-annotate with bzr. Just removes a bunch of code and adjusts 2 regexps. I've now applied this to the Emacs trunk. Just took nine years. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 14:13:57 2019 Received: (at control) by debbugs.gnu.org; 27 Jun 2019 18:13:57 +0000 Received: from localhost ([127.0.0.1]:39612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYuD-0007Lk-Jm for submit@debbugs.gnu.org; Thu, 27 Jun 2019 14:13:57 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYuC-0007Ld-NR for control@debbugs.gnu.org; Thu, 27 Jun 2019 14:13:57 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgYuA-0000Jb-7r for control@debbugs.gnu.org; Thu, 27 Jun 2019 20:13:56 +0200 Date: Thu, 27 Jun 2019 20:13:54 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #5428 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 5428 fixed close 5428 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 5428 fixed close 5428 27.1 quit From unknown Sat Jun 14 03:47:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 26 Jul 2019 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator