GNU bug report logs - #54273
[PATCH] gnu: nicotine+: update to 3.2.1.

Previous Next

Package: guix-patches;

Reported by: Fatima Toothpaste <fatimatoothpaste <at> disroot.org>

Date: Sun, 6 Mar 2022 16:50:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Fatima Toothpaste <fatimatoothpaste <at> disroot.org>
Cc: 54273 <at> debbugs.gnu.org
Subject: [bug#54273] [PATCH] gnu: nicotine+: update to 3.2.1.
Date: Fri, 11 Mar 2022 23:11:46 +0100

Hi,

Fatima Toothpaste <fatimatoothpaste <at> disroot.org> skribis:

> * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1.
>   [arguments]: Delete check phase.
>   [inputs]: Add bash-minimal.
>   [home-page]: Update URL.

[...]

> +         ;;Tests require network connection
> +         (delete 'check))))

Tests should rather be disabled with #:tests? #f.

However, could you check if we can just skip (or tweak?) the tests that
specifically depend on networking?

The rest of the patch looks good to me.

Thanks,
Ludo’.
This bug report was last modified 3 years and 68 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.