GNU bug report logs - #54273
[PATCH] gnu: nicotine+: update to 3.2.1.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Fatima Toothpaste <fatimatoothpaste <at> disroot.org>
Subject: bug#54273: closed (Re: bug#54273: [PATCH] gnu: nicotine+: update
 to 3.2.1.)
Date: Tue, 15 Mar 2022 09:53:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#54273: [PATCH] gnu: nicotine+: update to 3.2.1.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 54273 <at> debbugs.gnu.org.

-- 
54273: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54273
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Fatima Toothpaste <fatimatoothpaste <at> disroot.org>
Cc: maximedevos <at> telenet.be, 54273-done <at> debbugs.gnu.org
Subject: Re: bug#54273: [PATCH] gnu: nicotine+: update to 3.2.1.
Date: Tue, 15 Mar 2022 10:52:33 +0100

Hi,

Fatima Toothpaste <fatimatoothpaste <at> disroot.org> skribis:

> * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1.
>   [source]: Delete network requried tests in snippet.
>   [arguments]: Remove trailing #t.
>   Replae 'check phase to run proper test.
>   [inputs]: Add bash-minimal, gspell, libappindicator.
>   [native-inputs]: Remove python-pytest. Add xvfb-run.
>   [home-page]: Update URL.

[...]

> +              (snippet '(begin
> +                          (delete-file-recursively "test/integration")))))

I added a comment above the snippet explaining it and applied.

Thanks,
Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Fatima Toothpaste <fatimatoothpaste <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: Fatima Toothpaste <fatimatoothpaste <at> disroot.org>
Subject: [PATCH] gnu: nicotine+: update to 3.2.1.
Date: Sun,  6 Mar 2022 14:45:51 +0900

* gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1.
  [arguments]: Delete check phase.
  [inputs]: Add bash-minimal.
  [home-page]: Update URL.
---
 gnu/packages/nicotine.scm | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/nicotine.scm b/gnu/packages/nicotine.scm
index 8e194697de..6890c26cb6 100644
--- a/gnu/packages/nicotine.scm
+++ b/gnu/packages/nicotine.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2020 Martin Becze <mjbecze <at> riseup.net>
+;;; Copyright © 2022 Fatima Toothpaste <fatimatoothpaste <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21,6 +22,7 @@ (define-module (gnu packages nicotine)
   #:use-module (guix packages)
   #:use-module (guix git-download)
   #:use-module (guix build-system python)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gtk)
@@ -30,14 +32,14 @@ (define-module (gnu packages nicotine)
 (define-public nicotine+
   (package
     (name "nicotine+")
-    (version "2.1.2")
+    (version "3.2.1")
     (source (origin
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/Nicotine-Plus/nicotine-plus")
                     (commit version)))
               (file-name (git-file-name name version))
-              (sha256 (base32 "18rra8yqjr10z23chzcp53ncbd5fhm0iqgqxpbxfq7a10za02v6l"))))
+              (sha256 (base32 "1x08z5lvkdl62dkc11vrsackgzsh1vr9vp3vgsgfzjyrvlsybmfw"))))
     (build-system python-build-system)
     (arguments
      `(#:imported-modules ((guix build glib-or-gtk-build-system)
@@ -60,13 +62,16 @@ (define-public nicotine+
          (add-after 'wrap-program 'glib-or-gtk-wrap
            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
          (add-after 'glib-or-gtk-wrap 'glib-or-gtk-compile-schemas
-           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas)))))
+           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas))
+         ;;Tests require network connection
+         (delete 'check))))
     (inputs
-     (list gtk+ python-pygobject python-pytaglib))
+     ;;TODO: Add libayatana-appindicator
+     (list bash-minimal gtk+ python-pygobject python-pytaglib))
     (native-inputs
      `(("python-pytest" ,python-pytest)
        ("gettext" ,gettext-minimal)))
-    (home-page "https://nicotine-plus.github.io/nicotine-plus/")
+    (home-page "https://nicotine-plus.org/nicotine-plus/")
     (synopsis "Graphical client for Soulseek")
     (description
      "Nicotine+ is a graphical client for the Soulseek peer-to-peer
-- 
2.34.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.