GNU bug report logs - #54273
[PATCH] gnu: nicotine+: update to 3.2.1.

Previous Next

Full log

Message #14 received at 54273 <at> debbugs.gnu.org (full text, mbox):

From: Fatima Toothpaste <fatimatoothpaste <at> disroot.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 54273 <at> debbugs.gnu.org
Subject: Re: bug#54273: [PATCH] gnu: nicotine+: update to 3.2.1.
Date: Sun, 13 Mar 2022 10:14:11 +0900

Sorry, I fixed what you said, and other messes i made.
Thanks for reviewing.

On 3/12/22 07:11, Ludovic Courtès wrote:
> Hi,
>
> Fatima Toothpaste <fatimatoothpaste <at> disroot.org> skribis:
>
>> * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1.
>>    [arguments]: Delete check phase.
>>    [inputs]: Add bash-minimal.
>>    [home-page]: Update URL.
> [...]
>
>> +         ;;Tests require network connection
>> +         (delete 'check))))
> Tests should rather be disabled with #:tests? #f.
>
> However, could you check if we can just skip (or tweak?) the tests that
> specifically depend on networking?
>
> The rest of the patch looks good to me.
>
> Thanks,
> Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.