From unknown Sat Jun 21 10:37:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54273 <54273@debbugs.gnu.org> To: bug#54273 <54273@debbugs.gnu.org> Subject: Status: [PATCH] gnu: nicotine+: update to 3.2.1. Reply-To: bug#54273 <54273@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:37:18 +0000 retitle 54273 [PATCH] gnu: nicotine+: update to 3.2.1. reassign 54273 guix-patches submitter 54273 Fatima Toothpaste severity 54273 normal tag 54273 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 06 11:49:05 2022 Received: (at submit) by debbugs.gnu.org; 6 Mar 2022 16:49:05 +0000 Received: from localhost ([127.0.0.1]:51633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQu48-0000Sf-Pd for submit@debbugs.gnu.org; Sun, 06 Mar 2022 11:49:05 -0500 Received: from lists.gnu.org ([209.51.188.17]:45402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQjic-0001oL-T1 for submit@debbugs.gnu.org; Sun, 06 Mar 2022 00:46:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQjic-0007Ua-De for guix-patches@gnu.org; Sun, 06 Mar 2022 00:46:10 -0500 Received: from knopi.disroot.org ([178.21.23.139]:51662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQjiY-0005mO-3p for guix-patches@gnu.org; Sun, 06 Mar 2022 00:46:10 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 428E48C42A; Sun, 6 Mar 2022 06:46:01 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EBHg1HrxYP07; Sun, 6 Mar 2022 06:46:00 +0100 (CET) From: Fatima Toothpaste DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1646545559; bh=RCbhxk5Iev6QC1slQsn+vx08FuH6MhOiQT9e5vx5eYk=; h=From:To:Cc:Subject:Date; b=JDln5n7Qk8ONRoVGcjzk7ME34BtsjIVmwyhHEOMAAIzWP+n6Aoc9ypBV1gXWkv8+W AGYriV+6nqVtufNkv7hlO80iE75ZUXsxzyL1R5xiHc+XocHfdRsudPJjMWRC4SYhE+ MqPF7V8DEI5CJitaDuPBsBKob1kGys0+LE7wSqRafLI5G29DA/sxQ4QjH6De0vK9Il aF1cE9IPc/W/S5N3E7cUA/TGaZ/dVU3EZ4HpLywp7wGHYEDm0G1L8zuQLlHZ70DwX2 X05TRKlbTfYxVlhz9BEwJ0X6UPkcokSsF5Js0uahRkrO1yRs/XhFg114ZvdnSe3roe NgXgbXrNQNaqw== To: guix-patches@gnu.org Subject: [PATCH] gnu: nicotine+: update to 3.2.1. Date: Sun, 6 Mar 2022 14:45:51 +0900 Message-Id: <20220306054551.19383-1-fatimatoothpaste@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=fatimatoothpaste@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 06 Mar 2022 11:49:03 -0500 Cc: Fatima Toothpaste X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1. [arguments]: Delete check phase. [inputs]: Add bash-minimal. [home-page]: Update URL. --- gnu/packages/nicotine.scm | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/gnu/packages/nicotine.scm b/gnu/packages/nicotine.scm index 8e194697de..6890c26cb6 100644 --- a/gnu/packages/nicotine.scm +++ b/gnu/packages/nicotine.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2020 Martin Becze +;;; Copyright © 2022 Fatima Toothpaste ;;; ;;; This file is part of GNU Guix. ;;; @@ -21,6 +22,7 @@ (define-module (gnu packages nicotine) #:use-module (guix packages) #:use-module (guix git-download) #:use-module (guix build-system python) + #:use-module (gnu packages bash) #:use-module (gnu packages glib) #:use-module (gnu packages gettext) #:use-module (gnu packages gtk) @@ -30,14 +32,14 @@ (define-module (gnu packages nicotine) (define-public nicotine+ (package (name "nicotine+") - (version "2.1.2") + (version "3.2.1") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/Nicotine-Plus/nicotine-plus") (commit version))) (file-name (git-file-name name version)) - (sha256 (base32 "18rra8yqjr10z23chzcp53ncbd5fhm0iqgqxpbxfq7a10za02v6l")))) + (sha256 (base32 "1x08z5lvkdl62dkc11vrsackgzsh1vr9vp3vgsgfzjyrvlsybmfw")))) (build-system python-build-system) (arguments `(#:imported-modules ((guix build glib-or-gtk-build-system) @@ -60,13 +62,16 @@ (define-public nicotine+ (add-after 'wrap-program 'glib-or-gtk-wrap (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) (add-after 'glib-or-gtk-wrap 'glib-or-gtk-compile-schemas - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas))))) + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas)) + ;;Tests require network connection + (delete 'check)))) (inputs - (list gtk+ python-pygobject python-pytaglib)) + ;;TODO: Add libayatana-appindicator + (list bash-minimal gtk+ python-pygobject python-pytaglib)) (native-inputs `(("python-pytest" ,python-pytest) ("gettext" ,gettext-minimal))) - (home-page "https://nicotine-plus.github.io/nicotine-plus/") + (home-page "https://nicotine-plus.org/nicotine-plus/") (synopsis "Graphical client for Soulseek") (description "Nicotine+ is a graphical client for the Soulseek peer-to-peer -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 11 17:11:56 2022 Received: (at 54273) by debbugs.gnu.org; 11 Mar 2022 22:11:56 +0000 Received: from localhost ([127.0.0.1]:38586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnUJ-00051C-SE for submit@debbugs.gnu.org; Fri, 11 Mar 2022 17:11:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnUH-00050x-My for 54273@debbugs.gnu.org; Fri, 11 Mar 2022 17:11:54 -0500 Received: from [2001:470:142:3::e] (port=34038 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSnUC-0002m4-I2; Fri, 11 Mar 2022 17:11:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=tDd81XxTocTrPQh617xk87QQtPhFWjh7aSdH+Vr5ppg=; b=KYduy3TDpMhIFrHf1i52 qLi8dNsLnmL7fX9rGeM9PGPzLbC0vjILOoRcNUCv+02vKnrf2Cd5uoMfTodRJggB/ANIv/RFSsi5u XL940+aw4kCxB/mqO5LEQK0aK2A+yVfvJF9sHMLB1LDb+KY+uU4f4xd2ZN2Z2WRINH5lvZjColYDC eEBAgSePMTus5G37Xf5LLvhdTGCl3jvljW+OBcXyayA7Qs8sEv8J4m+DU0ihOZIjD58uQM8zF8KGe KGK/CXBlEA6stH7qU8kJgzrq2AWQqDbqE1J+I8gsKHexW9fqalF3ZC82uCrR1rPWOP5A3sONe3gZ6 Ek38cEf82/NrRQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:64247 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSnUC-0002S2-1L; Fri, 11 Mar 2022 17:11:48 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Fatima Toothpaste Subject: Re: bug#54273: [PATCH] gnu: nicotine+: update to 3.2.1. References: <20220306054551.19383-1-fatimatoothpaste@disroot.org> Date: Fri, 11 Mar 2022 23:11:46 +0100 In-Reply-To: <20220306054551.19383-1-fatimatoothpaste@disroot.org> (Fatima Toothpaste's message of "Sun, 6 Mar 2022 14:45:51 +0900") Message-ID: <87lexgw34t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54273 Cc: 54273@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Fatima Toothpaste skribis: > * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1. > [arguments]: Delete check phase. > [inputs]: Add bash-minimal. > [home-page]: Update URL. [...] > + ;;Tests require network connection > + (delete 'check)))) Tests should rather be disabled with #:tests? #f. However, could you check if we can just skip (or tweak?) the tests that specifically depend on networking? The rest of the patch looks good to me. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 12 11:05:57 2022 Received: (at 54273) by debbugs.gnu.org; 12 Mar 2022 16:05:57 +0000 Received: from localhost ([127.0.0.1]:40666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nT4Fg-0005aG-N0 for submit@debbugs.gnu.org; Sat, 12 Mar 2022 11:05:57 -0500 Received: from knopi.disroot.org ([178.21.23.139]:36778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nT2J9-0002Cr-Ip for 54273@debbugs.gnu.org; Sat, 12 Mar 2022 09:01:24 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 36396400C4; Sat, 12 Mar 2022 15:01:22 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id HK3FamyrYUoi; Sat, 12 Mar 2022 15:01:20 +0100 (CET) From: Fatima Toothpaste DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1647093675; bh=e/PPCS7m1QSMRe6k6QoxOAAAaQ+Yu8nIFBjE39ZjT90=; h=From:To:Cc:Subject:Date; b=Il7zBGLquvzmYUo7MVcqGu4pUgYWRlluP1E1l3iYIz5AcmQqrWcFbSUoduJsJWX1z MRWZnBx+aNAzb88SjaB+1vEjwJNZ8o7ryXHyrvS8uWLBJyZ3nPDDi6UcdorZY3H2TX mdgYZU/4qQgycierIli83qRLARDlYwjb3//ob9xEE7hyrsAwYBzmwwpEdsr7A+zJ9m XSUt1itvIO/I0lmqflnIqk7a8FH+WXnPKMurcl08sphYRsxPZcSooGZl4W3RaxEHd0 ks3UN6TjS5AyjnWHZq06Yyrm4qomcf8QuDus22w00K+qJguTvW551J+9U116ryW2tY rSfVRaQq+mNYw== To: 54273@debbugs.gnu.org Subject: [PATCH V2] gnu : nicotine+: Update to 3.2.1. Date: Sat, 12 Mar 2022 22:59:58 +0900 Message-Id: <20220312135958.5627-1-fatimatoothpaste@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54273 X-Mailman-Approved-At: Sat, 12 Mar 2022 11:05:55 -0500 Cc: Fatima Toothpaste X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1. [source]: Delete network requried tests in snippet. [arguments]: Remove trailing #t. Replae 'check to use python unittest module. [inputs]: Add bash-minimal. [native-inputs]: Remove python-pytest. Add python. [home-page]: Update URL. --- gnu/packages/nicotine.scm | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/gnu/packages/nicotine.scm b/gnu/packages/nicotine.scm index 8e194697de..62ad2bb9bf 100644 --- a/gnu/packages/nicotine.scm +++ b/gnu/packages/nicotine.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2020 Martin Becze +;;; Copyright © 2022 Fatima Toothpaste ;;; ;;; This file is part of GNU Guix. ;;; @@ -21,23 +22,27 @@ (define-module (gnu packages nicotine) #:use-module (guix packages) #:use-module (guix git-download) #:use-module (guix build-system python) + #:use-module (gnu packages bash) #:use-module (gnu packages glib) #:use-module (gnu packages gettext) #:use-module (gnu packages gtk) - #:use-module (gnu packages check) - #:use-module (gnu packages mp3)) + #:use-module (gnu packages mp3) + #:use-module (gnu packages python)) (define-public nicotine+ (package (name "nicotine+") - (version "2.1.2") + (version "3.2.1") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/Nicotine-Plus/nicotine-plus") (commit version))) (file-name (git-file-name name version)) - (sha256 (base32 "18rra8yqjr10z23chzcp53ncbd5fhm0iqgqxpbxfq7a10za02v6l")))) + (sha256 (base32 "1x08z5lvkdl62dkc11vrsackgzsh1vr9vp3vgsgfzjyrvlsybmfw")) + (modules '((guix build utils))) + (snippet '(begin + (delete-file-recursively "test/integration"))))) (build-system python-build-system) (arguments `(#:imported-modules ((guix build glib-or-gtk-build-system) @@ -55,18 +60,20 @@ (define-public nicotine+ "/bin/nicotine")) (gi-typelib-path (getenv "GI_TYPELIB_PATH"))) (wrap-program prog - `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))) - #t))) + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))) (add-after 'wrap-program 'glib-or-gtk-wrap (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) (add-after 'glib-or-gtk-wrap 'glib-or-gtk-compile-schemas - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas))))) + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas)) + (replace 'check + (lambda _ + (invoke "python" "-m" "unittest")))))) (inputs - (list gtk+ python-pygobject python-pytaglib)) + ;;TODO: Add libayatana-appindicator + (list bash-minimal gtk+ python-pygobject python-pytaglib)) (native-inputs - `(("python-pytest" ,python-pytest) - ("gettext" ,gettext-minimal))) - (home-page "https://nicotine-plus.github.io/nicotine-plus/") + (list python gettext-minimal)) + (home-page "https://nicotine-plus.org/") (synopsis "Graphical client for Soulseek") (description "Nicotine+ is a graphical client for the Soulseek peer-to-peer -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 12 20:35:17 2022 Received: (at 54273) by debbugs.gnu.org; 13 Mar 2022 01:35:17 +0000 Received: from localhost ([127.0.0.1]:41255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTD8f-0007r4-Ci for submit@debbugs.gnu.org; Sat, 12 Mar 2022 20:35:17 -0500 Received: from knopi.disroot.org ([178.21.23.139]:51120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTCoK-0007KG-NX for 54273@debbugs.gnu.org; Sat, 12 Mar 2022 20:14:17 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A405C400C5; Sun, 13 Mar 2022 02:14:15 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 45M_KUB8L8YK; Sun, 13 Mar 2022 02:14:14 +0100 (CET) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1647134054; bh=u3q/dUPHHQjSrSEFUdSvFvaRTN1VPGn9BBLAmq9zTxI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=IPT0F0TjdwefoIUe3aed78ni7E4WGqTL/FZ0IbuxHH0r8WxLVPncCSe/wCaXGGta5 PtYubu+M06V8mOL3tHkq9ChJ5jzx+EYu7RXJgJKRJgF+XNFcvA714D8BINuXxrjLrR bX5RhFIZsb/iv+hd1hISQhvaGZBuw3jxNnUkjneSVAkdDIlifTISj8BlQJJyV2EvtZ yr2aPwTAkIKWRiMnaUeX+c/INfFUNd9jPg2gvV/a36uWYGOZnk84dTO3W2BqKUvKTh NSH+L0zsbB2fFCMKBj49SI/OWX1xbzweRal3IBAnaVZCvvhxFuUFviOui6SZjz4XkO v2le8ukUPl8+g== Date: Sun, 13 Mar 2022 10:14:11 +0900 Mime-Version: 1.0 Subject: Re: bug#54273: [PATCH] gnu: nicotine+: update to 3.2.1. Content-Language: en-US To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20220306054551.19383-1-fatimatoothpaste@disroot.org> <87lexgw34t.fsf@gnu.org> From: Fatima Toothpaste In-Reply-To: <87lexgw34t.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54273 X-Mailman-Approved-At: Sat, 12 Mar 2022 20:35:16 -0500 Cc: 54273@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sorry, I fixed what you said, and other messes i made. Thanks for reviewing. On 3/12/22 07:11, Ludovic Courtès wrote: > Hi, > > Fatima Toothpaste skribis: > >> * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1. >> [arguments]: Delete check phase. >> [inputs]: Add bash-minimal. >> [home-page]: Update URL. > [...] > >> + ;;Tests require network connection >> + (delete 'check)))) > Tests should rather be disabled with #:tests? #f. > > However, could you check if we can just skip (or tweak?) the tests that > specifically depend on networking? > > The rest of the patch looks good to me. > > Thanks, > Ludo’. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 12 20:35:18 2022 Received: (at 54273) by debbugs.gnu.org; 13 Mar 2022 01:35:18 +0000 Received: from localhost ([127.0.0.1]:41257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTD8f-0007r7-P1 for submit@debbugs.gnu.org; Sat, 12 Mar 2022 20:35:18 -0500 Received: from knopi.disroot.org ([178.21.23.139]:51978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTCoR-0007Kd-1s for 54273@debbugs.gnu.org; Sat, 12 Mar 2022 20:14:23 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 91133400C5; Sun, 13 Mar 2022 02:14:22 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qmPVXuQu7hgJ; Sun, 13 Mar 2022 02:14:21 +0100 (CET) From: Fatima Toothpaste DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1647134061; bh=e/PPCS7m1QSMRe6k6QoxOAAAaQ+Yu8nIFBjE39ZjT90=; h=From:To:Cc:Subject:Date; b=dL1br/Hcf1taZJGxlqW/lkmxRgJ4tRwW1slaUpKbUUlkfcXj3dOUT8H0jSe6NPlP7 hnGL4OWp/KUz8sL1FMXcKXrUcgYl++p7iJ9IQa7hrsAH5c52z3rRobHf22KMpSGHqD 3s0FLaD5j2ZjkJLwCB83kUaHKeT+LgN+9Wm1592ujImf9a/tg6DgOrJX/qRVaRL8ay thQgs/qD3Xk/Zl6pQwT/c08bLQqmc78PCtYcPWVCLJq2TJgHu92Ny96TKW+E0ORCGp XwBvfHcEqmco/E0bjSh8ZLMOkZJCBY6ye+ie07+5/AU9W71ZojI/RuJYjksrRxpaY8 OyGx9P4Yd4aWQ== To: ludo@gnu.org Subject: [PATCH V2] gnu : nicotine+: Update to 3.2.1. Date: Sun, 13 Mar 2022 10:14:14 +0900 Message-Id: <20220313011414.10351-1-fatimatoothpaste@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54273 X-Mailman-Approved-At: Sat, 12 Mar 2022 20:35:16 -0500 Cc: 54273@debbugs.gnu.org, Fatima Toothpaste X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1. [source]: Delete network requried tests in snippet. [arguments]: Remove trailing #t. Replae 'check to use python unittest module. [inputs]: Add bash-minimal. [native-inputs]: Remove python-pytest. Add python. [home-page]: Update URL. --- gnu/packages/nicotine.scm | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/gnu/packages/nicotine.scm b/gnu/packages/nicotine.scm index 8e194697de..62ad2bb9bf 100644 --- a/gnu/packages/nicotine.scm +++ b/gnu/packages/nicotine.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2020 Martin Becze +;;; Copyright © 2022 Fatima Toothpaste ;;; ;;; This file is part of GNU Guix. ;;; @@ -21,23 +22,27 @@ (define-module (gnu packages nicotine) #:use-module (guix packages) #:use-module (guix git-download) #:use-module (guix build-system python) + #:use-module (gnu packages bash) #:use-module (gnu packages glib) #:use-module (gnu packages gettext) #:use-module (gnu packages gtk) - #:use-module (gnu packages check) - #:use-module (gnu packages mp3)) + #:use-module (gnu packages mp3) + #:use-module (gnu packages python)) (define-public nicotine+ (package (name "nicotine+") - (version "2.1.2") + (version "3.2.1") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/Nicotine-Plus/nicotine-plus") (commit version))) (file-name (git-file-name name version)) - (sha256 (base32 "18rra8yqjr10z23chzcp53ncbd5fhm0iqgqxpbxfq7a10za02v6l")))) + (sha256 (base32 "1x08z5lvkdl62dkc11vrsackgzsh1vr9vp3vgsgfzjyrvlsybmfw")) + (modules '((guix build utils))) + (snippet '(begin + (delete-file-recursively "test/integration"))))) (build-system python-build-system) (arguments `(#:imported-modules ((guix build glib-or-gtk-build-system) @@ -55,18 +60,20 @@ (define-public nicotine+ "/bin/nicotine")) (gi-typelib-path (getenv "GI_TYPELIB_PATH"))) (wrap-program prog - `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))) - #t))) + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))) (add-after 'wrap-program 'glib-or-gtk-wrap (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) (add-after 'glib-or-gtk-wrap 'glib-or-gtk-compile-schemas - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas))))) + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas)) + (replace 'check + (lambda _ + (invoke "python" "-m" "unittest")))))) (inputs - (list gtk+ python-pygobject python-pytaglib)) + ;;TODO: Add libayatana-appindicator + (list bash-minimal gtk+ python-pygobject python-pytaglib)) (native-inputs - `(("python-pytest" ,python-pytest) - ("gettext" ,gettext-minimal))) - (home-page "https://nicotine-plus.github.io/nicotine-plus/") + (list python gettext-minimal)) + (home-page "https://nicotine-plus.org/") (synopsis "Graphical client for Soulseek") (description "Nicotine+ is a graphical client for the Soulseek peer-to-peer -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 13 07:06:20 2022 Received: (at 54273) by debbugs.gnu.org; 13 Mar 2022 11:06:20 +0000 Received: from localhost ([127.0.0.1]:41724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTM3I-00020V-Ha for submit@debbugs.gnu.org; Sun, 13 Mar 2022 07:06:20 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:53268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTM3G-00020L-CV for 54273@debbugs.gnu.org; Sun, 13 Mar 2022 07:06:19 -0400 Received: from [172.20.10.5] ([188.189.206.172]) by albert.telenet-ops.be with bizsmtp id 5n6F2700F3jiMiL06n6GtG; Sun, 13 Mar 2022 12:06:16 +0100 Message-ID: Subject: Re: [bug#54273] [PATCH V2] gnu : nicotine+: Update to 3.2.1. From: Maxime Devos To: Fatima Toothpaste , ludo@gnu.org Date: Sun, 13 Mar 2022 12:06:10 +0100 In-Reply-To: <20220313011414.10351-1-fatimatoothpaste@disroot.org> References: <20220306054551.19383-1-fatimatoothpaste@disroot.org> <20220313011414.10351-1-fatimatoothpaste@disroot.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-LFGjlVVZbGnI+9KsMJ0f" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647169576; bh=oaV9H6f7apk5BdcgK0pbi1fIP6NfJ8w0Z02EUUFT9nM=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=M1oswg+2xAOaFPCrpB/1JJtpQiUIh5JQpbIusIRKBeLoIiJG6+Ams6cHgCJQlV7IQ LFKUkHRQCt/N/xRXvQIC7i3lwZCustMsfYVM8rXDPeYn/XeEfW1qKSYHAJLWCmOAGM HC3nfkHe5DEXgiuQlVva7p68flyl9VA3ObjWx9r1clEjMnWcB1JpSVsEcLU4lRur7x nUi0xdX5h1aJjoyT3ry7h57ia8VSAT3C5Qw4no9dokSDYzjj8HmbeNuMLbbB4LQ4FY w2MdDbfuSDT8hZCy8+6sUkdwceg7sGuhZSqlyxe0DGJuUe0bRbf7HsKIFAY3qPy3GL ZIPs4E+MQFhAg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54273 Cc: 54273@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-LFGjlVVZbGnI+9KsMJ0f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Fatima Toothpaste via Guix-patches via schreef op zo 13-03-2022 om 10:14 [+0900]: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (replace 'check > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lambda _ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= (invoke "python" "-m" "unittest")))))) "./pre-inst-env guix lint nicotine+" would warn about this. To make the '--without-tests' package transformatin work, this needs to be: > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (when tests? > + (invoke "python" "-m" "unittest"))))))) Greetings, Maxime. --=-LFGjlVVZbGnI+9KsMJ0f Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYi3QIhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tOGAP9TUy58fbxDqKCGGoB4wMxyi4qo mmDUAF6P+eSd6T7gjwD/Q5DantmhBNyAmtbmyt8PDIpjIQFBVcjvEZT8vLSFiAc= =qFmg -----END PGP SIGNATURE----- --=-LFGjlVVZbGnI+9KsMJ0f-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 13 11:45:12 2022 Received: (at 54273) by debbugs.gnu.org; 13 Mar 2022 15:45:12 +0000 Received: from localhost ([127.0.0.1]:43146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTQP9-0001qk-MI for submit@debbugs.gnu.org; Sun, 13 Mar 2022 11:45:11 -0400 Received: from knopi.disroot.org ([178.21.23.139]:57230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTQP7-0001qa-Sp for 54273@debbugs.gnu.org; Sun, 13 Mar 2022 11:45:10 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A4406400DC; Sun, 13 Mar 2022 16:45:08 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mpriCce9ZUHh; Sun, 13 Mar 2022 16:45:07 +0100 (CET) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1647186306; bh=p3DSIpWZzWObimanYXU4YB43rMbP2dNTUvZogYDpEMc=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=BiGLlQovwUDqijYFGeLFHbMzVYXzbpqqNTDg9CVKy3h5FBNL/rPV4kXdp1GkwmbaF z4rzC/UCgN+EVP4md/xkSHT9idpoRZSLYe4DH4PLAHr2qSmkN9PpjKwARwAw9/XLuW AnHo0ESTfZJdYS1CBiwRqvHL6kM0ysrpeUPc3XRoGI8jPmhaaohbo0FKeEQHhJk5Up g055sh0sTTyH/aJEguta4PcrlvH1VNNbleMqgeEweqAYPkDFhySyDwRIInC1lSG8w/ 6cavnsl5I+qNxFVV1FlbUeP0sIfSsybuZxkkmw3WeGXmhci/GEdjQmsgylUrtA7F8e 0eeUqcrT0mM6A== Date: Mon, 14 Mar 2022 00:45:03 +0900 Mime-Version: 1.0 Subject: Re: [bug#54273] [PATCH V2] gnu : nicotine+: Update to 3.2.1. Content-Language: en-US To: Maxime Devos , ludo@gnu.org References: <20220306054551.19383-1-fatimatoothpaste@disroot.org> <20220313011414.10351-1-fatimatoothpaste@disroot.org> From: Fatima Toothpaste In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54273 Cc: 54273@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sorry, I forgot to lint. By the way, I also included some optional dependencies on new patch, which i excluded on purpose before. gspell: spell checking doesn't work on my machine. However, gtk and gspell both are loaded with pygobject, and gtk works fine. so it might be the problem of nicotine+, or might work on other environment. libappindicator: i excluded it because i heard it is unmaintained and should be replaced with libayatana-appindicator. But, still though there are some packages depend on libappindicator in guix. So, Just using libappindicator for a now and replacing it all together with libayatana-appindicator someday doesn't seems so bad to me, What do you think? From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 13 11:45:19 2022 Received: (at 54273) by debbugs.gnu.org; 13 Mar 2022 15:45:19 +0000 Received: from localhost ([127.0.0.1]:43149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTQPH-0001r6-00 for submit@debbugs.gnu.org; Sun, 13 Mar 2022 11:45:19 -0400 Received: from knopi.disroot.org ([178.21.23.139]:58682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTQPF-0001qz-6i for 54273@debbugs.gnu.org; Sun, 13 Mar 2022 11:45:17 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 7C564400BE; Sun, 13 Mar 2022 16:45:16 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y8kEAZ3K8GP8; Sun, 13 Mar 2022 16:45:15 +0100 (CET) From: Fatima Toothpaste DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1647186315; bh=uJlJKm63DwaHDRyfc5OY9Wfgaq6+Sqlatftqm/7PB74=; h=From:To:Cc:Subject:Date; b=F2n7PwYtm06sR9rjbLq9On4JzAzv6FB+aGoDLvFKeUEZEfWk11MubY062CJydVxwR 08ykMR2+KM2gSodPAkRrRl1HWFd2zU/556UigApAUDInntxbG2dvqJtUQUXXQcXWG/ kyVJRDC7dQ/o8Y3NalY76QQYISYF4hoWF3MdG2m3rGWSOiqsVLMX0UhHCv1e5hOT8i b8e9MHRHMOZvrAvxJWN1c//ITSpKtNeb6aPIjpV9TuYKGGOj0hk2xgITBPzLZajai+ cXzpBNJxLiGA0HZmD1R4dp9kPjxikCF3NApqZufNziyciEnU+c2vl+BA4blJGlxHdl yssYuxVpbQowQ== To: maximedevos@telenet.be, ludo@gnu.org Subject: [PATCH V3] gnu : nicotine+: Update to 3.2.1. Date: Mon, 14 Mar 2022 00:41:24 +0900 Message-Id: <20220313154124.18317-1-fatimatoothpaste@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54273 Cc: 54273@debbugs.gnu.org, Fatima Toothpaste X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1. [source]: Delete network requried tests in snippet. [arguments]: Remove trailing #t. Replae 'check phase to run proper test. [inputs]: Add bash-minimal, gspell, libappindicator. [native-inputs]: Remove python-pytest. Add xvfb-run. [home-page]: Update URL. --- gnu/packages/nicotine.scm | 31 ++++++++++++++++++++----------- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/gnu/packages/nicotine.scm b/gnu/packages/nicotine.scm index 8e194697de..d46c5603f3 100644 --- a/gnu/packages/nicotine.scm +++ b/gnu/packages/nicotine.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2020 Martin Becze +;;; Copyright © 2022 Fatima Toothpaste ;;; ;;; This file is part of GNU Guix. ;;; @@ -21,23 +22,29 @@ (define-module (gnu packages nicotine) #:use-module (guix packages) #:use-module (guix git-download) #:use-module (guix build-system python) + #:use-module (gnu packages bash) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) #:use-module (gnu packages gettext) #:use-module (gnu packages gtk) - #:use-module (gnu packages check) - #:use-module (gnu packages mp3)) + #:use-module (gnu packages mp3) + #:use-module (gnu packages xorg)) (define-public nicotine+ (package (name "nicotine+") - (version "2.1.2") + (version "3.2.1") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/Nicotine-Plus/nicotine-plus") (commit version))) (file-name (git-file-name name version)) - (sha256 (base32 "18rra8yqjr10z23chzcp53ncbd5fhm0iqgqxpbxfq7a10za02v6l")))) + (sha256 (base32 "1x08z5lvkdl62dkc11vrsackgzsh1vr9vp3vgsgfzjyrvlsybmfw")) + (modules '((guix build utils))) + (snippet '(begin + (delete-file-recursively "test/integration"))))) (build-system python-build-system) (arguments `(#:imported-modules ((guix build glib-or-gtk-build-system) @@ -55,18 +62,20 @@ (define-public nicotine+ "/bin/nicotine")) (gi-typelib-path (getenv "GI_TYPELIB_PATH"))) (wrap-program prog - `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))) - #t))) + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))) (add-after 'wrap-program 'glib-or-gtk-wrap (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) (add-after 'glib-or-gtk-wrap 'glib-or-gtk-compile-schemas - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas))))) + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas)) + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (invoke "xvfb-run" "python" "-m" "unittest"))))))) (inputs - (list gtk+ python-pygobject python-pytaglib)) + (list bash-minimal gspell gtk+ python-pygobject libappindicator python-pytaglib)) (native-inputs - `(("python-pytest" ,python-pytest) - ("gettext" ,gettext-minimal))) - (home-page "https://nicotine-plus.github.io/nicotine-plus/") + (list gettext-minimal xvfb-run)) + (home-page "https://nicotine-plus.org/") (synopsis "Graphical client for Soulseek") (description "Nicotine+ is a graphical client for the Soulseek peer-to-peer -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 15 05:52:46 2022 Received: (at 54273-done) by debbugs.gnu.org; 15 Mar 2022 09:52:46 +0000 Received: from localhost ([127.0.0.1]:47594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nU3rB-0008VR-QD for submit@debbugs.gnu.org; Tue, 15 Mar 2022 05:52:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nU3r9-0008VB-4K for 54273-done@debbugs.gnu.org; Tue, 15 Mar 2022 05:52:44 -0400 Received: from [2001:470:142:3::e] (port=33406 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU3r2-0007vt-Lk; Tue, 15 Mar 2022 05:52:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=1zHnCS4Y41leuqVnvGUSV9z6C6xh7f9bd6phmr9tyME=; b=AQDlZtG1UuR0Fl2Y9uA4 gUu7hr1hTe/8TdHDfEjrGiG/JNvoJsMWVTHoJRUzMYSyh1tH9DpQVUWq/Cg07UArJ1YCksuzntyE8 kRiW99sVntLtbWIM++2ZoqkN6hON2HeQNMtUMg0BAwAoRl0fZ35I8WwWRRRgFRgX9RoOurkUythz1 mi/pXMoXUuPIuipZeQm48EckVVfTmLuhCkTJN0LfQWa4idD/op61DKJPlraa8PBqoV96Hpz/Bjec8 ZZ4GlP7s2mFEFq3BT6LnmG+ugNg4M8bBP58QADcOiHlPF/c0NDOep6PvTiLYBz0iUIydC2nt9vtrH BTS+pstjEu3Mtg==; Received: from [193.50.110.182] (port=59362 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU3r2-0005H2-45; Tue, 15 Mar 2022 05:52:36 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Fatima Toothpaste Subject: Re: bug#54273: [PATCH] gnu: nicotine+: update to 3.2.1. References: <20220306054551.19383-1-fatimatoothpaste@disroot.org> <20220313154124.18317-1-fatimatoothpaste@disroot.org> Date: Tue, 15 Mar 2022 10:52:33 +0100 In-Reply-To: <20220313154124.18317-1-fatimatoothpaste@disroot.org> (Fatima Toothpaste's message of "Mon, 14 Mar 2022 00:41:24 +0900") Message-ID: <87zglrlezi.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54273-done Cc: maximedevos@telenet.be, 54273-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Fatima Toothpaste skribis: > * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1. > [source]: Delete network requried tests in snippet. > [arguments]: Remove trailing #t. > Replae 'check phase to run proper test. > [inputs]: Add bash-minimal, gspell, libappindicator. > [native-inputs]: Remove python-pytest. Add xvfb-run. > [home-page]: Update URL. [...] > + (snippet '(begin > + (delete-file-recursively "test/integration")))= )) I added a comment above the snippet explaining it and applied. Thanks, Ludo=E2=80=99. From unknown Sat Jun 21 10:37:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 12 Apr 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator