From unknown Fri Jun 20 07:15:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54263 <54263@debbugs.gnu.org> To: bug#54263 <54263@debbugs.gnu.org> Subject: Status: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications Reply-To: bug#54263 <54263@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:15:41 +0000 retitle 54263 29.0.50; color-values-from-color-spec accepts whitespace in r= gbi: specifications reassign 54263 emacs submitter 54263 Philip Kaludercic severity 54263 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 12:05:22 2022 Received: (at submit) by debbugs.gnu.org; 5 Mar 2022 17:05:22 +0000 Received: from localhost ([127.0.0.1]:48950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQXqL-0000ib-Ua for submit@debbugs.gnu.org; Sat, 05 Mar 2022 12:05:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:58952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQXqJ-0000iT-PY for submit@debbugs.gnu.org; Sat, 05 Mar 2022 12:05:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQXqJ-0000oB-0f for bug-gnu-emacs@gnu.org; Sat, 05 Mar 2022 12:05:19 -0500 Received: from mout02.posteo.de ([185.67.36.66]:51939) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQXqF-0003ih-RE for bug-gnu-emacs@gnu.org; Sat, 05 Mar 2022 12:05:18 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 863D9240103 for ; Sat, 5 Mar 2022 18:05:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1646499909; bh=su5NJqo3XS7eCjFlq3qVpzbuzrORJc1Hd+4neLEMKQg=; h=From:To:Subject:Autocrypt:Date:From; b=h8i8QBCjOG0Fhj0+6UEZai1UFDLUAdROdsje8kukFMKCCKjRuM/OWZgJTvPWntlQW KT07/igi96Wy6gBJAa1f4qL1h8HoVsUrRdf3uUHQP32Y35nh4T9uuqf9NOglMCAGnY z59iWl8lqLNfbElZHTbMzAMCfg3/Y15sRjRa4G2qDzdTKfnHNqfFA8PMEY/CLtP3IK LZr+tuPXz3HIGtpBL4AY/T3uWLbXfwUarLrgbJo1UrnkWJyXOJhZeiQupTpACNsv/i D5LTvGGWfWRLQZieUxjrqcpiNIE49v9GpLXLSzIslrhA1DDkymsS0GgHbvm1JYLOxe 7bQrI1vJ1vbPQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4K9rgl2w1Mz9rxP for ; Sat, 5 Mar 2022 18:05:07 +0100 (CET) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Sat, 05 Mar 2022 17:05:04 +0000 Message-ID: <87v8wswcsf.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I am not certain if this is intended, but the "rgbi:" specifications appear to tolerate whitespace (color-values-from-color-spec "rgbi:0/0/ 0") despite not being documented. From what I see, the issue stems from parse_float_color_comp calling strtod, where strtod(3) says: The expected form of the (initial portion of the) string is op=E2= =80=90 tional leading white space as recognized by isspace(3) [...] If this is considered to be an issue (I'd argue that relying a detail of this kind in the libc could lead to problem), something like this could solve the issue: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/src/xfaces.c b/src/xfaces.c index cf155288bd..308509a026 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -220,6 +220,7 @@ Copyright (C) 1993-1994, 1998-2020 Free Software Foundation, Inc. #include "sysstdio.h" #include #include +#include #include "lisp.h" #include "character.h" @@ -819,6 +820,120 @@ load_pixmap (struct frame *f, Lisp_Object name) Color Handling ***********************************************************************/ +/* Parse hex color component at S ending right before E. + Set *DST to the value normalized so that the maximum for the + number of digits given becomes 65535, and return true on success, + false otherwise. */ +static bool +parse_hex_color_comp (const char *s, const char *e, unsigned short *dst) +{ + int n = e - s; + if (n <= 0 || n > 4) + return false; + int val = 0; + for (; s < e; s++) + { + int digit; + if (*s >= '0' && *s <= '9') + digit = *s - '0'; + else if (*s >= 'A' && *s <= 'F') + digit = *s - 'A' + 10; + else if (*s >= 'a' && *s <= 'f') + digit = *s - 'a' + 10; + else + return false; + val = (val << 4) | digit; + } + int maxval = (1 << (n * 4)) - 1; + *dst = (unsigned)val * 65535 / maxval; + return true; +} + +/* Parse floating-point color component at S ending right before E. + Return the number if in the range [0,1]; otherwise -1. */ +static double +parse_float_color_comp (const char *s, const char *e) +{ + char *end; + double x = strtod (s, &end); + return (end == e && x >= 0 && x <= 1) ? x : -1; +} + +/* Parse S as a numeric color specification and set *R, *G and *B. + Return true on success, false on failure. + Recognized formats: + + "#RGB", with R, G and B hex strings of equal length, 1-4 digits each + "rgb:R/G/B", with R, G and B hex strings, 1-4 digits each + "rgbi:R/G/B", with R, G and B numbers in [0,1] + + The result is normalized to a maximum value of 65535 per component. */ +bool +parse_color_spec (const char *s, + unsigned short *r, unsigned short *g, unsigned short *b) +{ + int len = strlen (s); + if (s[0] == '#') + { + if ((len - 1) % 3 == 0) + { + int n = (len - 1) / 3; + return ( parse_hex_color_comp (s + 1 + 0 * n, s + 1 + 1 * n, r) + && parse_hex_color_comp (s + 1 + 1 * n, s + 1 + 2 * n, g) + && parse_hex_color_comp (s + 1 + 2 * n, s + 1 + 3 * n, b)); + } + } + else if (strncmp (s, "rgb:", 4) == 0) + { + char *sep1, *sep2; + return ((sep1 = strchr (s + 4, '/')) != NULL + && (sep2 = strchr (sep1 + 1, '/')) != NULL + && parse_hex_color_comp (s + 4, sep1, r) + && parse_hex_color_comp (sep1 + 1, sep2, g) + && parse_hex_color_comp (sep2 + 1, s + len, b)); + } + else if (strncmp (s, "rgbi:", 5) == 0) + { + char *sep1, *sep2; + double red, green, blue; + if ((sep1 = strchr (s + 5, '/')) != NULL + && (sep2 = strchr (sep1 + 1, '/')) != NULL + && (red = parse_float_color_comp (s + 5, sep1)) >= 0 + && (green = parse_float_color_comp (sep1 + 1, sep2)) >= 0 + && (blue = parse_float_color_comp (sep2 + 1, s + len)) >= 0) + { + *r = lrint (red * 65535); + *g = lrint (green * 65535); + *b = lrint (blue * 65535); + return true; + } + } + return false; +} + +DEFUN ("internal-color-values-from-color-spec", + Finternal_color_values_from_color_spec, + Sinternal_color_values_from_color_spec, + 1, 1, 0, + doc: /* Parse STRING as a numeric color and return (RED GREEN BLUE). +Recognised formats for STRING are: + + #RGB, where R, G and B are hex numbers of equal length, 1-4 digits each + rgb:R/G/B, where R, G, and B are hex numbers, 1-4 digits each + rgbi:R/G/B, where R, G and B are floating-point numbers in [0,1] + +The result is normalized to a maximum value of 65535 per component, +forming a list of three integers in [0,65535]. +If STRING is not in one of the above forms, return nil. */) + (Lisp_Object string) +{ + CHECK_STRING (string); + unsigned short r, g, b; + return (parse_color_spec (SSDATA (string), &r, &g, &b) + ? list3i (r, g, b) + : Qnil); +} + /* Parse RGB_LIST, and fill in the RGB fields of COLOR. RGB_LIST should contain (at least) 3 lisp integers. Return true iff RGB_LIST is OK. */ @@ -7018,4 +7133,5 @@ syms_of_xfaces (void) defsubr (&Sinternal_face_x_get_resource); defsubr (&Sx_family_fonts); #endif + defsubr (&Sinternal_color_values_from_color_spec); } --=-=-= Content-Type: text/plain In GNU Emacs 29.0.50 (build 13, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0) of 2022-02-24 built on viero Repository revision: bd17fa2c7565f180cedbfa396c0b159e144178cb Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $EMACSLOADPATH: value of $LANG: en_US.utf8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: TeX-PDF-mode: t rcirc-track-minor-mode: t global-git-commit-mode: t magit-auto-revert-mode: t auto-revert-mode: t shell-dirtrack-mode: t outline-minor-mode: t corfu-mode: t flymake-mode: t flyspell-mode: t recentf-mode: t repeat-mode: t display-battery-mode: t display-time-mode: t diff-hl-flydiff-mode: t diff-hl-mode: t winner-mode: t windmove-mode: t electric-pair-mode: t save-place-mode: t savehist-mode: t xterm-mouse-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t line-number-mode: t transient-mark-mode: t auto-save-visited-mode: t Load-path shadows: /home/philip/Source/sp-tutor/sp-tutor hides /home/philip/.config/emacs/site-lisp/sp-tutor/sp-tutor /home/philip/Source/sp-tutor/waffel hides /home/philip/.config/emacs/site-lisp/sp-tutor/waffel /home/philip/.config/emacs/elpa/transient-0.3.7/transient hides /home/philip/Source/emacs/lisp/transient ~/.config/emacs/site-lisp/autoload hides /home/philip/Source/emacs/lisp/emacs-lisp/autoload Features: (shadow emacsbug pcmpl-unix reposition tabify man preview tex-buf tex-fold reftex-dcr reftex-auc reftex reftex-loaddefs reftex-vars font-latex latex latex-flymake tex-ispell tex-style tex texmathp tex-mode latexenc cl-print slime-tests ert debug backtrace slime gud apropos arc-mode archive-mode hyperspec cl compat-macs org-element avl-tree ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex ol org-keys oc org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs goto-addr shortdoc avy ffap grep mm-archive url-http url-gw url-cache url-auth cus-edit finder-inf autoconf autoconf-mode whitespace geiser-mode geiser-xref geiser-guile info-look geiser geiser-repl geiser-compile geiser-debug geiser-image geiser-company geiser-doc geiser-menu geiser-edit etags fileloop generator geiser-completion geiser-autodoc advice geiser-eval geiser-connection tq geiser-syntax geiser-log geiser-popup view scheme modus-vivendi-theme markdown-mode ibuffer ibuffer-loaddefs rcirc find-dired shell-command+ doc-view jka-compr image-mode exif pulse color find-func xref wdired flymake-cc cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs make-mode char-fold misearch multi-isearch dired-aux gnus-dired pp vc-mtn vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs bug-reference magit-ediff ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util magit-extras mule-util magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode git-commit log-edit add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor shell pcomplete server magit-mode transient edmacro kmacro magit-git magit-section benchmark magit-utils crm dash cus-start mailalias smtpmail autocrypt-message ecomplete sort smiley gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-bcklg qp copyright vc-backup log-view pcvs-util vc-fossil time-stamp gnus-async gnus-ml autocrypt-gnus autocrypt nndraft nnmh utf-7 nnfolder epa-file gnutls network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig nntp gnus-cache gnus-sum shr pixel-fill kinsoku url-file url-dired svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601 gnus-spec gnus-int gnus-range message yank-media rmc puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win cl-extra noutline outline corfu checkdoc flymake-proc flymake project warnings thingatpt flyspell ispell auth-source-pass recentf tree-widget repeat pcase format-spec battery dbus xml dired-x dired dired-loaddefs time sendmail rfc2047 rfc2045 ietf-drums gnus nnheader gnus-util time-date mail-utils range mm-util mail-prsvr wid-edit help-at-pt diff-hl-flydiff diff diff-hl face-remap vc-hg vc-git vc-dir ewoc vc vc-dispatcher diff-mode easy-mmode hippie-exp winner windmove rx elec-pair saveplace savehist xt-mouse modus-operandi-theme modus-themes rot13 disp-table cus-load setup compile text-property-search comint ansi-color autoload lisp-mnt tex-site geiser-impl help-fns radix-tree help-mode geiser-custom geiser-base ring slime-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1276046 170560) (symbols 48 52054 48) (strings 32 214741 20363) (string-bytes 1 6381398) (vectors 16 115056) (vector-slots 8 2265569 122894) (floats 8 774 827) (intervals 56 36636 4853) (buffers 992 113)) -- Philip Kaludercic --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 14:06:42 2022 Received: (at 54263) by debbugs.gnu.org; 5 Mar 2022 19:06:42 +0000 Received: from localhost ([127.0.0.1]:49090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQZjl-0008BL-Kb for submit@debbugs.gnu.org; Sat, 05 Mar 2022 14:06:41 -0500 Received: from quimby.gnus.org ([95.216.78.240]:36494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQZjj-0008BA-PG for 54263@debbugs.gnu.org; Sat, 05 Mar 2022 14:06:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AFKeTxkcF2praOne5sgpU4SfKNB38FXZkP/0imDJR28=; b=eJE/pVA97WfG6tbKwO1uQjkxdv 4fN1Y+Dfv4J/qnm2ttggBqucrJdTL0FkzER8RT5s+goepBQ+UiEFIUdlRs++7RRuRi7AWRPZFJE3B QcEUsqEJ5YCk2EZrnr56p10r7JijEVv/mr814DyJ64+JwIXxEUs/wwZyS6rtN+gzUGDI=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQZjb-0004Bw-8o; Sat, 05 Mar 2022 20:06:33 +0100 From: Lars Ingebrigtsen To: Philip Kaludercic Subject: Re: bug#54263: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications References: <87v8wswcsf.fsf@posteo.net> X-Now-Playing: Peter Gabriel's _Peter Gabriel 4_: "Wallflower" Date: Sat, 05 Mar 2022 20:06:29 +0100 In-Reply-To: <87v8wswcsf.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 05 Mar 2022 17:05:04 +0000") Message-ID: <87fsnwfccq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philip Kaludercic writes: > I am not certain if this is intended, but the "rgbi:" specifications > appear to tolerate whitespace > > (color-values-from-color-spec "rgbi:0/0/ 0") > > despite not being documented. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54263 Cc: 54263@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philip Kaludercic writes: > I am not certain if this is intended, but the "rgbi:" specifications > appear to tolerate whitespace > > (color-values-from-color-spec "rgbi:0/0/ 0") > > despite not being documented. If we were designing this function now, then being stricter here would be a good idea. But if there's code out there that relies on the current sloppy parsing, then it'd be problematic to make it stricter. On the other hand, I think that function was introduced in emacs-28, so perhaps that's not a concern in practice? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 15:28:55 2022 Received: (at 54263) by debbugs.gnu.org; 5 Mar 2022 20:28:56 +0000 Received: from localhost ([127.0.0.1]:49147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQb1L-000656-Nh for submit@debbugs.gnu.org; Sat, 05 Mar 2022 15:28:55 -0500 Received: from mout01.posteo.de ([185.67.36.65]:55853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQb1G-00064o-Vr for 54263@debbugs.gnu.org; Sat, 05 Mar 2022 15:28:53 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 29F38240026 for <54263@debbugs.gnu.org>; Sat, 5 Mar 2022 21:28:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1646512125; bh=LSqzSj1D7mY75t95S8qIULde34C7g7wzCqfzUuYZ/9M=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=VcWkLwErhDSqaWtvcirlHBoQYQsPsfSO583pv5ws6ayCmn/8z+0yMv2vvcEL3DbnG i5uIfZCh6hCopFyG+ayr0D8eOZOewrgL5I40N9NR9Ntmnbqy3T+pQr8/Z8EicssRu6 nqH5u+dyqQMisyAM2nJqsMTEzyugIxcWHeIHtGGDSm2sSs+kbFTapOnC1Jc52WIa5T 49D/LxABUmhTcSyVWsjLa+lnvXdCdjkNT+gN4hhgoBsSIJ5FJt9rG7ho9a3iqpInCc OTNWW5h3alPuGPZ7YX/UWNgJhGznnF+b+swVBjWGP5SFXTxUQxyyvLNu4zk/J/o7Bh 7VcGP01RwTZCw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4K9xBh1l84z6tm9; Sat, 5 Mar 2022 21:28:43 +0100 (CET) From: Philip Kaludercic To: Lars Ingebrigtsen Subject: Re: bug#54263: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications References: <87v8wswcsf.fsf@posteo.net> <87fsnwfccq.fsf@gnus.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Sat, 05 Mar 2022 20:28:32 +0000 In-Reply-To: <87fsnwfccq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 05 Mar 2022 20:06:29 +0100") Message-ID: <87tucccff3.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54263 Cc: 54263@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >> I am not certain if this is intended, but the "rgbi:" specifications >> appear to tolerate whitespace >> >> (color-values-from-color-spec "rgbi:0/0/ 0") >> >> despite not being documented. > > If we were designing this function now, then being stricter here would > be a good idea. But if there's code out there that relies on the > current sloppy parsing, then it'd be problematic to make it stricter. > > On the other hand, I think that function was introduced in emacs-28, so > perhaps that's not a concern in practice? I haven't seen the function being used anywhere up until now (which doesn't have to mean anything), but considering that this is a relatively niche edge-case I would say that the bug should either be solved now or never. -- Philip Kaludercic From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 06 04:56:39 2022 Received: (at 54263) by debbugs.gnu.org; 6 Mar 2022 09:56:39 +0000 Received: from localhost ([127.0.0.1]:49863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQnd1-0008ES-7B for submit@debbugs.gnu.org; Sun, 06 Mar 2022 04:56:39 -0500 Received: from mail1465c50.megamailservers.eu ([91.136.14.65]:40432 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQncy-0008EA-DC for 54263@debbugs.gnu.org; Sun, 06 Mar 2022 04:56:37 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1646560589; bh=7XZRqvzqUz1IDIOS3mn6fpg+b8k019t0YXVhkPVTra4=; h=From:Subject:Date:Cc:To:From; b=eHu2CfNY7PyHibMoULgP4tI+xt7fd0WqjiSVGAb4OC/h2HLOQKuovh66Z/QmfR230 ofd0yHYrNQ8q5b9h/eYr+eqYtWCyFW3jyGkqLtYyY5Ed8t54ifLJFLDXuKpXfNrJtv 3f+Gfqb63wIMnP4S1Sx5SPBMrCLimB3sEwHfTkDU= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 2269uQB4016368; Sun, 6 Mar 2022 09:56:28 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_BDB30E55-DDE5-4420-BF27-1BBBAC88435D" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: bug#54263: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications Message-Id: Date: Sun, 6 Mar 2022 10:56:26 +0100 To: Philip Kaludercic X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F18.6224854D.000F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > I haven't seen the function being used anywhere up until now (which doesn't have to mean anything), but considering that this is a relatively niche edge-case I would say that the bug should either b [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 54263 Cc: 54263@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_BDB30E55-DDE5-4420-BF27-1BBBAC88435D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > I haven't seen the function being used anywhere up until now (which = doesn't have to mean anything), but considering that this is a = relatively niche edge-case I would say that the bug should either be = solved now or never.=20 Let's solve it now then. I'm to blame, patch attached. --Apple-Mail=_BDB30E55-DDE5-4420-BF27-1BBBAC88435D Content-Disposition: attachment; filename=0001-Don-t-accept-leading-whitespace-in-rgbi-colour-specs.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Don-t-accept-leading-whitespace-in-rgbi-colour-specs.patch" Content-Transfer-Encoding: quoted-printable =46rom=200433c23ce12ea24bcb4de93b92b92070cf257310=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=206=20Mar=202022=2010:50:27=20+0100=0A= Subject:=20[PATCH]=20Don't=20accept=20leading=20whitespace=20in=20rgbi:=20= colour=20specs=0A=0A`color-values-from-color-spec`=20(new=20in=20Emacs=20= 28)=20erroneously=20accepted=0Aleading=20whitespace=20in=20rgbi:=20= components.=0A=0AReported=20by=20Philip=20Kaludercic.=0A=0A*=20= src/xfaces.c=20(parse_float_color_comp):=20Disallow=20leading=20= whitespace.=0A*=20test/src/xfaces-tests.el=0A= (xfaces-internal-color-values-from-color-spec):=20Add=20test=20case.=0A= ---=0A=20src/xfaces.c=20=20=20=20=20=20=20=20=20=20=20=20=20|=204=20++++=0A= =20test/src/xfaces-tests.el=20|=203=20++-=0A=202=20files=20changed,=206=20= insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20a/src/xfaces.c=20= b/src/xfaces.c=0Aindex=208100bdb157..7fbc667dfd=20100644=0A---=20= a/src/xfaces.c=0A+++=20b/src/xfaces.c=0A@@=20-888,6=20+888,10=20@@=20= parse_hex_color_comp=20(const=20char=20*s,=20const=20char=20*e,=20= unsigned=20short=20*dst)=0A=20static=20double=0A=20= parse_float_color_comp=20(const=20char=20*s,=20const=20char=20*e)=0A=20{=0A= +=20=20if=20(s=20>=3D=20e=20||=0A+=20=20=20=20=20=20!(*s=20=3D=3D=20'0'=20= ||=20*s=20=3D=3D=20'1'=20||=20*s=20=3D=3D=20'.'=20||=20*s=20=3D=3D=20'+'=20= ||=20*s=20=3D=3D=20'-'))=0A+=20=20=20=20/*=20No=20leading=20whitespace=20= permitted.=20=20*/=0A+=20=20=20=20return=20-1;=0A=20=20=20char=20*end;=0A= =20=20=20double=20x=20=3D=20strtod=20(s,=20&end);=0A=20=20=20return=20= (end=20=3D=3D=20e=20&&=20x=20>=3D=200=20&&=20x=20<=3D=201)=20?=20x=20:=20= -1;=0Adiff=20--git=20a/test/src/xfaces-tests.el=20= b/test/src/xfaces-tests.el=0Aindex=2031c0f021b2..1175874144=20100644=0A= ---=20a/test/src/xfaces-tests.el=0A+++=20b/test/src/xfaces-tests.el=0A@@=20= -47,7=20+47,8=20@@=20xfaces-internal-color-values-from-color-spec=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20'(0=2032768=206554)))=0A=20= =20=20(should=20(equal=20(color-values-from-color-spec=20= "rgbi:1e-3/1.0e-2/1e0")=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20'(66=20655=2065535)))=0A-=20=20(should=20(equal=20= (color-values-from-color-spec=20"rgbi:0/0.5/10")=20nil)))=0A+=20=20= (should=20(equal=20(color-values-from-color-spec=20"rgbi:0/0.5/10")=20= nil))=0A+=20=20(should=20(equal=20(color-values-from-color-spec=20= "rgbi:0/0/=200")=20nil)))=0A=20=0A=20(provide=20'xfaces-tests)=0A=20=0A= --=20=0A2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_BDB30E55-DDE5-4420-BF27-1BBBAC88435D-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 06 05:45:54 2022 Received: (at 54263) by debbugs.gnu.org; 6 Mar 2022 10:45:54 +0000 Received: from localhost ([127.0.0.1]:49946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQoOg-00012v-3a for submit@debbugs.gnu.org; Sun, 06 Mar 2022 05:45:54 -0500 Received: from mout02.posteo.de ([185.67.36.66]:46257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQoOe-00012g-66 for 54263@debbugs.gnu.org; Sun, 06 Mar 2022 05:45:53 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 992F3240105 for <54263@debbugs.gnu.org>; Sun, 6 Mar 2022 11:45:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1646563545; bh=H/iK+14S5n5e3TuhyJPIvQ0DmvOcyWG0yTdMImHSSF0=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=HX4w/9x6sxegvecAvwE5kiVFzyc+CleVDk4vodx/slzjyvUQK+uhfp2YtTcUyeA6c Q3Nkb+3WkQJFW/gcVBxE3oMK/9X/rUwRnfFAX5pskCjL7GqwZMF63Fp0GMdVTfVrNN h/MOIx+yUJjumSloBVW2aelpmLyzJ7wbc2eHjzvU8tIm3EF5rqLe+JpKrV5KtjZtW4 F+I7wqU5KKoD6rF1sJSfbiU0RFoCIr7OIS50T0ID8wjefAmNHM7Gpfu8YJmIaUDuIy j7MXKxq0BuRqPNX+YvuE4VqajjUzNOS0sg7JJUsxZRhMROIdjFFR/FLqv+5/T7OFnp JO3lmkNrxf73w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4KBJCX5M8Lz9rxb; Sun, 6 Mar 2022 11:45:44 +0100 (CET) From: Philip Kaludercic To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#54263: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications References: Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Sun, 06 Mar 2022 10:45:44 +0000 In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sun, 6 Mar 2022 10:56:26 +0100") Message-ID: <875yore4vb.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54263 Cc: 54263@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: >> I haven't seen the function being used anywhere up until now (which > doesn't have to mean anything), but considering that this is a > relatively niche edge-case I would say that the bug should either be > solved now or never. > > Let's solve it now then. I'm to blame, patch attached. A related question is if something like (should (equal (color-values-from-color-spec "rgbi:0/0/0x0") nil)) should be accepted or not. From looking at xfaces-tests.el I was surprised to see that the exponential notation was intentional, but there was no comment or test on the un-lispy 0x... notation that strtod allows. > From 0433c23ce12ea24bcb4de93b92b92070cf257310 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D > Date: Sun, 6 Mar 2022 10:50:27 +0100 > Subject: [PATCH] Don't accept leading whitespace in rgbi: colour specs > > `color-values-from-color-spec` (new in Emacs 28) erroneously accepted > leading whitespace in rgbi: components. > > Reported by Philip Kaludercic. > > * src/xfaces.c (parse_float_color_comp): Disallow leading whitespace. > * test/src/xfaces-tests.el > (xfaces-internal-color-values-from-color-spec): Add test case. > --- > src/xfaces.c | 4 ++++ > test/src/xfaces-tests.el | 3 ++- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/xfaces.c b/src/xfaces.c > index 8100bdb157..7fbc667dfd 100644 > --- a/src/xfaces.c > +++ b/src/xfaces.c > @@ -888,6 +888,10 @@ parse_hex_color_comp (const char *s, const char *e, = unsigned short *dst) > static double > parse_float_color_comp (const char *s, const char *e) > { > + if (s >=3D e || > + !(*s =3D=3D '0' || *s =3D=3D '1' || *s =3D=3D '.' || *s =3D=3D '+'= || *s =3D=3D '-')) > + /* No leading whitespace permitted. */ > + return -1; > char *end; > double x =3D strtod (s, &end); > return (end =3D=3D e && x >=3D 0 && x <=3D 1) ? x : -1; > diff --git a/test/src/xfaces-tests.el b/test/src/xfaces-tests.el > index 31c0f021b2..1175874144 100644 > --- a/test/src/xfaces-tests.el > +++ b/test/src/xfaces-tests.el > @@ -47,7 +47,8 @@ xfaces-internal-color-values-from-color-spec > '(0 32768 6554))) > (should (equal (color-values-from-color-spec "rgbi:1e-3/1.0e-2/1e0") > '(66 655 65535))) > - (should (equal (color-values-from-color-spec "rgbi:0/0.5/10") nil))) > + (should (equal (color-values-from-color-spec "rgbi:0/0.5/10") nil)) > + (should (equal (color-values-from-color-spec "rgbi:0/0/ 0") nil))) >=20=20 > (provide 'xfaces-tests) --=20 Philip Kaludercic From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 06 06:12:19 2022 Received: (at 54263) by debbugs.gnu.org; 6 Mar 2022 11:12:19 +0000 Received: from localhost ([127.0.0.1]:49959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQooE-0001jZ-Nt for submit@debbugs.gnu.org; Sun, 06 Mar 2022 06:12:18 -0500 Received: from mail204c50.megamailservers.eu ([91.136.10.214]:33776 helo=mail193c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQooC-0001jO-08 for 54263@debbugs.gnu.org; Sun, 06 Mar 2022 06:12:17 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1646565133; bh=8Fe8lZ2wJMrLSTBRjQ3Vr6BxjSdFtIhiu7SfDFurEbo=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=m/t0Ds3wLBo1MpxR6RpMAIj1fNNVNuwoIGGnlHkrGGOXxT18FD67JzEfj/xwYErou PHt/Q+9wnAnX044xp2vNOEGmJl4ewdMbs10U/TMyU0QFjNnijTGpKS6O5rRddSN3Y0 wj2foTDASaw09F/Xb/IlqL2DjZ4GUAC1uivWKsUQ= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail193c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 226BC9ou031566; Sun, 6 Mar 2022 11:12:12 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: <832485F0-60AE-48E6-B163-0DF031F31028@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_9A4EBC03-2F79-4A76-B6A0-662EF583C3A5" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#54263: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications Date: Sun, 6 Mar 2022 12:12:08 +0100 In-Reply-To: <875yore4vb.fsf@posteo.net> To: Philip Kaludercic References: <875yore4vb.fsf@posteo.net> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F1D.6224970D.0023, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 54263 Cc: 54263@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_9A4EBC03-2F79-4A76-B6A0-662EF583C3A5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 6 mars 2022 kl. 11.45 skrev Philip Kaludercic : > (should (equal (color-values-from-color-spec "rgbi:0/0/0x0") nil)) >=20 > should be accepted or not. =46rom looking at xfaces-tests.el I was > surprised to see that the exponential notation was intentional, but > there was no comment or test on the un-lispy 0x... notation that = strtod > allows. We could disallow hex floats (such as 0x1 or 0XDEFP-16) too, but whether = they are un-lispy or not should have no bearing on our decision because = we are parsing an external representation that doesn't come from the = Lisp world. Finding an authoritative source for the rgbi: format proved elusive but = it doesn't seem that X11 or NS allow hex floats so let's reject them. = New patch attached. --Apple-Mail=_9A4EBC03-2F79-4A76-B6A0-662EF583C3A5 Content-Disposition: attachment; filename=0001-Don-t-accept-whitespace-or-hex-floats-in-rgbi-colour.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Don-t-accept-whitespace-or-hex-floats-in-rgbi-colour.patch" Content-Transfer-Encoding: quoted-printable =46rom=205356a4dd21e2d427cc3c17a0592b30f85b7af1db=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=206=20Mar=202022=2010:50:27=20+0100=0A= Subject:=20[PATCH]=20Don't=20accept=20whitespace=20or=20hex=20floats=20= in=20rgbi:=20colour=20specs=0A=0A`color-values-from-color-spec`=20(new=20= in=20Emacs=2028)=20erroneously=20accepted=0Aleading=20whitespace=20and=20= hex=20floats=20in=20rgbi:=20components.=0A=0AReported=20by=20Philip=20= Kaludercic.=0A=0A*=20src/xfaces.c=20(parse_float_color_comp):=20Disallow=20= leading=20whitespace=0Aand=20hex=20floats.=0A*=20= test/src/xfaces-tests.el=0A= (xfaces-internal-color-values-from-color-spec):=20Add=20test=20cases.=0A= ---=0A=20src/xfaces.c=20=20=20=20=20=20=20=20=20=20=20=20=20|=205=20= +++++=0A=20test/src/xfaces-tests.el=20|=204=20+++-=0A=202=20files=20= changed,=208=20insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/src/xfaces.c=20b/src/xfaces.c=0Aindex=208100bdb157..d43e2936a9=20= 100644=0A---=20a/src/xfaces.c=0A+++=20b/src/xfaces.c=0A@@=20-888,6=20= +888,11=20@@=20parse_hex_color_comp=20(const=20char=20*s,=20const=20char=20= *e,=20unsigned=20short=20*dst)=0A=20static=20double=0A=20= parse_float_color_comp=20(const=20char=20*s,=20const=20char=20*e)=0A=20{=0A= +=20=20if=20(s=20>=3D=20e=0A+=20=20=20=20=20=20||=20!(*s=20=3D=3D=20'0'=20= ||=20*s=20=3D=3D=20'1'=20||=20*s=20=3D=3D=20'.'=20||=20*s=20=3D=3D=20'+'=20= ||=20*s=20=3D=3D=20'-')=0A+=20=20=20=20=20=20||=20(s=20+=201=20<=20e=20= &&=20(s[1]=20=3D=3D=20'x'=20||=20s[1]=20=3D=3D=20'X')))=0A+=20=20=20=20= /*=20No=20leading=20whitespace=20or=20hex=20floats=20permitted.=20=20*/=0A= +=20=20=20=20return=20-1;=0A=20=20=20char=20*end;=0A=20=20=20double=20x=20= =3D=20strtod=20(s,=20&end);=0A=20=20=20return=20(end=20=3D=3D=20e=20&&=20= x=20>=3D=200=20&&=20x=20<=3D=201)=20?=20x=20:=20-1;=0Adiff=20--git=20= a/test/src/xfaces-tests.el=20b/test/src/xfaces-tests.el=0Aindex=20= 31c0f021b2..fc0e731db4=20100644=0A---=20a/test/src/xfaces-tests.el=0A+++=20= b/test/src/xfaces-tests.el=0A@@=20-47,7=20+47,9=20@@=20= xfaces-internal-color-values-from-color-spec=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20'(0=2032768=206554)))=0A=20=20=20(should=20= (equal=20(color-values-from-color-spec=20"rgbi:1e-3/1.0e-2/1e0")=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20'(66=20655=2065535)))=0A= -=20=20(should=20(equal=20(color-values-from-color-spec=20= "rgbi:0/0.5/10")=20nil)))=0A+=20=20(should=20(equal=20= (color-values-from-color-spec=20"rgbi:0/0.5/10")=20nil))=0A+=20=20= (should=20(equal=20(color-values-from-color-spec=20"rgbi:0/0/=200")=20= nil))=0A+=20=20(should=20(equal=20(color-values-from-color-spec=20= "rgbi:0/0x0/0")=20nil)))=0A=20=0A=20(provide=20'xfaces-tests)=0A=20=0A--=20= =0A2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_9A4EBC03-2F79-4A76-B6A0-662EF583C3A5-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 06 06:24:11 2022 Received: (at 54263) by debbugs.gnu.org; 6 Mar 2022 11:24:11 +0000 Received: from localhost ([127.0.0.1]:49963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQozi-00023O-Sl for submit@debbugs.gnu.org; Sun, 06 Mar 2022 06:24:11 -0500 Received: from mail1439c50.megamailservers.eu ([91.136.14.39]:34700 helo=mail264c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQozg-00022s-DH for 54263@debbugs.gnu.org; Sun, 06 Mar 2022 06:24:09 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1646565828; bh=mom8yiFxAb37i+GFOcmk/j6zpyHKYKVWEbkp3sBIW6U=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=Z5Smu1GkdeIGbPP0BnslyZnC3y2vA5QjZIppSOUvtk9axhtkTtn/x+dd0AWw0KU7l 7RHOnhnAQWWXtBU1XU45BsI+QYmDfW9yS/1qDECmSugwbdieKPGDBFcO1XptU8p80y JyLz92Yzb40us8tvkNxQTnuWrowg/ddfDgWPQDEc= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 226BNkB7019320; Sun, 6 Mar 2022 11:23:47 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: <6E51015D-D59B-4120-8411-86F0909B4BDD@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_9369F558-96E4-4642-AE16-B08D2CBB4C9C" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#54263: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications Date: Sun, 6 Mar 2022 12:23:46 +0100 In-Reply-To: <832485F0-60AE-48E6-B163-0DF031F31028@acm.org> To: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= References: <875yore4vb.fsf@posteo.net> <832485F0-60AE-48E6-B163-0DF031F31028@acm.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F1F.622499C4.003C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The previous patch erroneously accepted "rgbi:0/+0x0/0". Here is one that doesn't try to be clever. Clear for emacs-28? Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 54263 Cc: 54263@debbugs.gnu.org, Philip Kaludercic , Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_9369F558-96E4-4642-AE16-B08D2CBB4C9C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii The previous patch erroneously accepted "rgbi:0/+0x0/0". Here is one = that doesn't try to be clever. Clear for emacs-28? --Apple-Mail=_9369F558-96E4-4642-AE16-B08D2CBB4C9C Content-Disposition: attachment; filename=0001-Don-t-accept-whitespace-or-hex-floats-in-rgbi-colour.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Don-t-accept-whitespace-or-hex-floats-in-rgbi-colour.patch" Content-Transfer-Encoding: quoted-printable =46rom=20e7bc68ae2f8e78278280a11d0392f52226f50449=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=206=20Mar=202022=2010:50:27=20+0100=0A= Subject:=20[PATCH]=20Don't=20accept=20whitespace=20or=20hex=20floats=20= in=20rgbi:=20colour=20specs=0A=0A`color-values-from-color-spec`=20(new=20= in=20Emacs=2028)=20erroneously=20accepted=0Aleading=20whitespace=20and=20= hex=20floats=20in=20rgbi:=20components.=0A=0AReported=20by=20Philip=20= Kaludercic.=0A=0A*=20src/xfaces.c=20(parse_float_color_comp):=20Disallow=20= leading=20whitespace=0Aand=20hex=20floats.=0A*=20= test/src/xfaces-tests.el=0A= (xfaces-internal-color-values-from-color-spec):=20Add=20test=20cases.=0A= ---=0A=20src/xfaces.c=20=20=20=20=20=20=20=20=20=20=20=20=20|=205=20= +++++=0A=20test/src/xfaces-tests.el=20|=205=20++++-=0A=202=20files=20= changed,=209=20insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/src/xfaces.c=20b/src/xfaces.c=0Aindex=208100bdb157..1d2e2489de=20= 100644=0A---=20a/src/xfaces.c=0A+++=20b/src/xfaces.c=0A@@=20-888,6=20= +888,11=20@@=20parse_hex_color_comp=20(const=20char=20*s,=20const=20char=20= *e,=20unsigned=20short=20*dst)=0A=20static=20double=0A=20= parse_float_color_comp=20(const=20char=20*s,=20const=20char=20*e)=0A=20{=0A= +=20=20/*=20Only=20allow=20decimal=20float=20literals=20without=20= whitespace.=20=20*/=0A+=20=20for=20(const=20char=20*p=20=3D=20s;=20p=20<=20= e;=20p++)=0A+=20=20=20=20if=20(!((*p=20>=3D=20'0'=20&&=20*p=20<=3D=20= '9')=0A+=09=20=20||=20*p=20=3D=3D=20'.'=20||=20*p=20=3D=3D=20'+'=20||=20= *p=20=3D=3D=20'-'=20||=20*p=20=3D=3D=20'e'=20||=20*p=20=3D=3D=20'E'))=0A= +=20=20=20=20=20=20return=20-1;=0A=20=20=20char=20*end;=0A=20=20=20= double=20x=20=3D=20strtod=20(s,=20&end);=0A=20=20=20return=20(end=20=3D=3D= =20e=20&&=20x=20>=3D=200=20&&=20x=20<=3D=201)=20?=20x=20:=20-1;=0Adiff=20= --git=20a/test/src/xfaces-tests.el=20b/test/src/xfaces-tests.el=0Aindex=20= 31c0f021b2..16f1653791=20100644=0A---=20a/test/src/xfaces-tests.el=0A+++=20= b/test/src/xfaces-tests.el=0A@@=20-47,7=20+47,10=20@@=20= xfaces-internal-color-values-from-color-spec=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20'(0=2032768=206554)))=0A=20=20=20(should=20= (equal=20(color-values-from-color-spec=20"rgbi:1e-3/1.0e-2/1e0")=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20'(66=20655=2065535)))=0A= -=20=20(should=20(equal=20(color-values-from-color-spec=20= "rgbi:0/0.5/10")=20nil)))=0A+=20=20(should=20(equal=20= (color-values-from-color-spec=20"rgbi:0/0.5/10")=20nil))=0A+=20=20= (should=20(equal=20(color-values-from-color-spec=20"rgbi:0/0/=200")=20= nil))=0A+=20=20(should=20(equal=20(color-values-from-color-spec=20= "rgbi:0/0x0/0")=20nil))=0A+=20=20(should=20(equal=20= (color-values-from-color-spec=20"rgbi:0/+0x1/0")=20nil)))=0A=20=0A=20= (provide=20'xfaces-tests)=0A=20=0A--=20=0A2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_9369F558-96E4-4642-AE16-B08D2CBB4C9C-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 06 07:48:14 2022 Received: (at 54263) by debbugs.gnu.org; 6 Mar 2022 12:48:14 +0000 Received: from localhost ([127.0.0.1]:49996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQqJ3-0006WR-N8 for submit@debbugs.gnu.org; Sun, 06 Mar 2022 07:48:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQqJ1-0006WD-V9 for 54263@debbugs.gnu.org; Sun, 06 Mar 2022 07:48:12 -0500 Received: from [2001:470:142:3::e] (port=46600 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQqIw-0001C6-9G; Sun, 06 Mar 2022 07:48:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=frdi/e/tyJekKYMXJfAsroCBSZ7UJCR/+sh0obbBGA0=; b=WU4yczoWzP3/r3nlezOw 9NvQKPxadOkrwTWayReyJgo6rcX7LHV3ubFubzNWiv4I38zQIdGBUJwil34S1585OaP6BDUR6OfYz Oyy0xFqPhd4xnISGNAIwNXGNvcFgZNdBMbBB/h3lhif0FM6VoyahiWq3clTrje9Tm62GV1GsgmeiY r3MC8oZW18WLshT6Niqo1U7hkjYyXjDoiFN8W19XJUyo1QnILi0XqWLDnvzF85C965toOMfzLuKkc JDRebpU6BKOulP6WLnO6vD0RGvLCIst8LjDs2SJyQY76bb43TuAwefMMRAZ5JFyvLDvwr67bYoJnc NBZEF9E8v7tZqg==; Received: from [87.69.77.57] (port=2981 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQqIv-0006ZO-F7; Sun, 06 Mar 2022 07:48:05 -0500 Date: Sun, 06 Mar 2022 14:47:51 +0200 Message-Id: <83bkyjgsco.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <6E51015D-D59B-4120-8411-86F0909B4BDD@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sun, 6 Mar 2022 12:23:46 +0100) Subject: Re: bug#54263: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications References: <875yore4vb.fsf@posteo.net> <832485F0-60AE-48E6-B163-0DF031F31028@acm.org> <6E51015D-D59B-4120-8411-86F0909B4BDD@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54263 Cc: 54263@debbugs.gnu.org, philipk@posteo.net, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Sun, 6 Mar 2022 12:23:46 +0100 > Cc: 54263@debbugs.gnu.org, Philip Kaludercic , > Lars Ingebrigtsen > > The previous patch erroneously accepted "rgbi:0/+0x0/0". Here is one that doesn't try to be clever. > Clear for emacs-28? I see no reason to install this on the release branch. It is not a recent regression, and there are no specific bug reports for it. So please install the fix for this on master. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 06 08:08:29 2022 Received: (at 54263-done) by debbugs.gnu.org; 6 Mar 2022 13:08:29 +0000 Received: from localhost ([127.0.0.1]:50017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQqcf-000756-Gf for submit@debbugs.gnu.org; Sun, 06 Mar 2022 08:08:29 -0500 Received: from mail236c50.megamailservers.eu ([91.136.10.246]:42286 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQqcd-00074t-Ab for 54263-done@debbugs.gnu.org; Sun, 06 Mar 2022 08:08:28 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1646572103; bh=eskVYGEjWNUlgh7QkjbLU7nm9nS+bT+gh9TE7Iol6Ps=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=jSx1vrhYQLSVsF1ryeyA0JmZiwmpQFrdB5G3pb6aG8YzFYzgNwXV5zjqdtVMQpONh xPBbyO6pQH5Az66N8QgWIB8tgr5oOaiuDVG5DqgZMSICPqu3CvKSqMNFQBa7FIUv6z WAMiFpmQgVTmygyOljL5TmDpUxYRWNPfyhNduiBc= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 226D8LPd023154; Sun, 6 Mar 2022 13:08:22 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#54263: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83bkyjgsco.fsf@gnu.org> Date: Sun, 6 Mar 2022 14:08:20 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <875yore4vb.fsf@posteo.net> <832485F0-60AE-48E6-B163-0DF031F31028@acm.org> <6E51015D-D59B-4120-8411-86F0909B4BDD@acm.org> <83bkyjgsco.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F1A.6224B247.0043, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 6 mars 2022 kl. 13.47 skrev Eli Zaretskii : > I see no reason to install this on the release branch. It is not a > recent regression, and there are no specific bug reports for it. The function is new in Emacs 28; installing the change on master means that we reject previously accepted input instead of making the function behave the way we want from the start. But better late th [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 54263-done Cc: Philip Kaludercic , 54263-done@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 6 mars 2022 kl. 13.47 skrev Eli Zaretskii : > I see no reason to install this on the release branch. It is not a > recent regression, and there are no specific bug reports for it. The function is new in Emacs 28; installing the change on master means = that we reject previously accepted input instead of making the function = behave the way we want from the start. But better late than never, I = suppose. Pushed to master. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 06 09:06:54 2022 Received: (at 54263-done) by debbugs.gnu.org; 6 Mar 2022 14:06:54 +0000 Received: from localhost ([127.0.0.1]:50045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQrXB-00005i-OX for submit@debbugs.gnu.org; Sun, 06 Mar 2022 09:06:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQrXA-00005R-5Q for 54263-done@debbugs.gnu.org; Sun, 06 Mar 2022 09:06:52 -0500 Received: from [2001:470:142:3::e] (port=47790 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQrWt-0000dJ-Pp; Sun, 06 Mar 2022 09:06:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HPuA4sEcBW5Lzx2He71okYBZg9kuRdl0HAy8CrftgnM=; b=haXLbcaAVAwwL6RxQ6tk rObDjSYsYUyPSH6FGrLsCWHuU29T4eK/cT2JbmWlyHYOrET1VC0JaR7hPyoPDvu38ZJhI764RZ9XZ w2VH9UJoqbBVrMMrgEhCwaRmfgRf29XkLfzZ7jala7COA7d1uOBGCYjqvA/XRwuAynj7wfyOjIF7k ubSDr4LBjBv6AwrmAFY45ev4Gde/s6ojCBpevZqkdSRurY1oakw/hvJzRXHWly+Mg/wwwRf+94wyM L8wX/QMfczMncOfSvmgzxJshSht1xWomgwuJBrIaiSDUWEnUzXzSVj/Zcj6kEogwRq1+fdUv5zryO 4+WSk8dMY8ITIA==; Received: from [87.69.77.57] (port=4173 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQrWs-0006tH-Vs; Sun, 06 Mar 2022 09:06:35 -0500 Date: Sun, 06 Mar 2022 16:06:22 +0200 Message-Id: <838rtngopt.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sun, 6 Mar 2022 14:08:20 +0100) Subject: Re: bug#54263: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications References: <875yore4vb.fsf@posteo.net> <832485F0-60AE-48E6-B163-0DF031F31028@acm.org> <6E51015D-D59B-4120-8411-86F0909B4BDD@acm.org> <83bkyjgsco.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54263-done Cc: philipk@posteo.net, 54263-done@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Feedback-ID:mattiase@acm.or > From: Mattias Engdegård > Date: Sun, 6 Mar 2022 14:08:20 +0100 > Cc: 54263-done@debbugs.gnu.org, Philip Kaludercic , > Lars Ingebrigtsen > > 6 mars 2022 kl. 13.47 skrev Eli Zaretskii : > > > I see no reason to install this on the release branch. It is not a > > recent regression, and there are no specific bug reports for it. > > The function is new in Emacs 28; installing the change on master means that we reject previously accepted input instead of making the function behave the way we want from the start. But better late than never, I suppose. > Pushed to master. Thanks. Like I said, I see no reason to hurry with this fix, but we could consider it for backporting to the emacs-28 branch once Emacs 28.1 is released. From unknown Fri Jun 20 07:15:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 04 Apr 2022 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator