GNU bug report logs - #54260
[PATCH 0/3] gnu: ucsim: Update to 0.7.1.

Previous Next

Package: guix-patches;

Reported by: Simon South <simon <at> simonsouth.net>

Date: Sat, 5 Mar 2022 12:57:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #49 received at 54260 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Simon South <simon <at> simonsouth.net>
Cc: 54260 <at> debbugs.gnu.org
Subject: Re: [bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t
 from phases.
Date: Fri, 11 Mar 2022 23:39:21 +0100

[Message part 1 (text/plain, inline)]
Simon South schreef op za 05-03-2022 om 11:39 [-0500]:
> This occurred to me, but is it not better in this case to rely on the
> "output" parameter passed into the procedure?  Using "#$output" in this
> context feels like a violation of the Law of Demeter, like using a
> global variable where a local one would be appropriate.

'outputs' is an argument to the phase procedure, but as I understand
it, it is only due to historical reasons (G-exps are relatively new-
ish) and because the procedures in (guix build FOO-build-system) have
no other method for determining the outputs.

Might be a good idea to confirm with chief gexpologist ludo though.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 3 years and 133 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.