GNU bug report logs - #54260
[PATCH 0/3] gnu: ucsim: Update to 0.7.1.

Previous Next

Package: guix-patches;

Reported by: Simon South <simon <at> simonsouth.net>

Date: Sat, 5 Mar 2022 12:57:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #23 received at 54260 <at> debbugs.gnu.org (full text, mbox):

From: Simon South <simon <at> simonsouth.net>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54260 <at> debbugs.gnu.org
Subject: Re: [bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t
 from phases.
Date: Sat, 05 Mar 2022 11:39:38 -0500
Maxime Devos <maximedevos <at> telenet.be> writes:
> Additionally, you could make the #:configure-flags a G-exp and
> eliminate input labels (or, in this case, output labels)

This occurred to me, but is it not better in this case to rely on the
"output" parameter passed into the procedure?  Using "#$output" in this
context feels like a violation of the Law of Demeter, like using a
global variable where a local one would be appropriate.

I'll drop the first patch though; I'd missed seeing the definition of
"gnu-cross-build".

-- 
Simon South
simon <at> simonsouth.net




This bug report was last modified 3 years and 133 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.