From unknown Tue Aug 19 07:26:38 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54260 <54260@debbugs.gnu.org> To: bug#54260 <54260@debbugs.gnu.org> Subject: Status: [PATCH 0/3] gnu: ucsim: Update to 0.7.1. Reply-To: bug#54260 <54260@debbugs.gnu.org> Date: Tue, 19 Aug 2025 14:26:38 +0000 retitle 54260 [PATCH 0/3] gnu: ucsim: Update to 0.7.1. reassign 54260 guix-patches submitter 54260 Simon South severity 54260 normal tag 54260 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 07:56:25 2022 Received: (at submit) by debbugs.gnu.org; 5 Mar 2022 12:56:25 +0000 Received: from localhost ([127.0.0.1]:47459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQTxR-0002jg-1u for submit@debbugs.gnu.org; Sat, 05 Mar 2022 07:56:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:43736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQTxQ-0002jZ-4i for submit@debbugs.gnu.org; Sat, 05 Mar 2022 07:56:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQTxP-0001UW-Gw for guix-patches@gnu.org; Sat, 05 Mar 2022 07:56:23 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:35158) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQTxK-00013c-Dk for guix-patches@gnu.org; Sat, 05 Mar 2022 07:56:20 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 06529EAE45 for ; Sat, 5 Mar 2022 12:56:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo01-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo01-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nFNykCVzcfxu for ; Sat, 5 Mar 2022 12:56:15 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id B546DEAE24 for ; Sat, 5 Mar 2022 12:56:15 +0000 (UTC) From: Simon South To: guix-patches@gnu.org Subject: [PATCH 0/3] gnu: ucsim: Update to 0.7.1. Date: Sat, 5 Mar 2022 07:56:14 -0500 Message-Id: X-Mailer: git-send-email 2.25.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Here's a patch series that updates μCsim, a collection of software simulators for various microcontroller families, to its latest version and fixes a couple of small outstanding issues with its package definition. I've tested this on AArch64 and x86-64 and all appears to be well. -- Simon South simon@simonsouth.net Simon South (3): gnu: ucsim: Don't run tests when cross-compiling. gnu: ucsim: Don't explicitly return #t from phases. gnu: ucsim: Update to 0.7.1. gnu/packages/embedded.scm | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) base-commit: 97065f9fe3da74adab54b70e28bd2cd59c06ee07 -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 07:59:09 2022 Received: (at 54260) by debbugs.gnu.org; 5 Mar 2022 12:59:09 +0000 Received: from localhost ([127.0.0.1]:47465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQU05-0002o7-HZ for submit@debbugs.gnu.org; Sat, 05 Mar 2022 07:59:09 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:48148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQU04-0002nt-DW for 54260@debbugs.gnu.org; Sat, 05 Mar 2022 07:59:08 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 95E2DEAE46 for <54260@debbugs.gnu.org>; Sat, 5 Mar 2022 12:59:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo01-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo01-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cRVBBOrqnL9P for <54260@debbugs.gnu.org>; Sat, 5 Mar 2022 12:59:02 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 5E9F9EAE24 for <54260@debbugs.gnu.org>; Sat, 5 Mar 2022 12:59:02 +0000 (UTC) From: Simon South To: 54260@debbugs.gnu.org Subject: [PATCH 1/3] gnu: ucsim: Don't run tests when cross-compiling. Date: Sat, 5 Mar 2022 07:58:59 -0500 Message-Id: X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54260 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/embedded.scm (ucsim)[arguments]: Skip tests when cross-compiling. --- gnu/packages/embedded.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm index f7573618b9..43fba510da 100644 --- a/gnu/packages/embedded.scm +++ b/gnu/packages/embedded.scm @@ -1501,6 +1501,7 @@ (define-public ucsim "--enable-m6809-port" "--enable-p1516-port" "--enable-st7-port") + #:tests? ,(not (%current-target-system)) ; run unless cross-compiling #:phases (modify-phases %standard-phases (add-after 'unpack 'patch-makefiles -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 07:59:12 2022 Received: (at 54260) by debbugs.gnu.org; 5 Mar 2022 12:59:12 +0000 Received: from localhost ([127.0.0.1]:47468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQU07-0002oS-P1 for submit@debbugs.gnu.org; Sat, 05 Mar 2022 07:59:12 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:48190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQU05-0002nw-Mc for 54260@debbugs.gnu.org; Sat, 05 Mar 2022 07:59:10 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 64640EAE24 for <54260@debbugs.gnu.org>; Sat, 5 Mar 2022 12:59:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo01-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo01-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qm3dx5eN2VMl for <54260@debbugs.gnu.org>; Sat, 5 Mar 2022 12:59:02 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 7B5D7EAE45 for <54260@debbugs.gnu.org>; Sat, 5 Mar 2022 12:59:02 +0000 (UTC) From: Simon South To: 54260@debbugs.gnu.org Subject: [PATCH 2/3] gnu: ucsim: Don't explicitly return #t from phases. Date: Sat, 5 Mar 2022 07:59:00 -0500 Message-Id: <49559efd0d392df29393ac7441b83f14c2840b21.1646484354.git.simon@simonsouth.net> X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54260 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/embedded.scm (ucsim)[arguments]: Don't explicitly return #t from phases. --- gnu/packages/embedded.scm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm index 43fba510da..1d232e471a 100644 --- a/gnu/packages/embedded.scm +++ b/gnu/packages/embedded.scm @@ -1507,13 +1507,11 @@ (define-public ucsim (add-after 'unpack 'patch-makefiles (lambda _ (substitute* (find-files "." "(\\.mk$|\\.in$)") - (("/bin/sh") (which "sh"))) - #t)) + (("/bin/sh") (which "sh"))))) (add-after 'install 'remove-empty-directory (lambda* (#:key outputs #:allow-other-keys) (delete-file-recursively - (string-append (assoc-ref outputs "out") "/share/man")) - #t))))) + (string-append (assoc-ref outputs "out") "/share/man"))))))) (native-inputs (list bison flex)) (home-page "http://mazsola.iit.uni-miskolc.hu/ucsim/") -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 07:59:12 2022 Received: (at 54260) by debbugs.gnu.org; 5 Mar 2022 12:59:12 +0000 Received: from localhost ([127.0.0.1]:47470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQU08-0002oU-61 for submit@debbugs.gnu.org; Sat, 05 Mar 2022 07:59:12 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:48156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQU04-0002nu-DX for 54260@debbugs.gnu.org; Sat, 05 Mar 2022 07:59:11 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id DE77FEAE40 for <54260@debbugs.gnu.org>; Sat, 5 Mar 2022 12:59:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo01-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo01-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z4VSz2rXGeCS for <54260@debbugs.gnu.org>; Sat, 5 Mar 2022 12:59:02 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 93FA5EAE49 for <54260@debbugs.gnu.org>; Sat, 5 Mar 2022 12:59:02 +0000 (UTC) From: Simon South To: 54260@debbugs.gnu.org Subject: [PATCH 3/3] gnu: ucsim: Update to 0.7.1. Date: Sat, 5 Mar 2022 07:59:01 -0500 Message-Id: X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54260 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/embedded.scm (ucsim): Update to 0.7.1. [source]: Update URI. [arguments]<#:configure-flags>: Remove as all stable ports are now built by default. <#:phases>: Remove obsolete "remove-empty-directory" phase. [inputs]: Add ncurses, needed for the serialview utility. [native-inputs]: Add sdcc when needed for tests. [description]: Update to mention newly supported microcontroller families. --- gnu/packages/embedded.scm | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm index 1d232e471a..f93968dd59 100644 --- a/gnu/packages/embedded.scm +++ b/gnu/packages/embedded.scm @@ -56,6 +56,7 @@ (define-module (gnu packages embedded) #:use-module (gnu packages libftdi) #:use-module (gnu packages libusb) #:use-module (gnu packages messaging) + #:use-module (gnu packages ncurses) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) #:use-module (gnu packages python) @@ -1486,40 +1487,40 @@ (define-public ebusd (define-public ucsim (package (name "ucsim") - (version "0.6-pre68") + (version "0.7.1") (source (origin (method url-fetch) (uri (string-append "http://mazsola.iit.uni-miskolc.hu/ucsim/download/unix/" - "devel/ucsim-" version ".tar.gz")) + "source/v" (version-major+minor version) ".x/" + "ucsim-" version ".tar.gz")) (sha256 (base32 - "1bfj21f5pcfcg1xqqynlcfr8mn6qj5705cgc2lfr2s3n97qsd9df")))) + "080471wvkjdzxz5j3zdaq1apjcj84ql50kn26b7p4ansixnimml4")))) (build-system gnu-build-system) (arguments - `(#:configure-flags '("--enable-avr-port" - "--enable-m6809-port" - "--enable-p1516-port" - "--enable-st7-port") - #:tests? ,(not (%current-target-system)) ; run unless cross-compiling + `(#:tests? ,(not (%current-target-system)) ; run unless cross-compiling #:phases (modify-phases %standard-phases (add-after 'unpack 'patch-makefiles (lambda _ (substitute* (find-files "." "(\\.mk$|\\.in$)") - (("/bin/sh") (which "sh"))))) - (add-after 'install 'remove-empty-directory - (lambda* (#:key outputs #:allow-other-keys) - (delete-file-recursively - (string-append (assoc-ref outputs "out") "/share/man"))))))) + (("/bin/sh") (which "sh")))))))) + (inputs + (list ncurses)) (native-inputs - (list bison flex)) + (append (list bison flex) + ;; Certain tests use assemblers provided by SDCC. + (if (not (%current-target-system)) + (list sdcc) + '()))) (home-page "http://mazsola.iit.uni-miskolc.hu/ucsim/") (synopsis "Simulators for various microcontroller families") (description "μCsim is a collection of software simulators for -microcontrollers in the Atmel AVR; Intel MCS-51 (8051); Motorola 68HC08 and -6809; P1516; Padauk PDK13, PDK14 and PDK15; STMicroelectronics ST7 and STM8; -and Zilog Z80 families, plus many of their variants.") +microcontrollers in the Atmel AVR; Intel MCS-51 (8051); Motorola 6800, 68HC08 +and 6809; MOS Technology 6502; P1516; Padauk PDK13, PDK14 and PDK15; Philips +XA; STMicroelectronics ST7 and STM8; Xilinx PicoBlaze; and Zilog Z80 families, +plus many of their variants.") (license license:gpl2+))) (define-public sdcc -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 10:21:11 2022 Received: (at 54260) by debbugs.gnu.org; 5 Mar 2022 15:21:11 +0000 Received: from localhost ([127.0.0.1]:48857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQWDX-0006YQ-3H for submit@debbugs.gnu.org; Sat, 05 Mar 2022 10:21:11 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:56368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQWDS-0006YD-UM for 54260@debbugs.gnu.org; Sat, 05 Mar 2022 10:21:09 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id 2fM5270034UW6Th01fM5mr; Sat, 05 Mar 2022 16:21:05 +0100 Message-ID: <52ed5eaa9ef9beb279c7d94ee952a9c9463f1123.camel@telenet.be> Subject: Re: [bug#54260] [PATCH 1/3] gnu: ucsim: Don't run tests when cross-compiling. From: Maxime Devos To: Simon South , 54260@debbugs.gnu.org Date: Sat, 05 Mar 2022 16:21:00 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-O2pzrfskKUhhvk5y8Vnw" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646493665; bh=ApZUmxZ3zewvgOVlkf+/7HoDj+KY+61bBc0FKuYWGVE=; h=Subject:From:To:Date:In-Reply-To:References; b=LNUviqiy8P3LhkMte8YsAWLiLp5EFRUTxMPfp0NfwPvSR0Md+BNtUC+rGbkZmmUJM k2ao6cne13fXHI4uTzJ3/zUBK6wfksoWKNrAAJplviyY0bwUhPdhj1QFFG4utca8cx +fM3X5eG3ny7RxsUJnrMIXh+JJ1m6dqSOY+H0r8VNY/Tpxbc7jJIP/YPGckLjUjdwK hZqRzaKruHzIYmCRdGOarQrOKno82wfJ8+kkxmrKA5ijTggSU5e3Y6Waf89EE1sgR1 Xzu87zm6gq7LLBPMFisToYpMKaCFM7WHm6qcQAOIsWMJ0EmDZvzZjnnanI6smWnnQj qkG32c9GKrNVA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54260 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-O2pzrfskKUhhvk5y8Vnw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Simon South schreef op za 05-03-2022 om 07:58 [-0500]: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:tests? ,(not (%current-target-sys= tem)) ; run unless cross-compiling #:tests? is #false by default when cross-compiling and #true by default when compiling natively (with some exceptions, e.g. emacs-build- system). You probably don't need to set this explicitly. Greetings, Maxime. --=-O2pzrfskKUhhvk5y8Vnw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYiN/3BccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kOMAP9hNNc72BIdigsYF4cBIUdOYkR2 6t6E7TULqbkZR9X8XgD9GGp35uY4p02NbIFw5XE3pXkBrtuwJX/aidC3KlqXpAg= =8pq3 -----END PGP SIGNATURE----- --=-O2pzrfskKUhhvk5y8Vnw-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 10:23:39 2022 Received: (at 54260) by debbugs.gnu.org; 5 Mar 2022 15:23:39 +0000 Received: from localhost ([127.0.0.1]:48862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQWFv-0006cH-G3 for submit@debbugs.gnu.org; Sat, 05 Mar 2022 10:23:39 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:46180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQWFu-0006c9-Ew for 54260@debbugs.gnu.org; Sat, 05 Mar 2022 10:23:38 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id 2fPc2700D4UW6Th06fPclS; Sat, 05 Mar 2022 16:23:37 +0100 Message-ID: Subject: Re: [bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t from phases. From: Maxime Devos To: Simon South , 54260@debbugs.gnu.org Date: Sat, 05 Mar 2022 16:23:35 +0100 In-Reply-To: <49559efd0d392df29393ac7441b83f14c2840b21.1646484354.git.simon@simonsouth.net> References: <49559efd0d392df29393ac7441b83f14c2840b21.1646484354.git.simon@simonsouth.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-u0CGSXc8+MJzPsy9SwKn" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646493817; bh=VG2tV8zU0D5CDc8GKNTxkdEIr5FyahcsuNNGI6aPb4E=; h=Subject:From:To:Date:In-Reply-To:References; b=IgxW2psVrjHSGqgGC/tZHRvFZtHlPheBYtWBeHczaWyIb4HvYbjN0BGm9851/ms3t Y94QkJGrqCyOD90qCquIiQECEVgrBsthZOgjfrKM+THrh3/trANiNHYLnKffOYzuJM PGJwR38pymFPkPeg2u/ShZB9KJzal1ppckvUU5sFLx6bj8Qa9sxgcQD08OOYx2SxUm Wgbs5CCl0hJ+daMlM79ukJV7N2zLUk1qYLA7I8QrtO9MhxBnAMidLKnHrfo4Ag6ZuL xphYZpN6y96DlJEi+3KmK6u4BieykCIptPVnjSuLR3LSubVHASRrtnDIQPEyyDR/9N zGkEwJrS/BJ9g== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54260 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-u0CGSXc8+MJzPsy9SwKn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 U2ltb24gU291dGggc2NocmVlZiBvcCB6YSAwNS0wMy0yMDIyIG9tIDA3OjU5IFstMDUwMF06Cj4g wqDCoMKgwqDCoMKgwqDCoMKgIChhZGQtYWZ0ZXIgJ2luc3RhbGwgJ3JlbW92ZS1lbXB0eS1kaXJl Y3RvcnkKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChsYW1iZGEqICgjOmtleSBvdXRwdXRzICM6 YWxsb3ctb3RoZXIta2V5cykKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoZGVsZXRlLWZp bGUtcmVjdXJzaXZlbHkKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHN0cmluZy1hcHBl bmQgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSAiL3NoYXJlL21hbiIpKQo+IC3CoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgI3QpKSkpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc3Ry aW5nLWFwcGVuZCAoYXNzb2MtcmVmIG91dHB1dHMgIm91dCIpICIvc2hhcmUvbWFuIikpKSkpKSkK CkFkZGl0aW9uYWxseSwgeW91IGNvdWxkIG1ha2UgdGhlICM6Y29uZmlndXJlLWZsYWdzIGEgRy1l eHAgYW5kCmVsaW1pbmF0ZSBpbnB1dCBsYWJlbHMgKG9yLCBpbiB0aGlzIGNhc2UsIG91dHB1dCBs YWJlbHMpOgoKKGxpc3QgIzpwaGFzZXMKICAgICAgI34obW9kaWZ5LXBoYXNlcyAuLi4KICAgICAg ICAgIChhZGQtYWZ0ZXIgLi4uIC4uLgogICAgICAgICAgICAobGFtYmRhIF8KICAgICAgICAgICAg ICAuLi4gKHN0cmluZy1hcHBlbmQgIyRvdXRwdXQgIi9zaGFyZS9tYW4iKSAuLi4pKSkpCgpHcmVl dGluZ3MsCk1heGltZS4K --=-u0CGSXc8+MJzPsy9SwKn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYiOAdxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7n8zAQCKkYGr6Bg2IFUWk5qsfqivCP7A k3t+7L8N8c1rVTN5ZQEA5DcRfOpCAVach6soAFs/trBAHYxPomnSlKp+b9C7pQQ= =zcVr -----END PGP SIGNATURE----- --=-u0CGSXc8+MJzPsy9SwKn-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 11:39:46 2022 Received: (at 54260) by debbugs.gnu.org; 5 Mar 2022 16:39:47 +0000 Received: from localhost ([127.0.0.1]:48946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQXRa-0008WE-Lz for submit@debbugs.gnu.org; Sat, 05 Mar 2022 11:39:46 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:56604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQXRY-0008W1-FS for 54260@debbugs.gnu.org; Sat, 05 Mar 2022 11:39:45 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id CEFA0731F2; Sat, 5 Mar 2022 16:39:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JkN61is8C0SP; Sat, 5 Mar 2022 16:39:38 +0000 (UTC) Received: from laptop (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 4C0BF72A58; Sat, 5 Mar 2022 16:39:38 +0000 (UTC) From: Simon South To: Maxime Devos Subject: Re: [bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t from phases. References: <49559efd0d392df29393ac7441b83f14c2840b21.1646484354.git.simon@simonsouth.net> Date: Sat, 05 Mar 2022 11:39:38 -0500 In-Reply-To: (Maxime Devos's message of "Sat, 05 Mar 2022 16:23:35 +0100") Message-ID: <87czj073qt.fsf@simonsouth.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54260 Cc: 54260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxime Devos writes: > Additionally, you could make the #:configure-flags a G-exp and > eliminate input labels (or, in this case, output labels) This occurred to me, but is it not better in this case to rely on the "output" parameter passed into the procedure? Using "#$output" in this context feels like a violation of the Law of Demeter, like using a global variable where a local one would be appropriate. I'll drop the first patch though; I'd missed seeing the definition of "gnu-cross-build". -- Simon South simon@simonsouth.net From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 09:12:52 2022 Received: (at 54260) by debbugs.gnu.org; 8 Mar 2022 14:12:52 +0000 Received: from localhost ([127.0.0.1]:55576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRaa4-0001D1-0T for submit@debbugs.gnu.org; Tue, 08 Mar 2022 09:12:52 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:40324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRaa1-0001CX-EU for 54260@debbugs.gnu.org; Tue, 08 Mar 2022 09:12:50 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id D8D03753F1 for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 14:12:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e83y5Dl_GFwN for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 14:12:43 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 6C672753F5 for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 14:12:43 +0000 (UTC) From: Simon South To: 54260@debbugs.gnu.org Subject: [PATCH v2 1/2] gnu: ucsim: Don't explicitly return #t from phases. Date: Tue, 8 Mar 2022 09:12:40 -0500 Message-Id: <7a21ce6c677c1776c82737a2a4b1c55e34aff1a1.1646747962.git.simon@simonsouth.net> X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54260 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/embedded.scm (ucsim)[arguments]: Don't explicitly return #t from phases. --- gnu/packages/embedded.scm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm index f7573618b9..7b219203be 100644 --- a/gnu/packages/embedded.scm +++ b/gnu/packages/embedded.scm @@ -1506,13 +1506,11 @@ (define-public ucsim (add-after 'unpack 'patch-makefiles (lambda _ (substitute* (find-files "." "(\\.mk$|\\.in$)") - (("/bin/sh") (which "sh"))) - #t)) + (("/bin/sh") (which "sh"))))) (add-after 'install 'remove-empty-directory (lambda* (#:key outputs #:allow-other-keys) (delete-file-recursively - (string-append (assoc-ref outputs "out") "/share/man")) - #t))))) + (string-append (assoc-ref outputs "out") "/share/man"))))))) (native-inputs (list bison flex)) (home-page "http://mazsola.iit.uni-miskolc.hu/ucsim/") -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 09:12:53 2022 Received: (at 54260) by debbugs.gnu.org; 8 Mar 2022 14:12:53 +0000 Received: from localhost ([127.0.0.1]:55578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRaa4-0001D3-E3 for submit@debbugs.gnu.org; Tue, 08 Mar 2022 09:12:52 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:40316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRaa1-0001CW-DG for 54260@debbugs.gnu.org; Tue, 08 Mar 2022 09:12:50 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 8D759753F6 for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 14:12:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VOjpg0W35-MP for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 14:12:43 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 537C9753F1 for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 14:12:43 +0000 (UTC) From: Simon South To: 54260@debbugs.gnu.org Subject: [PATCH v2 0/2] gnu: ucsim: Update to 0.7.1. Date: Tue, 8 Mar 2022 09:12:39 -0500 Message-Id: X-Mailer: git-send-email 2.25.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54260 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Here's a revised version of this patchset that updates μCsim to 0.7.1. I've responded to Maxime's feedback by dropping the first patch of the original set, since tests are normally disabled anyway when cross-compiling. The question of whether "#$output" ought to be used in the first patch of this set turns out to be academic as the code in question is deleted by the second. I've tested this again on AArch64 and x86-64 and all appears to be well. -- Simon South simon@simonsouth.net Simon South (2): gnu: ucsim: Don't explicitly return #t from phases. gnu: ucsim: Update to 0.7.1. gnu/packages/embedded.scm | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) base-commit: 875053310277ccdcb82ff86edf013cd28e6778c8 -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 09:12:53 2022 Received: (at 54260) by debbugs.gnu.org; 8 Mar 2022 14:12:53 +0000 Received: from localhost ([127.0.0.1]:55580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRaa5-0001DD-0J for submit@debbugs.gnu.org; Tue, 08 Mar 2022 09:12:53 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:40340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRaa1-0001CZ-SY for 54260@debbugs.gnu.org; Tue, 08 Mar 2022 09:12:50 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id AE7B0753F5 for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 14:12:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8tfS3bdcRPfk for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 14:12:43 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 893E3753F7 for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 14:12:43 +0000 (UTC) From: Simon South To: 54260@debbugs.gnu.org Subject: [PATCH v2 2/2] gnu: ucsim: Update to 0.7.1. Date: Tue, 8 Mar 2022 09:12:41 -0500 Message-Id: X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54260 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/embedded.scm (ucsim): Update to 0.7.1. [source]: Update URI. [arguments]<#:configure-flags>: Remove as all stable ports are now built by default. <#:phases>: Remove obsolete "remove-empty-directory" phase. [inputs]: Add ncurses, needed for the serialview utility. [native-inputs]: Add sdcc when needed for tests. [description]: Update to mention newly supported microcontroller families. --- gnu/packages/embedded.scm | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm index 7b219203be..e33cfb4be2 100644 --- a/gnu/packages/embedded.scm +++ b/gnu/packages/embedded.scm @@ -56,6 +56,7 @@ (define-module (gnu packages embedded) #:use-module (gnu packages libftdi) #:use-module (gnu packages libusb) #:use-module (gnu packages messaging) + #:use-module (gnu packages ncurses) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) #:use-module (gnu packages python) @@ -1486,39 +1487,39 @@ (define-public ebusd (define-public ucsim (package (name "ucsim") - (version "0.6-pre68") + (version "0.7.1") (source (origin (method url-fetch) (uri (string-append "http://mazsola.iit.uni-miskolc.hu/ucsim/download/unix/" - "devel/ucsim-" version ".tar.gz")) + "source/v" (version-major+minor version) ".x/" + "ucsim-" version ".tar.gz")) (sha256 (base32 - "1bfj21f5pcfcg1xqqynlcfr8mn6qj5705cgc2lfr2s3n97qsd9df")))) + "080471wvkjdzxz5j3zdaq1apjcj84ql50kn26b7p4ansixnimml4")))) (build-system gnu-build-system) (arguments - `(#:configure-flags '("--enable-avr-port" - "--enable-m6809-port" - "--enable-p1516-port" - "--enable-st7-port") - #:phases + `(#:phases (modify-phases %standard-phases (add-after 'unpack 'patch-makefiles (lambda _ (substitute* (find-files "." "(\\.mk$|\\.in$)") - (("/bin/sh") (which "sh"))))) - (add-after 'install 'remove-empty-directory - (lambda* (#:key outputs #:allow-other-keys) - (delete-file-recursively - (string-append (assoc-ref outputs "out") "/share/man"))))))) + (("/bin/sh") (which "sh")))))))) + (inputs + (list ncurses)) (native-inputs - (list bison flex)) + (append (list bison flex) + ;; Certain tests use assemblers provided by SDCC. + (if (not (%current-target-system)) + (list sdcc) + '()))) (home-page "http://mazsola.iit.uni-miskolc.hu/ucsim/") (synopsis "Simulators for various microcontroller families") (description "μCsim is a collection of software simulators for -microcontrollers in the Atmel AVR; Intel MCS-51 (8051); Motorola 68HC08 and -6809; P1516; Padauk PDK13, PDK14 and PDK15; STMicroelectronics ST7 and STM8; -and Zilog Z80 families, plus many of their variants.") +microcontrollers in the Atmel AVR; Intel MCS-51 (8051); Motorola 6800, 68HC08 +and 6809; MOS Technology 6502; P1516; Padauk PDK13, PDK14 and PDK15; Philips +XA; STMicroelectronics ST7 and STM8; Xilinx PicoBlaze; and Zilog Z80 families, +plus many of their variants.") (license license:gpl2+))) (define-public sdcc -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 10:52:18 2022 Received: (at 54260) by debbugs.gnu.org; 8 Mar 2022 15:52:18 +0000 Received: from localhost ([127.0.0.1]:57434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRc8H-0006ZU-VQ for submit@debbugs.gnu.org; Tue, 08 Mar 2022 10:52:18 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:51590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRc8G-0006Z3-F7 for 54260@debbugs.gnu.org; Tue, 08 Mar 2022 10:52:16 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id BAC3481BAF for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 15:52:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo03-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SjVIy_0jMhkH for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 15:52:10 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 8203481950 for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 15:52:10 +0000 (UTC) From: Simon South To: 54260@debbugs.gnu.org Subject: [PATCH v3 0/2] gnu: ucsim: Update to 0.7.1. Date: Tue, 8 Mar 2022 10:52:07 -0500 Message-Id: X-Mailer: git-send-email 2.25.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54260 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Here's one minor, final revision that modifies the ucsim package's "description" field to - Keep the microprocessor families ordered by vendor name; and - Drop mention of the Philips XA, which is actually an MCS-51 derivative. Everything else remains the same. -- Simon South simon@simonsouth.net Simon South (2): gnu: ucsim: Don't explicitly return #t from phases. gnu: ucsim: Update to 0.7.1. gnu/packages/embedded.scm | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) base-commit: 875053310277ccdcb82ff86edf013cd28e6778c8 -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 10:52:19 2022 Received: (at 54260) by debbugs.gnu.org; 8 Mar 2022 15:52:19 +0000 Received: from localhost ([127.0.0.1]:57436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRc8J-0006Zc-7f for submit@debbugs.gnu.org; Tue, 08 Mar 2022 10:52:19 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:51600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRc8H-0006Z7-3U for 54260@debbugs.gnu.org; Tue, 08 Mar 2022 10:52:17 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id CCB5081BB2 for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 15:52:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo03-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RylcQ3KTUtDV for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 15:52:10 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 9EB8381BB8 for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 15:52:10 +0000 (UTC) From: Simon South To: 54260@debbugs.gnu.org Subject: [PATCH v3 1/2] gnu: ucsim: Don't explicitly return #t from phases. Date: Tue, 8 Mar 2022 10:52:08 -0500 Message-Id: <3c1363cc28e702fdcfb356ca3aba4f5e031e0773.1646754416.git.simon@simonsouth.net> X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54260 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/embedded.scm (ucsim)[arguments]: Don't explicitly return #t from phases. --- gnu/packages/embedded.scm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm index f7573618b9..7b219203be 100644 --- a/gnu/packages/embedded.scm +++ b/gnu/packages/embedded.scm @@ -1506,13 +1506,11 @@ (define-public ucsim (add-after 'unpack 'patch-makefiles (lambda _ (substitute* (find-files "." "(\\.mk$|\\.in$)") - (("/bin/sh") (which "sh"))) - #t)) + (("/bin/sh") (which "sh"))))) (add-after 'install 'remove-empty-directory (lambda* (#:key outputs #:allow-other-keys) (delete-file-recursively - (string-append (assoc-ref outputs "out") "/share/man")) - #t))))) + (string-append (assoc-ref outputs "out") "/share/man"))))))) (native-inputs (list bison flex)) (home-page "http://mazsola.iit.uni-miskolc.hu/ucsim/") -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 10:52:19 2022 Received: (at 54260) by debbugs.gnu.org; 8 Mar 2022 15:52:20 +0000 Received: from localhost ([127.0.0.1]:57438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRc8J-0006Ze-G4 for submit@debbugs.gnu.org; Tue, 08 Mar 2022 10:52:19 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:51608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRc8H-0006Z8-6W for 54260@debbugs.gnu.org; Tue, 08 Mar 2022 10:52:17 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id E2B9681BB8 for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 15:52:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo03-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xGEZAxNfxuRq for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 15:52:10 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id B52A181BB9 for <54260@debbugs.gnu.org>; Tue, 8 Mar 2022 15:52:10 +0000 (UTC) From: Simon South To: 54260@debbugs.gnu.org Subject: [PATCH v3 2/2] gnu: ucsim: Update to 0.7.1. Date: Tue, 8 Mar 2022 10:52:09 -0500 Message-Id: X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54260 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/embedded.scm (ucsim): Update to 0.7.1. [source]: Update URI. [arguments]<#:configure-flags>: Remove as all stable ports are now built by default. <#:phases>: Remove obsolete "remove-empty-directory" phase. [inputs]: Add ncurses, needed for the serialview utility. [native-inputs]: Add sdcc when needed for tests. [description]: Update to mention newly supported microcontroller families. --- gnu/packages/embedded.scm | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm index 7b219203be..f3d5e8fced 100644 --- a/gnu/packages/embedded.scm +++ b/gnu/packages/embedded.scm @@ -56,6 +56,7 @@ (define-module (gnu packages embedded) #:use-module (gnu packages libftdi) #:use-module (gnu packages libusb) #:use-module (gnu packages messaging) + #:use-module (gnu packages ncurses) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) #:use-module (gnu packages python) @@ -1486,39 +1487,39 @@ (define-public ebusd (define-public ucsim (package (name "ucsim") - (version "0.6-pre68") + (version "0.7.1") (source (origin (method url-fetch) (uri (string-append "http://mazsola.iit.uni-miskolc.hu/ucsim/download/unix/" - "devel/ucsim-" version ".tar.gz")) + "source/v" (version-major+minor version) ".x/" + "ucsim-" version ".tar.gz")) (sha256 (base32 - "1bfj21f5pcfcg1xqqynlcfr8mn6qj5705cgc2lfr2s3n97qsd9df")))) + "080471wvkjdzxz5j3zdaq1apjcj84ql50kn26b7p4ansixnimml4")))) (build-system gnu-build-system) (arguments - `(#:configure-flags '("--enable-avr-port" - "--enable-m6809-port" - "--enable-p1516-port" - "--enable-st7-port") - #:phases + `(#:phases (modify-phases %standard-phases (add-after 'unpack 'patch-makefiles (lambda _ (substitute* (find-files "." "(\\.mk$|\\.in$)") - (("/bin/sh") (which "sh"))))) - (add-after 'install 'remove-empty-directory - (lambda* (#:key outputs #:allow-other-keys) - (delete-file-recursively - (string-append (assoc-ref outputs "out") "/share/man"))))))) + (("/bin/sh") (which "sh")))))))) + (inputs + (list ncurses)) (native-inputs - (list bison flex)) + (append (list bison flex) + ;; Certain tests use assemblers provided by SDCC. + (if (not (%current-target-system)) + (list sdcc) + '()))) (home-page "http://mazsola.iit.uni-miskolc.hu/ucsim/") (synopsis "Simulators for various microcontroller families") (description "μCsim is a collection of software simulators for -microcontrollers in the Atmel AVR; Intel MCS-51 (8051); Motorola 68HC08 and -6809; P1516; Padauk PDK13, PDK14 and PDK15; STMicroelectronics ST7 and STM8; -and Zilog Z80 families, plus many of their variants.") +microcontrollers in the Atmel AVR; Intel MCS-51 (8051); MOS Technology 6502; +Motorola 6800, 68HC08 and 6809; P1516; Padauk PDK13, PDK14 and PDK15; +STMicroelectronics ST7 and STM8; Xilinx PicoBlaze; and Zilog Z80 families, +plus many of their variants.") (license license:gpl2+))) (define-public sdcc -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 11 17:17:52 2022 Received: (at 54260-done) by debbugs.gnu.org; 11 Mar 2022 22:17:53 +0000 Received: from localhost ([127.0.0.1]:38599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSna4-0005Ak-Lz for submit@debbugs.gnu.org; Fri, 11 Mar 2022 17:17:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSna2-0005AX-UR for 54260-done@debbugs.gnu.org; Fri, 11 Mar 2022 17:17:51 -0500 Received: from [2001:470:142:3::e] (port=34184 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSnZx-0003l2-E2; Fri, 11 Mar 2022 17:17:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=lbIttDiEsvpzsQvH/ShuhxRSWyRDYvv4D+8XkQfpaKw=; b=d7pqq97yKy6whDdnLkHP i5DonPpP0qZjO3LydZNDtSjGA32f0yqcXiB2l4ocdrq7HpwnTZhakNb1x9K8kJMzO9t08IA7J63Ri p6x5oJ8aaWdymBUK4LEnT9TgJzdGtBbwYN525Opla2+OodSGL45dziGHjPYi4u0HjfRu4R2bo9Bx2 F7fntAaaqJ57KG2rK9KqqzUQa3fSrhL2XVPUQOAcfTF0A87OzGd4aMiPxn8KVowa0MCr56GzH4zpn kfotEmjXV6znl7wimheH/HZwVfZQAHJ54c+qimFM+C3Jwuq0xeNw7HWGYDRnArnyHiy6XffY8Ksbq wCpRz/13Id/FsQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56262 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSnZx-00031g-0k; Fri, 11 Mar 2022 17:17:45 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon South Subject: Re: bug#54260: [PATCH 0/3] gnu: ucsim: Update to 0.7.1. References: Date: Fri, 11 Mar 2022 23:17:42 +0100 In-Reply-To: (Simon South's message of "Tue, 8 Mar 2022 10:52:07 -0500") Message-ID: <87czisw2ux.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54260-done Cc: 54260-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Simon South skribis: > gnu: ucsim: Don't explicitly return #t from phases. > gnu: ucsim: Update to 0.7.1. Applied. Thank you, and thanks Maxime for reviewing! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 11 17:39:25 2022 Received: (at 54260) by debbugs.gnu.org; 11 Mar 2022 22:39:25 +0000 Received: from localhost ([127.0.0.1]:38637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnuv-0007uL-J7 for submit@debbugs.gnu.org; Fri, 11 Mar 2022 17:39:25 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:49830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnut-0007uD-QV for 54260@debbugs.gnu.org; Fri, 11 Mar 2022 17:39:24 -0500 Received: from [172.20.10.5] ([188.188.45.72]) by albert.telenet-ops.be with bizsmtp id 5AfN270021ZSGwU06AfNAz; Fri, 11 Mar 2022 23:39:22 +0100 Message-ID: Subject: Re: [bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t from phases. From: Maxime Devos To: Simon South Date: Fri, 11 Mar 2022 23:39:21 +0100 In-Reply-To: <87czj073qt.fsf@simonsouth.net> References: <49559efd0d392df29393ac7441b83f14c2840b21.1646484354.git.simon@simonsouth.net> <87czj073qt.fsf@simonsouth.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ZZ654GTQ3TU7wp7i655l" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647038362; bh=+lZ/qQPk6lKpBbN3M4LxnlH/oJEUeCvaMbe9WFzxtS0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ZpAoAJjHZ1ZPVBRj+2Ao8d9UFmkEGrr19pQZKzH2Jm9xw5iyrxfbuVn4gE33zLMuQ wPh66r5Ftq+kY0AZfRZ13UY7ETDv2X9gFSJAJd0w7T7oUZgAJn8t9hz6Fo3Sfwnmca p1gQynIUgTBYh7ioKgIIIZ/K7hazdHViuy4xShOofPDlEVPuIQyple6chvrd+LNTzG shKysa828Lc3HWHgNMYn0SoWfdPRtZkdkleiVdv9OzA4LUgdUQQI75Aao1G8pQx+Sn poqkGe/2+sNb758HUc9/pB+CY51BIfQuR0P9y8dXuyBy1R+sU9sGrvLqybiMVB/7nB lMuZMU65n1drw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54260 Cc: 54260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-ZZ654GTQ3TU7wp7i655l Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Simon South schreef op za 05-03-2022 om 11:39 [-0500]: > This occurred to me, but is it not better in this case to rely on the > "output" parameter passed into the procedure?=C2=A0 Using "#$output" in t= his > context feels like a violation of the Law of Demeter, like using a > global variable where a local one would be appropriate. 'outputs' is an argument to the phase procedure, but as I understand it, it is only due to historical reasons (G-exps are relatively new- ish) and because the procedures in (guix build FOO-build-system) have no other method for determining the outputs. Might be a good idea to confirm with chief gexpologist ludo though. Greetings, Maxime. --=-ZZ654GTQ3TU7wp7i655l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYivPmRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qH1AP4i0eFy+IiOgu1QeJgzlCIcFfdk LgPdzXKJUAkOYmfoJwEA8o4NMWyuhuuJ3PLlZX9K++7cOXxwyiseMNZ4SHR2uwQ= =6QAj -----END PGP SIGNATURE----- --=-ZZ654GTQ3TU7wp7i655l-- From unknown Tue Aug 19 07:26:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 09 Apr 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator