GNU bug report logs - #54236
[PATCH] Two fixes for 'gexp->approximate-sexp', addressing some linter problems.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54236 in the body.
You can then email your comments to 54236 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH] Two fixes for 'gexp->approximate-sexp', addressing some
 linter problems.
Date: Thu, 03 Mar 2022 15:21:44 +0100

[Message part 1 (text/plain, inline)]

Hi guix,

Try "guix lint -c wrapper-inputs libaio".  You'll see a false positive.
The first patch fixes it.  This fix exposes another issue, causing
"guix lint -c wrapper-inputs hostapd" to backtrace.  The second patches
fixes that.

Greetings,
Maxime.

[0001-gexp-Correctly-handle-unquoting-S-exp-objects.patch (text/x-patch, attachment)]

[0002-gexp-Correctly-handle-output-in-gexp-approximate-sex.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 54236 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54236 <at> debbugs.gnu.org
Subject: Re: bug#54236: [PATCH] Two fixes for 'gexp->approximate-sexp',
 addressing some linter problems.
Date: Fri, 11 Mar 2022 23:22:48 +0100

Hello,

Both patches LGTM, except for…

Maxime Devos <maximedevos <at> telenet.be> skribis:

> From 2aae3582fec4ba6ca719eacaa61f17589b09755e Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos <at> telenet.be>
> Date: Thu, 3 Mar 2022 13:57:03 +0000
> Subject: [PATCH 1/2] gexp: Correctly handle unquoting S-exp objects.
>
> TODO before committing: fix the link to issues.guix.gnu.org in tests/gexp.scm.

… this TODO.  :-)

Is there an actual issue to refer to, or just this one?

Thanks,
Ludo’.

Message #11 received at 54236 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 54236 <at> debbugs.gnu.org
Subject: Re: bug#54236: [PATCH] Two fixes for 'gexp->approximate-sexp',
 addressing some linter problems.
Date: Fri, 11 Mar 2022 23:34:45 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès schreef op vr 11-03-2022 om 23:22 [+0100]:
> Is there an actual issue to refer to, or just this one?

Yes, it's a ‘self-referrent patch’.  This patch
<https://issues.guix.gnu.org/54236> refers to the corresponding issue
<https://issues.guix.gnu.org/54236>.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 54236-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54236-done <at> debbugs.gnu.org
Subject: Re: bug#54236: [PATCH] Two fixes for 'gexp->approximate-sexp',
 addressing some linter problems.
Date: Sun, 13 Mar 2022 23:20:37 +0100

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Ludovic Courtès schreef op vr 11-03-2022 om 23:22 [+0100]:
>> Is there an actual issue to refer to, or just this one?
>
> Yes, it's a ‘self-referrent patch’.  This patch
> <https://issues.guix.gnu.org/54236> refers to the corresponding issue
> <https://issues.guix.gnu.org/54236>.

Ah ah, got it.  :-)

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.