From unknown Sun Aug 10 11:50:31 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54225 <54225@debbugs.gnu.org> To: bug#54225 <54225@debbugs.gnu.org> Subject: Status: [PATCH] with-demoted-errors: Fix macroexp-warn-and-return call Reply-To: bug#54225 <54225@debbugs.gnu.org> Date: Sun, 10 Aug 2025 18:50:31 +0000 retitle 54225 [PATCH] with-demoted-errors: Fix macroexp-warn-and-return call reassign 54225 emacs submitter 54225 Kyle Meyer severity 54225 normal tag 54225 patch moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 02 22:01:00 2022 Received: (at submit) by debbugs.gnu.org; 3 Mar 2022 03:01:00 +0000 Received: from localhost ([127.0.0.1]:41104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPbi8-0006PI-9b for submit@debbugs.gnu.org; Wed, 02 Mar 2022 22:01:00 -0500 Received: from lists.gnu.org ([209.51.188.17]:51708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPbi6-0006PA-60 for submit@debbugs.gnu.org; Wed, 02 Mar 2022 22:00:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPbi5-0005AD-Uk for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2022 22:00:57 -0500 Received: from out2.migadu.com ([188.165.223.204]:26373) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPbi3-0001mI-TP for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2022 22:00:57 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1646276453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=PwC/zh02jtstImNErNQpx/0WvDm0QrVAlOqrOpJcS7A=; b=dBVThS+ga7S44dyydutBGPQcpV0QCYuY6uqJADrEFWZsBF1n/UJzkzENgjBQC34/nCaPvx nd11ZDWDfhxqW2kHEL+rZ09qTJ2T8rr2W+FvcztAUgJpPJWzjxeRIAXJlpC9REX8paNF4W z++0jqsDhhNOBsjNbT38tqglkTqP/GTdxtE45irz92FrjbsK6C/uL/6FoZotgj76t+qOBk e0yq3AdMKaJRb+dcYNj7x1xQVypH/5H5hgKDeWiPR2KdiHbjfNn5deC9fmNr+Kd8C6+EVu kl2c17WLIQ6McjJZAJ++xPLlJFIZrI0sKL3afFkPcelySJRTpDVcUz0Ed92wQw== From: Kyle Meyer To: bug-gnu-emacs@gnu.org Subject: [PATCH] with-demoted-errors: Fix macroexp-warn-and-return call Date: Wed, 2 Mar 2022 22:00:35 -0500 Message-Id: <20220303030035.570230-1-kyle@kyleam.com> MIME-Version: 1.0 X-Debbugs-CC: monnier@iro.umontreal.ca X-Debbugs-CC: lomov.vl@yandex.ru Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: kyleam.com Received-SPF: pass client-ip=188.165.223.204; envelope-from=kyle@kyleam.com; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) The macroexp-warn-and-return call added to with-demoted-errors in d52c929e31f (2022-02-04) is incorrect. The with-demoted-errors format string is passed as MSG, the actual message is passed as FORM, and the form is passed as CATEGORY, leading to with-demoted-errors returning "Missing format argument". * lisp/subr.el (with-demoted-errors): Call macroexp-warn-and-return with correct arguments. --- lisp/subr.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/subr.el b/lisp/subr.el index eb9af0b36da..7dde7589dd9 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -4560,7 +4560,7 @@ with-demoted-errors (if (eq orig-body body) exp ;; The use without `format' is obsolete, let's warn when we bump ;; into any such remaining uses. - (macroexp-warn-and-return format "Missing format argument" exp)))) + (macroexp-warn-and-return "Missing format argument" exp)))) (defmacro combine-after-change-calls (&rest body) "Execute BODY, but don't call the after-change functions till the end. base-commit: 543640628607ec06e9698cc50c33497ca75155a4 -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 09:36:23 2022 Received: (at 54225) by debbugs.gnu.org; 3 Mar 2022 14:36:23 +0000 Received: from localhost ([127.0.0.1]:41980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPmZ5-0007qQ-5G for submit@debbugs.gnu.org; Thu, 03 Mar 2022 09:36:23 -0500 Received: from quimby.gnus.org ([95.216.78.240]:41938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPmZ3-0007qC-2o for 54225@debbugs.gnu.org; Thu, 03 Mar 2022 09:36:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FaQ9AE8W1CmrOLYLjZ5GneG7KeYk3hghBL86EweBlgw=; b=TtHzgitar3MilqZwO9Wp0KFL6S oCctL6Rek/lb39RtaAeB/V68OlhBg/pNwaJ/PD+/VOGSTmrp5BztS6VRW7eLPlNYp+7IZW3QgDBYG XsLSTlSTuA9aXeBpjNRMh1EDxcAnsWIQakdbDbS4u1dfnC12V5AdHttsS2LWZrXZK3Cg=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPmYr-0000t5-IS; Thu, 03 Mar 2022 15:36:11 +0100 From: Lars Ingebrigtsen To: Kyle Meyer Subject: Re: bug#54225: [PATCH] with-demoted-errors: Fix macroexp-warn-and-return call References: <20220303030035.570230-1-kyle@kyleam.com> X-Now-Playing: Twinkle3's _Minor Planets_: "Ryugu 162173" Date: Thu, 03 Mar 2022 15:36:09 +0100 In-Reply-To: <20220303030035.570230-1-kyle@kyleam.com> (Kyle Meyer's message of "Wed, 2 Mar 2022 22:00:35 -0500") Message-ID: <87o82nhzmu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kyle Meyer writes: > The macroexp-warn-and-return call added to with-demoted-errors in > d52c929e31f (2022-02-04) is incorrect. The with-demoted-errors format > string is passed as MSG, the actual message is passed as F [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54225 Cc: 54225@debbugs.gnu.org, Stefan Monnier , lomov.vl@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Kyle Meyer writes: > The macroexp-warn-and-return call added to with-demoted-errors in > d52c929e31f (2022-02-04) is incorrect. The with-demoted-errors format > string is passed as MSG, the actual message is passed as FORM, and the > form is passed as CATEGORY, leading to with-demoted-errors returning > "Missing format argument". > > * lisp/subr.el (with-demoted-errors): Call macroexp-warn-and-return > with correct arguments. [...] > - (macroexp-warn-and-return format "Missing format argument" exp)))) > + (macroexp-warn-and-return "Missing format argument" exp)))) The code flow in with-demoted-errors is pretty confusing. Can it be improved upon instead of tweaked this way? (`format' here will be "Error: %S" at least in some cases, I guess?) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 09:36:38 2022 Received: (at control) by debbugs.gnu.org; 3 Mar 2022 14:36:38 +0000 Received: from localhost ([127.0.0.1]:41983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPmZK-0007qy-DW for submit@debbugs.gnu.org; Thu, 03 Mar 2022 09:36:38 -0500 Received: from quimby.gnus.org ([95.216.78.240]:41968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPmZI-0007qj-Ue for control@debbugs.gnu.org; Thu, 03 Mar 2022 09:36:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gg7Bx7M6l4rhiHOqWFNrLMQ+JuNP0haC17RajlPuAzQ=; b=JpgfXy45OKBqH4ChawrI2u//JN 93ly/MnXErWyiGytDoL2ia/Q4kDX59+PGIe18WvWl+IITlCPs4+9MiT6KhFecDWFOilzgonBq5+M7 sP5wMbcBcyPgoYUTebatBuRlB1Z8NevJBdJkg5D1Ri8EhRHj0ywbvDeOy7AZQYJcEoSc=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPmZ7-0000tT-H2 for control@debbugs.gnu.org; Thu, 03 Mar 2022 15:36:31 +0100 Date: Thu, 03 Mar 2022 15:36:25 +0100 Message-Id: <87mti7hzme.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #54225 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 54225 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 54225 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 10:14:15 2022 Received: (at 54225-done) by debbugs.gnu.org; 3 Mar 2022 15:14:15 +0000 Received: from localhost ([127.0.0.1]:43361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPn9j-0005Bm-JB for submit@debbugs.gnu.org; Thu, 03 Mar 2022 10:14:15 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPn9i-0005Ba-80 for 54225-done@debbugs.gnu.org; Thu, 03 Mar 2022 10:14:15 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3B783442960; Thu, 3 Mar 2022 10:14:08 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B23CF44295F; Thu, 3 Mar 2022 10:14:06 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1646320446; bh=PFzhrSP6zMQ4u777TTtF77Nu7FeOuCYS0/CXbuDQFCQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=jDarXuIWaOXdOwLV493gjv1lAjaTOkHu+ur7gvfbmwazjflr9R2gNFID1DBlhbSZe QQmTu4X4xL5muxZff9m30xDUSU1pgAed4ns4t5mzUiypTS67ck6SPfVGpet3dTkf1y apX+aDnxRmr4cZKJ31pKlSkAYQrtwTuxxX1UEWEh7CoPGgVfran3ZUrG7O8vaGiEhT XA+bIQp+xJ25qe+A/yxXS4dRj3whzm1tAzC9lOi4TyOwWKeYyPEeMf9Txl6EDeW8m2 ZIc8mMolVN8vNfEV82OseBbYyiojERcSYwwfCcKfwySZjj7GZTnbyxiN6sePJJMLqB HTwuw/mb0k//g== Received: from pastel (unknown [45.72.208.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 73B991203E5; Thu, 3 Mar 2022 10:14:06 -0500 (EST) From: Stefan Monnier To: Kyle Meyer Subject: Re: bug#54225: [PATCH] with-demoted-errors: Fix macroexp-warn-and-return call Message-ID: References: <20220303030035.570230-1-kyle@kyleam.com> Date: Thu, 03 Mar 2022 10:14:04 -0500 In-Reply-To: <20220303030035.570230-1-kyle@kyleam.com> (Kyle Meyer's message of "Wed, 2 Mar 2022 22:00:35 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54225-done Cc: lomov.vl@yandex.ru, 54225-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Kyle Meyer [2022-03-02 22:00:35] wrote: > The macroexp-warn-and-return call added to with-demoted-errors in > d52c929e31f (2022-02-04) is incorrect. The with-demoted-errors format > string is passed as MSG, the actual message is passed as FORM, and the > form is passed as CATEGORY, leading to with-demoted-errors returning > "Missing format argument". > > * lisp/subr.el (with-demoted-errors): Call macroexp-warn-and-return > with correct arguments. > --- > lisp/subr.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/subr.el b/lisp/subr.el > index eb9af0b36da..7dde7589dd9 100644 > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -4560,7 +4560,7 @@ with-demoted-errors > (if (eq orig-body body) exp > ;; The use without `format' is obsolete, let's warn when we bump > ;; into any such remaining uses. > - (macroexp-warn-and-return format "Missing format argument" exp)))) > + (macroexp-warn-and-return "Missing format argument" exp)))) > > (defmacro combine-after-change-calls (&rest body) > "Execute BODY, but don't call the after-change functions till the end. > > base-commit: 543640628607ec06e9698cc50c33497ca75155a4 Thanks. I used the patch below, instead. Stefan diff --git a/lisp/subr.el b/lisp/subr.el index eb9af0b36da..2321765f953 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -4560,7 +4560,7 @@ with-demoted-errors (if (eq orig-body body) exp ;; The use without `format' is obsolete, let's warn when we bump ;; into any such remaining uses. - (macroexp-warn-and-return format "Missing format argument" exp)))) + (macroexp-warn-and-return "Missing format argument" exp nil nil format)))) (defmacro combine-after-change-calls (&rest body) "Execute BODY, but don't call the after-change functions till the end. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 19:22:13 2022 Received: (at 54225) by debbugs.gnu.org; 4 Mar 2022 00:22:13 +0000 Received: from localhost ([127.0.0.1]:44197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPvi1-000340-8v for submit@debbugs.gnu.org; Thu, 03 Mar 2022 19:22:13 -0500 Received: from mout.web.de ([217.72.192.78]:52157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPvhz-00033e-Hm for 54225@debbugs.gnu.org; Thu, 03 Mar 2022 19:22:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1646353320; bh=JQPukCGUv9Fse6AgZjLShNJdvpL5Qco/wQud6kPLYBI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=arMWgABFJM0LzRRsdHdh7YXo2uXeEuQgQ3TNUf8RJVKr6vm5UdEK64Ssw9QAKjkTE BLVmMTR8o4hFO8groucOPElT+x2aqA+L1lkH8AbA14L8s/4twEG7r6MTL50UnAkD1S tXltcWOlr8UjlzZ42q4jdcQXtNvSFDlPEjwWtaMg= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N30dT-1oB36T20jN-013Bim; Fri, 04 Mar 2022 01:22:00 +0100 From: Michael Heerdegen To: Lars Ingebrigtsen Subject: Re: bug#54225: [PATCH] with-demoted-errors: Fix macroexp-warn-and-return call References: <20220303030035.570230-1-kyle@kyleam.com> <87o82nhzmu.fsf@gnus.org> Date: Fri, 04 Mar 2022 01:21:58 +0100 In-Reply-To: <87o82nhzmu.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 03 Mar 2022 15:36:09 +0100") Message-ID: <87ee3ipnx5.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ON2CHgEkbOMQwQolcvV6Uo8xAC2FcuyheJEPsSWlG/5G4RTmCwG cGgtBO4j3E5z0TAFLrIl55d9rOoaEwxlWWzsbS+FuRb4iyuBBcQvTaHX8DD4xVUXflbXukr OiIscs9HnF7eK+Ow4DIUTe7hI2ek+yAxtRYOO4hiNSmmqxykFYToMji6j2ZYQR/hewK5u5N rE1TyMzajhZ2pHc1HRcDw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:nPsfawC4nPg=:M6wMzsPYhFwMq6mcvUo5nz 8OAMjJFYNwHad2csG+mi7XB7yOocNdC7fmSAy2XTc5yHdf+4oc5HGhfSgHp7fTZjYb0UDnlKp EuJHOhqtopUtqna6+1KCCSNNAKwhDAGPK17J8CSyJLJg+FV3Yczp0021ZodSZpF7P9TTSuBNG idy+8dBUZcz3w8KtOxO41xB8kYkgfU439hZ7ACutRlqqqKGazJmA1iMA/Jpqp0GtOqF85n88h JiLMLfXU2ewgxzN/zIKCkXfDcwlkJ2g3YcQrMWvqNDbHNn4T13PGP9x7FVN+UtjBJaWQSdzoY G4w9gpN5RPcl/AqLwrWOR/zACanz9IWreyZLU8kjuQzWcx4auKfrQ/jL4f538wEt79A/+Tpih mk7yTzmauGAwmVxSkLB/uOZBU8mOaQL6zWDLPpC/dbFY2p+Y38Gw1TIggEEdwJcZGRoj9TQ7a R05iw4uhysA7iTOO8z0+CXri4E54TwSAo8nGVtPSXLEdzJnPgWS2HwCY58V11SdD6YEVej93w 4kG5iKc651TEbUJAEokzHhFckGAIbnHON0hdScNEUZeSdLlvsB/F8k9EtbR2PXtZ02MOeGIt7 y+hcbCzIGEFR/QPp/tuaU1ulUsk/Q09YvuCfY2wNNClfp0kGQbe+8VnzYdcl1Lr+xFBdgAs3e jdQRuC8QE0BBrwFT4CME2HZzgJ784JDEiR0zj/G76bXpcvCSPBMEZXkGTYyt0zTuuxH5D8rNN odLj7O3mSezg/AAqWlwAeH0Zl5aBFatfOwi/0M9MTPThkA+VvsbhEY1axNmeyj5bMvfIXgaNU NkrKGZXQ3otQqy2QARlCE67quiRT6COzDVG7ID/8bSoy+JWGJtOR0t0c/waZvKIgvRM54udj0 QtDKeHYz6HX3SwkAXBJkJn39MkiP501Box1STC+5I+dshI5dVQZKxPXjWkL+kFY38xjsLjmm0 lKCoAT/0jFso1iEOBg+uqMgaVt/l+4WN+FiIYbxhxzM6uNcguLWNkPQj8k0j2izzhb/BDtoln PtXTRJ7ET9rJ8BwjWm8iHWAurtq+sQ5cDWFz6LI4Tc2ndXeuPWKKloYobnz0TgbyyShsvQDZR CieN1DUdek6lug= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54225 Cc: Kyle Meyer , 54225@debbugs.gnu.org, Stefan Monnier , lomov.vl@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > The code flow in with-demoted-errors is pretty confusing. Can it be > improved upon instead of tweaked this way? Yesterday I dealt with that, and I think I understood most parts: the code is a bit ugly but necessarily because the semantics are (also necessarily due to backwards compatibility). The cases to be supported are: - FORMAT is a string (and BODY not empty) - the expected use case - FORMAT is nil: that's equivalent to FORMAT being "Error: %S" - Anything else: also use the above default format string but additionally add that sexp to the BODY since it's expected to be code (backwards compatibility). It works but you get a warning. Once the third case will not be supported any more the code can be made much simpler. Michael. From unknown Sun Aug 10 11:50:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 01 Apr 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator