From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 01 08:49:48 2022 Received: (at submit) by debbugs.gnu.org; 1 Mar 2022 13:49:48 +0000 Received: from localhost ([127.0.0.1]:35883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP2sr-0002ph-2y for submit@debbugs.gnu.org; Tue, 01 Mar 2022 08:49:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:58912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP21t-0001R8-El for submit@debbugs.gnu.org; Tue, 01 Mar 2022 07:55:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nP21t-0001iF-58 for bug-gnu-emacs@gnu.org; Tue, 01 Mar 2022 07:55:01 -0500 Received: from plesklin7.if1.ehiweb.it ([79.98.45.16]:56407) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nP21n-0003rD-Ai for bug-gnu-emacs@gnu.org; Tue, 01 Mar 2022 07:54:56 -0500 Received: from tucano.isti.cnr.it (tucano.isti.cnr.it [146.48.81.102]) by plesklin7.if1.ehiweb.it (Postfix) with ESMTPSA id 51F661039EC for ; Tue, 1 Mar 2022 13:54:48 +0100 (CET) Received: from pot by tucano.isti.cnr.it with local (Exim 4.95) (envelope-from ) id 1nP21g-00GbQl-3r for bug-gnu-emacs@gnu.org; Tue, 01 Mar 2022 13:54:48 +0100 From: =?utf-8?Q?Francesco_Potort=C3=AC?= Date: Tue, 01 Mar 2022 13:54:47 +0100 To: bug-gnu-emacs@gnu.org Subject: 27.1; appt-add checks for bad data only at end X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-Id: X-PPP-Message-ID: <20220301125448.20356.14515@plesklin7.if1.ehiweb.it> X-PPP-Vhost: potorti.it Received-SPF: pass client-ip=79.98.45.16; envelope-from=pot@potorti.it; helo=plesklin7.if1.ehiweb.it X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 01 Mar 2022 08:49:43 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) appt-add asks the user for three parameters: - time (a time string) - message (a string) - minutes (a number) if the time string is badly formatted (for example if it is "8" rather than "8.00") appt-add barfs. That's ok, but it barfs only after all three parameters have been read. It should barf immediately after submitting the wrong parameter. Maybe I'll find the time to look at it and propose a patch, but since I don't know, I prefer reporting it now. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 01 09:22:07 2022 Received: (at 54210) by debbugs.gnu.org; 1 Mar 2022 14:22:07 +0000 Received: from localhost ([127.0.0.1]:35911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP3OB-0003cM-9O for submit@debbugs.gnu.org; Tue, 01 Mar 2022 09:22:07 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:45024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP3O9-0003bq-9N for 54210@debbugs.gnu.org; Tue, 01 Mar 2022 09:22:05 -0500 Received: by mail-wr1-f52.google.com with SMTP id u1so20747643wrg.11 for <54210@debbugs.gnu.org>; Tue, 01 Mar 2022 06:22:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=u5q7y1HGNzC6EVPjoMo1LIObaqGd/WBsZVHpo2R6jQc=; b=o2mEoHKSl6NY1ZJc/3mFPfjX8+DsgKh/RcQG62PbRviemZ1AB6bgeN5unYYj6/oT7q fd9oRoiKi9QPxaKPCIfc6X9FHPep6CwBpHAlZA1S/4Fg1TrwSnpQkdPVBWOlhsXVKCoi +QLLqGf20gKlrZLrgB21I3Pmi5iiV80JL+l6O1wZeq7ti9t44mG6drEh5GkRfwT+Oy3B N1GiuiGyMCxosCcwvn4U/0yGpARSCLy78acUEqHh2d5YOBDRLy9/LPI/DZAGRqwLM9w/ L7Dfuejf2PcO6Y38ef+0vlVGyobjgzCCJjbiGWCWRdpNMTi0kujbADdbPAJey4r8gWnQ 7h3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=u5q7y1HGNzC6EVPjoMo1LIObaqGd/WBsZVHpo2R6jQc=; b=zKivARcijNOSGPxfIOCA6mbKxmQ8HvmoiqNYuZQpvfmtrST1ONKUzp5/JMhDIb8Q4v B/bRf0/2/IvYrXf22f5zIYhe1LGWBu2ZSVPiOtwXHvsJQ+sdIQK6Jiw02XbDz/Cz2JqF trvVjwtbt6YjgEMBqTrNzdemyCJn5QH2MEh2ihdbSNRFBdHmzpW4ngcaxd2yG9RCk/F9 gI+s9aELOv9keyWkhePEX13j4hMi6ZhGpS+zEogZ8uNwebnjHdaCs5h1IZfTtN/xdckm 0ltg9tPqA79d6asBKOvD0wnOEbM2tyyqEdT9LLe7iA1CU5o8+0X2SU054CLgAomZfKzo S/Lg== X-Gm-Message-State: AOAM531EyjfiuHZy/weOP+KMT6kaeOB7CS7B0NXqgaPRPXegbESF2yvI G1BhbMoS7GOrqgv3jZyq99FPW3S7I+0= X-Google-Smtp-Source: ABdhPJxR+doC10lv3IYrIfGPzHExHcZK6res1YAbUyg1XTay2uM+WdK6OQh/HQtBaJM0VpTERSUTaQ== X-Received: by 2002:adf:db82:0:b0:1ed:bf4b:e327 with SMTP id u2-20020adfdb82000000b001edbf4be327mr19598627wri.527.1646144519063; Tue, 01 Mar 2022 06:21:59 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:70ae:2afb:87fc:d65c]) by smtp.gmail.com with ESMTPSA id b9-20020a5d45c9000000b001ef9200b856sm9377473wrs.115.2022.03.01.06.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 06:21:58 -0800 (PST) From: Robert Pluim To: Francesco =?utf-8?Q?Potort=C3=AC?= Subject: Re: bug#54210: 27.1; appt-add checks for bad data only at end References: Date: Tue, 01 Mar 2022 15:21:57 +0100 In-Reply-To: ("Francesco =?utf-8?Q?Potort=C3=AC=22's?= message of "Tue, 01 Mar 2022 13:54:47 +0100") Message-ID: <87v8wxiwhm.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54210 Cc: 54210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 01 Mar 2022 13:54:47 +0100, Francesco Potort=C3=AC said: Francesco> appt-add asks the user for three parameters: Francesco> - time (a time string) Francesco> - message (a string) Francesco> - minutes (a number) Francesco> if the time string is badly formatted (for example if it is = "8" rather Francesco> than "8.00") appt-add barfs. That's ok, but it barfs only a= fter all Francesco> three parameters have been read. It should barf immediately= after Francesco> submitting the wrong parameter. Francesco> Maybe I'll find the time to look at it and propose a patch, = but since Francesco> I don't know, I prefer reporting it now. Aha, a learning opportunity (for me :-) ) How about this (I can=CA=BCt find a `read-time-of-day', unless org has one = hidden away somewhere): diff --git a/lisp/calendar/appt.el b/lisp/calendar/appt.el index ebdafb438e..6a3ea7c356 100644 --- a/lisp/calendar/appt.el +++ b/lisp/calendar/appt.el @@ -510,10 +510,12 @@ appt-add Optional argument WARNTIME is an integer (or string) giving the number of minutes before the appointment at which to start warning. The default is `appt-message-warning-time'." - (interactive "sTime (hh:mm[am/pm]): \nsMessage: \n\ -sMinutes before the appointment to start warning: ") - (unless (string-match appt-time-regexp time) - (user-error "Unacceptable time-string")) + (interactive (list (let ((time (read-string "Time (hh:mm[am/pm]): "))) + (unless (string-match appt-time-regexp time) + (user-error "Unacceptable time-string")) + time) + (read-string "Message: ") + (read-string "Minutes before the appointment to start= warning: "))) (and (stringp warntime) (setq warntime (unless (string-equal warntime "") (string-to-number warntime)))) From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 01 09:40:54 2022 Received: (at 54210) by debbugs.gnu.org; 1 Mar 2022 14:40:54 +0000 Received: from localhost ([127.0.0.1]:35932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP3gM-000444-GH for submit@debbugs.gnu.org; Tue, 01 Mar 2022 09:40:54 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:45802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP3gK-00043r-Sf for 54210@debbugs.gnu.org; Tue, 01 Mar 2022 09:40:53 -0500 Received: by mail-wr1-f50.google.com with SMTP id p9so20835128wra.12 for <54210@debbugs.gnu.org>; Tue, 01 Mar 2022 06:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=4NHzPcDnXXAxZwdrVVWS4cmpSIQuty48ErzASSGFlS4=; b=Ub3D48G4sAvBsH4pPbfGMupcr+yLN+l7/6SS3LfyXFOhu4gchmrxHiG3jttpNGeigd im6FMjL31K38vnxwTSjt0RFN9SbbfX0zGRc6vXiEI2IjfAc2A9J8Xbc3RBLuJ+5RyMF/ l99hSCb+Ho4EYA15FlsAD6w/eYZdHjACvUDHT5RIdYsxYUNWhTeVwsxPycvU7gMqM7FN tYWf7sBwTt2Czldjqdqf9rgWqXsVuPD8vsWsS7rC9fuPwIKw9DCyOrBMTWrL+1YFEJ9F 5i3D57XNXje5IMNKoo0kxt+sRZ0KsFGlZJLVdG+RdIJyiAjWlrkWCwDMohWV3JwpAcQU EJ5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=4NHzPcDnXXAxZwdrVVWS4cmpSIQuty48ErzASSGFlS4=; b=dwPVNF5h7w8lR3P9EP4sBgFv+mUF1tB3J/YKB8xu8uceoxRSrKwb7btGyiphcoBANR zcBJIRh06Y2jSsoIi/oOnAFxrhjkoGe4AdhH6pfZlfKfnuGWUnwJ5ciErJudYUZ6jvsw c8AYwH70MMEO/PxXVRYq0mU6LKq4VjRtZ+FiyQdfvswXam0yxziSwc79YF/KsiceEjw7 ArvAAzE1W/wP8v5tU/Ur2UwaK5HgRE46jF1KvODZkXG8Wj8470KZe8xzZejXDXK+zoDn UhWMwXmp5Cm6bPPpDs3w83yS6j6TjoDMYSz6uTJgbI4wvieNRJV6UpfOvam6FBBIKBxG zrrA== X-Gm-Message-State: AOAM533+cJh8p2JkP2ZqaieSLuecE7mrJWUSXb+xq6VMHrJhmXGd+wqr qRDC3Wpr9CEay/Glngzzz5Se7bz5Nzo= X-Google-Smtp-Source: ABdhPJyJn2F6nFzPFj65ISuiMEtdDuQHk6GLCvb7w2o8iRbibVC84oEdAs4hCkYenPjN1c/S3Ooseg== X-Received: by 2002:adf:df0a:0:b0:1f0:2140:1b41 with SMTP id y10-20020adfdf0a000000b001f021401b41mr1632143wrl.94.1646145646803; Tue, 01 Mar 2022 06:40:46 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:70ae:2afb:87fc:d65c]) by smtp.gmail.com with ESMTPSA id b10-20020a5d550a000000b001e30e81afd1sm13885697wrv.2.2022.03.01.06.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 06:40:46 -0800 (PST) From: Robert Pluim To: Francesco =?utf-8?Q?Potort=C3=AC?= Subject: Re: bug#54210: 27.1; appt-add checks for bad data only at end References: <87v8wxiwhm.fsf@gmail.com> Date: Tue, 01 Mar 2022 15:40:45 +0100 In-Reply-To: ("Francesco =?utf-8?Q?Potort=C3=AC=22's?= message of "Tue, 01 Mar 2022 15:31:32 +0100") Message-ID: <87r17livma.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54210 Cc: 54210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 01 Mar 2022 15:31:32 +0100, Francesco Potort=C3=AC said: Francesco> It works for me! OK, I=CA=BCll queue it up (although I=CA=BCm running at about one push a we= ek at the moment, so don=CA=BCt hold your breath). Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 01 10:50:50 2022 Received: (at 54210) by debbugs.gnu.org; 1 Mar 2022 15:50:50 +0000 Received: from localhost ([127.0.0.1]:38062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP4m1-0006ee-Jw for submit@debbugs.gnu.org; Tue, 01 Mar 2022 10:50:50 -0500 Received: from plesklin7.if1.ehiweb.it ([79.98.45.16]:42833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP3XM-0003pu-Py for 54210@debbugs.gnu.org; Tue, 01 Mar 2022 09:31:37 -0500 Received: from tucano.isti.cnr.it (tucano.isti.cnr.it [146.48.81.102]) by plesklin7.if1.ehiweb.it (Postfix) with ESMTPSA id 0A362104445; Tue, 1 Mar 2022 15:31:33 +0100 (CET) Received: from pot by tucano.isti.cnr.it with local (Exim 4.95) (envelope-from ) id 1nP3XI-00GeXp-Qw; Tue, 01 Mar 2022 15:31:32 +0100 From: =?utf-8?Q?Francesco_Potort=C3=AC?= Date: Tue, 01 Mar 2022 15:31:32 +0100 To: Robert Pluim In-Reply-To: <87v8wxiwhm.fsf@gmail.com> (rpluim@gmail.com) Subject: Re: bug#54210: 27.1; appt-add checks for bad data only at end References: <87v8wxiwhm.fsf@gmail.com> X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-Id: X-PPP-Message-ID: <20220301143133.32138.63763@plesklin7.if1.ehiweb.it> X-PPP-Vhost: potorti.it X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54210 X-Mailman-Approved-At: Tue, 01 Mar 2022 10:50:48 -0500 Cc: 54210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>>> On Tue, 01 Mar 2022 13:54:47 +0100, Francesco Potortì said: > Francesco> appt-add asks the user for three parameters: > Francesco> - time (a time string) > Francesco> - message (a string) > Francesco> - minutes (a number) > > Francesco> if the time string is badly formatted (for example if it is "8" rather > Francesco> than "8.00") appt-add barfs. That's ok, but it barfs only after all > Francesco> three parameters have been read. It should barf immediately after > Francesco> submitting the wrong parameter. > > Francesco> Maybe I'll find the time to look at it and propose a patch, but since > Francesco> I don't know, I prefer reporting it now. > >Aha, a learning opportunity (for me :-) ) > >How about this (I canʼt find a `read-time-of-day', unless org has one hidden >away somewhere): > >diff --git a/lisp/calendar/appt.el b/lisp/calendar/appt.el >index ebdafb438e..6a3ea7c356 100644 >--- a/lisp/calendar/appt.el >+++ b/lisp/calendar/appt.el >@@ -510,10 +510,12 @@ appt-add > Optional argument WARNTIME is an integer (or string) giving the number > of minutes before the appointment at which to start warning. > The default is `appt-message-warning-time'." >- (interactive "sTime (hh:mm[am/pm]): \nsMessage: \n\ >-sMinutes before the appointment to start warning: ") >- (unless (string-match appt-time-regexp time) >- (user-error "Unacceptable time-string")) >+ (interactive (list (let ((time (read-string "Time (hh:mm[am/pm]): "))) >+ (unless (string-match appt-time-regexp time) >+ (user-error "Unacceptable time-string")) >+ time) >+ (read-string "Message: ") >+ (read-string "Minutes before the appointment to start warning: "))) > (and (stringp warntime) > (setq warntime (unless (string-equal warntime "") > (string-to-number warntime)))) > It works for me! From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 18:59:13 2022 Received: (at 54210) by debbugs.gnu.org; 3 Mar 2022 23:59:13 +0000 Received: from localhost ([127.0.0.1]:44185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPvLl-0002W1-Dl for submit@debbugs.gnu.org; Thu, 03 Mar 2022 18:59:13 -0500 Received: from mout.web.de ([217.72.192.78]:55381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPvLj-0002Vo-9L for 54210@debbugs.gnu.org; Thu, 03 Mar 2022 18:59:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1646351943; bh=raKJNc0+gIk+Bh/fXGe/fi1CRW4lcmnY17DatCdpuuA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Y/6ijZEQ1zhK8Bp51SJ7MCyAyd7p19awA96e+v8pH536vVSeuemQqMHebKURksXOo fUW9L3B5JlhnUFTHe0N0GPoYG7DNn4G0WOFxbU0x0QtKDN+HydcFPPg8bX9gDNzdoI bE3dvOZyeljmUkHFDZU6zDo0IjsvUtS2wGWsHtlY= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MN6Fj-1niH9149wr-00JAdB; Fri, 04 Mar 2022 00:59:03 +0100 From: Michael Heerdegen To: Robert Pluim Subject: Re: bug#54210: 27.1; appt-add checks for bad data only at end References: <87v8wxiwhm.fsf@gmail.com> Date: Fri, 04 Mar 2022 00:59:02 +0100 In-Reply-To: <87v8wxiwhm.fsf@gmail.com> (Robert Pluim's message of "Tue, 01 Mar 2022 15:21:57 +0100") Message-ID: <87ilsupozd.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:cWaK/v2TyhCdF7zV8allMkV+hYvotdog5ssLxebKhTIWJtmFByH /Kl6ntGWvLnggC27kHdD5rUEQUABbx9lOPQdxD5xandZzRigCZL8rLXOfi7aGtcs0dQ9xiF 1vPtpyxwXG8yGQkzfWSEzetfaxR809q4bTMg4R3RSaqt925HpTRCxyWiHMhCWSxeGTGQJev KBYtM9BZ68a5yiQUw+PRg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:GH8CoHrqFzQ=:hJPFX/+pIxraVs6FgvRNct S0YE8oXGwc2lPv8cJiz8LtPiCf1P/e4q71u3WgI/Yim5ZQDVJRgHeVnaZYhGZs7erxs00xJAm 5rePLizU6ZiklLuuaVZkbrmfUtpemgnlyTRvHXzZOsTGZfzeQedRw7Mz2Kgzl5iteULWko5eW I/SbQ9bQrl+Sf+/6hSMDN+T2mC22OzWBfJ/88hfE3IJaZxayohw56JFR2QxxnenzMBHWVgu7z rolkD5W8ATzlTnWVqhEPeadftw8aO1IOC7r0vUmzEe+tF2KCUoG+A9bmGi5/FodCKGVEJqvc3 BCr5BxiB21OHJgVi89H/0+2v1buUq8rr5TECVNidE8kdsdd501yP+oq9f5fbufgXON81InVmq 1WIPCRN9pycMuVgWbftJWKbt4IPYFLliVpMALHOKoOdcG79Mbwk+GW4mzWLqo82YFEf0cLt35 KX+nI05sv75hZUZsaI9LWVvrYGpr9paLkWHuDwtvQVbC0HKLGzyAfkm2LIeu5TdectP8Wd985 4jO3MX4oY5rWnVJDcqeVhtvKvN24d0GObvyd7kyoerYImHyw5Wd/3QuAI6YkRgyPJ5JyzrAK5 y6mFvmEbyLGLxqYPjACyZvIuJ5fU0G6nL4cJpV4PUw/u7hevPRlPD7NT4sruVMWXUfFbJLmLC jJPiyv18QK6AJ0EUk9YrpoSPHieskaG3NOMBlzDSAFFOmEbXbbAmHfDGYJc6QZ9SWLLnhJ7yD zVT2Lxy8VE5U4J5ULjgKFqpascntl+1HXB62u6k7gbwqWaLkhkH3uu0QObToNdBECaxWfuywm RBwafpJedBoqyxnSocMyWt6IjDt7Dnn/P/cNFXoLL7pbu74bFxdMXkTEJUblyCy9llhdjKkqE Xzm3nI89yzoDPG1ZtXT35thGLaWXrlu/E8TMUkC+R/9cSZ3iVgQPWp/AvmtnGhoxWDfACB/Jz gYM7lyUPxu/a3aA1m2FiQrK7wfeNW0jS4eO0Yu18UrvlA6Z3iieYYmg6NEhldVNoGpL/8UPqv P6k5VhsPq8vgaPAZtdvTWwMmDkbP1T5//4JSUFD6psSdNUyrV25pQU7y2GjOHcS0EG5Je6zK9 F3ToRHof1U7S1E= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54210 Cc: Francesco =?utf-8?Q?Potort=C3=AC?= , 54210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Robert Pluim writes: > How about this (I can=CA=BCt find a `read-time-of-day', unless org has on= e hidden > away somewhere): Doesn't look wrong to me. > + (unless (string-match appt-time-regexp time) > + (user-error "Unacceptable time-string")) I know you just more or less copied that code from the body, but I think this can be made a `string-match-p' test. I think that code is just older than the existence of `string-match-p'. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 05 12:12:02 2022 Received: (at 54210) by debbugs.gnu.org; 5 Apr 2022 16:12:02 +0000 Received: from localhost ([127.0.0.1]:55932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nblmk-0005hv-1Q for submit@debbugs.gnu.org; Tue, 05 Apr 2022 12:12:02 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:44840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nblmi-0005hU-Fp; Tue, 05 Apr 2022 12:12:01 -0400 Received: by mail-wr1-f44.google.com with SMTP id b19so20051911wrh.11; Tue, 05 Apr 2022 09:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=Ig6apUGdK3DozBDjqNIEC9KpE1A5Ljh24FhGH/4Ckxg=; b=hRkKYRGyV8YooKoRGbtHgEO05gAEvbCtpkKEC+f5Ruve//pYUfoGjyI2WKmFOXtNr1 4i7N0GnKvSk8X5NCj8693Z7nr7etpH8LJb4Ha15s+qluPFHlVlVs7/eFw0AaeEDi9gwn 5QROeReMGF9VwG9lrFrDFQ43e1rnxfY4FZ0Qpq3ZIzaa3TGZlFUGWPtR7FVnWp6lri9l 6m1JSDGYOKDTZbOFfSCzu2cDPV9Vh+ZB5Zmqr3jQIBAqkVtT7+1dvMzTthUBL6RDb6lb hekDOiy7ki20CJEKdH/m1eX4mm8GxFnGzlz5fjylJxz+XfjHTw+OepkJG7OkOcb1Wsmp GHwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=Ig6apUGdK3DozBDjqNIEC9KpE1A5Ljh24FhGH/4Ckxg=; b=PS5L6VHvBWUU2d0PA11jkMqfH7116gDOIO2NBZtJr8NpJl7nubjonlMttFx78VKR8v CGgThJsLdAQ1hUqmWZyEUqtegEzfG9mMPpklw72syGmt9IN+WJWFyNRvTcL9TbOVmR70 sWswJUxtxKza8rDq5F5BJvc0L9X6hFzXAK/G3Kmyol/C2Y7GSnHXYiLB2mjZJCWhOWlp s6dnaWKM3krjye3Bb5KYdR3dPsmRAmzgE9InOaokCGCflbLOypbOZ/gPozQmAJvJsuTe 6rddwxIm16PIGOKCUfE/cbv7E1SfJvZUT+e1wvn/xIobL5FsMQvJ3EufOGusJCVK+aGM nGDA== X-Gm-Message-State: AOAM532ndqJCWoSpZae9/SfNuUIvFnEgfcH2WgdIwom1gHIQN0jLdsD+ FstGjr6Y41hfosmv+wAtg/UFC0i/jIM= X-Google-Smtp-Source: ABdhPJwAqP8iKIuOZ4gfETRSHH110ueaPbkZS31UfDzY6/XaJSchxDSJ/co/8XGvF7VcJxDpf4GN4A== X-Received: by 2002:a05:6000:1549:b0:203:f11a:ac4c with SMTP id 9-20020a056000154900b00203f11aac4cmr3197271wry.233.1649175114297; Tue, 05 Apr 2022 09:11:54 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:f97:ff71:7e0d:55c6]) by smtp.gmail.com with ESMTPSA id g16-20020a05600c4ed000b0038ceb0b21b4sm3205347wmq.24.2022.04.05.09.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 09:11:53 -0700 (PDT) From: Robert Pluim To: Francesco =?utf-8?Q?Potort=C3=AC?= Subject: Re: bug#54210: 27.1; appt-add checks for bad data only at end References: <87v8wxiwhm.fsf@gmail.com> <87r17livma.fsf@gmail.com> Date: Tue, 05 Apr 2022 18:11:52 +0200 In-Reply-To: <87r17livma.fsf@gmail.com> (Robert Pluim's message of "Tue, 01 Mar 2022 15:40:45 +0100") Message-ID: <87y20j5x2v.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54210 Cc: 54210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 54210 fixed close 54210 29.1 quit >>>>> On Tue, 01 Mar 2022 15:40:45 +0100, Robert Pluim s= aid: >>>>> On Tue, 01 Mar 2022 15:31:32 +0100, Francesco Potort=C3=AC said: Francesco> It works for me! Robert> OK, I=CA=BCll queue it up (although I=CA=BCm running at about o= ne push a week at Robert> the moment, so don=CA=BCt hold your breath). Closing. Committed as 0e9420bc8f From unknown Sat Jun 14 14:26:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 May 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator