Subject: Re: [bug#54207] [PATCH] gnu: shepherd: Convert to build from git instead of a release.

From: Maxime Devos <[email-masked]>
Date: Tue, 01 Mar 2022 11:18:59 +0100

Attila Lendvai schreef op di 01-03-2022 om 09:59 [+0100]:
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://git.savannah.gnu.org/git/shepherd.git/")
> +             (commit (string-append "v" version))))

Perhaps add a comment about why it a git origin is used
and autoconf & friends are in native-inputs?

  ;; Build from git and add Autotools inputs, to make developing
  ;; the shepherd easier

Also, to avoid having to go through staging for adding a feature
to the shepherd to use in Guix, WDYT of defining a package variant
of shepherd for use in Guix, and modifying the default Guix in
'shepherd-configuration' appropriately?

(define-public shepherd-for-guix
  (let ((commit ...)
        (revision ...))
    (package
      (inherit shepherd)
      (source [the git origin])
      (version (git-version ...))
      (native-inputs
        (modify-inputs (package-inputs shepherd)
          (prepend [autotools packages])))
      (description [a package variant for use in Guix]))))

Greetings,
Maxime.