GNU bug report logs - #54190
29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes

Previous Next

Full log

Message #29 received at 54190 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: larsi <at> gnus.org, 54190 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for
 some Eshell "$" syntaxes
Date: Thu, 3 Mar 2022 21:55:41 -0800

[Message part 1 (text/plain, inline)]

On 3/1/2022 5:10 AM, Eli Zaretskii wrote:
> Thanks, installed on the emacs-28 branch.  (But the markup in the
> manual part was wrong; see my followup changes.)

Thanks for fixing that up.

> Fine with me.  It's up to you whether to close this bug or leave it
> open until a better solution is found for master.

After a bit of looking at the `eshell-do-eval' implementation, I 
realized that there's a better solution that's very simple. See the 
attached patch. It's simple enough that it might be fine for Emacs 28, 
but the existing change on the 28 branch is probably a bit safer, since 
that change was just a partial revert. I'm not aware of anything that 
could be broken by this new patch, but you never know...

This doesn't do anything more elaborate like using generator.el's 
machinery here; while (I think) that would be nice to have eventually, 
we can address that in a separate bug, since it'd be a pretty big 
change. We could probably close this bug after this new patch merges.

[0001-Fix-Eshell-s-command-forms-in-a-better-way.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.