From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 27 16:34:35 2022 Received: (at submit) by debbugs.gnu.org; 27 Feb 2022 21:34:35 +0000 Received: from localhost ([127.0.0.1]:59415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nORBb-0008OI-9c for submit@debbugs.gnu.org; Sun, 27 Feb 2022 16:34:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:53446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nORBZ-0008OA-8h for submit@debbugs.gnu.org; Sun, 27 Feb 2022 16:34:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nORBZ-0003D5-31 for bug-gnu-emacs@gnu.org; Sun, 27 Feb 2022 16:34:33 -0500 Received: from [2607:f8b0:4864:20::434] (port=33712 helo=mail-pf1-x434.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nORBW-00062z-5P for bug-gnu-emacs@gnu.org; Sun, 27 Feb 2022 16:34:31 -0500 Received: by mail-pf1-x434.google.com with SMTP id d17so9351215pfl.0 for ; Sun, 27 Feb 2022 13:34:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:message-id:date:mime-version:content-language; bh=nKjQbQq5mtozgCkmYKY5yU7iVfuSgNjoPGVz7aqk+lw=; b=PfA6Pvs8+0t53wnFQn7KyTCu0D+z0ZgvEKu0ovalbrDvtWZxHGGLetWUcd6YaqAQKD SzUXfkCBdwwZ4Sf9jpWBTnQVGGucc1/E3fAj3Widzzlq5JPP++SIb934Ee1Gb7EtNixY Yt8ct5RP289nrzYmY+OVO0aIqCu/mdLrWpxOdJUuqJ3R64dSvNigAKrg+3MlWy/5kOBX nzEaxRakpv3QjspxktVAdkwFZJLsMkFtnT+JcZgluM06F8axJBiT3H6NftlZkL0Fqs4X AOZLKwFx+LrgdYDorJhOiJHP/JbWfqEnCovcXHVe/VLSonp7ZgySYP19iBdidKm9PqpG ukag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:message-id:date:mime-version :content-language; bh=nKjQbQq5mtozgCkmYKY5yU7iVfuSgNjoPGVz7aqk+lw=; b=HfjZWSAUCDoEL/LVcBWtNv4svpnt0yqEfIK3GbO3HbzHWmeu8Cfs53OuBrtOs+EjRG AIQplxNRY3EayMK+jOG9PaVkJm2GSxGyJPhY4d0//kDHfCG12nFb0bS86GJmPcDB3m/Y mzceZYUxz9WBng4iiEl3WqO2CSc8V8/DAyimIhJZ6Yk7rCbeuWyos51jpDzGs0G+XE9a nXwWVgoZEkqy/UoXUInZPMf+A54cvN0yhuGbYqR4cAQhh4WxE0yO+Z3ffUe3+ULAY49z 522VBiqxRMn8KA8YAk6xOgCDbz40Ou0O/D6C/tT1rp3GbI7S8y7oAjfjQKbaKM+A7YgE iStw== X-Gm-Message-State: AOAM530DrwBkdkT3ptl8Nfcx25+nYw1W3XBXQ3L4HFJ8egHwbaB/Pkfh t+kkGAtM/Wx/sdXpmXAqQMDpSbOHHFI= X-Google-Smtp-Source: ABdhPJyZ3E24avll2jucwFE1jctSHxe8HPuIizbHtA2aTAPBG3tDFuC/BserHTYjcdMUmawsC6a95A== X-Received: by 2002:a63:2361:0:b0:378:af21:1d79 with SMTP id u33-20020a632361000000b00378af211d79mr1148760pgm.363.1645997668444; Sun, 27 Feb 2022 13:34:28 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d13-20020a17090ac24d00b001bcd7c2b2c3sm9485878pjx.16.2022.02.27.13.34.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Feb 2022 13:34:26 -0800 (PST) X-Mozilla-News-Host: news://news.gmane.org:119 From: Jim Porter Subject: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes To: bug-gnu-emacs@gnu.org Message-ID: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> Date: Sun, 27 Feb 2022 13:34:26 -0800 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------621208421B5428A95558A3F5" Content-Language: en-US X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::434 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x434.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------621208421B5428A95558A3F5 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit In the documentation for lisp/eshell/esh-var.el (and `eshell-parse-variable-ref' in that file), it says that "$" is a way of accessing the value of the variable FOO to disambiguate the length of the variable name, sort of like "${FOO}" in ordinary shells. However, that's not actually true. The correct syntax for that is: $"FOO" ;; or... $'FOO' In fact, what "$" does is to run FOO as a subcommand, writing its stdout to a temp file, and returning that file's name. This is (very!) subtly implied in the Eshell manual in the "Bugs and ideas" section, where it says: `grep python $' doesn't work, but using `*grep' does This happens because the `grep' Lisp function returns immediately, and then the asynchronous `grep' process expects to examine the temporary file, which has since been deleted. Attached is a patch which updates the documentation to correctly describe the current behavior. Note: since this is just a documentation change, it might be worth pushing to the 28 branch. --------------621208421B5428A95558A3F5 Content-Type: text/plain; charset=UTF-8; name="0001-Improve-correct-documentation-about-Eshell-variable-.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Improve-correct-documentation-about-Eshell-variable-.pa"; filename*1="tch" RnJvbSBlYzUyYjQ0ZjY5NGYyNTE1YmIzNjczZjk5OGU2ZWE4MGQyZDMxZTA4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjcgRmViIDIwMjIgMTM6MjA6NTEgLTA4MDAKU3ViamVjdDogW1BB VENIXSBJbXByb3ZlL2NvcnJlY3QgZG9jdW1lbnRhdGlvbiBhYm91dCBFc2hlbGwgdmFyaWFi bGUgZXhwYW5zaW9uCgoqIGxpc3AvZXNoZWxsL2VzaC12YXIuZWw6IENvcnJlY3QgZG9jdW1l bnRhdGlvbiBjb21tZW50LgooZXNoZWxsLXBhcnNlLXZhcmlhYmxlLXJlZik6IENvcnJlY3Qg ZG9jc3RyaW5nLgoKKiBkb2MvbWlzYy9lc2hlbGwudGV4aSAoRG9sbGFycyBFeHBhbnNpb24p OiBBZGQgZG9jdW1lbnRhdGlvbiBmb3IKJCJ2YXIiLyQndmFyJyBhbmQgJDxjb21tYW5kPiBz eW50YXhlcy4KLS0tCiBkb2MvbWlzYy9lc2hlbGwudGV4aSAgIHwgMTEgKysrKysrKysrKysK IGxpc3AvZXNoZWxsL2VzaC12YXIuZWwgfCAxNSArKysrKysrKysrKystLS0KIDIgZmlsZXMg Y2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9kb2MvbWlzYy9lc2hlbGwudGV4aSBiL2RvYy9taXNjL2VzaGVsbC50ZXhpCmluZGV4IDI2 MWU4OGQwMGMuLjg4YTdkN2IxMzAgMTAwNjQ0Ci0tLSBhL2RvYy9taXNjL2VzaGVsbC50ZXhp CisrKyBiL2RvYy9taXNjL2VzaGVsbC50ZXhpCkBAIC0xMDE2LDYgKzEwMTYsMTIgQEAgRG9s bGFycyBFeHBhbnNpb24KIEV4cGFuZHMgdG8gdGhlIHZhbHVlIGJvdW5kIHRvIEBjb2Rle3Zh cn0uICBUaGlzIGlzIHRoZSBtYWluIHdheSB0byB1c2UKIHZhcmlhYmxlcyBpbiBjb21tYW5k IGludm9jYXRpb25zLgogCitAaXRlbSAkInZhciIKK0BpdGVtICQndmFyJworRXhwYW5kcyB0 byB0aGUgdmFsdWUgYm91bmQgdG8gQGNvZGV7dmFyfS4gIFRoaXMgaXMgdXNlZnVsIHRvCitk aXNhbWJpZ3VhdGUgdGhlIHZhcmlhYmxlIG5hbWUgd2hlbiBjb25jYXRlbmF0aW5nIGl0IHdp dGggYW5vdGhlcgordmFsdWUsIHN1Y2ggYXMgQHNhbXB7JCJ2YXIiLXN1ZmZpeH0uCisKIEBp dGVtICQjdmFyCiBFeHBhbmRzIHRvIHRoZSBsZW5ndGggb2YgdGhlIHZhbHVlIGJvdW5kIHRv IEBjb2Rle3Zhcn0uICBSYWlzZXMgYW4gZXJyb3IKIGlmIHRoZSB2YWx1ZSBpcyBub3QgYSBz ZXF1ZW5jZQpAQCAtMTAzMCw2ICsxMDM2LDExIEBAIERvbGxhcnMgRXhwYW5zaW9uCiBSZXR1 cm5zIHRoZSBvdXRwdXQgb2YgQGNvbW1hbmR7Y29tbWFuZH0sIHdoaWNoIGNhbiBiZSBhbnkg dmFsaWQgRXNoZWxsCiBjb21tYW5kIGludm9jYXRpb24sIGFuZCBtYXkgZXZlbiBjb250YWlu IGV4cGFuc2lvbnMuCiAKK0BpdGVtICQ8Y29tbWFuZD4KK0FzIHdpdGggQHNhbXB7JEB7Y29t bWFuZEB9fSwgZXZhbHVhdGVzIHRoZSBFc2hlbGwgY29tbWFuZCBpbnZvY2F0aW9uCitAY29t bWFuZHtjb21tYW5kfSwgYnV0IHdyaXRlcyB0aGUgb3V0cHV0IHRvIGEgdGVtcG9yYXJ5IGZp bGUgYW5kCityZXR1cm5zIHRoZSBmaWxlIG5hbWUuCisKIEBpdGVtICR2YXJbaV0KIEV4cGFu ZHMgdG8gdGhlIEBjb2Rle2l9dGggZWxlbWVudCBvZiB0aGUgdmFsdWUgYm91bmQgdG8gQGNv ZGV7dmFyfS4gIElmCiB0aGUgdmFsdWUgaXMgYSBzdHJpbmcsIGl0IHdpbGwgYmUgc3BsaXQg YXQgd2hpdGVzcGFjZSB0byBtYWtlIGl0IGEgbGlzdC4KZGlmZiAtLWdpdCBhL2xpc3AvZXNo ZWxsL2VzaC12YXIuZWwgYi9saXNwL2VzaGVsbC9lc2gtdmFyLmVsCmluZGV4IDVjOGRhY2Q5 ODAuLmNmZWZlMTVjOWMgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaC12YXIuZWwKKysr IGIvbGlzcC9lc2hlbGwvZXNoLXZhci5lbApAQCAtMzQsNyArMzQsOCBAQAogOzsKIDs7ICIt IiBpcyBhIHZhbGlkIHBhcnQgb2YgYSB2YXJpYWJsZSBuYW1lLgogOzsKLTs7ICAgJDxNWVZB Uj4tVE9PCis7OyAgICRcIk1ZVkFSXCItVE9PCis7OyAgICQnTVlWQVInLVRPTwogOzsKIDs7 IE9ubHkgIk1ZVkFSIiBpcyBwYXJ0IG9mIHRoZSB2YXJpYWJsZSBuYW1lIGluIHRoaXMgY2Fz ZS4KIDs7CkBAIC01NSw2ICs1NiwxMSBAQAogOzsgUmV0dXJucyB0aGUgdmFsdWUgb2YgYW4g ZXNoZWxsIHN1YmNvbW1hbmQuICBTZWUgdGhlIG5vdGUgYWJvdmUKIDs7IHJlZ2FyZGluZyBM aXNwIGV2YWx1YXRpb25zLgogOzsKKzs7ICAgJDxjb21tYW5kPgorOzsKKzs7IEV2YWx1YXRl cyBhbiBlc2hlbGwgc3ViY29tbWFuZCwgcmVkaXJlY3RpbmcgdGhlIG91dHB1dCB0byBhCis7 OyB0ZW1wb3JhcnkgZmlsZSwgYW5kIHJldHVybmluZyB0aGUgZmlsZSBuYW1lLgorOzsKIDs7 ICAgJEFOWVZBUlsxMF0KIDs7CiA7OyBSZXR1cm4gdGhlIDEwdGggZWxlbWVudCBvZiBBTllW QVIuICBJZiBBTllWQVIncyB2YWx1ZSBpcyBhIHN0cmluZywKQEAgLTQyMyw5ICs0MjksMTIg QEAgZXNoZWxsLXBhcnNlLXZhcmlhYmxlLXJlZgogUG9zc2libGUgb3B0aW9ucyBhcmU6CiAK ICAgTkFNRSAgICAgICAgICBhbiBlbnZpcm9ubWVudCBvciBMaXNwIHZhcmlhYmxlIHZhbHVl Ci0gIDxMT05HLU5BTUU+ICAgZGlzYW1iaWd1YXRlcyB0aGUgbGVuZ3RoIG9mIHRoZSBuYW1l CisgIFwiTE9ORy1OQU1FXCIgICBkaXNhbWJpZ3VhdGVzIHRoZSBsZW5ndGggb2YgdGhlIG5h bWUKKyAgJ0xPTkctTkFNRScgICBhcyBhYm92ZQogICB7Q09NTUFORH0gICAgIHJlc3VsdCBv ZiBjb21tYW5kIGlzIHZhcmlhYmxlJ3MgdmFsdWUKLSAgKExJU1AtRk9STSkgICByZXN1bHQg b2YgTGlzcCBmb3JtIGlzIHZhcmlhYmxlJ3MgdmFsdWUiCisgIChMSVNQLUZPUk0pICAgcmVz dWx0IG9mIExpc3AgZm9ybSBpcyB2YXJpYWJsZSdzIHZhbHVlCisgIDxDT01NQU5EPiAgICAg d3JpdGUgdGhlIG91dHB1dCBvZiBjb21tYW5kIHRvIGEgdGVtcG9yYXJ5IGZpbGU7CisgICAg ICAgICAgICAgICAgcmVzdWx0IGlzIHRoZSBmaWxlIG5hbWUiCiAgIChjb25kCiAgICAoKGVx IChjaGFyLWFmdGVyKSA/eykKICAgICAobGV0ICgoZW5kIChlc2hlbGwtZmluZC1kZWxpbWl0 ZXIgP1x7ID9cfSkpKQotLSAKMi4yNS4xCgo= --------------621208421B5428A95558A3F5-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 28 01:11:09 2022 Received: (at 54190) by debbugs.gnu.org; 28 Feb 2022 06:11:10 +0000 Received: from localhost ([127.0.0.1]:59843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOZFV-0006HX-PK for submit@debbugs.gnu.org; Mon, 28 Feb 2022 01:11:09 -0500 Received: from mail-pf1-f170.google.com ([209.85.210.170]:40920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOZFT-0006HK-WC for 54190@debbugs.gnu.org; Mon, 28 Feb 2022 01:11:08 -0500 Received: by mail-pf1-f170.google.com with SMTP id z15so10150081pfe.7 for <54190@debbugs.gnu.org>; Sun, 27 Feb 2022 22:11:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=8knzE8l6BfwMD8HXzFKvdvL87Ghdq2GELgFatLMJJ+0=; b=iNUD3IN2N+8PDk1WFaHIVPdyGvLX2RMAEeDXUFmxyILOezvJ0DQ6MzXKY9zTFa6QI4 UGRBjMTmupYIEM8r4+QwyGc0SHy8W/d7js1h3mXK8rPJQ5QUDP6drKbfYqEc/y8mkpQ8 2m6gUehegAFs+OQEIJOzMDuZmBqvrjk/B4XYSUqb9vwB1wkfJpUNyDRztwcpJs0RL+XL DTKeAiUyAvPZ2ldrEnQT3yXO5m3dAPZtF+d/ZJYtAPuqd/r2AZM+o7RmEANh6GPdHYUN J6pKCFNKcjeeDKa1If4Xs5wYr6+QcJa0QoIQPYL8sCLs/q2LBtZWzvJLC8tNTgTpij3+ TThQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8knzE8l6BfwMD8HXzFKvdvL87Ghdq2GELgFatLMJJ+0=; b=BLNGlJXQ4D4uVphyyZrDP0pGR42uh1EhPbTR2kQwWofhsWPYAFfMZq73JX9U4KnC6x 9ckacUdSVkIdofMBSEuEIaqdSvYvYoaLHmxF5mfkpBmU7kvCrIwpYVmFX6gxbco23f5/ eNVM0YOqzFw7EJsCiw+BEciub0FOgkYW83hsZnkxqn7Rw9zd2B3VuaHFGqOp8/TmLs2d ZbL0WtF7jsTQWD2EliFY83JHM3UgHTMFplpo1Gfbm8arABiBG1kGEatpi8J5kP5yPzRx KI8kTdlih4fjDYZ8WuQLwsm8PIP1bjY1uzFPRl2YzJN2RWsDuHQL2RT/HqDQbpqGNfwD XDvg== X-Gm-Message-State: AOAM531ppiLFTwpaaEpXNrjJOVOaq3gf/y52c1HEUYEytI1VbQm0xOx0 lkqCfzsKJU+Imf/Q29A2OsmORh0CDZE= X-Google-Smtp-Source: ABdhPJwfBg9Kqivei2O2dCMpf3u0RCI3mJfvXXzUu+ZOfxL4CsmtxgyB4AhovjJLUTQ3Vvxp6DrPKA== X-Received: by 2002:a05:6a00:234a:b0:4e0:f776:876b with SMTP id j10-20020a056a00234a00b004e0f776876bmr20166030pfj.84.1646028662190; Sun, 27 Feb 2022 22:11:02 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id k5-20020aa788c5000000b004df7bf0a290sm11706557pff.1.2022.02.27.22.11.01 for <54190@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Feb 2022 22:11:01 -0800 (PST) Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes From: Jim Porter To: 54190@debbugs.gnu.org References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> Message-ID: <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> Date: Sun, 27 Feb 2022 22:11:01 -0800 MIME-Version: 1.0 In-Reply-To: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54190 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/27/2022 1:34 PM, Jim Porter wrote: > In fact, what "$" does is to run FOO as a subcommand, writing its > stdout to a temp file, and returning that file's name. Hmm, that's unfortunate. It seems that the "$" syntax in Eshell broke sometime between 27.2 and 28. I'm bisecting to figure out where that happened, but figured I'd mention it now so there's no confusion if someone tries it out now on 28/29. Fix forthcoming (hopefully). From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 28 03:16:40 2022 Received: (at 54190) by debbugs.gnu.org; 28 Feb 2022 08:16:40 +0000 Received: from localhost ([127.0.0.1]:59949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nObCn-0000zb-Ct for submit@debbugs.gnu.org; Mon, 28 Feb 2022 03:16:39 -0500 Received: from mail-pj1-f52.google.com ([209.85.216.52]:44985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nObCl-0000zK-Hy for 54190@debbugs.gnu.org; Mon, 28 Feb 2022 03:16:27 -0500 Received: by mail-pj1-f52.google.com with SMTP id cp23-20020a17090afb9700b001bbfe0fbe94so10658088pjb.3 for <54190@debbugs.gnu.org>; Mon, 28 Feb 2022 00:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=NAuZBtg+wfuYCSd/0cQplxwnyCckvWYJ9MtCQpBtxck=; b=mfLHAbI/ZhKHa08cPaUnZEiipxZW3xwplP+Hzaxk2wWn4pFIvzrCXsS9vM0DkbQNUP tXWSpIB0fQP8Ox1b8LWVAF4pAE4RMbzNH3wVjxb5Wr3ScBDiwKBiiwM8H2IoNeJZ+uHi DskY5/sclLlsdze7RLHP0VVsRksGqZhzmif6oWs6ltCxqOGMBRwe2SDg57iQE+oz8FRd IgHCVGIuVyY4UIgP8pPv91BMM5sBzchMzCQaPXUjrRsXqxs8mIi0JCfq5TUBKXCG8hND KSS9BJaP5fPWDf3wgTUVn+yl6gAHJa1hwcXHwTYcLcCjEMYaRnLRfV8wHN1t4jV6iLtz HpGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NAuZBtg+wfuYCSd/0cQplxwnyCckvWYJ9MtCQpBtxck=; b=OzCeT7sviGVEs+RQ3KPzfoTQ1Cq9DYir3OTs97//0RJISBYqEYQ0MEEmuonEIVmg7o QiXqk+KEiePoHqRXUpa9kj2AAMrBoEb0xli/OKh2nKWc94CNtSjI1yHNSk/BYlmFh+MI JHDBUqeEsIJzWlmoZUGC58rxAhHV6TMjHr7ZNSsgG4Fv189gGO/hXwEohf+RUVc74XmU SA75AgP3cj223KMQfI1jgWOqf6zhaHtTyUgNSuUNvs++6vC/yzXibeVtIj4ML7Mghc/Q 5GxYkJ0unIynw2CgIZnAxS3sqOHW7wrAv+4dydtHZNmBZLpsLLqa7vhJ+J/oYSjib7y/ qtRA== X-Gm-Message-State: AOAM533ybO9Qn6CWGjwRU8cpempSIYWmM2okl4c3IbpkoNJzrimPlnfX wQqUU3BJSi99L6eSMSEJUtQO4Cz5OM8= X-Google-Smtp-Source: ABdhPJxYtNL//e4XxDaKzMCdDyjB1N4efbV8t5quqguQUBplX/OAj10glT6BuEXTR7SRNJyaZN8TZQ== X-Received: by 2002:a17:902:cece:b0:150:3f2:4616 with SMTP id d14-20020a170902cece00b0015003f24616mr19664769plg.41.1646036181649; Mon, 28 Feb 2022 00:16:21 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 23-20020a17090a0d5700b001bc3c650e01sm20108659pju.1.2022.02.28.00.16.20 for <54190@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Feb 2022 00:16:21 -0800 (PST) Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes From: Jim Porter To: 54190@debbugs.gnu.org References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> Message-ID: <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> Date: Mon, 28 Feb 2022 00:16:21 -0800 MIME-Version: 1.0 In-Reply-To: <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54190 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/27/2022 10:11 PM, Jim Porter wrote: > Hmm, that's unfortunate. It seems that the "$" syntax in Eshell > broke sometime between 27.2 and 28. I'm bisecting to figure out where > that happened, but figured I'd mention it now so there's no confusion if > someone tries it out now on 28/29. Fix forthcoming (hopefully). Ok, the breaking commit is b03f74e0f2a578b1580e8b1c368665850ee7f808 ("Don't quote lambdas in several places"). Reverting the change in that commit in lisp/eshell/esh-var.el fixes things, although I'm not sure why yet. I believe that code gets evaluated by `eshell-do-eval', which evaluates things in a very particular way in order to support deferring evaluation at various points. Once I'm sure I understand why this is breaking, I'll post a patch to fix the bustage. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 28 04:38:43 2022 Received: (at 54190) by debbugs.gnu.org; 28 Feb 2022 09:38:43 +0000 Received: from localhost ([127.0.0.1]:60059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOcUN-0005IP-82 for submit@debbugs.gnu.org; Mon, 28 Feb 2022 04:38:43 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOcUL-0005IB-JV for 54190@debbugs.gnu.org; Mon, 28 Feb 2022 04:38:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GBrfacDkpbCi3fOTtfMQEO9Gjbo0AwTG7/R9ZU8TaqE=; b=vEnBN4CrD0dCS5T0++cP23khXn Sw5IPSk+/skW7FtVM0XgxdNKorbktuami2rf+7gyvdLKYOF2QtG/Q5a7ZZ/iWa+0yagy/cYlkjBdS r/KkmkWP0FogPl68E7xNyNkr7Oh3mcz0aVCjRf+uSBd9w9FfmiK08mRKIxCv3vscj4DU=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOcUB-0005t7-Rs; Mon, 28 Feb 2022 10:38:34 +0100 From: Lars Ingebrigtsen To: Jim Porter Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> X-Now-Playing: Xiu Xiu's _The Passenger_: "Ian Curtis Wish List SOLO" Date: Mon, 28 Feb 2022 10:38:31 +0100 In-Reply-To: <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> (Jim Porter's message of "Mon, 28 Feb 2022 00:16:21 -0800") Message-ID: <87o82rqqjs.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > Ok, the breaking commit is b03f74e0f2a578b1580e8b1c368665850ee7f808 > ("Don't quote lambdas in several places"). Reverting the change in > that commit in lisp/eshell/esh-var.el fixes things, althoug [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54190 Cc: 54190@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > Ok, the breaking commit is b03f74e0f2a578b1580e8b1c368665850ee7f808 > ("Don't quote lambdas in several places"). Reverting the change in > that commit in lisp/eshell/esh-var.el fixes things, although I'm not > sure why yet. I believe that code gets evaluated by `eshell-do-eval', > which evaluates things in a very particular way in order to support > deferring evaluation at various points. Once I'm sure I understand why > this is breaking, I'll post a patch to fix the bustage. It's this bit? Hm... diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el index 96838d4132..7388279f15 100644 --- a/lisp/eshell/esh-var.el +++ b/lisp/eshell/esh-var.el @@ -463,8 +463,8 @@ eshell-parse-variable-ref (eshell-as-subcommand ,(eshell-parse-command cmd)) (ignore (nconc eshell-this-command-hook - (list (function (lambda () - (delete-file ,temp)))))) + (list (lambda () + (delete-file ,temp))))) (quote ,temp))) (goto-char (1+ end))))))) ((eq (char-after) ?\() Trying to follow the logic of how this is eventually evaluated isn't, er, obvious, but I'm not sure how that change could break anything, either. Perhaps Stefan has a comment; added to the CCs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 28 08:18:37 2022 Received: (at 54190) by debbugs.gnu.org; 28 Feb 2022 13:18:37 +0000 Received: from localhost ([127.0.0.1]:60506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOfvA-0007iu-QN for submit@debbugs.gnu.org; Mon, 28 Feb 2022 08:18:37 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOfv8-0007ih-Ua for 54190@debbugs.gnu.org; Mon, 28 Feb 2022 08:18:35 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D5C4B805CC; Mon, 28 Feb 2022 08:18:28 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7D6A380543; Mon, 28 Feb 2022 08:18:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1646054307; bh=JhAvS4EIgtPfBLlxRRb3mvsrbWT1hu5zbqESuWG/CU8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DY/oWnMCgJEXKJCNaoOqnxbujwSnB3TIHRr4oAxUSnOR1kl7aMIcUPuisXBkU2RYV yCgr/2G2rmkY5hfSChY3ShZoeq8nEPjwpoW5qFDcirr23ERrlTcobdZ7SskQiHpWua F9aIwmEy5Nc+HbGvBnrseCVA//PPMVZsQkgr2TcVdrsDjSOC5d3gN+7peh62ZltvTZ RYxxZPSmBu6mPbsXZE5Ia0NnbPWxZdqHQRoDIOO8wljFxeUNDk46nNdwTu5BHYQLsG iyMwv64ASdv6tyfbWnQ1hm6V/caff9NyYgSrZRGu86yBKT8J0lmQQXMfVqIEwNe14c FhrfPUMdDSjMg== Received: from pastel (unknown [45.72.208.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 54CB9120ECC; Mon, 28 Feb 2022 08:18:27 -0500 (EST) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes Message-ID: References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> Date: Mon, 28 Feb 2022 08:18:26 -0500 In-Reply-To: <87o82rqqjs.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 28 Feb 2022 10:38:31 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54190 Cc: Jim Porter , 54190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2022-02-28 10:38:31] wrote: > Jim Porter writes: >> Ok, the breaking commit is b03f74e0f2a578b1580e8b1c368665850ee7f808 >> ("Don't quote lambdas in several places"). Reverting the change in >> that commit in lisp/eshell/esh-var.el fixes things, although I'm not >> sure why yet. I believe that code gets evaluated by `eshell-do-eval', >> which evaluates things in a very particular way in order to support >> deferring evaluation at various points. Once I'm sure I understand why >> this is breaking, I'll post a patch to fix the bustage. > > It's this bit? Hm... > > diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el > index 96838d4132..7388279f15 100644 > --- a/lisp/eshell/esh-var.el > +++ b/lisp/eshell/esh-var.el > @@ -463,8 +463,8 @@ eshell-parse-variable-ref > (eshell-as-subcommand ,(eshell-parse-command cmd)) > (ignore > (nconc eshell-this-command-hook > - (list (function (lambda () > - (delete-file ,temp)))))) > + (list (lambda () > + (delete-file ,temp))))) > (quote ,temp))) > (goto-char (1+ end))))))) > ((eq (char-after) ?\() > > > Trying to follow the logic of how this is eventually evaluated isn't, > er, obvious, but I'm not sure how that change could break anything, > either. Perhaps Stefan has a comment; added to the CCs. Looks like a bug somewhere in the `eshell-do-eval` machinery, yes. Until we find the problem (or rewrite `eshell-do-eval` on top of the CPS converter of `generator.el`), I think reverting this change (and adding a comment pointing to this bug) sounds like a great plan. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 28 08:28:21 2022 Received: (at 54190) by debbugs.gnu.org; 28 Feb 2022 13:28:21 +0000 Received: from localhost ([127.0.0.1]:60524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOg4b-0007xb-Dk for submit@debbugs.gnu.org; Mon, 28 Feb 2022 08:28:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOg4Z-0007xO-PK for 54190@debbugs.gnu.org; Mon, 28 Feb 2022 08:28:20 -0500 Received: from [2001:470:142:3::e] (port=40200 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOg4U-0002kb-05; Mon, 28 Feb 2022 08:28:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DF11SAI/yibQTnLoXti20sQNtY0cz441D3sZF0pGkEU=; b=BH0kFTLaGCZe Qmr9989O8ukrQ+dxXRdOlVkPAIXCuxJ4a3ZZuGDrPRyCq/IuqtS1Hd7JxSG4A6hrgqoEdQSgQ72cN COQMsEnG2qDI1NphK2yRu5nrA4ipi63mnuxBA/WpBHKfn/8ScCOW0U3s/vsoTaW/52u5ASC3HPnJH H5VHmEApXQTlHUuUswzc4pn3ZOwpDAEt+I01Uw8xc6mkmrdcwmbGe5yrIFDnFanjEqdfxo6lNtFh6 6zmVJ3lEErUyt0OoRPyPRsQ4Y/B/rmrrIPLlwJjcIqEm3vXCzvIYHkBGf+vBIGN1LP2M2L2srgoUZ frgZX/7KWT4I5GIIXtCRAA==; Received: from [87.69.77.57] (port=1806 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOg4T-0001IO-CP; Mon, 28 Feb 2022 08:28:13 -0500 Date: Mon, 28 Feb 2022 15:28:03 +0200 Message-Id: <83lexvm87w.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54190 Cc: jporterbugs@gmail.com, larsi@gnus.org, 54190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Jim Porter , 54190@debbugs.gnu.org > Date: Mon, 28 Feb 2022 08:18:26 -0500 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el > > index 96838d4132..7388279f15 100644 > > --- a/lisp/eshell/esh-var.el > > +++ b/lisp/eshell/esh-var.el > > @@ -463,8 +463,8 @@ eshell-parse-variable-ref > > (eshell-as-subcommand ,(eshell-parse-command cmd)) > > (ignore > > (nconc eshell-this-command-hook > > - (list (function (lambda () > > - (delete-file ,temp)))))) > > + (list (lambda () > > + (delete-file ,temp))))) > > (quote ,temp))) > > (goto-char (1+ end))))))) > > ((eq (char-after) ?\() > > > > > > Trying to follow the logic of how this is eventually evaluated isn't, > > er, obvious, but I'm not sure how that change could break anything, > > either. Perhaps Stefan has a comment; added to the CCs. > > Looks like a bug somewhere in the `eshell-do-eval` machinery, yes. > Until we find the problem (or rewrite `eshell-do-eval` on top of the CPS > converter of `generator.el`), I think reverting this change (and adding > a comment pointing to this bug) sounds like a great plan. I agree. We should revert this on the release branch, since this is a regression wrt Emacs 27. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 28 12:48:03 2022 Received: (at 54190) by debbugs.gnu.org; 28 Feb 2022 17:48:03 +0000 Received: from localhost ([127.0.0.1]:34722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOk7u-0000Kg-Bg for submit@debbugs.gnu.org; Mon, 28 Feb 2022 12:48:02 -0500 Received: from mail-pf1-f180.google.com ([209.85.210.180]:42513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOk7s-0000Jm-Gs for 54190@debbugs.gnu.org; Mon, 28 Feb 2022 12:48:01 -0500 Received: by mail-pf1-f180.google.com with SMTP id a5so10813975pfv.9 for <54190@debbugs.gnu.org>; Mon, 28 Feb 2022 09:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=OXnwzv8GRQejxE5wYC1jFgLQhfjTlQXHNSBo9w3L454=; b=qSUl/cv0S3oL+bn2iG9eow9eRvfhBeBJMWBz/jsw8TLaGb+x8zB6xOH6MXJV4vJcSS XXnXXBZ1YWdA6O17QKN663vQZtEzAMKXKZRqU6d3FAhwIYoIo7w8/hjRhiVlkBgorMOH qUVX76Ltc+nT59lqAqnnWl6egyMHNi7Y2/B05V2UdOC/wMYncM2Q5KjnHWjOvH1dgpoW DKbdtpIm1gTZH42p3uVZrqMFOQdpzRz4M7zH/QGXDmPz4Bp4Yp6ugfHEwZ7QkYGT6+gI 8U1IinbSPjjRX8iVuexSSfat05XlLiy4K2HIJS+Hwgi0H8hGWD0Ln16PLIrSAurcHxZU 4Vbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=OXnwzv8GRQejxE5wYC1jFgLQhfjTlQXHNSBo9w3L454=; b=7LX2hSQJiv1ibJBgDu4AKYU+Tgfp9QrkBEuAjF6Io5CoEbhRfswR4VmqipBhVA49Sy WTXtWvsAk36zNBUFaAVyBsLc7RdcFh/mdQLw5U+xWxpcMqb0POj1rJaZbVsX7MidqVw3 ZZPPgg8ASKuT8FfaTEGmRi5vjOJHajMQh+z20U0n50MTMWQl9QtucCHsuK9E3SfnpZL7 GNl/jOuwFyyCXqlxBD5+vhImPnE7mPGkqj/AVqRha0VRA0T23AWPCk9UX3ILgqPBk8j5 V0pSUtPwCWMcFLeLaCLolSSbIyuIUM147Ox1nOC1ZsG4giAvBcHP0lB2CSDgHWec2lBT MGjw== X-Gm-Message-State: AOAM531zCGDWpJebjOnKg7IQIbZOt3enWlqUR9QwIik/gljn2zp2QIie iCVNg2aED4YsG7/SrJ9iHE7ZnbCv5/w= X-Google-Smtp-Source: ABdhPJzEJs8Kw1XEvpYG/Jq5lTwiUS/Sfec51lZ1AtKDN/DgBjOFY+jebUMyqhGhHu1bJyNicrpgOg== X-Received: by 2002:aa7:8890:0:b0:4e1:b25b:634c with SMTP id z16-20020aa78890000000b004e1b25b634cmr22911436pfe.31.1646070474213; Mon, 28 Feb 2022 09:47:54 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b3-20020a056a00114300b004cc39630bfcsm14064423pfm.207.2022.02.28.09.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Feb 2022 09:47:53 -0800 (PST) Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes To: Stefan Monnier , Lars Ingebrigtsen References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> From: Jim Porter Message-ID: <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> Date: Mon, 28 Feb 2022 09:47:54 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------AB3BA7A3CC803FA075D50ADE" Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54190 Cc: 54190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------AB3BA7A3CC803FA075D50ADE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2/28/2022 5:18 AM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Lars Ingebrigtsen [2022-02-28 10:38:31] wrote: >> Jim Porter writes: >>> Ok, the breaking commit is b03f74e0f2a578b1580e8b1c368665850ee7f808 >>> ("Don't quote lambdas in several places"). [snip]> Looks like a bug somewhere in the `eshell-do-eval` machinery, yes. > Until we find the problem (or rewrite `eshell-do-eval` on top of the CPS > converter of `generator.el`), I think reverting this change (and adding > a comment pointing to this bug) sounds like a great plan. Here's a patch to fix this, with a test so it doesn't regress again. I also re-attached the doc fix for simplicity. Both should apply to the 28 branch with no issues. I'll try to figure out why `eshell-do-eval' expects quoted lambdas, but unless that's a really trivial problem, the method here is probably safer for the 28 branch. Besides, I'm now 4 or 5 steps removed from the patch I was *trying* to work on, so a quick fix here will help me get back on track. Longer term, I agree that rewriting `eshell-do-eval' in terms of generator.el would be good. I think there are some bugs with how local variable state is managed by `eshell-do-eval', but I haven't had a chance to investigate it in any detail yet. --------------AB3BA7A3CC803FA075D50ADE Content-Type: text/plain; charset=UTF-8; name="0001-Improve-correct-documentation-about-Eshell-variable-.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Improve-correct-documentation-about-Eshell-variable-.pa"; filename*1="tch" RnJvbSBlYzUyYjQ0ZjY5NGYyNTE1YmIzNjczZjk5OGU2ZWE4MGQyZDMxZTA4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjcgRmViIDIwMjIgMTM6MjA6NTEgLTA4MDAKU3ViamVjdDogW1BB VENIIDEvMl0gSW1wcm92ZS9jb3JyZWN0IGRvY3VtZW50YXRpb24gYWJvdXQgRXNoZWxsIHZh cmlhYmxlCiBleHBhbnNpb24KCiogbGlzcC9lc2hlbGwvZXNoLXZhci5lbDogQ29ycmVjdCBk b2N1bWVudGF0aW9uIGNvbW1lbnQuCihlc2hlbGwtcGFyc2UtdmFyaWFibGUtcmVmKTogQ29y cmVjdCBkb2NzdHJpbmcuCgoqIGRvYy9taXNjL2VzaGVsbC50ZXhpIChEb2xsYXJzIEV4cGFu c2lvbik6IEFkZCBkb2N1bWVudGF0aW9uIGZvcgokInZhciIvJCd2YXInIGFuZCAkPGNvbW1h bmQ+IHN5bnRheGVzLgotLS0KIGRvYy9taXNjL2VzaGVsbC50ZXhpICAgfCAxMSArKysrKysr KysrKwogbGlzcC9lc2hlbGwvZXNoLXZhci5lbCB8IDE1ICsrKysrKysrKysrKy0tLQogMiBm aWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2RvYy9taXNjL2VzaGVsbC50ZXhpIGIvZG9jL21pc2MvZXNoZWxsLnRleGkKaW5k ZXggMjYxZTg4ZDAwYy4uODhhN2Q3YjEzMCAxMDA2NDQKLS0tIGEvZG9jL21pc2MvZXNoZWxs LnRleGkKKysrIGIvZG9jL21pc2MvZXNoZWxsLnRleGkKQEAgLTEwMTYsNiArMTAxNiwxMiBA QCBEb2xsYXJzIEV4cGFuc2lvbgogRXhwYW5kcyB0byB0aGUgdmFsdWUgYm91bmQgdG8gQGNv ZGV7dmFyfS4gIFRoaXMgaXMgdGhlIG1haW4gd2F5IHRvIHVzZQogdmFyaWFibGVzIGluIGNv bW1hbmQgaW52b2NhdGlvbnMuCiAKK0BpdGVtICQidmFyIgorQGl0ZW0gJCd2YXInCitFeHBh bmRzIHRvIHRoZSB2YWx1ZSBib3VuZCB0byBAY29kZXt2YXJ9LiAgVGhpcyBpcyB1c2VmdWwg dG8KK2Rpc2FtYmlndWF0ZSB0aGUgdmFyaWFibGUgbmFtZSB3aGVuIGNvbmNhdGVuYXRpbmcg aXQgd2l0aCBhbm90aGVyCit2YWx1ZSwgc3VjaCBhcyBAc2FtcHskInZhciItc3VmZml4fS4K KwogQGl0ZW0gJCN2YXIKIEV4cGFuZHMgdG8gdGhlIGxlbmd0aCBvZiB0aGUgdmFsdWUgYm91 bmQgdG8gQGNvZGV7dmFyfS4gIFJhaXNlcyBhbiBlcnJvcgogaWYgdGhlIHZhbHVlIGlzIG5v dCBhIHNlcXVlbmNlCkBAIC0xMDMwLDYgKzEwMzYsMTEgQEAgRG9sbGFycyBFeHBhbnNpb24K IFJldHVybnMgdGhlIG91dHB1dCBvZiBAY29tbWFuZHtjb21tYW5kfSwgd2hpY2ggY2FuIGJl IGFueSB2YWxpZCBFc2hlbGwKIGNvbW1hbmQgaW52b2NhdGlvbiwgYW5kIG1heSBldmVuIGNv bnRhaW4gZXhwYW5zaW9ucy4KIAorQGl0ZW0gJDxjb21tYW5kPgorQXMgd2l0aCBAc2FtcHsk QHtjb21tYW5kQH19LCBldmFsdWF0ZXMgdGhlIEVzaGVsbCBjb21tYW5kIGludm9jYXRpb24K K0Bjb21tYW5ke2NvbW1hbmR9LCBidXQgd3JpdGVzIHRoZSBvdXRwdXQgdG8gYSB0ZW1wb3Jh cnkgZmlsZSBhbmQKK3JldHVybnMgdGhlIGZpbGUgbmFtZS4KKwogQGl0ZW0gJHZhcltpXQog RXhwYW5kcyB0byB0aGUgQGNvZGV7aX10aCBlbGVtZW50IG9mIHRoZSB2YWx1ZSBib3VuZCB0 byBAY29kZXt2YXJ9LiAgSWYKIHRoZSB2YWx1ZSBpcyBhIHN0cmluZywgaXQgd2lsbCBiZSBz cGxpdCBhdCB3aGl0ZXNwYWNlIHRvIG1ha2UgaXQgYSBsaXN0LgpkaWZmIC0tZ2l0IGEvbGlz cC9lc2hlbGwvZXNoLXZhci5lbCBiL2xpc3AvZXNoZWxsL2VzaC12YXIuZWwKaW5kZXggNWM4 ZGFjZDk4MC4uY2ZlZmUxNWM5YyAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZXNoLXZhci5l bAorKysgYi9saXNwL2VzaGVsbC9lc2gtdmFyLmVsCkBAIC0zNCw3ICszNCw4IEBACiA7Owog OzsgIi0iIGlzIGEgdmFsaWQgcGFydCBvZiBhIHZhcmlhYmxlIG5hbWUuCiA7OwotOzsgICAk PE1ZVkFSPi1UT08KKzs7ICAgJFwiTVlWQVJcIi1UT08KKzs7ICAgJCdNWVZBUictVE9PCiA7 OwogOzsgT25seSAiTVlWQVIiIGlzIHBhcnQgb2YgdGhlIHZhcmlhYmxlIG5hbWUgaW4gdGhp cyBjYXNlLgogOzsKQEAgLTU1LDYgKzU2LDExIEBACiA7OyBSZXR1cm5zIHRoZSB2YWx1ZSBv ZiBhbiBlc2hlbGwgc3ViY29tbWFuZC4gIFNlZSB0aGUgbm90ZSBhYm92ZQogOzsgcmVnYXJk aW5nIExpc3AgZXZhbHVhdGlvbnMuCiA7OworOzsgICAkPGNvbW1hbmQ+Cis7OworOzsgRXZh bHVhdGVzIGFuIGVzaGVsbCBzdWJjb21tYW5kLCByZWRpcmVjdGluZyB0aGUgb3V0cHV0IHRv IGEKKzs7IHRlbXBvcmFyeSBmaWxlLCBhbmQgcmV0dXJuaW5nIHRoZSBmaWxlIG5hbWUuCis7 OwogOzsgICAkQU5ZVkFSWzEwXQogOzsKIDs7IFJldHVybiB0aGUgMTB0aCBlbGVtZW50IG9m IEFOWVZBUi4gIElmIEFOWVZBUidzIHZhbHVlIGlzIGEgc3RyaW5nLApAQCAtNDIzLDkgKzQy OSwxMiBAQCBlc2hlbGwtcGFyc2UtdmFyaWFibGUtcmVmCiBQb3NzaWJsZSBvcHRpb25zIGFy ZToKIAogICBOQU1FICAgICAgICAgIGFuIGVudmlyb25tZW50IG9yIExpc3AgdmFyaWFibGUg dmFsdWUKLSAgPExPTkctTkFNRT4gICBkaXNhbWJpZ3VhdGVzIHRoZSBsZW5ndGggb2YgdGhl IG5hbWUKKyAgXCJMT05HLU5BTUVcIiAgIGRpc2FtYmlndWF0ZXMgdGhlIGxlbmd0aCBvZiB0 aGUgbmFtZQorICAnTE9ORy1OQU1FJyAgIGFzIGFib3ZlCiAgIHtDT01NQU5EfSAgICAgcmVz dWx0IG9mIGNvbW1hbmQgaXMgdmFyaWFibGUncyB2YWx1ZQotICAoTElTUC1GT1JNKSAgIHJl c3VsdCBvZiBMaXNwIGZvcm0gaXMgdmFyaWFibGUncyB2YWx1ZSIKKyAgKExJU1AtRk9STSkg ICByZXN1bHQgb2YgTGlzcCBmb3JtIGlzIHZhcmlhYmxlJ3MgdmFsdWUKKyAgPENPTU1BTkQ+ ICAgICB3cml0ZSB0aGUgb3V0cHV0IG9mIGNvbW1hbmQgdG8gYSB0ZW1wb3JhcnkgZmlsZTsK KyAgICAgICAgICAgICAgICByZXN1bHQgaXMgdGhlIGZpbGUgbmFtZSIKICAgKGNvbmQKICAg ICgoZXEgKGNoYXItYWZ0ZXIpID97KQogICAgIChsZXQgKChlbmQgKGVzaGVsbC1maW5kLWRl bGltaXRlciA/XHsgP1x9KSkpCi0tIAoyLjI1LjEKCg== --------------AB3BA7A3CC803FA075D50ADE Content-Type: text/plain; charset=UTF-8; name="0002-Partially-revert-b03f74e0f2a578b1580e8b1c368665850ee.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0002-Partially-revert-b03f74e0f2a578b1580e8b1c368665850ee.pa"; filename*1="tch" RnJvbSA2ZDg0ZDYyY2ViNzcxYjUxMzJkMDUxZTM0ZjQ1OGY3MTEwYTgzODA4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMjggRmViIDIwMjIgMDk6MzE6MjIgLTA4MDAKU3ViamVjdDogW1BB VENIIDIvMl0gUGFydGlhbGx5IHJldmVydCBiMDNmNzRlMGYyYTU3OGIxNTgwZThiMWMzNjg2 NjU4NTBlZTdmODA4CgpUaGF0IGNvbW1pdCByZWdyZXNzZWQgJyQ8Y29tbWFuZD4nIGZvcm1z IGluIEVzaGVsbCwgZHVlIHRvIGEKbGltaXRhdGlvbi9idWcgaW4gaG93ICdlc2hlbGwtZG8t ZXZhbCcgd29ya3MuCgoqIGxpc3AvZXNoZWxsL2VzaC12YXIuZWwgKGVzaGVsbC1wYXJzZS12 YXJpYWJsZS1yZWYpOiBRdW90ZSBhIGxhbWJkYS4KCiogdGVzdC9saXNwL2VzaGVsbC9lc2hl bGwtdGVzdHMuZWwgKGVzaGVsbC10ZXN0L2ludGVycC10ZW1wLWNtZCk6Ck5ldyB0ZXN0Lgot LS0KIGxpc3AvZXNoZWxsL2VzaC12YXIuZWwgICAgICAgICAgIHwgOCArKysrKystLQogdGVz dC9saXNwL2VzaGVsbC9lc2hlbGwtdGVzdHMuZWwgfCA0ICsrKysKIDIgZmlsZXMgY2hhbmdl ZCwgMTAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNw L2VzaGVsbC9lc2gtdmFyLmVsIGIvbGlzcC9lc2hlbGwvZXNoLXZhci5lbAppbmRleCBjZmVm ZTE1YzljLi5lZTNmZmJjNjQ3IDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lc2gtdmFyLmVs CisrKyBiL2xpc3AvZXNoZWxsL2VzaC12YXIuZWwKQEAgLTQ2Niw4ICs0NjYsMTIgQEAgZXNo ZWxsLXBhcnNlLXZhcmlhYmxlLXJlZgogICAgICAgICAgICAgICAgICAgIChlc2hlbGwtYXMt c3ViY29tbWFuZCAsKGVzaGVsbC1wYXJzZS1jb21tYW5kIGNtZCkpCiAgICAgICAgICAgICAg ICAgICAgKGlnbm9yZQogICAgICAgICAgICAgICAgICAgICAobmNvbmMgZXNoZWxsLXRoaXMt Y29tbWFuZC1ob29rCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAobGlzdCAobGFtYmRh ICgpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkZWxldGUtZmlsZSAs dGVtcCkpKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBRdW90ZSB0aGlzIGxh bWJkYTsgaXQgd2lsbCBiZSBldmFsdWF0ZWQKKyAgICAgICAgICAgICAgICAgICAgICAgICAg IDs7IGJ5IGBlc2hlbGwtZG8tZXZhbCcsIHdoaWNoIHJlcXVpcmVzIHZlcnkKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgIDs7IHBhcnRpY3VsYXIgZm9ybXMgaW4gb3JkZXIgdG8gd29y aworICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgcHJvcGVybHkuICBTZWUgYnVnIzU0 MTkwLgorICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxpc3QgKGZ1bmN0aW9uIChsYW1i ZGEgKCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGRlbGV0ZS1maWxl ICx0ZW1wKSkpKSkpCiAgICAgICAgICAgICAgICAgICAgKHF1b3RlICx0ZW1wKSkpCiAgICAg ICAgICAgICAoZ290by1jaGFyICgxKyBlbmQpKSkpKSkpCiAgICAoKGVxIChjaGFyLWFmdGVy KSA/XCgpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbCBi L3Rlc3QvbGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVsCmluZGV4IGQ2ZWUxYmRiMTcuLmVm ZjRlZGQ2MmMgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVs CisrKyBiL3Rlc3QvbGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVsCkBAIC05Myw2ICs5Mywx MCBAQCBlc2hlbGwtdGVzdC9pbnRlcnAtbGlzcAogICAiSW50ZXJwb2xhdGUgTGlzcCBmb3Jt IGV2YWx1YXRpb24iCiAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtdGVzdC1jb21tYW5kLXJl c3VsdCAiKyAkKCsgMSAyKSAzIikgNikpKQogCisoZXJ0LWRlZnRlc3QgZXNoZWxsLXRlc3Qv aW50ZXJwLXRlbXAtY21kICgpCisgICJJbnRlcnBvbGF0ZSBjb21tYW5kIHJlc3VsdCByZWRp cmVjdGVkIHRvIHRlbXAgZmlsZSIKKyAgKHNob3VsZCAoZXF1YWwgKGVzaGVsbC10ZXN0LWNv bW1hbmQtcmVzdWx0ICJjYXQgJDxlY2hvIGhpPiIpICJoaSIpKSkKKwogKGVydC1kZWZ0ZXN0 IGVzaGVsbC10ZXN0L2ludGVycC1jb25jYXQgKCkKICAgIkludGVycG9sYXRlIGFuZCBjb25j YXQgY29tbWFuZCIKICAgKHNob3VsZCAoZXF1YWwgKGVzaGVsbC10ZXN0LWNvbW1hbmQtcmVz dWx0ICIrICR7KyAxIDJ9MyAzIikgMzYpKSkKLS0gCjIuMjUuMQoK --------------AB3BA7A3CC803FA075D50ADE-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 01 08:11:09 2022 Received: (at 54190) by debbugs.gnu.org; 1 Mar 2022 13:11:09 +0000 Received: from localhost ([127.0.0.1]:35856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP2HV-0001s1-0O for submit@debbugs.gnu.org; Tue, 01 Mar 2022 08:11:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP2HQ-0001rE-Iy for 54190@debbugs.gnu.org; Tue, 01 Mar 2022 08:11:08 -0500 Received: from [2001:470:142:3::e] (port=34214 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nP2HL-0007Wm-BU; Tue, 01 Mar 2022 08:10:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VH0zm9e6LWZ3hvZOt+mjVj/ljoJxtjspYY+O8v7iIVg=; b=b4/xcW9Y9oRR HhBLHaBNnkoied7v6DV1td/lxF6TxXwlpk5wbQm+uAUPHAQrVO8QBNONIAIY1xJ4hr5w3wrzimMoI M1F6h8xYtS20t2O4YGUDgVzGtFb4JFq72FgrH1nQHorZAkKBTlxuS4IFrquxvmVnzPAo1zF/V7/rB xo+CvhKLtPRu8pjUrbYeVqvGiWsdf8a5c7FZthHQWAYeX+657kA0M9dkQ+bD/twY7wVGyAYFIYSR9 wmWk2uQ4RG9ccg39WsQIMACJzHq+CDh99/z9lo78q5NWDy30s3rMMPaqMoMzpgHcfi2qo6LzgX1A4 XhMC2+BeaMTedPFOl+SbTw==; Received: from [87.69.77.57] (port=1215 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nP2HJ-0006ES-Rc; Tue, 01 Mar 2022 08:10:59 -0500 Date: Tue, 01 Mar 2022 15:10:51 +0200 Message-Id: <83ilsxlsx0.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> (message from Jim Porter on Mon, 28 Feb 2022 09:47:54 -0800) Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54190 Cc: larsi@gnus.org, 54190@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jim Porter > Date: Mon, 28 Feb 2022 09:47:54 -0800 > Cc: 54190@debbugs.gnu.org > > Here's a patch to fix this, with a test so it doesn't regress again. I > also re-attached the doc fix for simplicity. Both should apply to the 28 > branch with no issues. Thanks, installed on the emacs-28 branch. (But the markup in the manual part was wrong; see my followup changes.) > I'll try to figure out why `eshell-do-eval' expects quoted lambdas, but > unless that's a really trivial problem, the method here is probably > safer for the 28 branch. Besides, I'm now 4 or 5 steps removed from the > patch I was *trying* to work on, so a quick fix here will help me get > back on track. > > Longer term, I agree that rewriting `eshell-do-eval' in terms of > generator.el would be good. I think there are some bugs with how local > variable state is managed by `eshell-do-eval', but I haven't had a > chance to investigate it in any detail yet. Fine with me. It's up to you whether to close this bug or leave it open until a better solution is found for master. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 04 00:55:50 2022 Received: (at 54190) by debbugs.gnu.org; 4 Mar 2022 05:55:50 +0000 Received: from localhost ([127.0.0.1]:44414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQ0us-0002gB-AB for submit@debbugs.gnu.org; Fri, 04 Mar 2022 00:55:50 -0500 Received: from mail-pl1-f179.google.com ([209.85.214.179]:37517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQ0uq-0002fx-Ls for 54190@debbugs.gnu.org; Fri, 04 Mar 2022 00:55:49 -0500 Received: by mail-pl1-f179.google.com with SMTP id n15so6844243plf.4 for <54190@debbugs.gnu.org>; Thu, 03 Mar 2022 21:55:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=xLSvBab8sRCT8b48nzbBpub6Z+L36PlVSuSdSjZkv6w=; b=koxC647cQ4huYMsp5jR63wS8Ct43+2w1XlsmnIwo9QReHVJgkVyHQE3K37i7XL6xX2 F32RVbEiGFiE3e+Pe/+WKjrHuzp6+h30KD9eqSKgvQmFl/TJLIWZuZUq9MuriKPF0NQt d+7oB7FKcRkIrXc0WC1M8dtxaDzrdimkrOhirYp49JIflfRiDnQQb+HvX0j8daxzoMcq UVdQziB5wq7X6k6E2JUJVhrSm5m9ZwtEstVS6ugrwS4L+KQy55kIbn2PN7Z+52rT2YPH QUFIpmk2qAdT36Z7aCK0u2+zbHBL5wAjO30ivtCSLdCwl9ynUu336qTN6xAxQ1Vds3Bf gGng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=xLSvBab8sRCT8b48nzbBpub6Z+L36PlVSuSdSjZkv6w=; b=25SK53DNsqB1N8B0QFeZ1K7PFQUygQwRAdAkS75vNuuIZSYzJA3RLRVDVIfHGDBCCA tlonoq3x0gwnYFY7t0OdS95Dt63Ec2vpoqF8fu+fi1vuV67Y0mVnnWg7v6tksCt2yuir 3yrpjD/IVXe6lt9IsfcmHPCSFH/g74X0zqcIFxZ1oMjOOuyOtQyWOTE4s0r0CNpmbH/Q 2omPiVQmF+SawR/OlIDjQYzyqU5mCAxJ/BR6Y5grxbSH7nckYFiKJ4ZEUoXPrFCLJJtz MJ90lAuNhd61VsKlmmwwbJZ5jLaFpYJ7NdhgdBeBxYXsNaeBaC23eY40LYGhgAm1XLkh rHYg== X-Gm-Message-State: AOAM532/QvcJ7TmppGk2JpFSDdgAwXpF+0mgkQl/5TyEruX7xkx1lRkD V9T8keemSWV8cAazCZNB7+Q= X-Google-Smtp-Source: ABdhPJxNvUNFvu/ESCkCq2M621xS16aakjeCFpwNriwYCbmPefsUAeoxYDn2C7PdAIn3NHiaKZvnkg== X-Received: by 2002:a17:90b:350c:b0:1bf:1dc5:1c3d with SMTP id ls12-20020a17090b350c00b001bf1dc51c3dmr4230921pjb.53.1646373342674; Thu, 03 Mar 2022 21:55:42 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a19-20020a17090ad81300b001bc447c2c91sm9585008pjv.31.2022.03.03.21.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 21:55:41 -0800 (PST) Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes To: Eli Zaretskii References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> <83ilsxlsx0.fsf@gnu.org> From: Jim Porter Message-ID: <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> Date: Thu, 3 Mar 2022 21:55:41 -0800 MIME-Version: 1.0 In-Reply-To: <83ilsxlsx0.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------8008EEF1671273D56305E545" Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54190 Cc: larsi@gnus.org, 54190@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------8008EEF1671273D56305E545 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 3/1/2022 5:10 AM, Eli Zaretskii wrote: > Thanks, installed on the emacs-28 branch. (But the markup in the > manual part was wrong; see my followup changes.) Thanks for fixing that up. > Fine with me. It's up to you whether to close this bug or leave it > open until a better solution is found for master. After a bit of looking at the `eshell-do-eval' implementation, I realized that there's a better solution that's very simple. See the attached patch. It's simple enough that it might be fine for Emacs 28, but the existing change on the 28 branch is probably a bit safer, since that change was just a partial revert. I'm not aware of anything that could be broken by this new patch, but you never know... This doesn't do anything more elaborate like using generator.el's machinery here; while (I think) that would be nice to have eventually, we can address that in a separate bug, since it'd be a pretty big change. We could probably close this bug after this new patch merges. --------------8008EEF1671273D56305E545 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-Eshell-s-command-forms-in-a-better-way.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-Eshell-s-command-forms-in-a-better-way.patch" RnJvbSA0ODM4N2U4MjdjZDhkNTUwZTk2MjdkZjcyNTZmZDNmMWE5NzA1YTI2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMyBNYXIgMjAyMiAyMTo0NjoxMSAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeCBFc2hlbGwncyAnJDxjb21tYW5kPicgZm9ybXMgaW4gYSBiZXR0ZXIgd2F5Cgoq IGxpc3AvZXNoZWxsL2VzaC1jbWQuZWwgKGVzaGVsbC1kby1ldmFsKTogSGFuZGxlICdsYW1i ZGEnIGZvcm1zLgoqIGxpc3AvZXNoZWxsL2VzaC12YXIuZWwgKGVzaGVsbC1wYXJzZS12YXJp YWJsZS1yZWYpOiBSZW1vdmUKd29ya2Fyb3VuZCBmcm9tIGNvbW1pdCA5ZTI1N2FlIChidWcj NTQxOTApLgotLS0KIGxpc3AvZXNoZWxsL2VzaC1jbWQuZWwgfCAyICstCiBsaXNwL2VzaGVs bC9lc2gtdmFyLmVsIHwgOCArKy0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlv bnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZXNoLWNt ZC5lbCBiL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKaW5kZXggMDRiNTRkOWQ3OS4uNDg0ODg4 ZWM0NyAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbAorKysgYi9saXNwL2Vz aGVsbC9lc2gtY21kLmVsCkBAIC0xMDc3LDcgKzEwNzcsNyBAQCBlc2hlbGwtZG8tZXZhbAog ICAoY29uZAogICAgKChub3QgKGxpc3RwIGZvcm0pKQogICAgIChsaXN0ICdxdW90ZSAoZXZh bCBmb3JtKSkpCi0gICAoKG1lbXEgKGNhciBmb3JtKSAnKHF1b3RlIGZ1bmN0aW9uKSkKKyAg ICgobWVtcSAoY2FyIGZvcm0pICcocXVvdGUgZnVuY3Rpb24gbGFtYmRhKSkKICAgICBmb3Jt KQogICAgKHQKICAgICA7OyBza2lwIHBhc3QgdGhlIGNhbGwgdG8gYGVzaGVsbC1kby1ldmFs JwpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZXNoLXZhci5lbCBiL2xpc3AvZXNoZWxsL2Vz aC12YXIuZWwKaW5kZXggYWY4OWUzNWY1NS4uMDkyZjlmODdhNCAxMDA2NDQKLS0tIGEvbGlz cC9lc2hlbGwvZXNoLXZhci5lbAorKysgYi9saXNwL2VzaGVsbC9lc2gtdmFyLmVsCkBAIC00 NTgsMTIgKzQ1OCw4IEBAIGVzaGVsbC1wYXJzZS12YXJpYWJsZS1yZWYKICAgICAgICAgICAg ICAgICAgICAgICAgKGVzaGVsbC1wYXJzZS1jb21tYW5kIGNtZCkpKQogICAgICAgICAgICAg ICAgICAgIChpZ25vcmUKICAgICAgICAgICAgICAgICAgICAgKG5jb25jIGVzaGVsbC10aGlz LWNvbW1hbmQtaG9vawotICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgUXVvdGUgdGhp cyBsYW1iZGE7IGl0IHdpbGwgYmUgZXZhbHVhdGVkCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICA7OyBieSBgZXNoZWxsLWRvLWV2YWwnLCB3aGljaCByZXF1aXJlcyB2ZXJ5Ci0gICAg ICAgICAgICAgICAgICAgICAgICAgICA7OyBwYXJ0aWN1bGFyIGZvcm1zIGluIG9yZGVyIHRv IHdvcmsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IHByb3Blcmx5LiAgU2VlIGJ1 ZyM1NDE5MC4KLSAgICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0IChmdW5jdGlvbiAo bGFtYmRhICgpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkZWxldGUt ZmlsZSAsdGVtcCkpKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxpc3QgKGxh bWJkYSAoKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLWZp bGUgLHRlbXApKSkpKQogICAgICAgICAgICAgICAgICAgIChxdW90ZSAsdGVtcCkpKQogICAg ICAgICAgICAgKGdvdG8tY2hhciAoMSsgZW5kKSkpKSkpKQogICAgKChlcSAoY2hhci1hZnRl cikgP1woKQotLSAKMi4yNS4xCgo= --------------8008EEF1671273D56305E545-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 04 02:16:57 2022 Received: (at 54190) by debbugs.gnu.org; 4 Mar 2022 07:16:57 +0000 Received: from localhost ([127.0.0.1]:44437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQ2BM-0004rV-Tm for submit@debbugs.gnu.org; Fri, 04 Mar 2022 02:16:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQ2BL-0004rI-5F for 54190@debbugs.gnu.org; Fri, 04 Mar 2022 02:16:55 -0500 Received: from [2001:470:142:3::e] (port=41172 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ2BD-0001ld-G1; Fri, 04 Mar 2022 02:16:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=S8hJDtZMJBD0nBPTjkTWPHTGo6SvpVG2Xub5aQqgWPU=; b=YYXd+4e4WA8z SpQ2SlTNqnqcMoZ+5mj9wYL/8IC2gUvR+ecBPPua5mCkuzo6GmbYemAQ7g36ztMVMg5vGduM4HKzO Z9NxhSWrCdHgTgf3jNY3nRod4CpYr7/vc7HX2PsKJ9okP/ct1lxJl4BnXBgDOL61++8OSUrbYoAnM ByI68VkdgxK0v8BbSgPRvjO2F4ZEZMmg/PT+6LfKYApuT7yDUOJJgLy/dYVuvjBYdU8lb5Wj+BbfK iBc+UVm0hcuwA70diZT8/+3YUE/LdbNVio1ZpQfSBow0c84eaqIjs74aT5qjc4+n7R8ibIB2PmKTz Xcmujw5iGpcHjZjB0+n2Rw==; Received: from [87.69.77.57] (port=1754 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ2BA-0007JG-JN; Fri, 04 Mar 2022 02:16:47 -0500 Date: Fri, 04 Mar 2022 09:16:44 +0200 Message-Id: <83k0dai3vn.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> (message from Jim Porter on Thu, 3 Mar 2022 21:55:41 -0800) Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> <83ilsxlsx0.fsf@gnu.org> <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54190 Cc: larsi@gnus.org, 54190@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, 54190@debbugs.gnu.org, monnier@iro.umontreal.ca > From: Jim Porter > Date: Thu, 3 Mar 2022 21:55:41 -0800 > > After a bit of looking at the `eshell-do-eval' implementation, I > realized that there's a better solution that's very simple. See the > attached patch. It's simple enough that it might be fine for Emacs 28, > but the existing change on the 28 branch is probably a bit safer, since > that change was just a partial revert. I'm not aware of anything that > could be broken by this new patch, but you never know... Thanks, I think this should be installed on master. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 04 08:36:06 2022 Received: (at 54190) by debbugs.gnu.org; 4 Mar 2022 13:36:06 +0000 Received: from localhost ([127.0.0.1]:44849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQ86I-00086b-FC for submit@debbugs.gnu.org; Fri, 04 Mar 2022 08:36:06 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQ86G-000865-KD for 54190@debbugs.gnu.org; Fri, 04 Mar 2022 08:36:05 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EEB424413DB; Fri, 4 Mar 2022 08:35:58 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 22CD64413D8; Fri, 4 Mar 2022 08:35:51 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1646400951; bh=5FhExBFoM5eER4LApkt7LU6fd0znNva5YC82AQaLZgg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ncATQLg0bIcYyzrSoFZ2oOV3f86WO+9sFURgY7D8aDFdbRr/x71gt+WuDZSS0bFEQ DzvCn+NOjjGswjL/efKPx4gzFvmWUw2BhDSgWTdA9BCklxF8W1DD4mTmkOm0wXOhHD WFtcWEJnQ2p6tq1456f+EmUeqHfChnoKZRsZqnTztjto2Rhzt7nKXl5hYhrDd1CPxL 6LdMqd0BdcW6bvK0AwO9dArYa8GkSSucXz2wrPeXZff6oDUhtVVh1tsmd2LPv6ck8T /tvk5c54uEuHcpAkKhP7INCEI1T+C2U/hHTfkam7frWWa7IQN+QmPZJ6Ktkb8uiAog FQCmPiDyAHKdQ== Received: from pastel (unknown [45.72.208.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DE62F120189; Fri, 4 Mar 2022 08:35:50 -0500 (EST) From: Stefan Monnier To: Jim Porter Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes Message-ID: References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> <83ilsxlsx0.fsf@gnu.org> <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> Date: Fri, 04 Mar 2022 08:35:50 -0500 In-Reply-To: <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> (Jim Porter's message of "Thu, 3 Mar 2022 21:55:41 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54190 Cc: Eli Zaretskii , 54190@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > @@ -1077,7 +1077,7 @@ eshell-do-eval > (cond > ((not (listp form)) > (list 'quote (eval form))) > - ((memq (car form) '(quote function)) > + ((memq (car form) '(quote function lambda)) > form) > (t > ;; skip past the call to `eshell-do-eval' This looks like a workaround rather than a fix. eshell-do-eval supposedly handles code that uses macros. `lambda` is just one such macro (and a very simple one at that), so if the `lambda` macro is not properly handled, then most likely there are other macros which are similarly mishandled. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 04 13:04:32 2022 Received: (at 54190) by debbugs.gnu.org; 4 Mar 2022 18:04:32 +0000 Received: from localhost ([127.0.0.1]:46784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQCI4-0000uI-8g for submit@debbugs.gnu.org; Fri, 04 Mar 2022 13:04:32 -0500 Received: from mail-pj1-f50.google.com ([209.85.216.50]:37754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQCI2-0000u5-HW for 54190@debbugs.gnu.org; Fri, 04 Mar 2022 13:04:30 -0500 Received: by mail-pj1-f50.google.com with SMTP id p3-20020a17090a680300b001bbfb9d760eso11219570pjj.2 for <54190@debbugs.gnu.org>; Fri, 04 Mar 2022 10:04:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=3VDvRMpUq244oHGBqTEXzjCFvmoxqrHBzSVrJYiE7NU=; b=LBxMYV2EMd1Ul5/7O/WJau3suW7Gc5nhXp9LBCzv8tsHznBhg4ymRtkKIxYbrqAr1A nj43TjvaE+aUBhDpB/+0usQmqLl0eQPaYnuMJY71QdF95LghTtD8LRgFKA9Dq/SXNd3l gK6e8jUiw8itdFSqAHhMes05CaiWHPVkwzAFqvWp/ewMOda104HUX8vwuApBIoX54dtr oL/lb3bpwD8Gp87pfUCcacJdjl+/EYu+vh84yryKQ0tSPE4jyt6BvlVF6xaVR+KU22Lj WwTd2IqrkCE7z10RNxHiAT0kBXwyltg5sEz7X+oaaPbcmK/AdnbNLd9YOuim3R/Tle7s gngw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3VDvRMpUq244oHGBqTEXzjCFvmoxqrHBzSVrJYiE7NU=; b=kLvSfZbV9X0hsE9BekQmTkYa+aYR1WWxF0H3I5BcoemZq//HHBFkTMAXuhm9HVDd68 fjIKDBZEzaEy5GDIcwNFr5704gnydQjwF5fR0XBkLIxkmmH2DpzYMhFd5n8T7g7IMtG8 ewBo5UrB7omS/4e/ngcKxXWkY2FgTayCm6V9UClCa8UbshXNBXcimplz03RnJObTwFfs X0LKmqKkeijV9DhQY8YZk/GL3M9Eln8CvhCDCE+f2LC6IquxGkGgRkPfN6hTf6KIvyzw g+1DXxgqmGIKqjcs0WcRn8jCzqYNlgUc9Ey+TIaRx8bnrMxZQTAts0OpfW2sPS1MVmoi Xx5w== X-Gm-Message-State: AOAM5314BYVn5bNgM60ebbHDCFgWoXvvjoj2SwpI7DMRa7nnQm0mAPIG bsOCc59wqy7KrOCWHK8f/5w= X-Google-Smtp-Source: ABdhPJy3YhXXoDojoQWSWXMni2GR+8J7eRNknQk7TiYAElnoGMbe450ma1n4UzHxeBD/Zrgcx7lomA== X-Received: by 2002:a17:903:186:b0:151:9d28:f468 with SMTP id z6-20020a170903018600b001519d28f468mr12812302plg.102.1646417064737; Fri, 04 Mar 2022 10:04:24 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id p22-20020a056a000b5600b004f4103c2f0dsm6342419pfo.218.2022.03.04.10.04.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Mar 2022 10:04:24 -0800 (PST) Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes To: Stefan Monnier References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> <83ilsxlsx0.fsf@gnu.org> <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> From: Jim Porter Message-ID: <984b22e5-08fe-bb00-2039-936c9046c0ad@gmail.com> Date: Fri, 4 Mar 2022 10:04:22 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54190 Cc: Eli Zaretskii , 54190@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 3/4/2022 5:35 AM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > This looks like a workaround rather than a fix. > eshell-do-eval supposedly handles code that uses macros. `lambda` is > just one such macro (and a very simple one at that), so if the `lambda` > macro is not properly handled, then most likely there are other macros > which are similarly mishandled. Agreed. This is just intended as a slightly cleaner workaround than the previous one, but it's not a true fix. I think a real fix would be significantly more complex (e.g. using generator.el), and that might be better to track in a separate bug. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 07:28:41 2022 Received: (at 54190) by debbugs.gnu.org; 6 Sep 2022 11:28:41 +0000 Received: from localhost ([127.0.0.1]:49868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVWky-0000e8-OE for submit@debbugs.gnu.org; Tue, 06 Sep 2022 07:28:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVWkw-0000dt-Vk for 54190@debbugs.gnu.org; Tue, 06 Sep 2022 07:28:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xzsxH8EVFnmdnMNvtUECiV/2KgLFsgij2REdpb6lKlY=; b=c4X03szYiKrplCjZTgQ//SVA3F JwmV0S5abNqzQjoYbZENFSEeK1J5UCbZsFlHNdlqIrGfHHtYOg7/TCJAwjUlmSawwnqTAJt8HI3Db Rsw4XxJ4zkAYH1967uAZrqSLAr7CfquUrBQ0GBdMMfG3Ax8cSa6gGnkRTQ89Y7vo6VFI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVWkn-00044j-6M; Tue, 06 Sep 2022 13:28:31 +0200 From: Lars Ingebrigtsen To: Jim Porter Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes In-Reply-To: <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> (Jim Porter's message of "Thu, 3 Mar 2022 21:55:41 -0800") References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> <83ilsxlsx0.fsf@gnu.org> <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> X-Now-Playing: Yes's _Tormato_: "a) Future Times b) Rejoice" Date: Tue, 06 Sep 2022 13:28:28 +0200 Message-ID: <87pmg8spwj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > This doesn't do anything more elaborate like using generator.el's > machinery here; while (I think) that would be nice to have eventually, > we can address that in a separate bug, since it'd be a pr [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54190 Cc: Eli Zaretskii , 54190@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > This doesn't do anything more elaborate like using generator.el's > machinery here; while (I think) that would be nice to have eventually, > we can address that in a separate bug, since it'd be a pretty big > change. We could probably close this bug after this new patch merges. This was several months ago, but it doesn't look like this was ever merged. If you still think this is the right solution, please go ahead and merge. (The patch no longer merges cleanly.) From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 23:50:26 2022 Received: (at 54190-done) by debbugs.gnu.org; 7 Sep 2022 03:50:26 +0000 Received: from localhost ([127.0.0.1]:53095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVm53-0000vG-PQ for submit@debbugs.gnu.org; Tue, 06 Sep 2022 23:50:26 -0400 Received: from mail-pl1-f177.google.com ([209.85.214.177]:44954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVm4z-0000v1-V5 for 54190-done@debbugs.gnu.org; Tue, 06 Sep 2022 23:50:24 -0400 Received: by mail-pl1-f177.google.com with SMTP id 9so10021901plj.11 for <54190-done@debbugs.gnu.org>; Tue, 06 Sep 2022 20:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc:subject :date; bh=Z+meUI0fWSGBWalH2+hAUIRxvbOckVTmLgu7jt6TYOA=; b=IobmOZxnBWESuUvQEHaLoTPOK7lcmDJNuQ65exFssXeHJT0RfD1ttGq/UlZZfAeCl4 eiXK/wWlUoBmL/kPnIPloxwVKiCFMtXPVDDbI8BYuB2A1E0p9C3DFf9rfhHwOvEGqRzb 2WEEVR6/KExLUQqwKa4oP2nWtuHioQgOd9Nur2kkp8GZa8n9COeWO7hOQ5FYCr+Cz2dT 0PUEjJ1DO10ygmCf/nGM2Fa4qejoPCx3wpmqOmAr81fPG3mhjtF6wSWarexd5K1upTGn 7d0cV1Fgqc+BR3ynYYUiq3YxtROFb07jmP9Uq7Ff7BMZOJ9kZOYWjsGG8s/i590MntNj +1EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc:subject:date; bh=Z+meUI0fWSGBWalH2+hAUIRxvbOckVTmLgu7jt6TYOA=; b=BKEFvlqsBzIUv/cn1q351divsEFwb6+NTBjMFj87E+KoNSQW2mSkjLm0VaIjdQSPz2 2xCqx0j7GboFLFVoQm/Q+aDHb2wPEeEQUOKveiyY+clBKfP6ujyw+yULTno9ALmAir6j 7y44Y+W3eg9+rGkAWCj5XsJWWLNjItYMLuayByGZpCMng7eFGdfiasGtR5s0TM+81gW+ IiwuXonstVvh5MfW04A8dR3cl02XBWDV/k01cRvoOfuxA4x8DPDlcUiwxFKM3t1zDwiA wDy2EDweYnZ1vyu1N+Q3sw6GWjgg9xqN64ObmG4UTeHatFmD96Z7Fg/3iLK2YMI4OnmJ /0dg== X-Gm-Message-State: ACgBeo3RlDNxMR6SyDZmfptHAdyN0wqkHU3wd1XZnzzGVIeP4HXSCnuO pGg8YYaL8z4WXw9T6FjIug4= X-Google-Smtp-Source: AA6agR66/T52EcU5e2xNkndfCan/U5E4dE/i2J5LNw34s14ZZyWuZ7COdcadBJjBVCGmI64zXH69CA== X-Received: by 2002:a17:902:f60e:b0:176:73e1:3683 with SMTP id n14-20020a170902f60e00b0017673e13683mr1745405plg.27.1662522616036; Tue, 06 Sep 2022 20:50:16 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b14-20020a1709027e0e00b0017542c2ddabsm10822040plm.288.2022.09.06.20.50.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Sep 2022 20:50:14 -0700 (PDT) Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes To: Lars Ingebrigtsen References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> <83ilsxlsx0.fsf@gnu.org> <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> <87pmg8spwj.fsf@gnus.org> From: Jim Porter Message-ID: Date: Tue, 6 Sep 2022 20:50:14 -0700 MIME-Version: 1.0 In-Reply-To: <87pmg8spwj.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54190-done Cc: Eli Zaretskii , 54190-done@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 9/6/2022 4:28 AM, Lars Ingebrigtsen wrote: > Jim Porter writes: > >> This doesn't do anything more elaborate like using generator.el's >> machinery here; while (I think) that would be nice to have eventually, >> we can address that in a separate bug, since it'd be a pretty big >> change. We could probably close this bug after this new patch merges. > > This was several months ago, but it doesn't look like this was ever > merged. If you still think this is the right solution, please go ahead > and merge. (The patch no longer merges cleanly.) This got merged into Emacs 28 as 2c3d1b6bf41509bf0ba8995925fec9f20d8ed89d, but I think it was left open since there was some discussion about rewriting 'eshell-do-eval' on top of generator.el. Let's close this, and I'll file a separate followup for the generator.el bit. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 00:00:01 2022 Received: (at 54190) by debbugs.gnu.org; 7 Sep 2022 04:00:01 +0000 Received: from localhost ([127.0.0.1]:53120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVmEK-0001AR-SR for submit@debbugs.gnu.org; Wed, 07 Sep 2022 00:00:01 -0400 Received: from mail-pg1-f175.google.com ([209.85.215.175]:35453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVmEI-0001AA-4k for 54190@debbugs.gnu.org; Tue, 06 Sep 2022 23:59:59 -0400 Received: by mail-pg1-f175.google.com with SMTP id t65so1476612pgt.2 for <54190@debbugs.gnu.org>; Tue, 06 Sep 2022 20:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:references:cc:to:from:subject:from:to:cc:subject :date; bh=U4R6GHPUSbi9fLV3rTPl+7yxBHnGUDDiDx3ReLfkd9s=; b=k1UoE9wPtvLqBU8rRicTgUw72NbQIZ/51Qaln+fLldZHmYmx7HN9826LhTIQYaasYT +2lYopfIj+FgnMPxtsZbi7AvhimJKsBvDW7lmeZfjqIUIkHkwq9G/IFmU/H7dDp7D2wQ L8rqd6FJYkkLFJnNqWKA7PgX0PauSWOE5eUBL6YYofmRwqUSv14PLhT/BzUWRZv2z/X6 hjfTzRLccqiBcyw2jcOIzp0svK/YXsNEtvSLrnSVjdQFHN+UWoW90pDJib3/ZcZLyUgJ j6DvehAgiKHLiQ8adEfcv0xD42nmWcKLGZ76PUmygGNAdYx78TN9NYq1ynb5d0yEzsml vpWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:references:cc:to:from:subject:x-gm-message-state :from:to:cc:subject:date; bh=U4R6GHPUSbi9fLV3rTPl+7yxBHnGUDDiDx3ReLfkd9s=; b=Bzm8eotiKdYIbG1bu/091qB0uy7ITkHBmmNbl03Il/PaBD52tjbxoE4yNSicKO9nSV MprAeKGbPaZ2kfUS7Q+MYcIpFmwciYDenBpVK2la6232LxTrnKzds+zm7a1cEVc8lGAD EpIU8TfwcHly4cysK4WE7HrUrYmeWkjk8h6IYCrZ69HLqT293CACOT4dUq9bnds+ameb WF0UapVuPD/w5VnpEsWhs2CZYZM3UJ2ixB8tQJGijLZdIwDrjSiBp1oEDOuc6pZr1WcL eeBmItIVnxFRJ1TcHxMyGOLNQ7HXWZcGGo4jk9QM9UM3RFIxf9dNFMrd25HhaWEIT9kM L98g== X-Gm-Message-State: ACgBeo0NaH7lZgsU5nCg5tAVq1JKxk+j/c/DUPqa8wfRIfpEQg2W190o jvl/ZfjEpX+Fj3R8YGsna5g= X-Google-Smtp-Source: AA6agR6FeZ9mmpewQMLDImf/EtpYloqW7ft5nPvZNn14V7UuTBj2CyTXbype6qD6IgfLKhRvuF2Xfw== X-Received: by 2002:a62:5ec6:0:b0:538:3aa:7fe5 with SMTP id s189-20020a625ec6000000b0053803aa7fe5mr1932016pfb.73.1662523192277; Tue, 06 Sep 2022 20:59:52 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id q8-20020a170902dac800b001713af9e85dsm10908140plx.180.2022.09.06.20.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Sep 2022 20:59:51 -0700 (PDT) Subject: Re: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes From: Jim Porter To: Lars Ingebrigtsen References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> <83ilsxlsx0.fsf@gnu.org> <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> <87pmg8spwj.fsf@gnus.org> Message-ID: <28535bd2-e8de-34e1-e703-5e44c78ac825@gmail.com> Date: Tue, 6 Sep 2022 20:59:51 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54190 Cc: Eli Zaretskii , 54190@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 9/6/2022 8:50 PM, Jim Porter wrote: > Let's close this, and I'll file a separate followup for the > generator.el bit. Filed bug#57635 for the generator.el followup. From unknown Mon Jun 16 23:45:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 05 Oct 2022 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator