GNU bug report logs - #54177
28.0.91; project-find-regexp misbehaves with ripgrep over tramp/sudo

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54177 in the body.
You can then email your comments to 54177 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.91; project-find-regexp misbehaves with ripgrep over tramp/sudo
Date: Sun, 27 Feb 2022 04:45:14 +0200

It shows only one match per file, apparently because the process
invocations over the 'sudo' transport are recognized as working in a
terminal. At least by ripgrep.

To repro:

1. (setq xref-search-program 'ripgrep)
2. C-x C-f /sudo:dgutov <at> localhost:vc/emacs/ RET
3. M-x project-find-regexp RET associative RET
4. Note seeing only one match per file.

FWIW, the fix is really simple:

diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 0ee7dd5cad..2fd5e19237 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -1626,7 +1626,7 @@ xref-search-program-alist
     (ripgrep
      .
      ;; '!*/' is there to filter out dirs (e.g. submodules).
-     "xargs -0 rg <C> --null -nH --no-messages -g '!*/' -e <R>"
+     "xargs -0 rg <C> --null -nH --no-heading --no-messages -g '!*/' -e 
<R>"
      ))
   "Associative list mapping program identifiers to command templates.

Is this okay for Emacs 28?

The problem might affect other Tramp transports as well (for all I
know), or maybe even other platforms. The risk for the fix seems minimal.

Message #8 received at 54177 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 54177 <at> debbugs.gnu.org
Subject: Re: bug#54177: 28.0.91;
 project-find-regexp misbehaves with ripgrep over tramp/sudo
Date: Sun, 27 Feb 2022 09:31:44 +0200

> Date: Sun, 27 Feb 2022 04:45:14 +0200
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> 
> --- a/lisp/progmodes/xref.el
> +++ b/lisp/progmodes/xref.el
> @@ -1626,7 +1626,7 @@ xref-search-program-alist
>       (ripgrep
>        .
>        ;; '!*/' is there to filter out dirs (e.g. submodules).
> -     "xargs -0 rg <C> --null -nH --no-messages -g '!*/' -e <R>"
> +     "xargs -0 rg <C> --null -nH --no-heading --no-messages -g '!*/' -e 
> <R>"
>        ))
>     "Associative list mapping program identifiers to command templates.
> 
> Is this okay for Emacs 28?

Is this additional switch supported by all versions of 'rg'?

Message #11 received at 54177 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 54177 <at> debbugs.gnu.org
Subject: Re: bug#54177: 28.0.91; project-find-regexp misbehaves with ripgrep
 over tramp/sudo
Date: Sun, 27 Feb 2022 15:07:46 +0200

On 27.02.2022 09:31, Eli Zaretskii wrote:
> Is this additional switch supported by all versions of 'rg'?

Yes, of course. It's been there from the beginning.

Message #14 received at 54177 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 54177 <at> debbugs.gnu.org
Subject: Re: bug#54177: 28.0.91; project-find-regexp misbehaves with ripgrep
 over tramp/sudo
Date: Sun, 27 Feb 2022 15:16:31 +0200

> Date: Sun, 27 Feb 2022 15:07:46 +0200
> Cc: 54177 <at> debbugs.gnu.org
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> 
> On 27.02.2022 09:31, Eli Zaretskii wrote:
> > Is this additional switch supported by all versions of 'rg'?
> 
> Yes, of course. It's been there from the beginning.

Then I'm okay with installing this on the release branch.

Thanks.

Message #17 received at 54177 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 54177 <at> debbugs.gnu.org
Subject: Re: bug#54177: 28.0.91; project-find-regexp misbehaves with ripgrep
 over tramp/sudo
Date: Sun, 27 Feb 2022 15:28:46 +0200

On 27.02.2022 15:16, Eli Zaretskii wrote:
> Then I'm okay with installing this on the release branch.

Thanks, done.

Message #22 received at 54177-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 54177-done <at> debbugs.gnu.org
Subject: Re: bug#54177: 28.0.91; project-find-regexp misbehaves with ripgrep
 over tramp/sudo
Date: Sun, 27 Feb 2022 15:41:21 +0200

On 27.02.2022 15:28, Dmitry Gutov wrote:
> On 27.02.2022 15:16, Eli Zaretskii wrote:
>> Then I'm okay with installing this on the release branch.
> 
> Thanks, done.
> 
> 
> 

And closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.