From unknown Sat Aug 16 20:57:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#5417 <5417@debbugs.gnu.org> To: bug#5417 <5417@debbugs.gnu.org> Subject: Status: Patch for animate.el bugs `animate-n-steps', `animate-sequence', `animate-birthday-present' Reply-To: bug#5417 <5417@debbugs.gnu.org> Date: Sun, 17 Aug 2025 03:57:14 +0000 retitle 5417 Patch for animate.el bugs `animate-n-steps', `animate-sequence= ', `animate-birthday-present' reassign 5417 emacs submitter 5417 MON KEY severity 5417 minor tag 5417 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 18 18:22:38 2010 Received: (at submit) by debbugs.gnu.org; 18 Jan 2010 23:22:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NX0vd-0008Vf-LX for submit@debbugs.gnu.org; Mon, 18 Jan 2010 18:22:37 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NX0vb-0008VU-Lg for submit@debbugs.gnu.org; Mon, 18 Jan 2010 18:22:36 -0500 Received: from mail.gnu.org ([199.232.76.166]:59660 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NX0vX-0001cg-OL for submit@debbugs.gnu.org; Mon, 18 Jan 2010 18:22:31 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NX0vV-0001qa-SF for submit@debbugs.gnu.org; Mon, 18 Jan 2010 18:22:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:50609) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NX0vV-0001qQ-9c for submit@debbugs.gnu.org; Mon, 18 Jan 2010 18:22:29 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NX0vU-0007me-MY for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2010 18:22:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NX0vP-0007mS-0o for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2010 18:22:27 -0500 Received: from [199.232.76.173] (port=47163 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NX0vO-0007mP-TX for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2010 18:22:22 -0500 Received: from mail-yx0-f191.google.com ([209.85.210.191]:43715) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NX0vO-0001oS-Hb for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2010 18:22:22 -0500 Received: by yxe29 with SMTP id 29so7604916yxe.14 for ; Mon, 18 Jan 2010 15:22:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.150.87.2 with SMTP id k2mr6507042ybb.267.1263856940482; Mon, 18 Jan 2010 15:22:20 -0800 (PST) Date: Mon, 18 Jan 2010 18:22:20 -0500 X-Google-Sender-Auth: 758ad99cf35162fe Message-ID: Subject: Patch for animate.el bugs `animate-n-steps', `animate-sequence', `animate-birthday-present' From: MON KEY To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary=000e0cd35112fc01d4047d789f06 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) --000e0cd35112fc01d4047d789f06 Content-Type: text/plain; charset=UTF-8 This is a bug report regarding play/animate.el for: variable `animate-n-steps' function `animate-sequence' function `animate-birthday-present' As there are not any customization options for this package the docstring of variable `animate-n-steps': "Number of steps to use `animate-string'." should get the asterisk leadin docstring asterisk as presumably (user-variable-p 'animate-n-steps) should evaluate to t. It currently does not. The function `animate-sequence' switches to the buffer "*Animation*" by default. The user should have some way to bind an alternate destination. The function `animate-birthday-present' uses a default buffer "Sarah". This is not a good default. Also, it should capitalize the name in the returned animated strring. The patch below attempt to address some of these concerns without resorting to defcustom forms which understandably might be overkill given this packages directory location e.g. /lisp/play/animate.el Note, it adds a variable `*animation*'. ;;; ============================== --- /quickfixes/lisp/play/animate.el.~99304~ 2010-01-18 17:44:04.000000000 -0500 +++ /quickfixes/lisp/play/animate.el 2010-01-18 17:13:27.000000000 -0500 @@ -90,11 +90,15 @@ (insert-char char 1)) (defvar animate-n-steps 10 - "Number of steps to use `animate-string'.") +"*Number of steps `animate-string' will place a char before its last position.") + +(defvar *animation* nil + "*String naming the default buffer for animations. +When null animations dipslayed in the buffer named *Animation*.") ;;;###autoload (defun animate-string (string vpos &optional hpos) - "Display STRING starting at position VPOS, HPOS, using animation. + "Display STRING animations starting at position VPOS, HPOS. The characters start at randomly chosen places, and all slide in parallel to their final positions, passing through `animate-n-steps' positions before the final ones. @@ -139,14 +143,20 @@ ;;;###autoload (defun animate-sequence (list-of-strings space) - "Display strings from LIST-OF-STRING with animation in a new buffer. -Strings will be separated from each other by SPACE lines." + "Display animation strings from LIST-OF-STRING with buffer *Animation*. +Strings will be separated from each other by SPACE lines. +When the variable `*animation*' is non-nil display animation in the +buffer named by variable's value creating the buffer if one does not exist." (let ((vpos (/ (- (window-height) 1 ;; For the mode-line (* (1- (length list-of-strings)) space) (length list-of-strings)) 2))) - (switch-to-buffer (get-buffer-create "*Animation*")) + (switch-to-buffer (get-buffer-create + (if (and (bound-and-true-p *animation*) + (stringp *animation*)) + *animation* + (capitalize (symbol-name '*animation*))))) (erase-buffer) (sit-for 0) (while list-of-strings @@ -156,19 +166,24 @@ ;;;###autoload (defun animate-birthday-present (&optional name) - "Display one's birthday present in a new buffer. -You can specify the one's name by NAME; the default value is \"Sarah\"." - (interactive (list (read-string "Name (default Sarah): " - nil nil "Sarah"))) + "Return a birthday present in the buffer *Birthday-Present*. +When optional arg NAME is non-nil or called-interactively, prompt for +NAME of birthday present receiver and return a birthday present in +the buffer *Birthday-Present-for-Name*." + (interactive (list (read-string "Birthday present for: " + nil nil))) ;; Make a suitable buffer to display the birthday present in. - (switch-to-buffer (get-buffer-create (format "*%s*" name))) + (switch-to-buffer (get-buffer-create (if name + (concat "*A-Present-for-" (capitalize name) "*") + "*Birthday-Present*"))) (erase-buffer) ;; Display the empty buffer. (sit-for 0) - (animate-string "Happy Birthday," 6) - (animate-string (format "%s" name) 7) - + (if name + (animate-string "Happy Birthday," 6) + (animate-string "Happy Birthday" 6)) + (when name (animate-string (format "%s" (capitalize name)) 7)) (sit-for 1) (animate-string "You are my sunshine," 10 30) ;;; ============================== --000e0cd35112fc01d4047d789f06 Content-Type: application/octet-stream; name="animate.el.diff" Content-Disposition: attachment; filename="animate.el.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g4lvs6kq0 Ci0tLSAvcXVpY2tmaXhlcy9saXNwL3BsYXkvYW5pbWF0ZS5lbC5+OTkzMDR+CTIwMTAtMDEtMTgg MTc6NDQ6MDQuMDAwMDAwMDAwIC0wNTAwCisrKyAvcXVpY2tmaXhlcy9saXNwL3BsYXkvYW5pbWF0 ZS5lbAkyMDEwLTAxLTE4IDE3OjEzOjI3LjAwMDAwMDAwMCAtMDUwMApAQCAtOTAsMTEgKzkwLDE1 IEBACiAgIChpbnNlcnQtY2hhciBjaGFyIDEpKQogCiAoZGVmdmFyIGFuaW1hdGUtbi1zdGVwcyAx MAotICAiTnVtYmVyIG9mIHN0ZXBzIHRvIHVzZSBgYW5pbWF0ZS1zdHJpbmcnLiIpCisiKk51bWJl ciBvZiBzdGVwcyBgYW5pbWF0ZS1zdHJpbmcnIHdpbGwgcGxhY2UgYSBjaGFyIGJlZm9yZSBpdHMg bGFzdCBwb3NpdGlvbi4iKQorCisoZGVmdmFyICphbmltYXRpb24qIG5pbAorICAiKlN0cmluZyBu YW1pbmcgdGhlIGRlZmF1bHQgYnVmZmVyIGZvciBhbmltYXRpb25zLgorV2hlbiBudWxsIGFuaW1h dGlvbnMgZGlwc2xheWVkIGluIHRoZSBidWZmZXIgbmFtZWQgKkFuaW1hdGlvbiouIikKIAogOzs7 IyMjYXV0b2xvYWQKIChkZWZ1biBhbmltYXRlLXN0cmluZyAoc3RyaW5nIHZwb3MgJm9wdGlvbmFs IGhwb3MpCi0gICJEaXNwbGF5IFNUUklORyBzdGFydGluZyBhdCBwb3NpdGlvbiBWUE9TLCBIUE9T LCB1c2luZyBhbmltYXRpb24uCisgICJEaXNwbGF5IFNUUklORyBhbmltYXRpb25zIHN0YXJ0aW5n IGF0IHBvc2l0aW9uIFZQT1MsIEhQT1MuCiBUaGUgY2hhcmFjdGVycyBzdGFydCBhdCByYW5kb21s eSBjaG9zZW4gcGxhY2VzLAogYW5kIGFsbCBzbGlkZSBpbiBwYXJhbGxlbCB0byB0aGVpciBmaW5h bCBwb3NpdGlvbnMsCiBwYXNzaW5nIHRocm91Z2ggYGFuaW1hdGUtbi1zdGVwcycgcG9zaXRpb25z IGJlZm9yZSB0aGUgZmluYWwgb25lcy4KQEAgLTEzOSwxNCArMTQzLDIwIEBACiAKIDs7OyMjI2F1 dG9sb2FkCiAoZGVmdW4gYW5pbWF0ZS1zZXF1ZW5jZSAobGlzdC1vZi1zdHJpbmdzIHNwYWNlKQot ICAiRGlzcGxheSBzdHJpbmdzIGZyb20gTElTVC1PRi1TVFJJTkcgd2l0aCBhbmltYXRpb24gaW4g YSBuZXcgYnVmZmVyLgotU3RyaW5ncyB3aWxsIGJlIHNlcGFyYXRlZCBmcm9tIGVhY2ggb3RoZXIg YnkgU1BBQ0UgbGluZXMuIgorICAiRGlzcGxheSBhbmltYXRpb24gc3RyaW5ncyBmcm9tIExJU1Qt T0YtU1RSSU5HIHdpdGggYnVmZmVyICpBbmltYXRpb24qLgorU3RyaW5ncyB3aWxsIGJlIHNlcGFy YXRlZCBmcm9tIGVhY2ggb3RoZXIgYnkgU1BBQ0UgbGluZXMuIAorV2hlbiB0aGUgdmFyaWFibGUg YCphbmltYXRpb24qJyBpcyBub24tbmlsIGRpc3BsYXkgYW5pbWF0aW9uIGluIHRoZQorYnVmZmVy IG5hbWVkIGJ5IHZhcmlhYmxlJ3MgdmFsdWUgY3JlYXRpbmcgdGhlIGJ1ZmZlciBpZiBvbmUgZG9l cyBub3QgZXhpc3QuIgogICAobGV0ICgodnBvcyAoLyAoLSAod2luZG93LWhlaWdodCkKIAkJICAg IDEgOzsgRm9yIHRoZSBtb2RlLWxpbmUKIAkJICAgICgqICgxLSAobGVuZ3RoIGxpc3Qtb2Ytc3Ry aW5ncykpIHNwYWNlKQogCQkgICAgKGxlbmd0aCBsaXN0LW9mLXN0cmluZ3MpKQogCQkgMikpKQot ICAgIChzd2l0Y2gtdG8tYnVmZmVyIChnZXQtYnVmZmVyLWNyZWF0ZSAiKkFuaW1hdGlvbioiKSkK KyAgICAoc3dpdGNoLXRvLWJ1ZmZlciAoZ2V0LWJ1ZmZlci1jcmVhdGUgCisgICAgICAgICAgICAg ICAgICAgICAgIChpZiAoYW5kIChib3VuZC1hbmQtdHJ1ZS1wICphbmltYXRpb24qKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5ncCAqYW5pbWF0aW9uKikpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICphbmltYXRpb24qCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAoY2FwaXRhbGl6ZSAoc3ltYm9sLW5hbWUgJyphbmltYXRpb24qKSkpKSkKICAgICAo ZXJhc2UtYnVmZmVyKQogICAgIChzaXQtZm9yIDApCiAgICAgKHdoaWxlIGxpc3Qtb2Ytc3RyaW5n cwpAQCAtMTU2LDE5ICsxNjYsMjQgQEAKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBhbmltYXRl LWJpcnRoZGF5LXByZXNlbnQgKCZvcHRpb25hbCBuYW1lKQotICAiRGlzcGxheSBvbmUncyBiaXJ0 aGRheSBwcmVzZW50IGluIGEgbmV3IGJ1ZmZlci4KLVlvdSBjYW4gc3BlY2lmeSB0aGUgb25lJ3Mg bmFtZSBieSBOQU1FOyB0aGUgZGVmYXVsdCB2YWx1ZSBpcyBcIlNhcmFoXCIuIgotICAoaW50ZXJh Y3RpdmUgKGxpc3QgKHJlYWQtc3RyaW5nICJOYW1lIChkZWZhdWx0IFNhcmFoKTogIgotCQkJCSAg bmlsIG5pbCAiU2FyYWgiKSkpCisgICJSZXR1cm4gYSBiaXJ0aGRheSBwcmVzZW50IGluIHRoZSBi dWZmZXIgKkJpcnRoZGF5LVByZXNlbnQqLgorV2hlbiBvcHRpb25hbCBhcmcgTkFNRSBpcyBub24t bmlsIG9yIGNhbGxlZC1pbnRlcmFjdGl2ZWx5LCBwcm9tcHQgZm9yCitOQU1FIG9mIGJpcnRoZGF5 IHByZXNlbnQgcmVjZWl2ZXIgYW5kIHJldHVybiBhIGJpcnRoZGF5IHByZXNlbnQgaW4KK3RoZSBi dWZmZXIgKkJpcnRoZGF5LVByZXNlbnQtZm9yLU5hbWUqLiIKKyAgKGludGVyYWN0aXZlIChsaXN0 IChyZWFkLXN0cmluZyAiQmlydGhkYXkgcHJlc2VudCBmb3I6ICIKKwkJCQkgIG5pbCBuaWwpKSkK ICAgOzsgTWFrZSBhIHN1aXRhYmxlIGJ1ZmZlciB0byBkaXNwbGF5IHRoZSBiaXJ0aGRheSBwcmVz ZW50IGluLgotICAoc3dpdGNoLXRvLWJ1ZmZlciAoZ2V0LWJ1ZmZlci1jcmVhdGUgKGZvcm1hdCAi KiVzKiIgbmFtZSkpKQorICAoc3dpdGNoLXRvLWJ1ZmZlciAoZ2V0LWJ1ZmZlci1jcmVhdGUgKGlm IG5hbWUgCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNvbmNh dCAiKkEtUHJlc2VudC1mb3ItIiAoY2FwaXRhbGl6ZSBuYW1lKSAiKiIpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIipCaXJ0aGRheS1QcmVzZW50KiIpKSkKICAg KGVyYXNlLWJ1ZmZlcikKICAgOzsgRGlzcGxheSB0aGUgZW1wdHkgYnVmZmVyLgogICAoc2l0LWZv ciAwKQogCi0gIChhbmltYXRlLXN0cmluZyAiSGFwcHkgQmlydGhkYXksIiA2KQotICAoYW5pbWF0 ZS1zdHJpbmcgKGZvcm1hdCAiJXMiIG5hbWUpIDcpCi0KKyAgKGlmIG5hbWUgCisgICAgICAoYW5p bWF0ZS1zdHJpbmcgIkhhcHB5IEJpcnRoZGF5LCIgNikKKyAgICAgIChhbmltYXRlLXN0cmluZyAi SGFwcHkgQmlydGhkYXkiIDYpKQorICAod2hlbiBuYW1lIChhbmltYXRlLXN0cmluZyAoZm9ybWF0 ICIlcyIgKGNhcGl0YWxpemUgbmFtZSkpIDcpKQogICAoc2l0LWZvciAxKQogCiAgIChhbmltYXRl LXN0cmluZyAiWW91IGFyZSBteSBzdW5zaGluZSwiIDEwIDMwKQoKCg== --000e0cd35112fc01d4047d789f06-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 18 18:43:51 2010 Received: (at control) by debbugs.gnu.org; 18 Jan 2010 23:43:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NX1GA-0000M8-SZ for submit@debbugs.gnu.org; Mon, 18 Jan 2010 18:43:50 -0500 Received: from mail-bw0-f211.google.com ([209.85.218.211]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NX1G9-0000M0-Un for control@debbugs.gnu.org; Mon, 18 Jan 2010 18:43:50 -0500 Received: by bwz3 with SMTP id 3so1628664bwz.16 for ; Mon, 18 Jan 2010 15:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=Emow+U7x8CJAW+P8zMMhYQB0TVNRAlpkiuv59bZLa74=; b=C1R61ybn1vp1LPFIqTtgSFfvN6s8ftDJud6G+uOQFqWK7zyd6mkSJE9ua7GU4KJUE7 8mvZj0JQCiZzdAq9ATAvbbYxuA7TWUta39VrIa5wKNZRYRPUpjkdpE9P+e9WfG8CazPP G3zEOlyuyUf8S7TDHwvYD8JJbgHSi9/y4Ut8Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=b/QK9yWvR0xOGRK4f2p5OEuLvEiECuys90FnhesukIY+Ry+qbxSK7Of4JQQV6grwp7 tkVyNvFTbyhgQ4E0E8nBI/bCj1mmTJhZFA33ymmhmAQfLUsdV1o5RfOJYCJWc4FxZ8WI CRoN/h6kgduMwSu7Iqo6ZxK5GdSM5ZhMmJHr0= MIME-Version: 1.0 Received: by 10.204.30.208 with SMTP id v16mr3842738bkc.18.1263858225142; Mon, 18 Jan 2010 15:43:45 -0800 (PST) From: Juanma Barranquero Date: Tue, 19 Jan 2010 00:43:24 +0100 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.8 (-) tags 5417 + patch severity 5417 minor reassign 5395 emacs,cc-mode quit From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 03 15:37:24 2011 Received: (at 5417) by debbugs.gnu.org; 3 Jul 2011 19:37:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdSTs-0006ZY-Fc for submit@debbugs.gnu.org; Sun, 03 Jul 2011 15:37:24 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdSTp-0006ZM-OH for 5417@debbugs.gnu.org; Sun, 03 Jul 2011 15:37:23 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QdSTd-0005dx-Mf; Sun, 03 Jul 2011 21:37:09 +0200 From: Lars Magne Ingebrigtsen To: MON KEY Subject: Re: Patch for animate.el bugs `animate-n-steps', `animate-sequence', `animate-birthday-present' In-Reply-To: (MON KEY's message of "Mon, 18 Jan 2010 18:22:20 -0500") Date: Sun, 03 Jul 2011 21:36:54 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: The Notwist's _Storm_: "Sarajevo 2" X-Hashcash: 1:23:110703:monkey@sandpframing.com::qN2MIliNr4SLf2QN:00000000000000000000000000000000000000Lu8K X-Hashcash: 1:23:110703:5417@debbugs.gnu.org::8HJTzgYMIxSOhieO:000000000000000000000000000000000000000016bVb MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QdSTd-0005dx-Mf X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310326630.10239@ktJ2/sQIv9ZKKXsSwpjtow X-Spam-Status: No X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 5417 Cc: 5417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) MON KEY writes: > This is a bug report regarding play/animate.el for: > > variable `animate-n-steps' > function `animate-sequence' > function `animate-birthday-present' The patch looks OK to me. It's over 10 lines, though, so the FSF needs copyright assignment papers on file before I can apply the patch. Do you have such papers on file with the FSF? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 03 22:41:47 2011 Received: (at 5417) by debbugs.gnu.org; 4 Jul 2011 02:41:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdZ6Z-0004rk-Nv for submit@debbugs.gnu.org; Sun, 03 Jul 2011 22:41:47 -0400 Received: from vm-emlprdomr-02.its.yale.edu ([130.132.50.143]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdZ6Y-0004rZ-ET for 5417@debbugs.gnu.org; Sun, 03 Jul 2011 22:41:46 -0400 Received: from furball (dhcp128036225047.central.yale.edu [128.36.225.47]) (authenticated bits=0) by vm-emlprdomr-02.its.yale.edu (8.14.4/8.14.4) with ESMTP id p642feud014584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 3 Jul 2011 22:41:41 -0400 From: Chong Yidong To: Lars Magne Ingebrigtsen Subject: Re: bug#5417: Patch for animate.el bugs `animate-n-steps', `animate-sequence', `animate-birthday-present' References: Date: Sun, 03 Jul 2011 22:41:40 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sun, 03 Jul 2011 21:36:54 +0200") Message-ID: <8762ni4viz.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.143 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 5417 Cc: 5417@debbugs.gnu.org, MON KEY X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Lars Magne Ingebrigtsen writes: > It's over 10 lines, though, so the FSF needs copyright assignment papers > on file before I can apply the patch. > > Do you have such papers on file with the FSF? Yes, he has an assignment. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 04 07:45:57 2011 Received: (at control) by debbugs.gnu.org; 4 Jul 2011 11:45:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdhbA-0003Pp-TZ for submit@debbugs.gnu.org; Mon, 04 Jul 2011 07:45:57 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qdhb9-0003Pe-5Q for control@debbugs.gnu.org; Mon, 04 Jul 2011 07:45:56 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qdhax-0007Oo-4w for control@debbugs.gnu.org; Mon, 04 Jul 2011 13:45:43 +0200 Date: Mon, 04 Jul 2011 13:45:42 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #5417 X-MailScanner-ID: 1Qdhax-0007Oo-4w X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310384743.23526@ugzdz5Y+x/vLD/wYUA/R8g X-Spam-Status: No X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) tags 5417 fixed close 5417 24.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 04 07:46:15 2011 Received: (at 5417) by debbugs.gnu.org; 4 Jul 2011 11:46:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdhbT-0003Qz-7o for submit@debbugs.gnu.org; Mon, 04 Jul 2011 07:46:15 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdhbQ-0003Qm-V6 for 5417@debbugs.gnu.org; Mon, 04 Jul 2011 07:46:14 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QdhbF-0007Qs-Fp; Mon, 04 Jul 2011 13:46:01 +0200 From: Lars Magne Ingebrigtsen To: MON KEY Subject: Re: Patch for animate.el bugs `animate-n-steps', `animate-sequence', `animate-birthday-present' In-Reply-To: (MON KEY's message of "Mon, 18 Jan 2010 18:22:20 -0500") Date: Mon, 04 Jul 2011 13:45:58 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Joanna Newsom's _Have One On Me (2)_: "Go Long" X-Hashcash: 1:23:110704:bug-gnu-emacs@gnu.org::VJnoyDPrls0bs0JR:00000000000000000000000000000000000000009XsP X-Hashcash: 1:23:110704:monkey@sandpframing.com::g1Tn22TcRMS/oReH:00000000000000000000000000000000000000EN2S X-Hashcash: 1:23:110704:5417@debbugs.gnu.org::vbtJZ+OZGtGb8ly3:00000000000000000000000000000000000000000MBZW MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QdhbF-0007Qs-Fp X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310384762.04432@estBGQe9TfQD5Ib9kNRrxA X-Spam-Status: No X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 5417 Cc: 5417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) MON KEY writes: > The patch below attempt to address some of these concerns without resorting to > defcustom forms which understandably might be overkill given this packages > directory location e.g. /lisp/play/animate.el I've now applied your patch, and fixed up the naming to match Emacs' conventions. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Sat Aug 16 20:57:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Aug 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator