GNU bug report logs - #54136
29.0.50; Eshell emits extra prompts when killing processes in some cases

Previous Next

Full log

Message #22 received at 54136 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 54136 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#54136: 29.0.50; Eshell emits extra prompts when killing
 processes in some cases
Date: Thu, 24 Feb 2022 22:03:36 +0200

> Cc: 54136 <at> debbugs.gnu.org
> From: Jim Porter <jporterbugs <at> gmail.com>
> Date: Thu, 24 Feb 2022 10:55:48 -0800
> 
> > I'm quite sure about the "sh" vs "sh.exe" part, but what about the
> > "killed" vs "interrupt" part? any idea why this happens on MS-Windows?
> 
> I think this makes sense. POSIX-style signal handling on MS Windows is 
> only approximate, so I'm not surprised it produces some surprising 
> results like that. Maybe it's possible to pass the signal code through 
> the process exit status more accurately, but that's probably only a 
> partial solution at best (due to the API differences), and at worst 
> could break Emacs's subprocess handling for MS Windows in subtle ways.
> 
> Another solution would be to replace the call to `eshell-kill-process' 
> in `esh-proc-test/kill-pipeline' with `eshell-interrupt-process'. Then 
> the exit status should be "interrupt\n" on all platforms. I've verified 
> that that works ok on GNU/Linux, but it's possible that it runs into 
> some other issue on MS Windows.
> 
> This is sort of just working around the issue, but I also think there's 
> an argument that `eshell-interrupt-process' is the more "natural" 
> function to call, since it corresponds to a user hitting ^C in the shell 
> (or C-c C-c in Eshell).

OK, so I installed my changes.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.