From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 00:11:55 2022 Received: (at submit) by debbugs.gnu.org; 24 Feb 2022 05:11:55 +0000 Received: from localhost ([127.0.0.1]:47156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN6Pz-0000PA-JY for submit@debbugs.gnu.org; Thu, 24 Feb 2022 00:11:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:48358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN6Py-0000P0-F5 for submit@debbugs.gnu.org; Thu, 24 Feb 2022 00:11:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nN6Py-0001jz-3j for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 00:11:54 -0500 Received: from [2607:f8b0:4864:20::435] (port=36849 helo=mail-pf1-x435.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nN6Pu-0001IY-SD for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 00:11:53 -0500 Received: by mail-pf1-x435.google.com with SMTP id z16so889399pfh.3 for ; Wed, 23 Feb 2022 21:11:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:message-id:date:mime-version:content-language :content-transfer-encoding; bh=NdU8k40TCy9G/oanCj0cgSSOnOapAwR0R82w8IKbvKg=; b=Wr3r1tq91lpq/ECgBZxCmvspMqU4pfpWwVqXG+/eybTj8+bEZieagCFrxSeU0aXTw8 eeRhlnpNhcHtbfLqCVLcEoc9tjDlF3BI0CAp4z1RjdJcsY2xKR5EehY/bxseTndNkb8f 5V2VKMZl9CYW+bjiROQ0Tn1p39rdqCLx/8mKeiudz0fSFfhCX7iXduPYIjdr/QJtcGaK A/n9a5lK/OL1yr4uB8JwK7rSiK3kyr31IyapjCdIinPK2PTOOOWcBCO2Epk/XIVgNuyt /w2QNJfxLfHtxjp9sy7ioO5LKfMw/qwzbsDM+/xI2vXfTK43heJoqUs3wdmVJdURW/9U AvqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:message-id:date:mime-version :content-language:content-transfer-encoding; bh=NdU8k40TCy9G/oanCj0cgSSOnOapAwR0R82w8IKbvKg=; b=YXOSIuJSOQ68fXQ3TuKKObsUJb3919+74pchTgD9/2fE4geKDmedAnjn5tgx/KUMzi GRsGL0ICTqBZl61Ux8ZuepzsnoOD7D3zN4FloS4WiH5ho4kxjXFZhJgMcg39OzSXCTvB 9i2vCz57ZRODzt9gqfZt3rh1OMLvb9rcBEwDCimUwIE8tiIk1ispit5oowPnUSYvKy73 vPQ0GuUMZWO0RQn4Upp5J4l8z2ScaEXlSHL0NOXLkRdjooV6A0IrLvuUupYoxY8Q4lto 44hckDmx7UI2pPNj+ev3EumgempLT8beSnW3dprv8KWyWbwwcq76MCH6ktzQ5tv3c+EZ zBnA== X-Gm-Message-State: AOAM5328WceMu+/sKTiib3AX0eVaTzt2Ib+wUBHDH983NzCeVJ3qlRuB mBhShZYAxUvD/FgVyFVqb/9z08OGuws= X-Google-Smtp-Source: ABdhPJxK9hyqr93AyjeU9PRmxX6wgs7sAXGLvK1ECxfzwl9c1Ac54ECYAi63KUjKmsiRrqWzMyAObg== X-Received: by 2002:a63:465b:0:b0:374:642c:ab62 with SMTP id v27-20020a63465b000000b00374642cab62mr1015291pgk.187.1645679502611; Wed, 23 Feb 2022 21:11:42 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 23-20020a17090a0d5700b001bc3c650e01sm7487595pju.1.2022.02.23.21.11.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Feb 2022 21:11:42 -0800 (PST) X-Mozilla-News-Host: news://news.gmane.org:119 From: Jim Porter Subject: 29.0.50; Eshell emits extra prompts when killing processes in some cases To: bug-gnu-emacs@gnu.org Message-ID: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> Date: Wed, 23 Feb 2022 21:11:41 -0800 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::435 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x435.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) (Patch forthcoming; I'm just getting a bug number first...) Sometimes, when killing processes in Eshell (especially in pipelines), Eshell will emit *two* prompts instead of one. Starting with "emacs -Q --eval '(eshell)'... Problem #1: Killing pipelines ----------------------------- ~ $ sh -c 'while true; do echo y; sleep 1; done' | sh -c 'while true; do read NAME; done' C-c C-c ; or C-c C-k The result is ("|" is the point): interrupted ~ $ ~ $ | What's happening here is one prompt is being emitted per process in the pipeline. It should only emit one prompt total. Problem #2: Killing the head of a pipeline ------------------------------------------ ~ $ sh -c 'while true; do sleep 1; done' | sh -c 'while read NAME; do echo =${NAME}=; done' M-: (kill-process (eshell-head-process)) RET The result is: ~ $ =killed= | In this case, Eshell writes the head process's exit status message to its stdout handle (i.e. to the tail process's stdin). It should either write directly to the terminal, or not write at all. I went with the latter, since the former would mean that we write "interrupted" N times in problem #1 above. Problem #3: Killing a background process ---------------------------------------- ~ $ sh -c 'while true; do sleep 1; done' & This outputs, as expected: [sh] 12345 ~ $ Now call `(kill-process (caar eshell-process-list))'. The result is: ~ $ killed ~ $ | Here, Eshell writes the exit status to the terminal, but does so in an awkward spot, and then emits a new prompt. I think it should just avoid printing anything here. Information about the killed process is also shown in the minibuffer, so the user already has a place (and a better one at that!) to see what happened. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 00:16:12 2022 Received: (at 54136) by debbugs.gnu.org; 24 Feb 2022 05:16:13 +0000 Received: from localhost ([127.0.0.1]:47174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN6U8-0000XB-9N for submit@debbugs.gnu.org; Thu, 24 Feb 2022 00:16:12 -0500 Received: from mail-pf1-f172.google.com ([209.85.210.172]:43993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN6U6-0000Wy-OS for 54136@debbugs.gnu.org; Thu, 24 Feb 2022 00:16:11 -0500 Received: by mail-pf1-f172.google.com with SMTP id d187so869342pfa.10 for <54136@debbugs.gnu.org>; Wed, 23 Feb 2022 21:16:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:mime-version:in-reply-to :content-language; bh=jtQXAkcrTfrbokPdAPqlnaQ3xrixRFI+xRy1ogBGRtY=; b=cmpoSXi8lDWp0XJYNIi4liduyOxANJu21Q8NYLRoFrwZmtHsyhcvPtzLnDgunIzIkZ F2vD3Z5INo/ScXUcHY7o23y77D4t3Eq4b6Gg8HWUydad6s2E3BQ0NZ825XgitUapOplz z5b49CMsyRTRl/9Oteq7KZnBwoziXF4PZ+LbyikfhEDImMGLBRPr6pm5AuA3nwdbss1d +BhlviumzxW7QjEN98yWLm19SN/N/lwJpVXlIJyfzMAOqP+OxR/G2aRhyO9sA135o6Xq VwhsUAZc+FHy3E7x8yj/uWLhrxp2/vb7OSnaSLtOhB7PsVwQgs/mwpFgB8nrNwyNWd8o wHAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language; bh=jtQXAkcrTfrbokPdAPqlnaQ3xrixRFI+xRy1ogBGRtY=; b=nNItqN/B+seK1BGalWa/+LeUOgrL7pJ9yFe9nH7pDN1OiHuvQ9tHBPZOEsTIzMaff7 T6IoggEuxMQ+08+kZ2Emg1MzTuLiZ1LasFvAPTALfiEsuVlERyU2UEQwWK5fQoNkHJv0 L58hZjiKh+Ikuf3gK1D8Re+3N+coYrajiF1awo/KGeKQGfWGE3pt3/Y3mXdz1eXvXyWS LQ8Bj+CJ7Y6OEo+XvXdhF6mdVixXbgoMRgKLDpZco0a76Ngo+IoK3d2xV/++36tZm9bk f+PrZhdLQKSjgpRBrvjCwNX+iUa3Fq8ZJ4UVD1qSa2lKLikj3x/j0GKUG8ivBkXIt2pn IM6A== X-Gm-Message-State: AOAM531J9T86H8ngT1iZK+BtkJmcKBGDmxTueJo8hkY8c1pXuid3WGt0 50VDeksKgZUJA7rDY07j2o7rMKl93lA= X-Google-Smtp-Source: ABdhPJwB/fVbLstm/OTX1v9fOOaIVpUTTic9A79OD1V126+2l3tBwuhhajVome4qOxI8UpktgAxAyg== X-Received: by 2002:a05:6a00:1586:b0:4f0:fa03:cb53 with SMTP id u6-20020a056a00158600b004f0fa03cb53mr1296274pfk.76.1645679764781; Wed, 23 Feb 2022 21:16:04 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id e15-20020a17090a118f00b001bcc9efa7fasm425065pja.42.2022.02.23.21.16.03 for <54136@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Feb 2022 21:16:04 -0800 (PST) Subject: Re: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases From: Jim Porter To: 54136@debbugs.gnu.org References: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> Message-ID: <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> Date: Wed, 23 Feb 2022 21:16:04 -0800 MIME-Version: 1.0 In-Reply-To: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> Content-Type: multipart/mixed; boundary="------------EAD995306995577D98F63070" Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54136 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------EAD995306995577D98F63070 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2/23/2022 9:11 PM, Jim Porter wrote: > (Patch forthcoming; I'm just getting a bug number first...) Ok, here's the patch with some tests. --------------EAD995306995577D98F63070 Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-superfluously-emit-prompts-when-terminating-pr.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Don-t-superfluously-emit-prompts-when-terminating-pr.pa"; filename*1="tch" RnJvbSA1MjUzMGMyMDhkMWIwNmNmYmY1MjdkNzc0MjViYmJhZTE2NjZiMzQ1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMjMgRmViIDIwMjIgMjA6NDM6MzggLTA4MDAKU3ViamVjdDogW1BB VENIXSBEb24ndCBzdXBlcmZsdW91c2x5IGVtaXQgcHJvbXB0cyB3aGVuIHRlcm1pbmF0aW5n IHByb2Nlc3NlcwogaW4gRXNoZWxsCgoqIGxpc3AvZXNoZWxsL2VzaC1wcm9jLmVsIChlc2hl bGwta2lsbC1wcm9jZXNzLWZ1bmN0aW9uKTogT25seSByZXNldAp0aGUgcHJvbXB0IGlmIFBS T0MgaXMgd3JpdGluZyB0byB0aGUgdGVybWluYWwuCihlc2hlbGwtc2VudGluZWwpOiBPbmx5 IHdyaXRlIHRoZSBleGl0IG1lc3NhZ2UgaWYgUFJPQyBpcyB3cml0aW5nIHRvCnRoZSB0ZXJt aW5hbCAoYnVnIzU0MTM2KS4KCiogdGVzdC9saXNwL2VzaGVsbC9lc2gtcHJvYy10ZXN0cy5l bCAoZXNoLXByb2MtdGVzdC9raWxsLXBpcGVsaW5lKQooZXNoLXByb2MtdGVzdC9raWxsLXBp cGVsaW5lLWhlYWQpCihlc2gtcHJvYy10ZXN0L2tpbGwtYmFja2dyb3VuZC1wcm9jZXNzKTog TmV3IHRlc3RzLgotLS0KIGxpc3AvZXNoZWxsL2VzaC1wcm9jLmVsICAgICAgICAgICAgfCAx NiArKysrKysrKy0tLQogdGVzdC9saXNwL2VzaGVsbC9lc2gtcHJvYy10ZXN0cy5lbCB8IDQ2 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA1OCBp bnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxs L2VzaC1wcm9jLmVsIGIvbGlzcC9lc2hlbGwvZXNoLXByb2MuZWwKaW5kZXggZDdkMjJkMmE5 ZS4uNzA0MjZjY2FmMiAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZXNoLXByb2MuZWwKKysr IGIvbGlzcC9lc2hlbGwvZXNoLXByb2MuZWwKQEAgLTEwMiw2ICsxMDIsNyBAQCBlc2hlbGwt cHJvY2Vzcy1saXN0CiAgICJBIGxpc3Qgb2YgdGhlIGN1cnJlbnQgc3RhdHVzIG9mIHN1YnBy b2Nlc3Nlcy4iKQogCiAoZGVjbGFyZS1mdW5jdGlvbiBlc2hlbGwtc2VuZC1lb2YtdG8tcHJv Y2VzcyAiZXNoLW1vZGUiKQorKGRlY2xhcmUtZnVuY3Rpb24gZXNoZWxsLXRhaWwtcHJvY2Vz cyAiZXNoLWNtZCIpCiAKIChkZWZ2YXIta2V5bWFwIGVzaGVsbC1wcm9jLW1vZGUtbWFwCiAg ICJDLWMgTS1pIiAgIydlc2hlbGwtaW5zZXJ0LXByb2Nlc3MKQEAgLTExOSw3ICsxMjAsOSBA QCBlc2hlbGwta2lsbC1wcm9jZXNzLWZ1bmN0aW9uCiBQUk9DIGFuZCBTVEFUVVMgdG8gZnVu Y3Rpb25zIG9uIHRoZSBsYXR0ZXIuIgogICA7OyBXYXMgdGhlcmUgdGlsbCAyNC4xLCBidXQg aXQgaXMgbm90IG9wdGlvbmFsLgogICAocmVtb3ZlLWhvb2sgJ2VzaGVsbC1raWxsLWhvb2sg Iydlc2hlbGwtcmVzZXQtYWZ0ZXItcHJvYykKLSAgKGVzaGVsbC1yZXNldC1hZnRlci1wcm9j IHN0YXR1cykKKyAgOzsgT25seSByZXNldCB0aGUgcHJvbXB0IGlmIHRoaXMgcHJvY2VzcyBp cyBydW5uaW5nIGludGVyYWN0aXZlbHkuCisgICh3aGVuIChlcSBwcm9jIChlc2hlbGwtdGFp bC1wcm9jZXNzKSkKKyAgICAoZXNoZWxsLXJlc2V0LWFmdGVyLXByb2Mgc3RhdHVzKSkKICAg KHJ1bi1ob29rLXdpdGgtYXJncyAnZXNoZWxsLWtpbGwtaG9vayBwcm9jIHN0YXR1cykpCiAK IChkZWZpbmUtbWlub3ItbW9kZSBlc2hlbGwtcHJvYy1tb2RlCkBAIC00MTQsNyArNDE3LDcg QEAgZXNoZWxsLXNlbnRpbmVsCiAgICh3aGVuIChidWZmZXItbGl2ZS1wIChwcm9jZXNzLWJ1 ZmZlciBwcm9jKSkKICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciAocHJvY2Vzcy1idWZmZXIg cHJvYykKICAgICAgICh1bndpbmQtcHJvdGVjdAotCSAgKGxldCogKChlbnRyeSAoYXNzcSBw cm9jIGVzaGVsbC1wcm9jZXNzLWxpc3QpKSkKKyAgICAgICAgICAobGV0ICgoZW50cnkgKGFz c3EgcHJvYyBlc2hlbGwtcHJvY2Vzcy1saXN0KSkpCiA7CSAgICAoaWYgKG5vdCBlbnRyeSkK IDsJCShlcnJvciAiU2VudGluZWwgY2FsbGVkIGZvciB1bm93bmVkIHByb2Nlc3MgYCVzJyIK IDsJCSAgICAgICAocHJvY2Vzcy1uYW1lIHByb2MpKQpAQCAtNDIyLDggKzQyNSwxMyBAQCBl c2hlbGwtc2VudGluZWwKIAkgICAgICAodW53aW5kLXByb3RlY3QKIAkJICAocHJvZ24KIAkJ ICAgICh1bmxlc3MgKHN0cmluZz0gc3RyaW5nICJydW4iKQotCQkgICAgICAodW5sZXNzIChz dHJpbmctbWF0Y2ggIl5cXChmaW5pc2hlZFxcfGV4aXRlZFxcKSIgc3RyaW5nKQotCQkJKGVz aGVsbC1pbnNlcnRpb24tZmlsdGVyIHByb2Mgc3RyaW5nKSkKKyAgICAgICAgICAgICAgICAg ICAgICA7OyBXcml0ZSB0aGUgZXhpdCBtZXNzYWdlIGlmIHRoZSBzdGF0dXMgaXMKKyAgICAg ICAgICAgICAgICAgICAgICA7OyBhYm5vcm1hbCBhbmQgdGhlIHByb2Nlc3MgaXMgYWxyZWFk eSB3cml0aW5nCisgICAgICAgICAgICAgICAgICAgICAgOzsgdG8gdGhlIHRlcm1pbmFsLgor ICAgICAgICAgICAgICAgICAgICAgICh3aGVuIChhbmQgKGVxIHByb2MgKGVzaGVsbC10YWls LXByb2Nlc3MpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG5vdCAoc3Ry aW5nLW1hdGNoICJeXFwoZmluaXNoZWRcXHxleGl0ZWRcXCkiCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RyaW5nKSkpCisgICAgICAg ICAgICAgICAgICAgICAgICAoZnVuY2FsbCAocHJvY2Vzcy1maWx0ZXIgcHJvYykgcHJvYyBz dHJpbmcpKQogICAgICAgICAgICAgICAgICAgICAgIChsZXQgKChoYW5kbGVzIChudGggMSBl bnRyeSkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0ciAocHJvZzEgKG50aCAz IGVudHJ5KQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc2V0ZiAobnRo IDMgZW50cnkpIG5pbCkpKQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VzaGVsbC9lc2gtcHJv Yy10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9lc2hlbGwvZXNoLXByb2MtdGVzdHMuZWwKaW5kZXgg ZTdlYTZjMDBkNi4uYThiZTBmODAzMCAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2VzaGVsbC9l c2gtcHJvYy10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaC1wcm9jLXRlc3Rz LmVsCkBAIC00MywzICs0Myw0OSBAQCBlc2gtcHJvYy10ZXN0L3NpZ3BpcGUtZXhpdHMtcHJv Y2VzcwogICAgICJ5XG4iKQogICAgKGVzaGVsbC13YWl0LWZvci1zdWJwcm9jZXNzIHQpCiAg ICAoc2hvdWxkIChlcSAocHJvY2Vzcy1saXN0KSBuaWwpKSkpCisKKyhlcnQtZGVmdGVzdCBl c2gtcHJvYy10ZXN0L2tpbGwtcGlwZWxpbmUgKCkKKyAgIlRlc3QgdGhhdCBraWxsaW5nIGEg cGlwZWxpbmUgb2YgcHJvY2Vzc2VzIG9ubHkgZW1pdHMgYSBzaW5nbGUKK3Byb21wdC4gIFNl ZSBidWcjNTQxMzYuIgorICAoc2tpcC11bmxlc3MgKGFuZCAoZXhlY3V0YWJsZS1maW5kICJz aCIpCisgICAgICAgICAgICAgICAgICAgIChleGVjdXRhYmxlLWZpbmQgImVjaG8iKQorICAg ICAgICAgICAgICAgICAgICAoZXhlY3V0YWJsZS1maW5kICJzbGVlcCIpKSkKKyAgKHdpdGgt dGVtcC1lc2hlbGwKKyAgIChlc2hlbGwtaW5zZXJ0LWNvbW1hbmQKKyAgICAoY29uY2F0ICJz aCAtYyAnd2hpbGUgdHJ1ZTsgZG8gZWNobyB5OyBzbGVlcCAxOyBkb25lJyB8ICIKKyAgICAg ICAgICAgICJzaCAtYyAnd2hpbGUgdHJ1ZTsgZG8gcmVhZCBOQU1FOyBkb25lJyIpKQorICAg KGxldCAoKG91dHB1dC1zdGFydCAoZXNoZWxsLWJlZ2lubmluZy1vZi1vdXRwdXQpKSkKKyAg ICAgKGVzaGVsbC1raWxsLXByb2Nlc3MpCisgICAgIChlc2hlbGwtd2FpdC1mb3Itc3VicHJv Y2VzcyB0KQorICAgICAoc2hvdWxkIChlcXVhbCAoYnVmZmVyLXN1YnN0cmluZy1uby1wcm9w ZXJ0aWVzCisgICAgICAgICAgICAgICAgICAgICBvdXRwdXQtc3RhcnQgKGVzaGVsbC1lbmQt b2Ytb3V0cHV0KSkKKyAgICAgICAgICAgICAgICAgICAgImtpbGxlZFxuIikpKSkpCisKKyhl cnQtZGVmdGVzdCBlc2gtcHJvYy10ZXN0L2tpbGwtcGlwZWxpbmUtaGVhZCAoKQorICAiVGVz dCB0aGF0IGtpbGxpbmcgdGhlIGZpcnN0IHByb2Nlc3MgaW4gYSBwaXBlbGluZSBkb2Vzbid0 Cit3cml0ZSB0aGUgZXhpdCBzdGF0dXMgdG8gdGhlIHBpcGUuICBTZWUgYnVnIzU0MTM2LiIK KyAgKHNraXAtdW5sZXNzIChhbmQgKGV4ZWN1dGFibGUtZmluZCAic2giKQorICAgICAgICAg ICAgICAgICAgICAoZXhlY3V0YWJsZS1maW5kICJlY2hvIikKKyAgICAgICAgICAgICAgICAg ICAgKGV4ZWN1dGFibGUtZmluZCAic2xlZXAiKSkpCisgICh3aXRoLXRlbXAtZXNoZWxsCisg ICAoZXNoZWxsLWluc2VydC1jb21tYW5kCisgICAgKGNvbmNhdCAic2ggLWMgJ3doaWxlIHRy dWU7IHNsZWVwIDE7IGRvbmUnIHwgIgorICAgICAgICAgICAgInNoIC1jICd3aGlsZSByZWFk IE5BTUU7IGRvIGVjaG8gPSR7TkFNRX09OyBkb25lJyIpKQorICAgKGxldCAoKG91dHB1dC1z dGFydCAoZXNoZWxsLWJlZ2lubmluZy1vZi1vdXRwdXQpKSkKKyAgICAgKGtpbGwtcHJvY2Vz cyAoZXNoZWxsLWhlYWQtcHJvY2VzcykpCisgICAgIChlc2hlbGwtd2FpdC1mb3Itc3VicHJv Y2VzcyB0KQorICAgICAoc2hvdWxkIChlcXVhbCAoYnVmZmVyLXN1YnN0cmluZy1uby1wcm9w ZXJ0aWVzCisgICAgICAgICAgICAgICAgICAgICBvdXRwdXQtc3RhcnQgKGVzaGVsbC1lbmQt b2Ytb3V0cHV0KSkKKyAgICAgICAgICAgICAgICAgICAgIiIpKSkpKQorCisoZXJ0LWRlZnRl c3QgZXNoLXByb2MtdGVzdC9raWxsLWJhY2tncm91bmQtcHJvY2VzcyAoKQorICAiVGVzdCB0 aGF0IGtpbGxpbmcgYSBiYWNrZ3JvdW5kIHByb2Nlc3MgZG9lc24ndCBlbWl0IGEgbmV3Citw cm9tcHQuICBTZWUgYnVnIzU0MTM2LiIKKyAgKHNraXAtdW5sZXNzIChhbmQgKGV4ZWN1dGFi bGUtZmluZCAic2giKQorICAgICAgICAgICAgICAgICAgICAoZXhlY3V0YWJsZS1maW5kICJz bGVlcCIpKSkKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChlc2hlbGwtaW5zZXJ0LWNvbW1h bmQgInNoIC1jICd3aGlsZSB0cnVlOyBkbyBzbGVlcCAxOyBkb25lJyAmIikKKyAgIChraWxs LXByb2Nlc3MgKGNhYXIgZXNoZWxsLXByb2Nlc3MtbGlzdCkpCisgICA7OyBHaXZlIGBlc2hl bGwtc2VudGluZWwnIGEgY2hhbmNlIHRvIHJ1bi4KKyAgIChzaXQtZm9yIDAuMSkKKyAgIChl c2hlbGwtbWF0Y2gtcmVzdWx0ICJcXFtzaFxcXSBbWzpkaWdpdDpdXStcbiIpKSkKLS0gCjIu MjUuMQoK --------------EAD995306995577D98F63070-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 04:35:45 2022 Received: (at 54136) by debbugs.gnu.org; 24 Feb 2022 09:35:45 +0000 Received: from localhost ([127.0.0.1]:47594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNAXJ-0001cI-GI for submit@debbugs.gnu.org; Thu, 24 Feb 2022 04:35:45 -0500 Received: from quimby.gnus.org ([95.216.78.240]:43630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNAXH-0001c5-Ot for 54136@debbugs.gnu.org; Thu, 24 Feb 2022 04:35:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8RNVv20r9pPAyE4R1XX4zW8DwoZ5RNJAJncjA++dpcw=; b=fnor13QJB8NPZU+mU5BpCE4E9E 7ecaVCC1vRZOWB4y9sqRKaXGxzctg1Va2D7JiEQ/fM/wj7KyEVc3W8JGmA+CwWX//at7KIhzOlEQy Bb95kgxrJY+q57hdtif/AsVObqNMHz3iqVS4htheWBp7zW7QMA9IkcHhigR+QYOONdlU=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNAX9-000414-9p; Thu, 24 Feb 2022 10:35:37 +0100 From: Lars Ingebrigtsen To: Jim Porter Subject: Re: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases References: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> X-Now-Playing: Bobbie Gentry's _The Girl From Chickasaw County (6): Fancy_: "Apartment 21 (Without Strings)" Date: Thu, 24 Feb 2022 10:35:32 +0100 In-Reply-To: <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> (Jim Porter's message of "Wed, 23 Feb 2022 21:16:04 -0800") Message-ID: <87y22038uz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > Ok, here's the patch with some tests. Thanks; pushed to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54136 Cc: 54136@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > Ok, here's the patch with some tests. Thanks; pushed to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 04:35:53 2022 Received: (at control) by debbugs.gnu.org; 24 Feb 2022 09:35:53 +0000 Received: from localhost ([127.0.0.1]:47597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNAXQ-0001cd-PF for submit@debbugs.gnu.org; Thu, 24 Feb 2022 04:35:53 -0500 Received: from quimby.gnus.org ([95.216.78.240]:43644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNAXP-0001cP-4c for control@debbugs.gnu.org; Thu, 24 Feb 2022 04:35:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EOsQhDK3/9EC11i/+w3gKwZOXbTWxqdWsMHNKzN4bpY=; b=iaVygzgPcmhdVSPiw/QMLjK+LY ll2r4t+JtlruAps3hOd1Avpz+Cv76Isw1bflTNkeT06fQkRZAmHHBF3edslHsQKuFIp3Jf4/5M+Mu M72nW4gODIKrZLqV8RhNtHLppFhWDlC47/UupUms9Y0+uERMtjXfKzpLOq5zyg0WSnPo=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNAXH-00041H-01 for control@debbugs.gnu.org; Thu, 24 Feb 2022 10:35:45 +0100 Date: Thu, 24 Feb 2022 10:35:40 +0100 Message-Id: <87wnhk38ur.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #54136 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 54136 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 54136 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 06:03:33 2022 Received: (at 54136) by debbugs.gnu.org; 24 Feb 2022 11:03:33 +0000 Received: from localhost ([127.0.0.1]:47721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNBuG-00061R-O9 for submit@debbugs.gnu.org; Thu, 24 Feb 2022 06:03:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNBuE-00061E-KJ for 54136@debbugs.gnu.org; Thu, 24 Feb 2022 06:03:31 -0500 Received: from [2001:470:142:3::e] (port=38424 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNBu9-0007fe-7b; Thu, 24 Feb 2022 06:03:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eKIVtsnYkEnVI/z9PUEL2GfU+8ncshpzLFg82a65h+w=; b=jc+JpdIg1qqX Tbw1pcm1Li2SBF5f950lsHPgGwkwspDqHt+Lpd1Y8uj5sfLV1XGeMA38D64N6UdLN018jieKTbxGz 7MUqTylQLYsvVxp2sTt8YR3DXsz7pAYI5oZINe7OmSQbm5D0KHbtfwkrtYUqxp1VUSglzby4PDEru EO3e2bQ5Q/VUy1ExkSdzS/V/IgDke+PImCwGyYj0MXnqIoyz68+JGbwCafCyum7fkFowKnrAbLc9+ VCaEEFq51lb0OWY0TjoiLKP7qs6JAIp08XP5v8dkj2zCIlgfldRjEXcuxGhI6KkjQyGspK+IbjXza ycKvxDqbxoPS6XGQN/VEpg==; Received: from [87.69.77.57] (port=2434 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNBu8-00039V-N5; Thu, 24 Feb 2022 06:03:25 -0500 Date: Thu, 24 Feb 2022 13:03:36 +0200 Message-Id: <834k4osf07.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87y22038uz.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 24 Feb 2022 10:35:32 +0100) Subject: Re: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases References: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> <87y22038uz.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54136 Cc: 54136@debbugs.gnu.org, jporterbugs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Thu, 24 Feb 2022 10:35:32 +0100 > Cc: 54136@debbugs.gnu.org > > Jim Porter writes: > > > Ok, here's the patch with some tests. > > Thanks; pushed to Emacs 29. The new tests fail on MS-Windows. Does the patch below look right? I'm quite sure about the "sh" vs "sh.exe" part, but what about the "killed" vs "interrupt" part? any idea why this happens on MS-Windows? diff --git a/test/lisp/eshell/esh-proc-tests.el b/test/lisp/eshell/esh-proc-tests.el index a8be0f8..3f67961 100644 --- a/test/lisp/eshell/esh-proc-tests.el +++ b/test/lisp/eshell/esh-proc-tests.el @@ -59,7 +59,7 @@ esh-proc-test/kill-pipeline (eshell-wait-for-subprocess t) (should (equal (buffer-substring-no-properties output-start (eshell-end-of-output)) - "killed\n"))))) + (or "interrupt\n" "killed\n")))))) (ert-deftest esh-proc-test/kill-pipeline-head () "Test that killing the first process in a pipeline doesn't @@ -88,4 +88,4 @@ esh-proc-test/kill-background-process (kill-process (caar eshell-process-list)) ;; Give `eshell-sentinel' a chance to run. (sit-for 0.1) - (eshell-match-result "\\[sh\\] [[:digit:]]+\n"))) + (eshell-match-result "\\[sh\\(\\.exe\\)?\\] [[:digit:]]+\n"))) From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 13:55:57 2022 Received: (at 54136) by debbugs.gnu.org; 24 Feb 2022 18:55:57 +0000 Received: from localhost ([127.0.0.1]:50428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNJHR-0000Uf-2S for submit@debbugs.gnu.org; Thu, 24 Feb 2022 13:55:57 -0500 Received: from mail-pj1-f46.google.com ([209.85.216.46]:53013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNJHP-0000UT-Nc for 54136@debbugs.gnu.org; Thu, 24 Feb 2022 13:55:56 -0500 Received: by mail-pj1-f46.google.com with SMTP id v4so2785743pjh.2 for <54136@debbugs.gnu.org>; Thu, 24 Feb 2022 10:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=G0Nt92HdrjmJysyCGuVbE+AYmK0oZ2hqQHqzeAr4+40=; b=ZPXHsQBrbyP9tApIQgT+aY/noyVWq4cRyriDOZImNlKZmCaygCsAGd3d2wuoyNdNo+ RUdLyKRGUmExTLCxRJdggjJNAfMp0v2MVwsDuivT+q3VyV2+dbVnnSKS1Hkx43eY0WY8 +ApRdfO9LylPbD4+zaWV9EcnYTQdISBUxkMPgVLcVuEpN1wX5seKH+bVicXK5mtG8pRI qPWFnJbyrrg8DVYgustQRR68yx29z1CNaUUkJjv4zQE3bFRzIFZrh/XwADpdSL7tuiTc Fa/2PJ3I/+xpm3NOYOKpxrJaoEilrIBDk30kht4XhtbV9h1j0kp2orbcSHLha+yIeLbE DBrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=G0Nt92HdrjmJysyCGuVbE+AYmK0oZ2hqQHqzeAr4+40=; b=luENKG84l5Bpq2UG5WOV9mIrXSOelm6KZAjinAREqK+faGHxle2CDaul9DDva9BFQr +nl6HzryoyY6bqZA2ZL3U6gbwW7Ep8OV47f0+HDelV/MktzPQFYzadpT3mLgGmGq0SXo K8HnD+wcSGzkqH+UlKHSabVdR781wCjlcjY5Zf1u6n7GHPuw8UlxWorM2OG1y/rWuXlD M792ii4u1B3OTZXAKSrbzPqXtLEQr4VHVnXZ0iyztlqkFYkqF8i9CDUjav7+cC98uHOq Y8IwwV80+X4JUB9HQvIPL81TR/5PrGLK5T2gUDuL9ZdhH0ozQkAZnZdiwhSknr+1xSld OEzQ== X-Gm-Message-State: AOAM532oS61OMUepGGGtCCPdR3050z6HdN6vik+yLg3cWYwoDAN3O9mh C0e/kQrkcve2t8ALzSwJD8IXlP/x2uM= X-Google-Smtp-Source: ABdhPJwi9IzLIqfE0AYEaT5O4XmGSay+0DFiBUHEripRW2m/s4nho5A/jRD2BiaNhgfy/y5f1btpYA== X-Received: by 2002:a17:902:c403:b0:14f:ecc9:bc82 with SMTP id k3-20020a170902c40300b0014fecc9bc82mr3807067plk.27.1645728949781; Thu, 24 Feb 2022 10:55:49 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id e11-20020a63e00b000000b0037341d979b8sm207302pgh.94.2022.02.24.10.55.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Feb 2022 10:55:49 -0800 (PST) Subject: Re: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases To: Eli Zaretskii , Lars Ingebrigtsen References: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> <87y22038uz.fsf@gnus.org> <834k4osf07.fsf@gnu.org> From: Jim Porter Message-ID: <7f820c27-a58c-3b2b-3132-a57e2a25ea96@gmail.com> Date: Thu, 24 Feb 2022 10:55:48 -0800 MIME-Version: 1.0 In-Reply-To: <834k4osf07.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54136 Cc: 54136@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/24/2022 3:03 AM, Eli Zaretskii wrote: >> From: Lars Ingebrigtsen >> Date: Thu, 24 Feb 2022 10:35:32 +0100 >> Cc: 54136@debbugs.gnu.org >> >> Thanks; pushed to Emacs 29. > > The new tests fail on MS-Windows. Does the patch below look right? Thanks, and sorry for the breakage. > I'm quite sure about the "sh" vs "sh.exe" part, but what about the > "killed" vs "interrupt" part? any idea why this happens on MS-Windows? I think this makes sense. POSIX-style signal handling on MS Windows is only approximate, so I'm not surprised it produces some surprising results like that. Maybe it's possible to pass the signal code through the process exit status more accurately, but that's probably only a partial solution at best (due to the API differences), and at worst could break Emacs's subprocess handling for MS Windows in subtle ways. Another solution would be to replace the call to `eshell-kill-process' in `esh-proc-test/kill-pipeline' with `eshell-interrupt-process'. Then the exit status should be "interrupt\n" on all platforms. I've verified that that works ok on GNU/Linux, but it's possible that it runs into some other issue on MS Windows. This is sort of just working around the issue, but I also think there's an argument that `eshell-interrupt-process' is the more "natural" function to call, since it corresponds to a user hitting ^C in the shell (or C-c C-c in Eshell). From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 15:03:31 2022 Received: (at 54136) by debbugs.gnu.org; 24 Feb 2022 20:03:31 +0000 Received: from localhost ([127.0.0.1]:50486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNKKo-00028c-PB for submit@debbugs.gnu.org; Thu, 24 Feb 2022 15:03:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNKKn-00028Q-LR for 54136@debbugs.gnu.org; Thu, 24 Feb 2022 15:03:29 -0500 Received: from [2001:470:142:3::e] (port=50664 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNKKh-0000TB-W9; Thu, 24 Feb 2022 15:03:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XGAf56t26hbnFOEbXiJjCcjTI4hVAuO3J5BN7yCFylk=; b=dL/oKeNlgJpq XJXX6783kwyOYwkVXNHdj5NG8iZRz6QKIcqT3Tswz5AilyGXNTBc2vOBpYVE1qPTyRucYRqvtBOQM fMrrqG3eTfnGTjNxH0Y83QdX4+WciKalcImqCm6vs5ccW7MZ2ohAYI+a+nVV1yamcWFvLn6EfIO4H OsAtPPet+xip++V/ZWmQ5rQhFGYMhdk4hlrL5/9+/I1uczur6/IFMGfzU70ixTGu2yjDzgiYCpGsi GYxWZVRZ7X0jupSzJZitB9tYblKWdxx55qbc1gEZhBD+mZv9Q/m4xNc739beH4Uvy5UNb0LNuz9EY Yoy8eAfuZ1Sdori40ZhH5w==; Received: from [87.69.77.57] (port=4019 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNKKg-00034l-F3; Thu, 24 Feb 2022 15:03:22 -0500 Date: Thu, 24 Feb 2022 22:03:36 +0200 Message-Id: <83tucoqbfr.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <7f820c27-a58c-3b2b-3132-a57e2a25ea96@gmail.com> (message from Jim Porter on Thu, 24 Feb 2022 10:55:48 -0800) Subject: Re: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases References: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> <87y22038uz.fsf@gnus.org> <834k4osf07.fsf@gnu.org> <7f820c27-a58c-3b2b-3132-a57e2a25ea96@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54136 Cc: 54136@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 54136@debbugs.gnu.org > From: Jim Porter > Date: Thu, 24 Feb 2022 10:55:48 -0800 > > > I'm quite sure about the "sh" vs "sh.exe" part, but what about the > > "killed" vs "interrupt" part? any idea why this happens on MS-Windows? > > I think this makes sense. POSIX-style signal handling on MS Windows is > only approximate, so I'm not surprised it produces some surprising > results like that. Maybe it's possible to pass the signal code through > the process exit status more accurately, but that's probably only a > partial solution at best (due to the API differences), and at worst > could break Emacs's subprocess handling for MS Windows in subtle ways. > > Another solution would be to replace the call to `eshell-kill-process' > in `esh-proc-test/kill-pipeline' with `eshell-interrupt-process'. Then > the exit status should be "interrupt\n" on all platforms. I've verified > that that works ok on GNU/Linux, but it's possible that it runs into > some other issue on MS Windows. > > This is sort of just working around the issue, but I also think there's > an argument that `eshell-interrupt-process' is the more "natural" > function to call, since it corresponds to a user hitting ^C in the shell > (or C-c C-c in Eshell). OK, so I installed my changes. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 15:07:44 2022 Received: (at 54136) by debbugs.gnu.org; 24 Feb 2022 20:07:44 +0000 Received: from localhost ([127.0.0.1]:50490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNKOu-0002EL-AC for submit@debbugs.gnu.org; Thu, 24 Feb 2022 15:07:44 -0500 Received: from quimby.gnus.org ([95.216.78.240]:49464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNKOq-0002E3-SV for 54136@debbugs.gnu.org; Thu, 24 Feb 2022 15:07:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=E98DMzPNk3qiFuBbRVhvVc6dgOwxSSaBJXvzL/pAjug=; b=ifgxU+hoxq1dnv73vltxkM02+B wLjcTrxhpqd2j9YkfGSiQEA3Q3p8TYPvEAo9GEam2+VCXbBv20dT+9UI9DRx5y56ShmGA5FC5/QmZ ZWRM9Cw7B+4Cij24K+2v9waCvQwF+m0xQ/EEZ8qxCCWT99OcP++DUv/4uXRk2rJixRLU=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNKOg-0001P6-VX; Thu, 24 Feb 2022 21:07:33 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases References: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> <87y22038uz.fsf@gnus.org> <834k4osf07.fsf@gnu.org> <7f820c27-a58c-3b2b-3132-a57e2a25ea96@gmail.com> <83tucoqbfr.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWQnrfXnSyqZB0/ Mhn////+V3jdAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YCGBQHBl6pRnEAAAGDSURBVDjLdZMBssIg DEQZuYCkF5DlAhjuf7e/m1TbfjXjaM1jNyHQUn5Fa603jLEU8wQMQAc8wQkZFWSgpMz4HFYwgweq zFcmJ7+adWsWdqPSaBZJayiaUdSD0WjVOmdakSgvr+U3lFIP0OS2RDqXPMoLBBweEjS0dgATgPai P73dDwV20OVqjzcwpNVyG2xjvkGWjuBm/QDLX8A5tzE1q4gssJOBNzB/55dcZ0FPcORVbDwKcAYx lsHOHmUkyE6zDkvgzhPsGsfJaT3Z7p1WHA7rafnesaOzBveZGW+cxEAAt7mDUEDnog5iVmaOEc1Y 71sfCVTcNANtD4Ytqug0qdAi19fTuOURngk2PW3qkl0HoDkBKyiUyG6xK6CnEUXynuzgpgnkjIA8 Qd0wKpaueqZa/EC3me2673dNfe4jabwlNStfw6m4dfvIxyt0G2t9BfYBdEsEPuyRiu11/scdSVD/ g3UBK+a6cALnta+NXhRZ+CdY38EpyqXGBXxX5Iv7Nf4Adi2jQdcelw4AAAAldEVYdGRhdGU6Y3Jl YXRlADIwMjItMDItMjRUMjA6MDc6MDYrMDA6MDA2F58tAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIy LTAyLTI0VDIwOjA3OjA2KzAwOjAwR0onkQAAAABJRU5ErkJggg== X-Now-Playing: Neil Young's _Neil Young_: "What Did You Do To My Life?" Date: Thu, 24 Feb 2022 21:07:29 +0100 In-Reply-To: <83tucoqbfr.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 24 Feb 2022 22:03:36 +0200") Message-ID: <87ee3s111a.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > OK, so I installed my changes. The test now fails on Debian: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54136 Cc: 54136@debbugs.gnu.org, Jim Porter X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > OK, so I installed my changes. The test now fails on Debian: Test esh-proc-test/kill-pipeline condition: (ert-test-failed ((should (equal (buffer-substring-no-properties output-start ...) (or "interrupt\n" "killed\n"))) :form (equal "killed\n" "interrupt\n") :value nil :explanation (arrays-of-different-length 7 10 "killed\n" "interrupt\n" first-mismatch-at 0))) FAILED 2/4 esh-proc-test/kill-pipeline (0.109668 sec) at lisp/eshell/esh-proc-tests.el:47 passed 3/4 esh-proc-test/kill-pipeline-head (0.112142 sec) passed 4/4 esh-proc-test/sigpipe-exits-process (1.010359 sec) Ran 4 tests, 3 results as expected, 1 unexpected (2022-02-24 21:06:48+0100, 1.446135 sec) 1 unexpected results: FAILED esh-proc-test/kill-pipeline -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 20:04:51 2022 Received: (at 54136) by debbugs.gnu.org; 25 Feb 2022 01:04:51 +0000 Received: from localhost ([127.0.0.1]:50753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNP2R-0003Ae-2x for submit@debbugs.gnu.org; Thu, 24 Feb 2022 20:04:51 -0500 Received: from mail-pl1-f178.google.com ([209.85.214.178]:46679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNP2P-0003AL-Bk for 54136@debbugs.gnu.org; Thu, 24 Feb 2022 20:04:49 -0500 Received: by mail-pl1-f178.google.com with SMTP id bd1so3383318plb.13 for <54136@debbugs.gnu.org>; Thu, 24 Feb 2022 17:04:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=hdM3f2OcTQ4JT6N1JkIsSysuYVc0VSiKl9+okajSqYQ=; b=UHTeMSBWKg2G0TgUXIsGI7SP7XShMK9HfoHjGcEZiwB//y/2gXWykbgxr2zWt5FY1C 9EYDMXkYIPyj0pY9vX2+D6ZW0AXzSXaG+nM325479+U4pAhrPDcjd+KcovtaxuTtiUJb BtPvIr/YDRqyXnK5OYAPSqiDUG/hSBcP3kBEcuZt677T7ieBoxshnUBetolsV9JRjZqY ClMaI58o0Baht7tR+Y+mXAkoGR6i7c1DA8LEd7mQbM2OQQLMFX7oj3DR/Mx474FXVYLw zq42TYfkoIYSJBbtf2Wu8JgwT9YNip4gL1+OXoEQ9Ep0Ye6WIDDbsJmuTKOTXMHtffsm DOiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=hdM3f2OcTQ4JT6N1JkIsSysuYVc0VSiKl9+okajSqYQ=; b=FO2fQjHn1HHzh7wXD01stON+231xpoI+eGe8dYdEZmwFHR9g9Yx61Bfdj2ZDufOuJ3 inixTfZlsqMiHLNUScERonn2iM0U9XvOOr1I2zACJcziQF54JZtNX596zzVQ8ry2Zh2f 0S0Xd43FlJLUFkqsgh/EL7RcKesyxSmq1VfoMt3ZEC3q+HosTfGZ1KOrjI+4K90lnhCp r1OUu35zRoO1T5sL0Z/hgq/Yi3j8IkhbR1sqmfWVX1MFNQRVT/umjKEl4M6DqGnQJIdg BfCYUkC5oxD43MgeMCX2xpPqt0EmLhc9/bpceaFGwMZoEKTGbsxsTVWLz53cqn1QIZYO f+sQ== X-Gm-Message-State: AOAM533Gz4wG4mGJgQbiv8jIgdoHYe9Ftt3oMsvHIT/RlO7rqYP6fZSO LysHMsiJvQxFbzYTzOO7qEs+M7cFE3U= X-Google-Smtp-Source: ABdhPJyGX4r9fHQvCmsWvUaKrsVPZEXlCZD/zmKesq0XcHCIlGt1TAPe52kGJ/0ZlRAZEFaetnSenQ== X-Received: by 2002:a17:902:6841:b0:150:9b8c:3a67 with SMTP id f1-20020a170902684100b001509b8c3a67mr479702pln.151.1645751083403; Thu, 24 Feb 2022 17:04:43 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x6-20020a17090aa38600b001bce781ce03sm380153pjp.18.2022.02.24.17.04.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Feb 2022 17:04:42 -0800 (PST) Subject: Re: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases To: Lars Ingebrigtsen , Eli Zaretskii References: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> <87y22038uz.fsf@gnus.org> <834k4osf07.fsf@gnu.org> <7f820c27-a58c-3b2b-3132-a57e2a25ea96@gmail.com> <83tucoqbfr.fsf@gnu.org> <87ee3s111a.fsf@gnus.org> From: Jim Porter Message-ID: <4741f5c9-8846-9584-318e-1a7536d43e70@gmail.com> Date: Thu, 24 Feb 2022 17:04:42 -0800 MIME-Version: 1.0 In-Reply-To: <87ee3s111a.fsf@gnus.org> Content-Type: multipart/mixed; boundary="------------C3966743D50C6D6FA01F18A6" Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54136 Cc: 54136@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------C3966743D50C6D6FA01F18A6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2/24/2022 12:07 PM, Lars Ingebrigtsen wrote: > Eli Zaretskii writes: > >> OK, so I installed my changes. > > The test now fails on Debian: > > Test esh-proc-test/kill-pipeline condition: > (ert-test-failed > ((should > (equal > (buffer-substring-no-properties output-start ...) > (or "interrupt\n" "killed\n"))) > :form > (equal "killed\n" "interrupt\n") > :value nil :explanation > (arrays-of-different-length 7 10 "killed\n" "interrupt\n" first-mismatch-at 0))) > FAILED 2/4 esh-proc-test/kill-pipeline (0.109668 sec) at lisp/eshell/esh-proc-tests.el:47 > passed 3/4 esh-proc-test/kill-pipeline-head (0.112142 sec) > passed 4/4 esh-proc-test/sigpipe-exits-process (1.010359 sec) > > Ran 4 tests, 3 results as expected, 1 unexpected (2022-02-24 21:06:48+0100, 1.446135 sec) > > 1 unexpected results: > FAILED esh-proc-test/kill-pipeline Here's a patch for that. It works for me on GNU/Linux, and hopefully it's ok on MS Windows too. --------------C3966743D50C6D6FA01F18A6 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-Eshell-process-tests-to-hopefully-work-on-all-pl.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Fix-Eshell-process-tests-to-hopefully-work-on-all-pl.pa"; filename*1="tch" RnJvbSAwYjkxNTM1ZjdiYTQ5YjRlODY0YWE3MzVjOGE4M2VlNzNiNWRlMTE4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMjQgRmViIDIwMjIgMTY6NTc6NDQgLTA4MDAKU3ViamVjdDogW1BB VENIXSBGaXggRXNoZWxsIHByb2Nlc3MgdGVzdHMgdG8gKGhvcGVmdWxseSkgd29yayBvbiBh bGwgcGxhdGZvcm1zCgoqIHRlc3QvbGlzcC9lc2hlbGwvZXNoLXByb2MtdGVzdHMuZWwgKGVz aC1wcm9jLXRlc3Qva2lsbC1waXBlbGluZSk6CkZpeCB0ZXN0LgotLS0KIHRlc3QvbGlzcC9l c2hlbGwvZXNoLXByb2MtdGVzdHMuZWwgfCA5ICsrKysrLS0tLQogMSBmaWxlIGNoYW5nZWQs IDUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90ZXN0L2xp c3AvZXNoZWxsL2VzaC1wcm9jLXRlc3RzLmVsIGIvdGVzdC9saXNwL2VzaGVsbC9lc2gtcHJv Yy10ZXN0cy5lbAppbmRleCBlMTllYWY5Nzc5Li44Y2Q4OTNjZTU3IDEwMDY0NAotLS0gYS90 ZXN0L2xpc3AvZXNoZWxsL2VzaC1wcm9jLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9lc2hl bGwvZXNoLXByb2MtdGVzdHMuZWwKQEAgLTU3LDEwICs1NywxMSBAQCBlc2gtcHJvYy10ZXN0 L2tpbGwtcGlwZWxpbmUKICAgIChsZXQgKChvdXRwdXQtc3RhcnQgKGVzaGVsbC1iZWdpbm5p bmctb2Ytb3V0cHV0KSkpCiAgICAgIChlc2hlbGwta2lsbC1wcm9jZXNzKQogICAgICAoZXNo ZWxsLXdhaXQtZm9yLXN1YnByb2Nlc3MgdCkKLSAgICAgKHNob3VsZCAoZXF1YWwgKGJ1ZmZl ci1zdWJzdHJpbmctbm8tcHJvcGVydGllcwotICAgICAgICAgICAgICAgICAgICAgb3V0cHV0 LXN0YXJ0IChlc2hlbGwtZW5kLW9mLW91dHB1dCkpCi0gICAgICAgICAgICAgICAgICAgIDs7 ICJpbnRlcnJ1cHRcbiIgaXMgZm9yIE1TLVdpbmRvd3MuCi0gICAgICAgICAgICAgICAgICAg IChvciAiaW50ZXJydXB0XG4iICJraWxsZWRcbiIpKSkpKSkKKyAgICAgKHNob3VsZCAoc3Ry aW5nLW1hdGNoLXAKKyAgICAgICAgICAgICAgOzsgImludGVycnVwdFxuIiBpcyBmb3IgTVMt V2luZG93cy4KKyAgICAgICAgICAgICAgKHJ4IChvciAiaW50ZXJydXB0XG4iICJraWxsZWRc biIpKQorICAgICAgICAgICAgICAoYnVmZmVyLXN1YnN0cmluZy1uby1wcm9wZXJ0aWVzCisg ICAgICAgICAgICAgICBvdXRwdXQtc3RhcnQgKGVzaGVsbC1lbmQtb2Ytb3V0cHV0KSkpKSkp KQogCiAoZXJ0LWRlZnRlc3QgZXNoLXByb2MtdGVzdC9raWxsLXBpcGVsaW5lLWhlYWQgKCkK ICAgIlRlc3QgdGhhdCBraWxsaW5nIHRoZSBmaXJzdCBwcm9jZXNzIGluIGEgcGlwZWxpbmUg ZG9lc24ndAotLSAKMi4yNS4xCgo= --------------C3966743D50C6D6FA01F18A6-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 21:19:06 2022 Received: (at 54136) by debbugs.gnu.org; 25 Feb 2022 02:19:06 +0000 Received: from localhost ([127.0.0.1]:50849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNQCI-0005VL-3r for submit@debbugs.gnu.org; Thu, 24 Feb 2022 21:19:06 -0500 Received: from quimby.gnus.org ([95.216.78.240]:51972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNQCF-0005Uo-Os for 54136@debbugs.gnu.org; Thu, 24 Feb 2022 21:19:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5RgSGY+L0+QLtNxMH2FgQ0/QtZGsD0YJ13eGmicIOUY=; b=SgUKedb9R8gsC0sQpIRNEunTVv tX+gps2Nzj5rH8O7WVX4+bDoxbs226gBUawOXfVHutMXAszvRXWTtE97LNujrdgZxCTdUvykaeWug zNpUE3l+xJSziRCT82/DXlDGQhl/NylSu2xBudhWbY6cmGut05YaomhIJhs6Z1EuOhWk=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNQC7-0004bu-2i; Fri, 25 Feb 2022 03:18:57 +0100 From: Lars Ingebrigtsen To: Jim Porter Subject: Re: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases References: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> <87y22038uz.fsf@gnus.org> <834k4osf07.fsf@gnu.org> <7f820c27-a58c-3b2b-3132-a57e2a25ea96@gmail.com> <83tucoqbfr.fsf@gnu.org> <87ee3s111a.fsf@gnus.org> <4741f5c9-8846-9584-318e-1a7536d43e70@gmail.com> X-Now-Playing: Tenniscoats's _Tan-Tan Therapy_: "One Swan Swim" Date: Fri, 25 Feb 2022 03:18:52 +0100 In-Reply-To: <4741f5c9-8846-9584-318e-1a7536d43e70@gmail.com> (Jim Porter's message of "Thu, 24 Feb 2022 17:04:42 -0800") Message-ID: <874k4n1yer.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > Here's a patch for that. It works for me on GNU/Linux, and hopefully > it's ok on MS Windows too. Thanks; pushed to the trunk. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54136 Cc: 54136@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > Here's a patch for that. It works for me on GNU/Linux, and hopefully > it's ok on MS Windows too. Thanks; pushed to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 25 02:09:34 2022 Received: (at 54136) by debbugs.gnu.org; 25 Feb 2022 07:09:34 +0000 Received: from localhost ([127.0.0.1]:51126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNUjO-0001h9-AL for submit@debbugs.gnu.org; Fri, 25 Feb 2022 02:09:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNUjM-0001gv-1v for 54136@debbugs.gnu.org; Fri, 25 Feb 2022 02:09:32 -0500 Received: from [2001:470:142:3::e] (port=58862 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNUjG-0003Ty-73; Fri, 25 Feb 2022 02:09:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wUnhnmKVcpaYqajZTnolL+cHWxYwJy09V11pQvqIG9s=; b=mfyNynMXiXYo 3u4I4NS4KFdI8l1b94z18nCbB/gTx76CNHNEAyr/YO5+9X1dU4Elz3RwVE7i0h0Lv/IQYHz+FU82H 7zPF1+A9U6JzYeaRZLZMtbXgC0uEfafuE6uDmPi6Gmkm3QXllZFCshkgf6a8hMIhoT1y7Pts53ec2 W3pRvvbYwTkT1Gh1SUCmaKFXBb3QjejHy6GDEN6+762Mrzvz3ZuGJBZNwKK5ArgSUzAT0/0WM9vox p2S0id50j145wNbFhhSt22ODZZGW5QzkKYvik49Ay6uB/dG5J3jApFcY9yv0fphTtFOmA5tv/jiab Jz5bASZ96bFjzUHyMK2+5w==; Received: from [87.69.77.57] (port=1153 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNUjB-0003n8-S6; Fri, 25 Feb 2022 02:09:25 -0500 Date: Fri, 25 Feb 2022 09:09:36 +0200 Message-Id: <83o82vqv67.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <4741f5c9-8846-9584-318e-1a7536d43e70@gmail.com> (message from Jim Porter on Thu, 24 Feb 2022 17:04:42 -0800) Subject: Re: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases References: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> <87y22038uz.fsf@gnus.org> <834k4osf07.fsf@gnu.org> <7f820c27-a58c-3b2b-3132-a57e2a25ea96@gmail.com> <83tucoqbfr.fsf@gnu.org> <87ee3s111a.fsf@gnus.org> <4741f5c9-8846-9584-318e-1a7536d43e70@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54136 Cc: 54136@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 54136@debbugs.gnu.org > From: Jim Porter > Date: Thu, 24 Feb 2022 17:04:42 -0800 > > On 2/24/2022 12:07 PM, Lars Ingebrigtsen wrote: > > Eli Zaretskii writes: > > > >> OK, so I installed my changes. > > > > The test now fails on Debian: > > > > Test esh-proc-test/kill-pipeline condition: > > (ert-test-failed > > ((should > > (equal > > (buffer-substring-no-properties output-start ...) > > (or "interrupt\n" "killed\n"))) > > :form > > (equal "killed\n" "interrupt\n") > > :value nil :explanation > > (arrays-of-different-length 7 10 "killed\n" "interrupt\n" first-mismatch-at 0))) > > FAILED 2/4 esh-proc-test/kill-pipeline (0.109668 sec) at lisp/eshell/esh-proc-tests.el:47 > > passed 3/4 esh-proc-test/kill-pipeline-head (0.112142 sec) > > passed 4/4 esh-proc-test/sigpipe-exits-process (1.010359 sec) > > > > Ran 4 tests, 3 results as expected, 1 unexpected (2022-02-24 21:06:48+0100, 1.446135 sec) > > > > 1 unexpected results: > > FAILED esh-proc-test/kill-pipeline > > Here's a patch for that. It works for me on GNU/Linux, and hopefully > it's ok on MS Windows too. Thanks, and sorry for the thinko. (I thought posting the patch would have that caught, but I guess no one reads my patches seriously.) From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 25 13:31:52 2022 Received: (at 54136) by debbugs.gnu.org; 25 Feb 2022 18:31:52 +0000 Received: from localhost ([127.0.0.1]:53726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNfNg-0003Cm-DO for submit@debbugs.gnu.org; Fri, 25 Feb 2022 13:31:52 -0500 Received: from mail-pj1-f51.google.com ([209.85.216.51]:32857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNfNe-0003CW-ML for 54136@debbugs.gnu.org; Fri, 25 Feb 2022 13:31:50 -0500 Received: by mail-pj1-f51.google.com with SMTP id m13-20020a17090aab0d00b001bbe267d4d1so8135812pjq.0 for <54136@debbugs.gnu.org>; Fri, 25 Feb 2022 10:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=3lXN4a9cKumkt35TkOXlwe5nMkybNddGFJ3ukjChHKU=; b=FiUwgrCnk74enxu/2ZyuSh+ugFY35+xPbHryXTznQPZ4jxcEZw13MK8EzcWhnIlN5U s+0/ZZ1owBcF5q7H13eRREaPiJcTIE+wNR2gs0hLw6/63Q3JQ1Lr3guTIywcIOEgjtdx aEb/LNjtL2aqHi9fZ4rPmlRsKW688mNpEU6iyUvyGyXxdavbipo/dVrugKyZHpFiNVDE LbM/R4YdHXcazEiTS1c1Dv7dBG1ZFRPTd3XvdAv0tYQz21g/qz9GoHa8/Yeb/AdD03bN GkrLkNkeTldtrzhhtxgdLCK3mqzoZlW7BK/2x1/va0llm5gTXMq12rb7WaYHYdlxpFLb Xupw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3lXN4a9cKumkt35TkOXlwe5nMkybNddGFJ3ukjChHKU=; b=7vUdqGVPcB59Mf1iw2tHsYOt9Yk69Jlc0Fm4pUm7SYheHy3JoXnCwUb5KescQBbxaX cC0sGCEb+fDR9HF6tuH6Yw+1oleW89ZGz/rX0BxmJCaf4FFIUQiaT8gfCN+z92XaaOI9 nbiu/gQssv5p0rC/Wg0mOLbzxfrLpzJ0FSY9MFooIDw/Uo3r0+hb5qkRUxSDDyh65ooK RYQdPLS1Dydv7Pz04q7FqCuqex68s1hLvczaASbr1410UN2/a6p8HPm7aK/chRayB+kD rT1VbCeetg5LIL9QBf7OXa7e/DuvamPaj+gkg7DhI/Xg2RnLtzIGNOpm/KCBUIGPhX0p m7aA== X-Gm-Message-State: AOAM530iv47xXxG+Rl3mmQ6skQGhkke5nkV0w56GWs80gTj1ZA8Vc21B yyfsOpIT+bOdySX8x2iwqZM= X-Google-Smtp-Source: ABdhPJwv5kIYvVOIg/Hr+pUSGJV8Na8YNqdelK/mndQs4Usu0lHXZ3AZbXaP4gS+EXjtd/fxf8oKLA== X-Received: by 2002:a17:90a:d584:b0:1bc:e520:91f2 with SMTP id v4-20020a17090ad58400b001bce52091f2mr4404068pju.192.1645813904780; Fri, 25 Feb 2022 10:31:44 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id s22-20020a056a0008d600b004f0eaa735f2sm3831601pfu.57.2022.02.25.10.31.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Feb 2022 10:31:44 -0800 (PST) Subject: Re: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases To: Eli Zaretskii References: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> <87y22038uz.fsf@gnus.org> <834k4osf07.fsf@gnu.org> <7f820c27-a58c-3b2b-3132-a57e2a25ea96@gmail.com> <83tucoqbfr.fsf@gnu.org> <87ee3s111a.fsf@gnus.org> <4741f5c9-8846-9584-318e-1a7536d43e70@gmail.com> <83o82vqv67.fsf@gnu.org> From: Jim Porter Message-ID: <49aff7fa-1ade-98bd-66b8-239cb8050f55@gmail.com> Date: Fri, 25 Feb 2022 10:31:45 -0800 MIME-Version: 1.0 In-Reply-To: <83o82vqv67.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54136 Cc: 54136@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/24/2022 11:09 PM, Eli Zaretskii wrote: >> Here's a patch for that. It works for me on GNU/Linux, and hopefully >> it's ok on MS Windows too. > > Thanks, and sorry for the thinko. (I thought posting the patch would > have that caught, but I guess no one reads my patches seriously.) Indeed, sorry about that. I spent an hour reading the Emacs's C sources and digging through Microsoft docs on subprocesses to try and understand why the exit message differed, but neglected the obvious step of "read the actual patch". D'oh. From unknown Sun Jun 22 11:40:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 26 Mar 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator