From unknown Fri Jun 20 07:21:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54132 <54132@debbugs.gnu.org> To: bug#54132 <54132@debbugs.gnu.org> Subject: Status: [PATCH] gnu: imgui: Add missing build files. Reply-To: bug#54132 <54132@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:21:37 +0000 retitle 54132 [PATCH] gnu: imgui: Add missing build files. reassign 54132 guix-patches submitter 54132 John Kehayias severity 54132 normal tag 54132 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 23 14:55:57 2022 Received: (at submit) by debbugs.gnu.org; 23 Feb 2022 19:55:57 +0000 Received: from localhost ([127.0.0.1]:46603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMxjx-00006F-Dx for submit@debbugs.gnu.org; Wed, 23 Feb 2022 14:55:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:39512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMxjs-000062-Lh for submit@debbugs.gnu.org; Wed, 23 Feb 2022 14:55:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMxjs-0002kO-6w for guix-patches@gnu.org; Wed, 23 Feb 2022 14:55:52 -0500 Received: from mail-40133.protonmail.ch ([185.70.40.133]:56033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMxjp-0001ty-LA for guix-patches@gnu.org; Wed, 23 Feb 2022 14:55:51 -0500 Date: Wed, 23 Feb 2022 19:55:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1645646144; bh=WFtW71gbM6G7oOSqQ7xFlmi6pHK5gnVdfHpo6kvmJJo=; h=Date:To:From:Reply-To:Subject:Message-ID:From:To:Cc:Date:Subject: Reply-To:Feedback-ID:Message-ID; b=OKhNOANrbMvFdBiPcuZ/VTmDnCGVT+29ggsOzG2JovEKlebtcSpuEfP2vB2c2RovX 1EK0AWFDKgEzUq3ydFFR5Ss0BJ8ZPUx8DD02Ttypz6hUkhpoEOIPV778FRQUmoC1gN mjf1p2MD8yvx816ejXGfemzJGKyTBlbCZcacjl9abvFz/3GtbsCCTsXHYeRvhKUQwm s8pkfU+sFoQd1fpA8hwnGY7V7xspGm64nXqt2Z/mali4MJ/lWwwIJ5oIUrsby0CBAW ip7CFd9JZQjx5nRodZf+AsKYos0ai0oSTVK4If2TtGdan/7+Uk1g2SwsgMEhMkOTTN AUdewd2/43Heg== To: Guix-patches From: John Kehayias Subject: [PATCH] gnu: imgui: Add missing build files. Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_QRlSyC98m223S1chZlMne9Be7qeH5tGgysxa9RrL1M" X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.40.133; envelope-from=john.kehayias@protonmail.com; helo=mail-40133.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: John Kehayias Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_QRlSyC98m223S1chZlMne9Be7qeH5tGgysxa9RrL1M Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Imgui was being built without two of its files, removing table and widget s= upport from the built library. This simple patch adds them back to the buil= d phase. Tested it builds and those features work in a package (mangohud) that uses = them. --b1_QRlSyC98m223S1chZlMne9Be7qeH5tGgysxa9RrL1M Content-Type: text/x-patch; name=0001-gnu-imgui-Add-missing-build-files.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-imgui-Add-missing-build-files.patch RnJvbSAxMWM4YWE3MWQzZTIyNmI0NjllNGVkM2M2NWZkODU4NTFlYjYzZjc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2huIEtlaGF5aWFzIDxqb2huLmtlaGF5aWFzQHByb3Rvbm1h aWwuY29tPgpEYXRlOiBXZWQsIDIzIEZlYiAyMDIyIDE0OjUxOjMyIC0wNTAwClN1YmplY3Q6IFtQ QVRDSF0gZ251OiBpbWd1aTogQWRkIG1pc3NpbmcgYnVpbGQgZmlsZXMuCgoqIGdudS9wYWNrYWdl cy90b29sa2l0cy5zY20gKGltZ3VpKVtwaGFzZXNdOiBBZGQgaW1ndWlfdGFibGVzLmNwcCBhbmQK aW1ndWlfd2lkZ2V0cy5jcHAgdG8gdGhlIGJ1aWxkIHBoYXNlLgotLS0KIGdudS9wYWNrYWdlcy90 b29sa2l0cy5zY20gfCAzICsrKwogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQoKZGlm ZiAtLWdpdCBhL2dudS9wYWNrYWdlcy90b29sa2l0cy5zY20gYi9nbnUvcGFja2FnZXMvdG9vbGtp dHMuc2NtCmluZGV4IGVlMGNmZmEyZjkuLmJhODYwMDE0YTQgMTAwNjQ0Ci0tLSBhL2dudS9wYWNr YWdlcy90b29sa2l0cy5zY20KKysrIGIvZ251L3BhY2thZ2VzL3Rvb2xraXRzLnNjbQpAQCAtMSw2 ICsxLDcgQEAKIDs7OyBHTlUgR3VpeCAtLS0gRnVuY3Rpb25hbCBwYWNrYWdlIG1hbmFnZW1lbnQg Zm9yIEdOVQogOzs7IENvcHlyaWdodCDCqSAyMDIyIE1heGltIENvdXJub3llciA8bWF4aW0uY291 cm5veWVyQGdtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAyMCBUb2JpYXMgR2VlcmluY2t4 LVJpY2UgPG1lQHRvYmlhcy5ncj4KKzs7OyBDb3B5cmlnaHQgwqkgMjAyMiBKb2huIEtlaGF5aWFz IDxqb2huLmtlaGF5aWFzQHByb3Rvbm1haWwuY29tPgogOzs7CiA7OzsgVGhpcyBmaWxlIGlzIHBh cnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTY5LDYgKzcwLDggQEAgKGRlZmluZS1wdWJsaWMgaW1n dWkKICAgICAgICAgICAgICAgICAgICAgICItbyIgImxpYmltZ3VpLnNvIgogICAgICAgICAgICAg ICAgICAgICAgImltZ3VpLmNwcCIKICAgICAgICAgICAgICAgICAgICAgICJpbWd1aV9kcmF3LmNw cCIKKyAgICAgICAgICAgICAgICAgICAgICJpbWd1aV90YWJsZXMuY3BwIgorICAgICAgICAgICAg ICAgICAgICAgImltZ3VpX3dpZGdldHMuY3BwIgogICAgICAgICAgICAgICAgICAgICAgOzsgSW5j bHVkZSB0aGUgc3VwcG9ydGVkIGJhY2tlbmRzLgogICAgICAgICAgICAgICAgICAgICAgImJhY2tl bmRzL2ltZ3VpX2ltcGxfZ2xmdy5jcHAiCiAgICAgICAgICAgICAgICAgICAgICAiYmFja2VuZHMv aW1ndWlfaW1wbF9zZGwuY3BwIgotLSAKMi4zNC4wCgo= --b1_QRlSyC98m223S1chZlMne9Be7qeH5tGgysxa9RrL1M-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 23 22:09:54 2022 Received: (at 54132-done) by debbugs.gnu.org; 24 Feb 2022 03:09:54 +0000 Received: from localhost ([127.0.0.1]:47003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN4Vt-0002z8-SU for submit@debbugs.gnu.org; Wed, 23 Feb 2022 22:09:54 -0500 Received: from mail-qk1-f173.google.com ([209.85.222.173]:44755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN4Vn-0002yc-Qo for 54132-done@debbugs.gnu.org; Wed, 23 Feb 2022 22:09:49 -0500 Received: by mail-qk1-f173.google.com with SMTP id q4so761098qki.11 for <54132-done@debbugs.gnu.org>; Wed, 23 Feb 2022 19:09:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=uxk5AaFvoko7oPVRAz6OVxyk0QDqhgkJ4yQT6NxauFY=; b=j5j1kHDqqJmyQYiE3Aea8FZfHjVHIBnQkZ5VKhXJahPhEO+IgLpDoCHMdW1lFR3VF/ OGann8xGp178cpaJwVsn830AyS21Ij9Ri34YknZNVJ2cW9WcA/IfOSLrzthSAu4nLbs0 j1SsSSgy07bNjEm+OBJJwicrTawB/APuETgBrnnUJ+oxmnEFcicFNpSxImhAuLgEOdfO 6CoSJInkP6aTyKH9GnyI9pTVnyPWlL59ovtL+1R+AOD3ORhKPpOYRSTUxw+Lfhk3wiUG /jVdhIAbthWDNkqgh6Tf9FVvb0dwFpYpQZyQRd3K79grZgUwGjm42vqO3d3iwBKr7yS+ 0WMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=uxk5AaFvoko7oPVRAz6OVxyk0QDqhgkJ4yQT6NxauFY=; b=AA6kNHeFRroIx+lfam9499/QcrEjhkUH/IQeJrrNi9zoOXcPcJRvkvhMU0uqN/qOQO p76Y43aXdcfSixnNRpQqXhVZKT+rHOLdfDunNFmRaa5QpkR3zCtNAc9VHM/1cP0LG9uV eixHWnzIkibRyunN3QwOMENm1E6xNkRONG6SW20LQT/CSXPsok3unJRoApK8Bm4nmV2Z XUjuyaRnMTMiFL7FopcwpZVsZcDhYj1SHwAZWMAP/DaET78XZX/VUr7edBbaT84jjTr1 9itVKXDw9H3DB3sp32hKC9hh4q9kmnFvcD9XjSeufrrFLaKGash5lRldh0nVB+J4Hjmn X1Mg== X-Gm-Message-State: AOAM530gISYr1oh7wWHKiyaaHtgKy/1NMYA+GtpH717pr4a00sZq+1Ja S8a+6nACGjfrysrFjfENk03sAJ7bBOA= X-Google-Smtp-Source: ABdhPJwrPbQilFN2PRIEZMyUEGs1i/LfjBh0Ju3+dmusCEy0an1HHHwnoxoPzdF4GWLEYYNy7COSug== X-Received: by 2002:a05:620a:20c8:b0:47b:4219:40d9 with SMTP id f8-20020a05620a20c800b0047b421940d9mr450883qka.224.1645672182157; Wed, 23 Feb 2022 19:09:42 -0800 (PST) Received: from hurd (dsl-156-1.b2b2c.ca. [66.158.156.1]) by smtp.gmail.com with ESMTPSA id v145sm751627qkb.63.2022.02.23.19.09.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 19:09:41 -0800 (PST) From: Maxim Cournoyer To: John Kehayias Subject: Re: bug#54132: [PATCH] gnu: imgui: Add missing build files. References: Date: Wed, 23 Feb 2022 22:09:41 -0500 In-Reply-To: (John Kehayias's message of "Wed, 23 Feb 2022 19:55:42 +0000") Message-ID: <87y221klje.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54132-done Cc: 54132-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello! John Kehayias writes: > Imgui was being built without two of its files, removing table and > widget support from the built library. This simple patch adds them > back to the build phase. > > Tested it builds and those features work in a package (mangohud) that use= s them. > > From 11c8aa71d3e226b469e4ed3c65fd85851eb63f76 Mon Sep 17 00:00:00 2001 > From: John Kehayias > Date: Wed, 23 Feb 2022 14:51:32 -0500 > Subject: [PATCH] gnu: imgui: Add missing build files. > > * gnu/packages/toolkits.scm (imgui)[phases]: Add imgui_tables.cpp and > imgui_widgets.cpp to the build phase. > --- > gnu/packages/toolkits.scm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gnu/packages/toolkits.scm b/gnu/packages/toolkits.scm > index ee0cffa2f9..ba860014a4 100644 > --- a/gnu/packages/toolkits.scm > +++ b/gnu/packages/toolkits.scm > @@ -1,6 +1,7 @@ > ;;; GNU Guix --- Functional package management for GNU > ;;; Copyright =C2=A9 2022 Maxim Cournoyer > ;;; Copyright =C2=A9 2020 Tobias Geerinckx-Rice > +;;; Copyright =C2=A9 2022 John Kehayias > ;;; > ;;; This file is part of GNU Guix. > ;;; I've heard for contributions of less than about 10 new lines, the changes are not substantial enough to be protected by copyright. Something to keep in mind for your future patches :-). > @@ -69,6 +70,8 @@ (define-public imgui > "-o" "libimgui.so" > "imgui.cpp" > "imgui_draw.cpp" > + "imgui_tables.cpp" > + "imgui_widgets.cpp" > ;; Include the supported backends. > "backends/imgui_impl_glfw.cpp" > "backends/imgui_impl_sdl.cpp" Applied as 74f9c8e47f08826eff12b793e668d7e8c5898b0e. Thanks for the investigation and fix! Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 23 22:35:27 2022 Received: (at 54132) by debbugs.gnu.org; 24 Feb 2022 03:35:27 +0000 Received: from localhost ([127.0.0.1]:47038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN4ud-0005qX-63 for submit@debbugs.gnu.org; Wed, 23 Feb 2022 22:35:27 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:64048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN4ub-0005qK-7K for 54132@debbugs.gnu.org; Wed, 23 Feb 2022 22:35:26 -0500 Date: Thu, 24 Feb 2022 03:35:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1645673718; bh=Ndrb0W/mdRMFjC4zXZc8yC5BFt3dDNA3GSGwYCMCk78=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=aufJ5d0b1p3LgxAuEXQRqUKBu2sXFIt4RwVOKdVedecleJ+Ee7KHs026Uq5CbswIR s/H4AFWPOGcbc81tPw70zve9igfSOqxrRQCE2D5f4Ln4PzcaSfGXg+B9QjxiH9cLSk xnHR5u7tIsJOXc50Cb82LpQkgIYLPVzPdEzqQa93vvzoOQawZ1tbrp1zirXdL1z0Hj +aEhmYH44g79elj+Ge2d0GNEHg2SugPGHFgmarmWTiKjRALiZwIzMXNNSx8www+d3N HWCXXlsj7sJ9b6c7cbxKLHeWDz+kT+y78HazUgKH/1UOPfoot9OaAPEgDR13IQfFy1 cmD6ri8c4uTng== To: Maxim Cournoyer From: John Kehayias Subject: Re: bug#54132: [PATCH] gnu: imgui: Add missing build files. Message-ID: In-Reply-To: <87y221klje.fsf@gmail.com> References: <87y221klje.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54132 Cc: "54132@debbugs.gnu.org" <54132@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: John Kehayias Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim! ------- Original Message ------- On Wednesday, February 23rd, 2022 at 10:09 PM, Maxim Cournoyer wrote: > > I've heard for contributions of less than about 10 new lines, the > changes are not substantial enough to be protected by copyright. > Something to keep in mind for your future patches :-). > Ah, good to know! I was never sure about the short patches and sort of flip= a coin sometimes. Feel free to remove the copyright line if needed. Or, yo= u know, I'll just have to make sure to get some more code into toolkits.scm= in the next 10 months :) Thanks for the quick review and push! John From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 09:13:48 2022 Received: (at 54132) by debbugs.gnu.org; 24 Feb 2022 14:13:48 +0000 Received: from localhost ([127.0.0.1]:47922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNEsO-0004cH-I1 for submit@debbugs.gnu.org; Thu, 24 Feb 2022 09:13:48 -0500 Received: from mail-qk1-f174.google.com ([209.85.222.174]:46842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNEsM-0004c2-Cn for 54132@debbugs.gnu.org; Thu, 24 Feb 2022 09:13:46 -0500 Received: by mail-qk1-f174.google.com with SMTP id f21so1817116qke.13 for <54132@debbugs.gnu.org>; Thu, 24 Feb 2022 06:13:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mcOyyV5adofKqTwwSh86iTInGrRL+bdPZyCN/nh4eWk=; b=LDs2/1OxxWU8GqGDw0OuSV2uKUCt6tAbw+rIKzKSnSpzEa6ZodliEtX9gHl49Lz9xb yrrvN6E6gdkm1BK4CWSZPc3zcNmCUpMNCl8d9q9hOWBqp2cjdHpQrV2kKChYZgqJzGyy pwqWXPq2QKNuAx7bEozgk3Ax09uQTy9RSW4j28geUp88zQ8CTDtheUKrGJEsIDmveq1B RAubN4fCUZMWzHfEz/R+7SEQfFAR3QhE0HR4m9lsKrx1/G4MUz8Y8ySllzYFp50dvhiN t5lx0muJ6hxtkflvVA4HQzHnNytv+taWoIthgfrSBKvPDnXaqT+/qWbPJ6/ncaaaKHOU k+aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=mcOyyV5adofKqTwwSh86iTInGrRL+bdPZyCN/nh4eWk=; b=YkS/56VZbVYI7NuTlHyIBWq1JpR4Bxwdd8xq3yUEwxv2CotA7KZCTZmrlG9/9XNOr8 UxE31OpiJ4EeAeXjfsUV+FkvYILOYIAYrHaNRao2xBi3U1zOtDOXutBrf0/mmmg2K1+O KjfBA78R3GokQF7M0gvSj0BRBrejUOG0k9s4zrC3viSPC4e2e5uouxUR2ABXeE9rptsr zVlEn9GEE1bjhclw5X567mlYWjC6aVZrzNPrjOEpTnq6Pv/liy255x4r6GL86qv10xys f0DqP08Hu4T5QNIetEpwvC+5WZHoew9Mq9Af+5cVZMJvDET2z28/QmwcTDvcpIrsXSWW +GNw== X-Gm-Message-State: AOAM532CaCiiJbQ4FVcLjMb2b7A+Zxqz6TFOtN7Bdap8lEA7bz9spcsW pCwzT0jGLdklDDKr5kQGsPjStFdBiRUFDw== X-Google-Smtp-Source: ABdhPJzksNI45eJWZO0NtdtjuY4h56GOz2dLUlGS4jYwymtAuL8A7XeJTPsblBcA8QxoGgHAyb8S2g== X-Received: by 2002:a37:a795:0:b0:475:ce3f:ac76 with SMTP id q143-20020a37a795000000b00475ce3fac76mr1732756qke.193.1645712020576; Thu, 24 Feb 2022 06:13:40 -0800 (PST) Received: from hurd (dsl-156-1.b2b2c.ca. [66.158.156.1]) by smtp.gmail.com with ESMTPSA id b6sm1310792qkg.51.2022.02.24.06.13.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 06:13:40 -0800 (PST) From: Maxim Cournoyer To: John Kehayias Subject: Re: bug#54132: [PATCH] gnu: imgui: Add missing build files. References: <87y221klje.fsf@gmail.com> Date: Thu, 24 Feb 2022 09:13:39 -0500 In-Reply-To: (John Kehayias's message of "Thu, 24 Feb 2022 03:35:17 +0000") Message-ID: <87v8x4jqss.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54132 Cc: "54132@debbugs.gnu.org" <54132@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi John, John Kehayias writes: > Hi Maxim! > > ------- Original Message ------- > > On Wednesday, February 23rd, 2022 at 10:09 PM, Maxim Cournoyer wrote: > >> >> I've heard for contributions of less than about 10 new lines, the >> changes are not substantial enough to be protected by copyright. >> Something to keep in mind for your future patches :-). >> > > Ah, good to know! I was never sure about the short patches and sort of > flip a coin sometimes. Feel free to remove the copyright line if > needed. Or, you know, I'll just have to make sure to get some more > code into toolkits.scm in the next 10 months :) Haha, sounds fair. > Thanks for the quick review and push! No problem, Have a good Thursday, Maxim From unknown Fri Jun 20 07:21:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Mar 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator