GNU bug report logs - #54132
[PATCH] gnu: imgui: Add missing build files.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54132 in the body.
You can then email your comments to 54132 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: imgui: Add missing build files.
Date: Wed, 23 Feb 2022 19:55:42 +0000

[Message part 1 (text/plain, inline)]

Imgui was being built without two of its files, removing table and widget support from the built library. This simple patch adds them back to the build phase.

Tested it builds and those features work in a package (mangohud) that uses them.

[0001-gnu-imgui-Add-missing-build-files.patch (text/x-patch, attachment)]

Message #10 received at 54132-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: 54132-done <at> debbugs.gnu.org
Subject: Re: bug#54132: [PATCH] gnu: imgui: Add missing build files.
Date: Wed, 23 Feb 2022 22:09:41 -0500

Hello!

John Kehayias <john.kehayias <at> protonmail.com> writes:

> Imgui was being built without two of its files, removing table and
> widget support from the built library. This simple patch adds them
> back to the build phase.
>
> Tested it builds and those features work in a package (mangohud) that uses them.
>
> From 11c8aa71d3e226b469e4ed3c65fd85851eb63f76 Mon Sep 17 00:00:00 2001
> From: John Kehayias <john.kehayias <at> protonmail.com>
> Date: Wed, 23 Feb 2022 14:51:32 -0500
> Subject: [PATCH] gnu: imgui: Add missing build files.
>
> * gnu/packages/toolkits.scm (imgui)[phases]: Add imgui_tables.cpp and
> imgui_widgets.cpp to the build phase.
> ---
>  gnu/packages/toolkits.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/toolkits.scm b/gnu/packages/toolkits.scm
> index ee0cffa2f9..ba860014a4 100644
> --- a/gnu/packages/toolkits.scm
> +++ b/gnu/packages/toolkits.scm
> @@ -1,6 +1,7 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>  ;;; Copyright © 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
> +;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;

I've heard for contributions of less than about 10 new lines, the
changes are not substantial enough to be protected by copyright.
Something to keep in mind for your future patches :-).

> @@ -69,6 +70,8 @@ (define-public imgui
>                       "-o" "libimgui.so"
>                       "imgui.cpp"
>                       "imgui_draw.cpp"
> +                     "imgui_tables.cpp"
> +                     "imgui_widgets.cpp"
>                       ;; Include the supported backends.
>                       "backends/imgui_impl_glfw.cpp"
>                       "backends/imgui_impl_sdl.cpp"

Applied as 74f9c8e47f08826eff12b793e668d7e8c5898b0e.

Thanks for the investigation and fix!

Maxim

Message #13 received at 54132 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: "54132 <at> debbugs.gnu.org" <54132 <at> debbugs.gnu.org>
Subject: Re: bug#54132: [PATCH] gnu: imgui: Add missing build files.
Date: Thu, 24 Feb 2022 03:35:17 +0000

Hi Maxim!

------- Original Message -------

On Wednesday, February 23rd, 2022 at 10:09 PM, Maxim Cournoyer wrote:

>
> I've heard for contributions of less than about 10 new lines, the
> changes are not substantial enough to be protected by copyright.
> Something to keep in mind for your future patches :-).
>

Ah, good to know! I was never sure about the short patches and sort of flip a coin sometimes. Feel free to remove the copyright line if needed. Or, you know, I'll just have to make sure to get some more code into toolkits.scm in the next 10 months :)

Thanks for the quick review and push!

John

Message #16 received at 54132 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: "54132 <at> debbugs.gnu.org" <54132 <at> debbugs.gnu.org>
Subject: Re: bug#54132: [PATCH] gnu: imgui: Add missing build files.
Date: Thu, 24 Feb 2022 09:13:39 -0500

Hi John,

John Kehayias <john.kehayias <at> protonmail.com> writes:

> Hi Maxim!
>
> ------- Original Message -------
>
> On Wednesday, February 23rd, 2022 at 10:09 PM, Maxim Cournoyer wrote:
>
>>
>> I've heard for contributions of less than about 10 new lines, the
>> changes are not substantial enough to be protected by copyright.
>> Something to keep in mind for your future patches :-).
>>
>
> Ah, good to know! I was never sure about the short patches and sort of
> flip a coin sometimes. Feel free to remove the copyright line if
> needed. Or, you know, I'll just have to make sure to get some more
> code into toolkits.scm in the next 10 months :)

Haha, sounds fair.

> Thanks for the quick review and push!

No problem,

Have a good Thursday,

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.