GNU bug report logs - #54127
29.0.50; auth-sources defcustom bug

Previous Next

Full log

Message #8 received at 54127 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 54127 <at> debbugs.gnu.org
Subject: Re: bug#54127: 29.0.50; auth-sources defcustom bug
Date: Wed, 23 Feb 2022 11:49:11 -0300

[Message part 1 (text/plain, inline)]

Here's a patch:

[0001-Fix-auth-sources-defcustom.patch (text/x-patch, inline)]

From 57b5ff82d35f8059f152453526a30283cf65ea22 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda <at> gmail.com>
Date: Sun, 20 Feb 2022 19:35:31 -0300
Subject: [PATCH] Fix auth-sources defcustom

* lisp/auth-source.el (auth-sources): The extra attributes should be
in a plist, so inline both :host and :port.  Also, give a valid
default value for the choice.  (Bug#54127)
---
 lisp/auth-source.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/auth-source.el b/lisp/auth-source.el
index 8a425cf9bc..cb528cebdc 100644
--- a/lisp/auth-source.el
+++ b/lisp/auth-source.el
@@ -280,15 +280,16 @@ auth-sources
                                          (const :tag "default" default))))
                         (repeat :tag "Extra Parameters" :inline t
                                 (choice :tag "Extra parameter"
+                                        :value (:host t)
                                         (list
-                                         :tag "Host"
+                                         :tag "Host" :inline t
                                          (const :format "" :value :host)
                                          (choice :tag "Host (machine) choice"
                                                  (const :tag "Any" t)
                                                  (regexp
                                                   :tag "Regular expression")))
                                         (list
-                                         :tag "Protocol"
+                                         :tag "Protocol" :inline t
                                          (const :format "" :value :port)
                                          (choice
                                           :tag "Protocol"
-- 
2.17.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.