GNU bug report logs - #54122
29.0.50; [PATCH] Update modus-themes to version 2.2.0

Previous Next

Package: emacs;

Reported by: Protesilaos Stavrou <info <at> protesilaos.com>

Date: Wed, 23 Feb 2022 07:48:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Done: Protesilaos Stavrou <info <at> protesilaos.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54122 in the body.
You can then email your comments to 54122 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#54122; Package emacs. (Wed, 23 Feb 2022 07:48:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Protesilaos Stavrou <info <at> protesilaos.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 23 Feb 2022 07:48:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Update modus-themes to version 2.2.0
Date: Wed, 23 Feb 2022 09:46:49 +0200
[Message part 1 (text/plain, inline)]
Dear maintainers,

I just published the latest version of the modus-themes.  Normally I tag
a release once every few weeks, but this is a necessary exception.

Please see the attached patch.  The major change is that the user option
'modus-themes-completions' accepts an alist value instead of a symbol.

The patch also removes a default value from a defcustom form that
affected the initialization of user options in the Custom UI.

The release notes are available here:
<https://protesilaos.com/codelog/2022-02-23-modus-themes-2-2-0/>.

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com
[0001-Update-modus-themes-to-version-2.2.0.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#54122; Package emacs. (Wed, 23 Feb 2022 11:34:01 GMT) Full text and rfc822 format available.

Message #8 received at 54122 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 54122 <at> debbugs.gnu.org
Subject: Re: bug#54122: 29.0.50; [PATCH] Update modus-themes to version 2.2.0
Date: Wed, 23 Feb 2022 12:32:59 +0100
Protesilaos Stavrou <info <at> protesilaos.com> writes:

> Please see the attached patch.  The major change is that the user option
> 'modus-themes-completions' accepts an alist value instead of a symbol.

Makes sense to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#54122; Package emacs. (Wed, 23 Feb 2022 12:32:02 GMT) Full text and rfc822 format available.

Message #11 received at 54122 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54122 <at> debbugs.gnu.org
Subject: Re: bug#54122: 29.0.50; [PATCH] Update modus-themes to version 2.2.0
Date: Wed, 23 Feb 2022 14:31:16 +0200
On 2022-02-23, 12:32 +0100, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> Please see the attached patch.  The major change is that the user option
>> 'modus-themes-completions' accepts an alist value instead of a symbol.
>
> Makes sense to me.

Do you think it is okay if I push these changes?

And sorry for taking up your time with these back-to-back releases!

-- 
Protesilaos Stavrou
https://protesilaos.com




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#54122; Package emacs. (Wed, 23 Feb 2022 12:53:01 GMT) Full text and rfc822 format available.

Message #14 received at 54122 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 54122 <at> debbugs.gnu.org
Subject: Re: bug#54122: 29.0.50; [PATCH] Update modus-themes to version 2.2.0
Date: Wed, 23 Feb 2022 13:52:23 +0100
Protesilaos Stavrou <info <at> protesilaos.com> writes:

>> Makes sense to me.
>
> Do you think it is okay if I push these changes?

Oh, yeah, please go ahead.  :-)  And in the future, you can just push
directly without going through debbugs first -- these modus-theme
updates have all been fine.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Reply sent to Protesilaos Stavrou <info <at> protesilaos.com>:
You have taken responsibility. (Wed, 23 Feb 2022 13:14:01 GMT) Full text and rfc822 format available.

Notification sent to Protesilaos Stavrou <info <at> protesilaos.com>:
bug acknowledged by developer. (Wed, 23 Feb 2022 13:14:02 GMT) Full text and rfc822 format available.

Message #19 received at 54122-done <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54122-done <at> debbugs.gnu.org
Subject: Re: bug#54122: 29.0.50; [PATCH] Update modus-themes to version 2.2.0
Date: Wed, 23 Feb 2022 15:13:22 +0200
On 2022-02-23, 13:52 +0100, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>>> Makes sense to me.
>>
>> Do you think it is okay if I push these changes?
>
> Oh, yeah, please go ahead.  :-)

Done!

> And in the future, you can just push directly without going through
> debbugs first -- these modus-theme updates have all been fine.

Understood.  Thank you!

Closing this bug now.

-- 
Protesilaos Stavrou
https://protesilaos.com




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 24 Mar 2022 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 89 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.