GNU bug report logs - #54095
Feature request: make 'outline-blank-line' defcustom and local-safe.

Previous Next

Package: emacs;

Reported by: Jeff Norden <jeff <at> jnorden.com>

Date: Mon, 21 Feb 2022 22:14:02 UTC

Severity: wishlist

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jeff Norden <jeff <at> jnorden.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Feature request: make 'outline-blank-line' defcustom and local-safe.
Date: Mon, 21 Feb 2022 14:12:40 -0600
[Message part 1 (text/plain, inline)]
I've been playing with outline-mode for the first time in a while. I've 
got a
simple suggestion: it seems like the `outline-blank-line' variable ought 
to be
customizable and file-local safe. It causes a single blank line to 
separate
hidden heading lines when there is at least one blank line in the 
un-hidden
text.

If you leave blank lines before some headings and not others, it 
provides an
additional visual way of grouping them, without the need to create 
another
heading level. This is handy if the distinction is temporary, as in: 
"I'm done
with these sections, but still working on those."

A trivial patch is below (and also attached). Version 22.1 is a guess on 
my
part, someone with better git skills than me could probably check it.

Thanks!
-Jeff

============================================================
--- outline.el.orig    2022-02-21 12:08:50.124838087 -0600
+++ outline.el    2022-02-21 13:05:59.087075549 -0600
@@ -294,8 +294,11 @@
 (defvar outline-mode-hook nil
   "This hook is run when outline mode starts.")

-(defvar outline-blank-line nil
-  "Non-nil means to leave unhidden blank line before heading.")
+(defcustom outline-blank-line nil
+  "Non-nil means to leave an unhidden blank line before headings."
+  :type 'boolean
+  :version "22.1")
+;;;###autoload(put 'outline-blank-line 'safe-local-variable 'booleanp)

 ;;;###autoload
 (define-derived-mode outline-mode text-mode "Outline"
============================================================
[outline_el.diff (text/x-diff, attachment)]

This bug report was last modified 3 years and 180 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.