Subject: Re: [bug#54090] [PATCH v2] gnu: Add tessen.

From: Nicolas Goaziou <[email-masked]>
Date: Thu, 10 Mar 2022 19:56:19 +0100

Hello,

Tanguy Le Carrour <[email-masked]> writes:

> * gnu/packages/password-utils.scm (tessen): New variable.

Thanks. I simply suggest some style overhaul!

> +    (arguments

(list
 #:phases
 #~(modify-phases ...)
 ...)

> +     `(#:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'patch-wtype-path
> +                    (lambda* (#:key inputs #:allow-other-keys)
> +                      (let ((wtype (assoc-ref inputs "wtype")))
> +                        (substitute* "tessen"
> +                          (("wtype") (string-append wtype "/bin/wtype"))))))

You can drop the `wtype' binding, and use

  (search-input-file inputs "/bin/wtype")

as a replacement for "wtype".

> +                  (delete 'configure)

There should be a comment (perhaps there is no configure script)

> +                  (delete 'check))

Disabling tests is done with "#:tests? #f", but then, a comment is
necessary (perhaps there are no tests).
)
> +       #:make-flags
> +       (let ((out (assoc-ref %outputs "out")))

  #~(let ...)

> +         (list (string-append "PREFIX=" out)))))

You can drop the `out' binding and use (string-append "PREFIX=" #$output)

You'll need to add

  #:use-module (guix gexp)

at the top-level for those changes.

Regards,
-- 
Nicolas Goaziou