GNU bug report logs - #54089
[PATCH] gnu: Add emacs-highlight-doxygen

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#54089: closed ([PATCH] gnu: Add emacs-highlight-doxygen)
Date: Tue, 22 Feb 2022 10:36:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 22 Feb 2022 11:35:48 +0100
with message-id <877d9n429n.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#54089] [PATCH] gnu: Add emacs-highlight-doxygen
has caused the debbugs.gnu.org bug report #54089,
regarding [PATCH] gnu: Add emacs-highlight-doxygen
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
54089: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54089
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-highlight-doxygen
Date: Mon, 21 Feb 2022 17:07:35 +0000

[Message part 3 (text/plain, inline)]

Hello,

here is a patch adding the highlight-doxygen package for Emacs.

Best regards,

Niklas Eklund

[0001-gnu-Add-emacs-highlight-doxygen.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: 54089-done <at> debbugs.gnu.org
Subject: Re: [bug#54089] [PATCH] gnu: Add emacs-highlight-doxygen
Date: Tue, 22 Feb 2022 11:35:48 +0100

Hello,

Niklas Eklund <niklas.eklund <at> posteo.net> writes:

> here is a patch adding the highlight-doxygen package for Emacs.

Thank you. I applied your patch with the changes explained below.

> +(define-public emacs-highlight-doxygen
> +  ;; Upstream does not tag releases.  Commit below matches version bump.
> +  (let ((commit "eec4874e2e89d4eb39091aad89a67dff8f8ec84c")
> +        (revision "0"))
> +    (package
> +      (name "emacs-highlight-doxygen")
> +      (version (git-version "0.0.2" revision commit))

Since commit matches version bump, you don't need GIT-VERSION at all.
I removed REVISION binding, and wrote:

  (version "0.0.2")

> +      (description
> +       "Advanced highlighting package for Doxygen comments.

This is not a complete sentence. I wrote

  This package highlights Doxygen comments.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.