GNU bug report logs - #54089
[PATCH] gnu: Add emacs-highlight-doxygen

Previous Next

Full log

Message #10 received at 54089-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: 54089-done <at> debbugs.gnu.org
Subject: Re: [bug#54089] [PATCH] gnu: Add emacs-highlight-doxygen
Date: Tue, 22 Feb 2022 11:35:48 +0100

Hello,

Niklas Eklund <niklas.eklund <at> posteo.net> writes:

> here is a patch adding the highlight-doxygen package for Emacs.

Thank you. I applied your patch with the changes explained below.

> +(define-public emacs-highlight-doxygen
> +  ;; Upstream does not tag releases.  Commit below matches version bump.
> +  (let ((commit "eec4874e2e89d4eb39091aad89a67dff8f8ec84c")
> +        (revision "0"))
> +    (package
> +      (name "emacs-highlight-doxygen")
> +      (version (git-version "0.0.2" revision commit))

Since commit matches version bump, you don't need GIT-VERSION at all.
I removed REVISION binding, and wrote:

  (version "0.0.2")

> +      (description
> +       "Advanced highlighting package for Doxygen comments.

This is not a complete sentence. I wrote

  This package highlights Doxygen comments.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.