Subject: Re: bug#54038: 29.0.50; doc-view cannot show different pages in different tabs

From: Juri Linkov <[email-masked]>
Date: Mon, 29 Jul 2024 21:12:28 +0300

> The problem is that when 'image-mode-winprops' does window cleanup,
> it doesn't take into account windows saved in tabs.
>
> diff --git a/lisp/image-mode.el b/lisp/image-mode.el
> index 5bee155460..c127df12ae 100644
> --- a/lisp/image-mode.el
> +++ b/lisp/image-mode.el
> @@ -179,7 +179,7 @@ image-mode-reapply-winprops
>      ;; Beware: this call to image-mode-winprops can't be optimized away,
>      ;; because it not only gets the winprops data but sets it up if needed
>      ;; (e.g. it's used by doc-view to display the image in a new window).
> -    (let* ((winprops (image-mode-winprops nil t))
> +    (let* ((winprops (image-mode-winprops nil nil))
>             (hscroll (image-mode-window-get 'hscroll winprops))
>             (vscroll (image-mode-window-get 'vscroll winprops)))
>        (when (image-get-display-property) ;Only do it if we display an image!

I see that Po Lu corrected display of Doc View documents after tab switching
in the commit a475360af98.  I tried the original report, but it still doesn't
work without the patch above.