GNU bug report logs - #54034
29.0.50; Diff prettify broken for empty files

Previous Next

Full log

Message #53 received at 54034 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Matthias Meulien <orontee <at> gmail.com>
Cc: 54034 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#54034: 29.0.50; Diff prettify broken for empty files
Date: Fri, 24 Jun 2022 01:36:15 +0300

Matthias Meulien [2022-04-07 14:15 +0200] wrote:

> From: Matthias Meulien <orontee <at> gmail.com>
> Date: Thu, 7 Apr 2022 00:11:55 +0200
> Subject: [PATCH] Display file mode information when diff font lock prettify
>  enabled
>
> * lisp/vc/diff-mode.el (diff--font-lock-prettify): Make regexp capture
> file mode information.

I think this gave rise to the following regression in the header when
diff-font-lock-prettify is enabled:

0. emacs -Q
1. M-x diff-buffers RET RET RET
   [ Header now comprises 'diff -u ...'. ]
2. (setq diff-font-lock-prettify t) C-x C-e
3. C-x o g
   [ Header is now 'Deleted file'. ]

It's not particularly jarring to see a header like that when diffing
non-file-visiting buffers, but more importantly the same header appears
when diffing any regular files via M-x diff.

Thanks,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.