GNU bug report logs - #54030
29.0.50; [PATCH] Extend bookmark menu with column displaying handler type

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54030 in the body.
You can then email your comments to 54030 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matthias Meulien <orontee <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Extend bookmark menu with column displaying
 handler type
Date: Wed, 16 Feb 2022 20:55:35 +0100

[Message part 1 (text/plain, inline)]

This is a feature request.

Bookmarks handled by VC (through `vc-dir-bookmark-make-record') are
named after the VC directory prefixed by the name of the VC backend
(with parentheses).  Thus when one use a single VC backend, eg Git, all
bookmarks handled by VC start with "(Git) " which makes the sort of
bookmarks by name in bookmark menu useless.

I suggest to remove that prefix but extend the bookmark menu with a new
column "Type" displaying the type of bookmark handler.  As a result
sorting bookmarks by their name don't gather bookmarks handled by VC
anymore.

Example:

[Capture d’écran du 2022-02-16 20-49-48.png (image/png, inline)]

[Message part 3 (text/plain, inline)]

becomes with the proposed patches:

[Capture d’écran du 2022-02-16 20-39-57.png (image/png, inline)]

[Message part 5 (text/plain, inline)]

Patch are attached. Note that at present time there's no way to filter
bookmarks by type, but I may add this feature if people are interested.

[0001-Extend-bookmark-menu-with-with-handler-type-column.patch (text/x-diff, attachment)]

[0002-Don-t-prefix-bookmark-name-with-VC-backend-name.patch (text/x-diff, attachment)]

[Message part 8 (text/plain, inline)]

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
 of 2022-02-14 built on carbon
Repository revision: d52d913fa032a6cd1b6422cbbd44169b318ca174
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-native-compilation'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LANG: fr_FR.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Bookmark Menu

Minor modes in effect:
  hl-line-mode: t
  highlight-changes-visible-mode: t
  shell-dirtrack-mode: t
  minions-mode: t
  global-company-mode: t
  company-mode: t
  desktop-save-mode: t
  save-place-mode: t
  electric-pair-mode: t
  icomplete-mode: t
  global-so-long-mode: t
  global-auto-revert-mode: t
  auto-insert-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-layout-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tab-bar-mode: t
  file-name-shadow-mode: t
  context-menu-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  window-divider-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
/home/matthias/.config/emacs/elpa/transient-20220130.1941/transient hides /usr/local/share/emacs/29.0.50/lisp/transient
/home/matthias/.config/emacs/elpa/dictionary-20201001.1727/dictionary hides /usr/local/share/emacs/29.0.50/lisp/net/dictionary

Features:
(shadow emacsbug sendmail image-dired autoload lisp-mnt log-edit edebug
shortdoc dabbrev url-http url-gw url-cache url-auth view woman cl-print
apropos man misearch multi-isearch speedbar ezimage dframe pulse grep
help-fns radix-tree smerge-mode diff add-log log-view pcvs-util
sh-script executable mhtml-mode css-mode hideshow cap-words superword
subword js generic meson-mode smie conf-mode yaml-mode make-mode rng-xsd
xsd-regexp rng-cmpct rng-nxml rng-valid nxml-mode nxml-outln nxml-rap
sgml-mode facemenu rst sort gnus-cite smiley shr-color mm-archive
mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable
textsec-check gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic
nndraft nnmh nnfolder utf-7 epa-file gnutls network-stream nsm
gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-cache
hl-line dired-aux whitespace vc-dir flyspell ox-odt rng-loc rng-uri
rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns
nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda ox-html table
ox-ascii ox-publish ox goto-addr org-element avl-tree ol-eww eww xdg
url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect
gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr
pixel-fill kinsoku svg dom ol-docview doc-view image-mode exif ol-bibtex
ol-bbdb ol-w3m ol-doi org-link-doi follow mule-util jka-compr python
bug-reference display-line-numbers hilit-chg vc-mtn vc-hg vc-bzr vc-src
vc-sccs vc-svn vc-cvs vc-rcs vc bash-completion shell eglot array
jsonrpc ert ewoc debug backtrace flymake-proc flymake compile imenu
company-oddmuse company-keywords company-etags etags fileloop generator
xref project company-gtags company-dabbrev-code company-dabbrev
company-files company-clang company-capf company-cmake company-semantic
company-template company-bbdb avoid minions company pcase carbon-custom
cus-edit cus-load gnus-demon nntp gnus-group gnus-undo gnus-start
gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 netrc
parse-time gnus-spec gnus-win nnoo gnus-int gnus-range message
yank-media rmc puny rfc822 mml mml-sec epa derived epg rfc6068
epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047
rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus nnheader
gnus-util mail-utils range mm-util mail-prsvr wid-edit gnus-dired
dired-x dired dired-loaddefs org-capture org-refile org ob ob-tangle
ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint
org-pcomplete pcomplete comint ansi-color ring org-list org-faces
org-entities org-version ob-emacs-lisp ob-core ob-eval org-table
oc-basic bibtex iso8601 time-date ol org-keys oc org-compat org-macs
org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs
dictionary link connection advice markdown-mode edit-indirect color
thingatpt noutline outline skeleton find-file vc-git diff-mode
easy-mmode vc-dispatcher ispell comp comp-cstr warnings rx cl-extra
help-mode desktop frameset server bookmark text-property-search pp
saveplace elec-pair icomplete so-long autorevert filenotify autoinsert
cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine
cc-vars cc-defs generic-x face-remap proof-site proof-autoloads info
package browse-url url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util mailcap url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json map url-vars seq gv subr-x byte-opt bytecomp
byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice
button loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process
native-compile emacs)

Memory information:
((conses 16 1234632 143740)
 (symbols 48 44787 17)
 (strings 32 239868 12813)
 (string-bytes 1 9302463)
 (vectors 16 110937)
 (vector-slots 8 2819948 246391)
 (floats 8 736 1584)
 (intervals 56 30215 2743)
 (buffers 992 240))

-- 
Matthias

Message #8 received at 54030 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Matthias Meulien <orontee <at> gmail.com>
Cc: 54030 <at> debbugs.gnu.org
Subject: Re: bug#54030: 29.0.50; [PATCH] Extend bookmark menu with column
 displaying handler type
Date: Thu, 17 Feb 2022 12:57:53 +0100

Matthias Meulien <orontee <at> gmail.com> writes:

> I suggest to remove that prefix but extend the bookmark menu with a new
> column "Type" displaying the type of bookmark handler.  As a result
> sorting bookmarks by their name don't gather bookmarks handled by VC
> anymore.

Looks good to me, so I've pushed it to Emacs 29.  (But I made the type
column shorter since the types probably won't be very long.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 54030 <at> debbugs.gnu.org (full text, mbox):

From: Matthias Meulien <orontee <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54030 <at> debbugs.gnu.org
Subject: Re: bug#54030: 29.0.50; [PATCH] Extend bookmark menu with column
 displaying handler type
Date: Thu, 17 Feb 2022 13:50:49 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Looks good to me, so I've pushed it to Emacs 29.  (But I made the type
> column shorter since the types probably won't be very long.)

You're right, the column was too wide.

Thank you!
-- 
Matthias

Message #16 received at 54030 <at> debbugs.gnu.org (full text, mbox):

From: Matthias Meulien <orontee <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54030 <at> debbugs.gnu.org
Subject: Re: bug#54030: 29.0.50; [PATCH] Extend bookmark menu with column
 displaying handler type
Date: Sun, 20 Feb 2022 11:01:31 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Looks good to me, so I've pushed it to Emacs 29.  (But I made the type
> column shorter since the types probably won't be very long.)

Thank you, Lars.

Unfortunately, I've forgotten two bookmark handlers:
One for Gnus summary buffers and one for man pages. Could you add the
missing two lines?

(I didn't try to support xwidgets bookmarks since I never compiled with
this option and I've no knowledge of how to test that feature.)

diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index 8fb07d5905..1be5a48068 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -13278,6 +13278,8 @@ gnus-summary-bookmark-jump
        (buffer . ,(current-buffer))
        . ,(bookmark-get-bookmark-record bookmark)))))
 
+(put 'gnus-summary-bookmark-jump 'bookmark-handler-type "Gnus")
+
 (gnus-summary-make-all-marking-commands)
 
 (provide 'gnus-sum)
diff --git a/lisp/man.el b/lisp/man.el
index a53a696c31..951e0ef9ad 100644
--- a/lisp/man.el
+++ b/lisp/man.el
@@ -1976,6 +1976,8 @@ Man-bookmark-jump
     (bookmark-default-handler
      `("" (buffer . ,buf) . ,(bookmark-get-bookmark-record bookmark)))))
 
+(put 'Man-bookmark-jump 'bookmark-handler-type "Man")
+
 ;;; Mouse support
 (defun Man-at-mouse (e)
   "Open man manual at point."
-- 
Matthias

Message #19 received at 54030 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Matthias Meulien <orontee <at> gmail.com>
Cc: 54030 <at> debbugs.gnu.org
Subject: Re: bug#54030: 29.0.50; [PATCH] Extend bookmark menu with column
 displaying handler type
Date: Sun, 20 Feb 2022 13:23:19 +0100

Matthias Meulien <orontee <at> gmail.com> writes:

> Unfortunately, I've forgotten two bookmark handlers:
> One for Gnus summary buffers and one for man pages. Could you add the
> missing two lines?

Pushed to Emacs 29 now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.