GNU bug report logs - #54028
Window is not a valid window

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> linkov.net>

Date: Wed, 16 Feb 2022 18:54:01 UTC

Severity: normal

Fixed in version 28.1

Done: martin rudalics <rudalics <at> gmx.at>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>, 54028 <at> debbugs.gnu.org
Cc: "eliz <at> gnu.org" <eliz <at> gnu.org>
Subject: bug#54028: Window is not a valid window
Date: Mon, 21 Feb 2022 10:07:59 +0100

Eli, is the below OK to install on the release branch?  It's a trivial
safety check that would fix this bug.

Thanks, martin


--- a/lisp/window.el
+++ b/lisp/window.el
@@ -6394,7 +6394,8 @@ window-state-put
 	(window--state-put-2 ignore pixelwise))
       (while window-state-put-stale-windows
 	(let ((window (pop window-state-put-stale-windows)))
-	  (when (eq (window-deletable-p window) t)
+	  (when (and (window-valid-p window)
+                     (eq (window-deletable-p window) t))
 	    (delete-window window))))
       (window--check frame))))
This bug report was last modified 3 years and 86 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.