GNU bug report logs - #54021
[PATCH] Add rhino javascript package

Previous Next

Package: guix-patches;

Reported by: Frank Pursel <frank.pursel <at> gmail.com>

Date: Wed, 16 Feb 2022 02:00:02 UTC

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 54021 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Frank Pursel <frank.pursel <at> gmail.com>, 54021 <at> debbugs.gnu.org
Subject: Re: [bug#54021] [PATCH] Add rhino javascript package
Date: Wed, 16 Feb 2022 18:00:20 +0100

[Message part 1 (text/plain, inline)]
Frank Pursel schreef op di 15-02-2022 om 17:58 [-0800]:
> +                        (if tests?
> +                            (setenv "ANT_OPTS" "-Doffline=true")
> +                            (invoke "ant" "junit")) #t))

This does 'setenv' when tests?, and runs "ant junit" when (not tests?),
which doesn't seem useful.

Did you mean

  (when tests?
    (setenv ...)
    (invoke ...))

instead?  Also, you can drop the trailing #t, while they used to be
necessary, they don't have a meaning anymore and are gradually removed
from existing packages.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 3 years and 78 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.