Subject: bug#54007: closed (Re: bug#54007: Misleading comment in grep.c, patch included)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 16 Feb 2022 01:02:02 +0000

Your bug report

#54007: Misleading comment in grep.c, patch included

which was filed against the grep package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
54007: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54007
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#54007: Misleading comment in grep.c, patch included
From: Paul Eggert <[email-masked]>
To: Ulrich Eckhardt <[email-masked]>
Cc: [email-masked]
Date: Tue, 15 Feb 2022 17:01:07 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Thanks, installed. (This is also so small that we don't need copyright 
paperwork for it.)

Subject: Misleading comment in grep.c, patch included
From: Ulrich Eckhardt <[email-masked]>
To: [email-masked]
Date: Tue, 15 Feb 2022 08:36:01 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

this just removes a misleading comment. The origin and rationale are
included in the patch.

Cheers!

Uli
>From dd690f14bc62d90e0ce038d66ad012556a0dcc7e Mon Sep 17 00:00:00 2001
From: Ulrich Eckhardt <[email-masked]>
Date: Mon, 14 Feb 2022 22:30:41 +0100
Subject: [PATCH] grep: Remove comment.

The comment was introduced in 500f07fee50ab16a70fe2946b85318020c7f4017 and
relates to absent cleanup code at the end of main(), not the code following
it. It relates to fallible flushing of stdout and related error handling,
but even then it doesn't explain much.
---
 src/grep.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/grep.c b/src/grep.c
index 6ff852a..9c933e4 100644
--- a/src/grep.c
+++ b/src/grep.c
@@ -3008,6 +3008,5 @@ main (int argc, char **argv)
     status &= grep_command_line_arg (*files++);
   while (*files != NULL);
 
-  /* We register via atexit to test stdout.  */
   return errseen ? EXIT_TROUBLE : status;
 }
-- 
2.32.0