Subject: bug#54006: Duplicate test

From: Ulrich Eckhardt <[email-masked]>
Date: Tue, 15 Feb 2022 00:06:50 +0100

Greetings,

there's a duplicate test in tests/empty, see attached patch.

I'm working on a few other improvements, so please provide feedback if
there's anything I should do differently in the future.

Cheers!

Uli
>From a33fdfb0318bb4dd4e6c7bb09453c801447fc403 Mon Sep 17 00:00:00 2001
From: Ulrich Eckhardt <[email-masked]>
Date: Mon, 14 Feb 2022 19:58:45 +0100
Subject: [PATCH] tests: Remove redundant test.

Test #4 is identical to test #1.
---
 tests/empty | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/tests/empty b/tests/empty
index 8e070e7..44b691d 100755
--- a/tests/empty
+++ b/tests/empty
@@ -39,17 +39,10 @@ for locale in C en_US.UTF-8; do
           failures=1
         fi
 
-        # should return 0 found a match
-        echo "" | LC_ALL=$locale timeout 10s grep $options -e ''
-        if test $? -ne 0 ; then
-          echo "Status: Wrong status code, test \#4 failed ($options $locale)"
-          failures=1
-        fi
-
         # should return 0 found a match
         echo abcd | LC_ALL=$locale timeout 10s grep $options -e ''
         if test $? -ne 0 ; then
-          echo "Status: Wrong status code, test \#5 failed ($options $locale)"
+          echo "Status: Wrong status code, test \#4 failed ($options $locale)"
           failures=1
         fi
     done
-- 
2.32.0