From unknown Thu Aug 21 14:54:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54006: Duplicate test Resent-From: Ulrich Eckhardt Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Tue, 15 Feb 2022 04:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54006 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: 54006@debbugs.gnu.org X-Debbugs-Original-To: bug-grep@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164490010312454 (code B ref -1); Tue, 15 Feb 2022 04:42:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Feb 2022 04:41:43 +0000 Received: from localhost ([127.0.0.1]:43234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJpeo-0003Eo-H4 for submit@debbugs.gnu.org; Mon, 14 Feb 2022 23:41:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:39888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJkQr-00013m-Gi for submit@debbugs.gnu.org; Mon, 14 Feb 2022 18:07:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJkQr-00075r-CE for bug-grep@gnu.org; Mon, 14 Feb 2022 18:06:57 -0500 Received: from ms-10.1blu.de ([178.254.4.101]:55250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJkQo-0005r4-Dg for bug-grep@gnu.org; Mon, 14 Feb 2022 18:06:57 -0500 Received: from [77.8.104.172] (helo=serenity) by ms-10.1blu.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJkQl-0007ip-6b for bug-grep@gnu.org; Tue, 15 Feb 2022 00:06:51 +0100 Date: Tue, 15 Feb 2022 00:06:50 +0100 From: Ulrich Eckhardt Message-ID: <20220215000650.04764d82@serenity> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_//Z/t_NrTk_igYVUv8.6pwu5" X-Con-Id: 144198 X-Con-U: 0-ulricheckhardt X-Originating-IP: 77.8.104.172 Received-SPF: none client-ip=178.254.4.101; envelope-from=ulrich.eckhardt@base-42.de; helo=ms-10.1blu.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Mailman-Approved-At: Mon, 14 Feb 2022 23:41:42 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --MP_//Z/t_NrTk_igYVUv8.6pwu5 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Greetings, there's a duplicate test in tests/empty, see attached patch. I'm working on a few other improvements, so please provide feedback if there's anything I should do differently in the future. Cheers! Uli --MP_//Z/t_NrTk_igYVUv8.6pwu5 Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=gnu-grep-duplicate-test.patch >From a33fdfb0318bb4dd4e6c7bb09453c801447fc403 Mon Sep 17 00:00:00 2001 From: Ulrich Eckhardt Date: Mon, 14 Feb 2022 19:58:45 +0100 Subject: [PATCH] tests: Remove redundant test. Test #4 is identical to test #1. --- tests/empty | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/tests/empty b/tests/empty index 8e070e7..44b691d 100755 --- a/tests/empty +++ b/tests/empty @@ -39,17 +39,10 @@ for locale in C en_US.UTF-8; do failures=1 fi - # should return 0 found a match - echo "" | LC_ALL=$locale timeout 10s grep $options -e '' - if test $? -ne 0 ; then - echo "Status: Wrong status code, test \#4 failed ($options $locale)" - failures=1 - fi - # should return 0 found a match echo abcd | LC_ALL=$locale timeout 10s grep $options -e '' if test $? -ne 0 ; then - echo "Status: Wrong status code, test \#5 failed ($options $locale)" + echo "Status: Wrong status code, test \#4 failed ($options $locale)" failures=1 fi done -- 2.32.0 --MP_//Z/t_NrTk_igYVUv8.6pwu5-- From unknown Thu Aug 21 14:54:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ulrich Eckhardt Subject: bug#54006: closed (Re: bug#54006: Duplicate test) Message-ID: References: <20220215000650.04764d82@serenity> X-Gnu-PR-Message: they-closed 54006 X-Gnu-PR-Package: grep Reply-To: 54006@debbugs.gnu.org Date: Tue, 15 Feb 2022 17:43:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1644946981-29358-1" This is a multi-part message in MIME format... ------------=_1644946981-29358-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #54006: Duplicate test which was filed against the grep package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 54006@debbugs.gnu.org. --=20 54006: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D54006 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1644946981-29358-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 54006-done) by debbugs.gnu.org; 15 Feb 2022 17:42:17 +0000 Received: from localhost ([127.0.0.1]:46362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nK1qD-0007cS-1W for submit@debbugs.gnu.org; Tue, 15 Feb 2022 12:42:17 -0500 Received: from mail-yb1-f180.google.com ([209.85.219.180]:43965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nK1qB-0007cF-C3 for 54006-done@debbugs.gnu.org; Tue, 15 Feb 2022 12:42:15 -0500 Received: by mail-yb1-f180.google.com with SMTP id v63so31234102ybv.10 for <54006-done@debbugs.gnu.org>; Tue, 15 Feb 2022 09:42:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o5LQMfeOVLExZAOCUqryW7JPJO/c9EU/vV2YVCSd2FM=; b=W18swNBpfZ+hfBT3L3cvHNev9nrafsbkdOz7lCK6OqYmcoTwdbIqM7jXsywf8fAQS+ wFAQqBxI/3k8gPUBh3UOkjExTxmBYuIKOBnPqABAKc5lEt/7WZm/30gN30Qz/9X8T3sL NOQd5Zq0KqlW/xRcKuevX1qd/jSdY8EuZ3I0Q3v/iJHI47iFklA4nP7rxMlCucLM+6km 00W/g3a54URMrJERjbysYztT8pUp0exFQyuB6JQB0e/mWd71pXoetlAmV9iBCgtcKO2X GHPonqz+2gz35fFi8dIdR5q1iCPekQkNBqvEDjdKiLWuJS8Z/OPjWL7N81DBc7dRobBK a+BA== X-Gm-Message-State: AOAM533ETo5l6J15ulxPZ1dFZGqlyg3xf5avxOVq5cs7P54qcyBa/QZL JHz3YDAoYwQHzC8e4rJQygRm6+B1hUtUAwJQ+ZXaZMf0 X-Google-Smtp-Source: ABdhPJwsx+pWadE7dAQknGHUJsfb74jVCTZBEdYGBfnKk+l7wklziNIHN7IV8Xm8fvrFBiqcqBpoG151MsPoxrDvWiA= X-Received: by 2002:a25:9945:: with SMTP id n5mr15006ybo.630.1644946929172; Tue, 15 Feb 2022 09:42:09 -0800 (PST) MIME-Version: 1.0 References: <20220215000650.04764d82@serenity> In-Reply-To: <20220215000650.04764d82@serenity> From: Jim Meyering Date: Tue, 15 Feb 2022 09:41:57 -0800 Message-ID: Subject: Re: bug#54006: Duplicate test To: Ulrich Eckhardt Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 54006-done Cc: 54006-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Mon, Feb 14, 2022 at 8:42 PM Ulrich Eckhardt wrote: > there's a duplicate test in tests/empty, see attached patch. > > I'm working on a few other improvements, so please provide feedback if > there's anything I should do differently in the future. Thank you. I've applied that, edited the commit log to make it conform, and pushed. See the file HACKING for policy on how to write Emacs-style ChangeLog entries for grep commit logs. E.g., title is not a sentence and usually has no punctuation. And each affected file name is called out. Sometimes function names are also listed, e.g., * dir/file_name (func1, func2): Description. ------------=_1644946981-29358-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Feb 2022 04:41:43 +0000 Received: from localhost ([127.0.0.1]:43234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJpeo-0003Eo-H4 for submit@debbugs.gnu.org; Mon, 14 Feb 2022 23:41:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:39888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJkQr-00013m-Gi for submit@debbugs.gnu.org; Mon, 14 Feb 2022 18:07:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJkQr-00075r-CE for bug-grep@gnu.org; Mon, 14 Feb 2022 18:06:57 -0500 Received: from ms-10.1blu.de ([178.254.4.101]:55250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJkQo-0005r4-Dg for bug-grep@gnu.org; Mon, 14 Feb 2022 18:06:57 -0500 Received: from [77.8.104.172] (helo=serenity) by ms-10.1blu.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJkQl-0007ip-6b for bug-grep@gnu.org; Tue, 15 Feb 2022 00:06:51 +0100 Date: Tue, 15 Feb 2022 00:06:50 +0100 From: Ulrich Eckhardt To: bug-grep@gnu.org Subject: Duplicate test Message-ID: <20220215000650.04764d82@serenity> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_//Z/t_NrTk_igYVUv8.6pwu5" X-Con-Id: 144198 X-Con-U: 0-ulricheckhardt X-Originating-IP: 77.8.104.172 Received-SPF: none client-ip=178.254.4.101; envelope-from=ulrich.eckhardt@base-42.de; helo=ms-10.1blu.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 14 Feb 2022 23:41:42 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --MP_//Z/t_NrTk_igYVUv8.6pwu5 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Greetings, there's a duplicate test in tests/empty, see attached patch. I'm working on a few other improvements, so please provide feedback if there's anything I should do differently in the future. Cheers! Uli --MP_//Z/t_NrTk_igYVUv8.6pwu5 Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=gnu-grep-duplicate-test.patch >From a33fdfb0318bb4dd4e6c7bb09453c801447fc403 Mon Sep 17 00:00:00 2001 From: Ulrich Eckhardt Date: Mon, 14 Feb 2022 19:58:45 +0100 Subject: [PATCH] tests: Remove redundant test. Test #4 is identical to test #1. --- tests/empty | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/tests/empty b/tests/empty index 8e070e7..44b691d 100755 --- a/tests/empty +++ b/tests/empty @@ -39,17 +39,10 @@ for locale in C en_US.UTF-8; do failures=1 fi - # should return 0 found a match - echo "" | LC_ALL=$locale timeout 10s grep $options -e '' - if test $? -ne 0 ; then - echo "Status: Wrong status code, test \#4 failed ($options $locale)" - failures=1 - fi - # should return 0 found a match echo abcd | LC_ALL=$locale timeout 10s grep $options -e '' if test $? -ne 0 ; then - echo "Status: Wrong status code, test \#5 failed ($options $locale)" + echo "Status: Wrong status code, test \#4 failed ($options $locale)" failures=1 fi done -- 2.32.0 --MP_//Z/t_NrTk_igYVUv8.6pwu5-- ------------=_1644946981-29358-1--