GNU bug report logs - #54004
29.0.50; [PATCH] Gnus outdated tool bar variables

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54004 in the body.
You can then email your comments to 54004 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: emacs-bugs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50; [PATCH] Gnus outdated tool bar variables
Date: Mon, 14 Feb 2022 22:50:59 +0100

[Message part 1 (text/plain, inline)]

Hi all,

I think some tool bar variables from Gnus are gone, namely
gnus-use-toolbar, gnus-toolbar-thickness and gnus-summary-mail-toolbar.
gnus-{group,summary}-toolbar are now gnus-{group,summary}-tool-bar.

Please find attached a small patch fixing this in Gnus manual.

Best, Arash

[gnus.texi.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables
Date: Mon, 14 Feb 2022 14:19:35 -0800

Arash Esbati <arash <at> gnu.org> writes:

> Hi all,
>
> I think some tool bar variables from Gnus are gone, namely
> gnus-use-toolbar, gnus-toolbar-thickness and gnus-summary-mail-toolbar.
> gnus-{group,summary}-toolbar are now gnus-{group,summary}-tool-bar.

I wonder if the gnome and retro tool bars are even in effect any more?
It seems to be "retro" by default, but if I turn tool-bar-mode on and
switch `gnus-group-tool-bar' to gnome and back, nothing happens.

Message #11 received at 54004 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 54004 <at> debbugs.gnu.org
Subject: Re: bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables
Date: Mon, 14 Feb 2022 23:22:29 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> I wonder if the gnome and retro tool bars are even in effect any more?
> It seems to be "retro" by default, but if I turn tool-bar-mode on and
> switch `gnus-group-tool-bar' to gnome and back, nothing happens.

I think there's a bug report about that somewhere...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables
Date: Mon, 14 Feb 2022 14:36:26 -0800

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> I wonder if the gnome and retro tool bars are even in effect any more?
>> It seems to be "retro" by default, but if I turn tool-bar-mode on and
>> switch `gnus-group-tool-bar' to gnome and back, nothing happens.
>
> I think there's a bug report about that somewhere...

I can't find anything with a quick bug search...

Message #17 received at 54004 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 54004 <at> debbugs.gnu.org
Subject: Re: bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables
Date: Mon, 14 Feb 2022 23:39:43 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> I can't find anything with a quick bug search...

Me neither.  But I remember vaguely there was some discussion about
removing the...  retro tool bar stuff, I guess, since switching doesn't
work.  Or it only works if you switch before starting Gnus.  Or
something like that.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #20 received at 54004 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54004 <at> debbugs.gnu.org
Subject: Re: bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables
Date: Mon, 14 Feb 2022 14:44:47 -0800

On 02/14/22 23:39 PM, Lars Ingebrigtsen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> I can't find anything with a quick bug search...
>
> Me neither.  But I remember vaguely there was some discussion about
> removing the...  retro tool bar stuff, I guess, since switching doesn't
> work.  Or it only works if you switch before starting Gnus.  Or
> something like that.

Oh indeed, you have to restart Gnus. My that's unattractive :)

Anyway, I'll put this patch in and close the bug (thank you Arash!). I'm
not sure the tool-bar switching issue is worth attacking at the moment...

Message #25 received at 54004-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: 54004-done <at> debbugs.gnu.org
Subject: Re: bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables
Date: Mon, 14 Feb 2022 15:23:44 -0800

On 02/14/22 14:44 PM, Eric Abrahamsen wrote:
> On 02/14/22 23:39 PM, Lars Ingebrigtsen wrote:
>> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>>
>>> I can't find anything with a quick bug search...
>>
>> Me neither.  But I remember vaguely there was some discussion about
>> removing the...  retro tool bar stuff, I guess, since switching doesn't
>> work.  Or it only works if you switch before starting Gnus.  Or
>> something like that.
>
> Oh indeed, you have to restart Gnus. My that's unattractive :)
>
> Anyway, I'll put this patch in and close the bug (thank you Arash!). I'm
> not sure the tool-bar switching issue is worth attacking at the moment...

Message #28 received at 54004 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 54004 <at> debbugs.gnu.org
Subject: Re: bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables
Date: Tue, 15 Feb 2022 10:06:18 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Anyway, I'll put this patch in and close the bug (thank you Arash!).

Thanks for your quick response.  I pushed a small change fixing the
entries for vindex which I missed to do in my initial patch.

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.