GNU bug report logs - #54001
29.0.50; abbreviate-file-name has side-effects

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#54001: closed (29.0.50; abbreviate-file-name has side-effects)
Date: Tue, 15 Feb 2022 13:12:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 15 Feb 2022 08:11:35 -0500
with message-id <jwvee44ff7c.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects
has caused the debbugs.gnu.org bug report #54001,
regarding 29.0.50; abbreviate-file-name has side-effects
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
54001: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54001
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; abbreviate-file-name has side-effects
Date: Mon, 14 Feb 2022 12:19:57 -0500

Package: Emacs
Version: 29.0.50


Since:

    commit bf505a63f98ed61934a8fb81ec65c96859606b6e
    Author: Jim Porter <jporterbugs <at> gmail.com>
    Date:   Mon Nov 15 13:33:07 2021 +0100

    Support abbreviating home directory of Tramp filenames

`abbreviate-file-name` has significantly changed in its behavior:
- it's slower (because it goes through file-name-handlers)
- it can have very visible side effects like prompting the user for a password.

I haven't measured the slowdown, so I'll assume it's acceptable, but
asking for a password (or contacting a remote host) is not.

I suggest we take a step back and think of how to get that feature
without having to contact any remote host during `abbreviate-file-name`.
Maybe we can do that by making Tramp opportunistically add entries to
`directory-abbrev-alist` when it performs expansion?


        Stefan

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, 54001-done <at> debbugs.gnu.org
Subject: Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects
Date: Tue, 15 Feb 2022 08:11:35 -0500

> I've only lightly tested this patch, but I think it should resolve the
> issue. It only sets the "home-directory" connection property when
> a connection is already established. Otherwise, it just uses the cached
> value (if any).

Thanks, pushed to master.  And closing.
Daniel, feel to ping us back if the fix isn't good enough.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.