From unknown Mon Aug 18 04:38:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#54001 <54001@debbugs.gnu.org> To: bug#54001 <54001@debbugs.gnu.org> Subject: Status: 29.0.50; abbreviate-file-name has side-effects Reply-To: bug#54001 <54001@debbugs.gnu.org> Date: Mon, 18 Aug 2025 11:38:04 +0000 retitle 54001 29.0.50; abbreviate-file-name has side-effects reassign 54001 emacs submitter 54001 Stefan Monnier severity 54001 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 12:21:42 2022 Received: (at submit) by debbugs.gnu.org; 14 Feb 2022 17:21:42 +0000 Received: from localhost ([127.0.0.1]:42468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJf2k-0000j0-E9 for submit@debbugs.gnu.org; Mon, 14 Feb 2022 12:21:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:32996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJf2g-0000io-EP for submit@debbugs.gnu.org; Mon, 14 Feb 2022 12:21:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJf2g-0003YF-6f for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2022 12:21:38 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJf2Z-0008BP-IK for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2022 12:21:37 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B8AA480300 for ; Mon, 14 Feb 2022 12:21:29 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 378BC802FF for ; Mon, 14 Feb 2022 12:21:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1644859284; bh=paH3Ugl4PqKau6GHRSNusKGfQN9qin/afnJBfN07Y4o=; h=From:To:Subject:Date:From; b=FzXI0tWlZsspEEsp0qc3eo+weLqbQygnCnpd7aON0CGjbPHSPIJ+mOjbfD4IoaMvL u3YP5QAG9/+AOXs4ZcjBewJ5U4w6PMAnJ0RHLq/s6mJddIL+2hOq/CfI5QDrcfFRO+ bHv8jDfqV4yIrWhLtwgdLGpR7OHx2cajN+6nDT6m5KpLqRHXPReSF9H+q/vpu7Kihg Axnt1GkY0+S8Lf6s8fsiCFDGeGjVEic9iB2PlI3g3PVGH+6sfH6js2Dznoq0dl057u CpPwRbkYXX+0XpsCopz5d3DRqvmExcRIv9tFNPwVxFaFrIWguOnQkGKB8if5X9lWf3 Gg5GVaBKgrm/w== Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0D93A1203F3 for ; Mon, 14 Feb 2022 12:21:24 -0500 (EST) From: Stefan Monnier To: bug-gnu-emacs@gnu.org Subject: 29.0.50; abbreviate-file-name has side-effects Date: Mon, 14 Feb 2022 12:19:57 -0500 Message-ID: X-Debbugs-Cc: Daniel Mendler , monnier@iro.umontreal.ca User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Package: Emacs Version: 29.0.50 Since: commit bf505a63f98ed61934a8fb81ec65c96859606b6e Author: Jim Porter Date: Mon Nov 15 13:33:07 2021 +0100 Support abbreviating home directory of Tramp filenames `abbreviate-file-name` has significantly changed in its behavior: - it's slower (because it goes through file-name-handlers) - it can have very visible side effects like prompting the user for a password. I haven't measured the slowdown, so I'll assume it's acceptable, but asking for a password (or contacting a remote host) is not. I suggest we take a step back and think of how to get that feature without having to contact any remote host during `abbreviate-file-name`. Maybe we can do that by making Tramp opportunistically add entries to `directory-abbrev-alist` when it performs expansion? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 12:52:40 2022 Received: (at 54001) by debbugs.gnu.org; 14 Feb 2022 17:52:40 +0000 Received: from localhost ([127.0.0.1]:42493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJfWi-0001Wu-AB for submit@debbugs.gnu.org; Mon, 14 Feb 2022 12:52:40 -0500 Received: from mail-pl1-f178.google.com ([209.85.214.178]:37846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJfWf-0001Wg-Ft for 54001@debbugs.gnu.org; Mon, 14 Feb 2022 12:52:38 -0500 Received: by mail-pl1-f178.google.com with SMTP id x4so11135470plb.4 for <54001@debbugs.gnu.org>; Mon, 14 Feb 2022 09:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=PcegR0gAKg2ptFMf4SM7UqRMH0/X0OVw6zNVnp7GQI4=; b=A1fg7Mj3KAfL4TiXYzQa+N8wdmXNnABWZWLSoIUEQpvtBbtJ1slCVMmP4TVEMznQul n1nI7SGwdwRaK1hlEQLTXpYsaFDbRtwZkRleJoIJH17m7XZN3jlGhhTrVLIfA0B/Tok9 Bl10eGHBT4YZS0VirAyr/aJc+mYzP77O0mEctr4Ue97y1E0Zykd3nVdBjg8/GUO/gJ+N vvGQlsi9+TDf8FAxZb5TXCQpt0GRZ0KbTwDAr4oeRStrBVyuUl/F/kgtsT1tO1FaFiuq 2Ay9NiBf8d0+KBeJTD0jXw4R3X/vPgnzEv8F3VHsg0iuYgeTK+I5LWgnfQfyMa7ceLO3 BkCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PcegR0gAKg2ptFMf4SM7UqRMH0/X0OVw6zNVnp7GQI4=; b=VUtn/hi8Ou/E8rbCFsgVysMZx9Q2ffEn0S+kHCbbeFMkGGjHEpEtzfH4LhCP3fjAUh ZfeiO5Uy9qxnHvFWPj2NUpfBvg7MAXQggacN7VO1UYu7Kf2+A9179QFnkBhiqoxcQR/3 QyfbORVP3plmSWGS8LeK3PXKDmyRZc8v6wjaKlSc5jnrQcvkUE4FjS9QAPQq43XoUc9q tYZb6Skyj/k8+UgYts1xWQxwWFUeP0Hai32yHgBu6g2lODsUfGyaRnRgvAgZ2cDltjpC Jr4yllLiT2q3A8447XEalgTLacq6tyPKd6yZdooQIZOyC6SIW3vF+25+1z5Nf/DuwSpl 2fZQ== X-Gm-Message-State: AOAM530AYpssTYbJuMTCYojWMxTfSYGVpENtlBeAgPVLpjopmnA1XAPX B7Zc7BZmjIo0LXc9DghahRM= X-Google-Smtp-Source: ABdhPJz3yLymwmi3cCvYBPBFOAGB9t17eEADVGoeMGMhSC9LiJ9L9s5SrurQgqgFjWFMuZfjrWMD7w== X-Received: by 2002:a17:90a:ae11:: with SMTP id t17mr798475pjq.53.1644861151480; Mon, 14 Feb 2022 09:52:31 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d16sm30430461pfj.1.2022.02.14.09.52.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Feb 2022 09:52:31 -0800 (PST) Subject: Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects To: Stefan Monnier , 54001@debbugs.gnu.org References: From: Jim Porter Message-ID: <96603590-acc9-65d1-4086-7e2f114f9441@gmail.com> Date: Mon, 14 Feb 2022 09:52:32 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54001 Cc: Daniel Mendler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/14/2022 9:19 AM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Package: Emacs > Version: 29.0.50 > > > Since: > > commit bf505a63f98ed61934a8fb81ec65c96859606b6e > Author: Jim Porter > Date: Mon Nov 15 13:33:07 2021 +0100 > > Support abbreviating home directory of Tramp filenames > > `abbreviate-file-name` has significantly changed in its behavior: > - it's slower (because it goes through file-name-handlers) > - it can have very visible side effects like prompting the user for a password. > > I haven't measured the slowdown, so I'll assume it's acceptable, but > asking for a password (or contacting a remote host) is not. Sorry about that. I did what I could to minimize the slowdown (including some more general optimizations to make Tramp faster). There are some benchmarks in the original bug here (these are with 1000 iterations; you'll want to compare the first section with the last): . > I suggest we take a step back and think of how to get that feature > without having to contact any remote host during `abbreviate-file-name`. > Maybe we can do that by making Tramp opportunistically add entries to > `directory-abbrev-alist` when it performs expansion? I think Michael Albinus suggested doing that in the original bug, although I was concerned about modifying defcustoms invisibly like that. Is that ok to do? Another option might be to store the abbreviations for a given file-name-handler somewhere internally and consult that when calling that file-name-handler's implementation of `abbreviate-file-name'. Maybe this patch should be backed out for now; it shouldn't be interrupting the user. (I thought I'd tested that, but maybe it was on an earlier revision of the patch.) I'll probably have time to look into a new solution in a few weeks, but anyone else who's interested should feel free to fix it in the meantime. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 14:48:55 2022 Received: (at 54001) by debbugs.gnu.org; 14 Feb 2022 19:48:55 +0000 Received: from localhost ([127.0.0.1]:42608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJhLD-0004TU-Ik for submit@debbugs.gnu.org; Mon, 14 Feb 2022 14:48:55 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJhL8-0004TB-M1 for 54001@debbugs.gnu.org; Mon, 14 Feb 2022 14:48:54 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6C0254422F3; Mon, 14 Feb 2022 14:48:44 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 24D894422EB; Mon, 14 Feb 2022 14:48:43 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1644868123; bh=YCqtwBekVyuSbAa/250XtyVNxc72D23H2jsjLauHIVA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=hdPmCVWUsHfuVWeN2xpL1S471pSkBPjrq/ehxoShEHvlR64BXol/O7cNU8Q7lUS1T /s/CoW8KH7IfJJwRcN1DSRf3/hF3u4AU2IEdeLxlBJTrBI/HR7B5AxCM5OuEJor8Vt I/Lu8+/JWHVX46zITy9yBsT/QD20JE5XVVyNI3AzLhP1tbAryPbTkEMCxkUgK6BVfl w99hlN9W0l85iQr088VgAL6oK3+3JEhEMKs/gO8SBQ5b48JigwjyYPpwfm6vUu2WpX Mgndy0i0cwrRqeYeiyCIyteKrXIrVwlolkfYqFjg8+w98b7PVqnDalpyZNCZKEBoVt NiN1gPN/cYe1Q== Received: from ceviche (modemcable085.122-83-70.mc.videotron.ca [70.83.122.85]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 055F1120491; Mon, 14 Feb 2022 14:48:42 -0500 (EST) From: Stefan Monnier To: Jim Porter Subject: Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects Message-ID: References: <96603590-acc9-65d1-4086-7e2f114f9441@gmail.com> Date: Mon, 14 Feb 2022 14:48:41 -0500 In-Reply-To: <96603590-acc9-65d1-4086-7e2f114f9441@gmail.com> (Jim Porter's message of "Mon, 14 Feb 2022 09:52:32 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54001 Cc: Daniel Mendler , 54001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I suggest we take a step back and think of how to get that feature >> without having to contact any remote host during `abbreviate-file-name`. >> Maybe we can do that by making Tramp opportunistically add entries to >> `directory-abbrev-alist` when it performs expansion? > > I think Michael Albinus suggested doing that in the original bug, although > I was concerned about modifying defcustoms invisibly like that. Is that ok > to do? No it's not, but we can add a non-defcustom'd variable holding additional entries to circumvent this problem. > Another option might be to store the abbreviations for a given > file-name-handler somewhere internally and consult that when calling that > file-name-handler's implementation of `abbreviate-file-name'. That would work as well. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 15:52:32 2022 Received: (at 54001) by debbugs.gnu.org; 14 Feb 2022 20:52:32 +0000 Received: from localhost ([127.0.0.1]:42784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJiKm-00068U-HT for submit@debbugs.gnu.org; Mon, 14 Feb 2022 15:52:32 -0500 Received: from mail-pj1-f48.google.com ([209.85.216.48]:38481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJiKj-00068E-NZ for 54001@debbugs.gnu.org; Mon, 14 Feb 2022 15:52:31 -0500 Received: by mail-pj1-f48.google.com with SMTP id h14-20020a17090a130e00b001b88991a305so418655pja.3 for <54001@debbugs.gnu.org>; Mon, 14 Feb 2022 12:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=WgOi7ESJdfqDHR0qNnyq5TQ0mouw6t8L9QKJd3IKl74=; b=oMK19GnJrUpk5PpSWSRzl5EBcXH++vQ0F/AjNA4RCkkoY+2nYdhRu9SLm4aHBLmf6x QTzYr5llfnQz8cAR93halB6WPLnf8sLVPhtZznYdLbg6hacTAFMQeq37wwtAG5yWQCA1 R1/Q8cAMXfrRf1WlhuXYI2rQan2bkYAjN/2pxfztkWpwVG2l7Fg/roJci/fkOok6pJU3 Hx5PoPS7knRehvJR4jvNsVbRaGnOeXwiAT7cqQIu2JFnh8a+E/9a1BOfclKWMrDoLNN/ dSG1+rg+vvpPXHrGbv/qrU399G3KCKeOOedRsjOe61YNF/It5Jn/5AdiRgstf2TG8rnj cXBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WgOi7ESJdfqDHR0qNnyq5TQ0mouw6t8L9QKJd3IKl74=; b=M/ApMTAwYsloMstdKqs0OsyxY/JDebJYAB6RL4DjsZfXb9uDTsGAmOpbe12d09NEAe c9vCEA+RDvvkOLyPdECldERDllbfBagCiNXwYK2dBQshuQ6bs0C6K33h+xJdXa6ZrGP3 tktqdJLvDopLRvcfTz1gY0I9z6m3mT1HRRlmWphipVF1gGRf5B2DjkJ8uU/FJ/LIAshs euQ9bPX1PEkcwr9rt5zPRm4HZryNoKIzJU0XynZNGH18FfjT58EsE9jytrwtYjC4553X tgwSu3PT44XqwkQicQjvT2O/3Ua2p5TtHRR5rAMKF0PMWQHPTdRcZ48D1xBVdCrhmcZq MaKw== X-Gm-Message-State: AOAM5321tfgbcAP3uAuWP3fa47utCTMs+6tY/c5ikyOvyXvTu5YTNPeP O5IeuiAD/LAEhM1bbSvTURdw5+kQexI= X-Google-Smtp-Source: ABdhPJzYYRyAYPRiWuDndbJV6hdsb6oqiiMzb8KKFYaFQjSXp7AgsHXevI7Z0AZ2e7UEM9l1bUfJAg== X-Received: by 2002:a17:90a:cc14:b0:1b9:f392:56f7 with SMTP id b20-20020a17090acc1400b001b9f39256f7mr621539pju.44.1644871943793; Mon, 14 Feb 2022 12:52:23 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id mn7sm15042689pjb.8.2022.02.14.12.52.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Feb 2022 12:52:23 -0800 (PST) Subject: Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects To: Stefan Monnier References: <96603590-acc9-65d1-4086-7e2f114f9441@gmail.com> From: Jim Porter Message-ID: <506247fd-ed3a-f560-c8b5-1ece88cdfa76@gmail.com> Date: Mon, 14 Feb 2022 12:52:22 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54001 Cc: Daniel Mendler , 54001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/14/2022 11:48 AM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >>> I suggest we take a step back and think of how to get that feature >>> without having to contact any remote host during `abbreviate-file-name`. >>> Maybe we can do that by making Tramp opportunistically add entries to >>> `directory-abbrev-alist` when it performs expansion? [snip] >> Another option might be to store the abbreviations for a given >> file-name-handler somewhere internally and consult that when calling that >> file-name-handler's implementation of `abbreviate-file-name'. > > That would work as well. Looking at my original patch again, this value is already cached as a Tramp connection property named "home-directory". If the code were changed to set that connection property in a more-appropriate place, and `tramp-handle-abbreviate-file-name' simply *reads* that connection property, then I think that should resolve this issue. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 16:00:51 2022 Received: (at 54001) by debbugs.gnu.org; 14 Feb 2022 21:00:51 +0000 Received: from localhost ([127.0.0.1]:42790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJiSp-0006LP-Bq for submit@debbugs.gnu.org; Mon, 14 Feb 2022 16:00:51 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJiSm-0006L9-PY for 54001@debbugs.gnu.org; Mon, 14 Feb 2022 16:00:50 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C76BB100189; Mon, 14 Feb 2022 16:00:42 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2EE04100008; Mon, 14 Feb 2022 16:00:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1644872441; bh=eddxseVP0CVhYShTKptQxEugSydP7JrtzmhXkYPFNo4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ES8UcDBqpc/0QSi6+uXTdu65qRND6lEqNTT9YCM2867TiUK14E1mYjuGyLbNTFXLy V9UsNQcwlXs9IIpvnBz0zqQYPPD1AZa6RF4DKTXFkFvz3LPZ4d17DmHAMb3Gmi7NSn Dxy2xttYbgbxZMLhUpRDM6ZAPC/8uDShu9J76E4diGp0/hFm56xyVuWeSXr0GCnMEp U2nOJvEKb0uyruEm25LMmjfP7Ex9YieLmQwA3qUH6UezLtSHmymoCFFciXmIuZz8Z3 wFQEJPOjQjqF5tr4oZNAkvFXkAhU7ZfRW32dB5EI/4iMFqgThd8aFjrYEb55ozY/za eEOoKkZn1iZhg== Received: from ceviche (modemcable085.122-83-70.mc.videotron.ca [70.83.122.85]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EC1AB12036E; Mon, 14 Feb 2022 16:00:40 -0500 (EST) From: Stefan Monnier To: Jim Porter Subject: Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects Message-ID: References: <96603590-acc9-65d1-4086-7e2f114f9441@gmail.com> <506247fd-ed3a-f560-c8b5-1ece88cdfa76@gmail.com> Date: Mon, 14 Feb 2022 16:00:34 -0500 In-Reply-To: <506247fd-ed3a-f560-c8b5-1ece88cdfa76@gmail.com> (Jim Porter's message of "Mon, 14 Feb 2022 12:52:22 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54001 Cc: Daniel Mendler , 54001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Looking at my original patch again, this value is already cached as a Tramp > connection property named "home-directory". If the code were changed to set > that connection property in a more-appropriate place, and > `tramp-handle-abbreviate-file-name' simply *reads* that connection property, > then I think that should resolve this issue. Sounds like it, Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 16:39:14 2022 Received: (at 54001) by debbugs.gnu.org; 14 Feb 2022 21:39:14 +0000 Received: from localhost ([127.0.0.1]:42819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJj3s-0007Fy-Nm for submit@debbugs.gnu.org; Mon, 14 Feb 2022 16:39:14 -0500 Received: from mail-pl1-f179.google.com ([209.85.214.179]:36754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJj3p-0007FS-Ee for 54001@debbugs.gnu.org; Mon, 14 Feb 2022 16:39:07 -0500 Received: by mail-pl1-f179.google.com with SMTP id u5so368048ple.3 for <54001@debbugs.gnu.org>; Mon, 14 Feb 2022 13:39:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=MbBsLBiAl6pI0PXIJjph6O+CVPXuy+JAtTj6UXEBHBs=; b=ip3VqfLr+gDvO6Tf7zxQqaxbGZ5aMDOA8lgmuF7UoNq9tu9GmM4xt1IaDCPwNsx9Ja CdhqqvW9fuSzpUXZahhrOPB3+4/IaxGJyqYnJ1PhLc5glV/Q/FYIC7aXlwlrFcGk45dh R6/8OYtkzAgllSUQkAZPiLLbxVoKDtyrnh3xMkenpH+wS+9+4xtOY6VcrBT6Y2etXlUo wUuTxB4gwsKnCU4anicQhNHBvwEIflv9pn+35HFytCmgkbTcBVjahq6M6dI9rzv8pvH7 u6erL3YFxCmN2OxKAtG7nxSf8cyTE74tDHfHJCb2KY5j91GvdROCuOsJVj3cyPbmgkOQ kCaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=MbBsLBiAl6pI0PXIJjph6O+CVPXuy+JAtTj6UXEBHBs=; b=sXewATy0DF4UJQvfI0blnQBsMockW6TPOzBGX1D+nVH6Qx6OKsv6So7OXc/Wtp9C8H O2nUEPL0HeqFhGu12lp2bRh7nal3Qw8+szurUwobA6ALneSskFqQorknEVl2mFCmeFFy N8UTqqBYaItiOKECmt6/YxMHTwhGaMEf6ye20x1wp71MBLhwc6EasrYKIlKTSfWrKUxt 5pvqTmp81fhdWQjAcTRi6vUfeQm8UOD1u6JrAWt9mY26i1RwN5o7uQngGJ1x6w1oMgFZ vl0EuivP/DoRAELkpBVpidRrrTBWO3KWxsSH8sG5OXALgJ434D7Cue3xNxeT0O9Hixk3 K/xQ== X-Gm-Message-State: AOAM533owcCgovC+LNIrHMTUqK0L6V+ov6i+WPuhznReFb2up3poyqVB mA85tUf3vuxLoQIYdYPDSWLXUh24Bzs= X-Google-Smtp-Source: ABdhPJyTJdkKQ8/P9flj6VDZ1sXHQFWCRo77XfcKEoH7hM5MpY9VeIepC1NkFSemJkLCoBjJCAlv5Q== X-Received: by 2002:a17:902:d641:: with SMTP id y1mr790545plh.64.1644874739558; Mon, 14 Feb 2022 13:38:59 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id y10sm2889288pjc.0.2022.02.14.13.38.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Feb 2022 13:38:58 -0800 (PST) Subject: Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects To: Stefan Monnier References: <96603590-acc9-65d1-4086-7e2f114f9441@gmail.com> <506247fd-ed3a-f560-c8b5-1ece88cdfa76@gmail.com> From: Jim Porter Message-ID: Date: Mon, 14 Feb 2022 13:38:58 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------EED72BCE072C2BA326A623E3" Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54001 Cc: Daniel Mendler , 54001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------EED72BCE072C2BA326A623E3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2/14/2022 1:00 PM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >> Looking at my original patch again, this value is already cached as a Tramp >> connection property named "home-directory". If the code were changed to set >> that connection property in a more-appropriate place, and >> `tramp-handle-abbreviate-file-name' simply *reads* that connection property, >> then I think that should resolve this issue. > > Sounds like it, I've only lightly tested this patch, but I think it should resolve the issue. It only sets the "home-directory" connection property when a connection is already established. Otherwise, it just uses the cached value (if any). Maybe there's a cleaner way to do this though; opportunistically setting a connection property like this seems like something there might be a special function for in Tramp, but I didn't see one after a bit of looking so this is what I went with. --------------EED72BCE072C2BA326A623E3 Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-attempt-to-connect-to-a-remote-server-during-a.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Don-t-attempt-to-connect-to-a-remote-server-during-a.pa"; filename*1="tch" RnJvbSBmNjZkY2JkYmNkMjZhZDk3NDIzZTM3MDM0NTA4YTMyZjU1MjYzNTk3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMTQgRmViIDIwMjIgMTM6MTY6MDUgLTA4MDAKU3ViamVjdDogW1BB VENIXSBEb24ndCBhdHRlbXB0IHRvIGNvbm5lY3QgdG8gYSByZW1vdGUgc2VydmVyIGR1cmlu ZwogJ2FiYnJldmlhdGUtZmlsZS1uYW1lJwoKKiBsaXNwL25ldC90cmFtcC5lbCAodHJhbXAt aGFuZGxlLWFiYnJldmlhdGUtZmlsZS1uYW1lKTogT25seSB1c2UgdGhlCiJob21lLWRpcmVj dG9yeSIgd2hlbiBhIGNvbm5lY3Rpb24gaGFzIGJlZW4gZXN0YWJsaXNoZWQuCi0tLQogbGlz cC9uZXQvdHJhbXAuZWwgfCAyMCArKysrKysrKysrKysrKy0tLS0tLQogMSBmaWxlIGNoYW5n ZWQsIDE0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlz cC9uZXQvdHJhbXAuZWwgYi9saXNwL25ldC90cmFtcC5lbAppbmRleCAzMjcxMmVmYjNlLi4z YzA2YWQxNjMwIDEwMDY0NAotLS0gYS9saXNwL25ldC90cmFtcC5lbAorKysgYi9saXNwL25l dC90cmFtcC5lbApAQCAtMzM0MywxNiArMzM0MywyNCBAQCB0cmFtcC1oYW5kbGUtYWJicmV2 aWF0ZS1maWxlLW5hbWUKICAgKGxldCogKChjYXNlLWZvbGQtc2VhcmNoIChmaWxlLW5hbWUt Y2FzZS1pbnNlbnNpdGl2ZS1wIGZpbGVuYW1lKSkKIAkgKHZlYyAodHJhbXAtZGlzc2VjdC1m aWxlLW5hbWUgZmlsZW5hbWUpKQogICAgICAgICAgKGhvbWUtZGlyCi0gICAgICAgICAgKHdp dGgtdHJhbXAtY29ubmVjdGlvbi1wcm9wZXJ0eSB2ZWMgImhvbWUtZGlyZWN0b3J5IgotICAg ICAgICAgICAgKHRyYW1wLWNvbXBhdC1mdW5jYWxsCi0JICAgICAnZGlyZWN0b3J5LWFiYnJl di1hcHBseQotCSAgICAgKGV4cGFuZC1maWxlLW5hbWUgKHRyYW1wLW1ha2UtdHJhbXAtZmls ZS1uYW1lIHZlYyAifiIpKSkpKSkKKyAgICAgICAgICAoaWYgKGxldCAoKG5vbi1lc3NlbnRp YWwgdCkpICh0cmFtcC1jb25uZWN0YWJsZS1wIHZlYykpCisgICAgICAgICAgICAgIDs7IElm IGEgY29ubmVjdGlvbiBoYXMgYWxyZWFkeSBiZWVuIGVzdGFibGlzaGVkLCBtYWtlCisgICAg ICAgICAgICAgIDs7IHN1cmUgdGhlICJob21lLWRpcmVjdG9yeSIgY29ubmVjdGlvbiBwcm9w ZXJ0eSBpcworICAgICAgICAgICAgICA7OyBwcm9wZXJseSBzZXQuCisgICAgICAgICAgICAg ICh3aXRoLXRyYW1wLWNvbm5lY3Rpb24tcHJvcGVydHkgdmVjICJob21lLWRpcmVjdG9yeSIK KyAgICAgICAgICAgICAgICAodHJhbXAtY29tcGF0LWZ1bmNhbGwKKwkgICAgICAgICAnZGly ZWN0b3J5LWFiYnJldi1hcHBseQorCSAgICAgICAgIChleHBhbmQtZmlsZS1uYW1lICh0cmFt cC1tYWtlLXRyYW1wLWZpbGUtbmFtZSB2ZWMgIn4iKSkpKQorICAgICAgICAgICAgOzsgT3Ro ZXJ3aXNlLCBqdXN0IHVzZSB0aGUgY2FjaGVkIHZhbHVlLgorICAgICAgICAgICAgKHRyYW1w LWdldC1jb25uZWN0aW9uLXByb3BlcnR5IHZlYyAiaG9tZS1kaXJlY3RvcnkiIG5pbCkpKSkK ICAgICA7OyBJZiBhbnkgZWx0IG9mIGBkaXJlY3RvcnktYWJicmV2LWFsaXN0JyBtYXRjaGVz IHRoaXMgbmFtZSwKICAgICA7OyBhYmJyZXZpYXRlIGFjY29yZGluZ2x5LgogICAgIChzZXRx IGZpbGVuYW1lICh0cmFtcC1jb21wYXQtZnVuY2FsbCAnZGlyZWN0b3J5LWFiYnJldi1hcHBs eSBmaWxlbmFtZSkpCiAgICAgOzsgQWJicmV2aWF0ZSBob21lIGRpcmVjdG9yeS4KLSAgICAo aWYgKHN0cmluZy1tYXRjaAotCSAodHJhbXAtY29tcGF0LWZ1bmNhbGwgJ2RpcmVjdG9yeS1h YmJyZXYtbWFrZS1yZWdleHAgaG9tZS1kaXIpIGZpbGVuYW1lKQorICAgIChpZiAoYW5kIGhv bWUtZGlyCisgICAgICAgICAgICAgKHN0cmluZy1tYXRjaAorCSAgICAgICh0cmFtcC1jb21w YXQtZnVuY2FsbCAnZGlyZWN0b3J5LWFiYnJldi1tYWtlLXJlZ2V4cCBob21lLWRpcikKKyAg ICAgICAgICAgICAgZmlsZW5hbWUpKQogICAgICAgICAodHJhbXAtbWFrZS10cmFtcC1maWxl LW5hbWUKIAkgdmVjIChjb25jYXQgIn4iIChzdWJzdHJpbmcgZmlsZW5hbWUgKG1hdGNoLWJl Z2lubmluZyAxKSkpKQogICAgICAgKHRyYW1wLW1ha2UtdHJhbXAtZmlsZS1uYW1lICh0cmFt cC1kaXNzZWN0LWZpbGUtbmFtZSBmaWxlbmFtZSkpKSkpCi0tIAoyLjI1LjEKCg== --------------EED72BCE072C2BA326A623E3-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 16:51:25 2022 Received: (at 54001) by debbugs.gnu.org; 14 Feb 2022 21:51:25 +0000 Received: from localhost ([127.0.0.1]:42841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJjFk-0007bG-OE for submit@debbugs.gnu.org; Mon, 14 Feb 2022 16:51:24 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJjFj-0007az-2L for 54001@debbugs.gnu.org; Mon, 14 Feb 2022 16:51:23 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C9BC0100189; Mon, 14 Feb 2022 16:51:16 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5615C100008; Mon, 14 Feb 2022 16:51:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1644875475; bh=tUwQV7Aqsuls0CWifs3H8bqpC6Pj/WO0cG+63i1I1cE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=D/sX8arX9E0l2jgoQRlt/dnKToXM8Mb6+EOi2tmFb6AH2OIFblAjKODUXOUWpF2/J cMh8rmkpCsWDoaRCTvcLE4Z5ns4z35jXaAKPiUJVomsCMo1920n3gP4SoIf8SeBkEE nrk4RDCfV3nI6iwTalb+E8V6zYiU9NcjuEmNqmrX59nqiXUFrMA7udE4EnxHBUWGZq n+TAvG1fdsZfEBLA+EIXtq9gXtjClr/c7y0f/ynSiUrdDYVNABqkxvnGSZfRd3r2Yo /tfbQFPKWmWpXW/jSPs2SkLr0o+eJQvVUVLZLa2BzvftIg+5qijLRHKG+s0uAm2GXn rkS1dhf92805Q== Received: from ceviche (modemcable085.122-83-70.mc.videotron.ca [70.83.122.85]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 147DE12020D; Mon, 14 Feb 2022 16:51:15 -0500 (EST) From: Stefan Monnier To: Michael Albinus Subject: Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects Message-ID: References: <96603590-acc9-65d1-4086-7e2f114f9441@gmail.com> <506247fd-ed3a-f560-c8b5-1ece88cdfa76@gmail.com> Date: Mon, 14 Feb 2022 16:51:14 -0500 In-Reply-To: (Jim Porter's message of "Mon, 14 Feb 2022 13:38:58 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54001 Cc: Jim Porter , Daniel Mendler , 54001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter [2022-02-14 13:38:58] wrote: > I've only lightly tested this patch, but I think it should resolve the > issue. It only sets the "home-directory" connection property when > a connection is already established. Otherwise, it just uses the cached > value (if any). > > Maybe there's a cleaner way to do this though; opportunistically setting > a connection property like this seems like something there might be > a special function for in Tramp, but I didn't see one after a bit of looking > so this is what I went with. Thanks Jim. Michael, I assume you'll want to take care of this patch. Let me know if you prefer that I install it, of course, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 15 03:53:16 2022 Received: (at 54001) by debbugs.gnu.org; 15 Feb 2022 08:53:16 +0000 Received: from localhost ([127.0.0.1]:43436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJtaG-0001ZV-4p for submit@debbugs.gnu.org; Tue, 15 Feb 2022 03:53:16 -0500 Received: from mout.gmx.net ([212.227.15.15]:51755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJtaD-0001ZF-KG for 54001@debbugs.gnu.org; Tue, 15 Feb 2022 03:53:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1644915165; bh=z8tE5GR1cqVWtfVCTfj0BAbUwmeteodDfzRblpKQ5PU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=P3L9N/6hF5TECZvGI17GruD2e2X5fZrdp79gOvFW9jiyV1ESH9EQ4zOA6gEjGG5F8 TfkchXOtbKLb+fB1Wequf87tyzcKajgOb1R1SKrZdtXMTz3xJX+KdmbfPDSOUo/Zgh 5NHFYnB6X/DwlR+AgXoDN5cGJ8ecKSLmSxQydUc4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.158.128]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N4hzZ-1oJo0A2PdX-011igx; Tue, 15 Feb 2022 09:52:45 +0100 From: Michael Albinus To: Stefan Monnier Subject: Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects References: <96603590-acc9-65d1-4086-7e2f114f9441@gmail.com> <506247fd-ed3a-f560-c8b5-1ece88cdfa76@gmail.com> Date: Tue, 15 Feb 2022 09:52:43 +0100 In-Reply-To: (Stefan Monnier's message of "Mon, 14 Feb 2022 16:51:14 -0500") Message-ID: <874k50y0is.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:fEoMkK0HnYaCCle5+aLv7uwrSZ1nHgEqJz9KkXfSJbY1rLgS26a bc67f26DOLhSqvVKAZ4eA1iIIxCrWlCJSdGTcu/2FSpfFPjciqHaF/bLFvw7FUv4svglCcB jhHX7jgjAp03i95FE58pkRe/zP2F7tRG7UVgQXjQyi+C5zccXzLSu1Ede5R97LWNLYXUEdz y7bKTaRVcX84GCg27CODA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:GeYrEOh3iXw=:Ju6Qb3nAAAxHo7tKPmL+Hw dcSqU3sIp+jT7A5emzEVSEAwp6Vb+VHzsy7AG+4XqAtxFyZug1fyAGEVCcPNkQx4jbzrK8tgj UAp0h9toD8jE71qyADtQF4kBdA5ncmflPR2OAJAWtvy2rBNUuq1HVQV0g79n1ouYWO/ctotZU EONmAYa0dRB6eHXW7fwuj1QAkXO6iI2cuWRsSmd60JLc6Q7PeZlFKwe6JL8wEonk3qKgaWkkQ hm2bKa9eseF9ae8kqQNORjdZsctmQF94pCL0HZMjUlvcWNMqXJpgdKaPecl5ajH65ap5NHzkP NUq8LWqi1fXOCMftmp1GH7Xr0k7qWMrY6RW47HaQSZJ89ESx3Qy9PDMUVOXbg4Bcfl6yLYeSS ZOj/z0hO+7NorESzON0SuH2jtUyn4kCQpiJTrDxBCcVVFZJXaI2Kaz5VUDoQ7PolHVEZW3YqM k4v9HzYQQbr6aqn8AKXE59v9nTR1NdmtcxNZvI5GYHEnmYPikImaiJ7gkZsmkBnCrYdepn8N+ ohdCbnnJGIkM4peP2a/smBEAwVRXj1NMZQAqiCNnZTwvE9+zQPmqxnQbVkPWKJGEORCc+/64p oxxXwA98FNSSeTUa+TcK4HFsph/aqpdWSs9QVZSw/dR50BUmxobxX2UVB9I30zMnk7L7ZrFqL rZZ6ElPmRyzc5iOiz2C/uHKtPvD5r3PIIfh6FnMyLmgTlySwv3e6W+4wsuSCJUENFvHrVWrN7 FlMOAnVpCp7rE2uHZr4sUIv/WtGKVT7QIhx8F9WEg81QL1z6nh1RQLpqaVmGV2pMvrKfHEjQt s2fEHpQHPPhvSPfEaCtykcioD4Y4CqmwJPI6K03osHtYMCmQ5VoAu0Zb0CPDT/VEAcRL5p8hD XdghmzlxfyZ6ieadwco9vByWOIw3GLGfQdyc1SY6xTDdSD/M0XZ1e+RL7pZWTFjjjHPFClFpN XxCMjtQ94B03IzElNZvP2g/BBK1yMlJPwk5Ia+KSPvgGaZ3MDG58Vmorl+S2Y92WaT+F3VdSR xJEUKOFGgTVlQAvAFQDsDIR4sXLReTPqPXS0LX6Vz6rdDHlnMZOj5kYhmZ888DtkkKZay2itu jWShMWFY+LqVuw= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54001 Cc: Jim Porter , Daniel Mendler , 54001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: Hi Jim, Stefan, >> I've only lightly tested this patch, but I think it should resolve the >> issue. It only sets the "home-directory" connection property when >> a connection is already established. Otherwise, it just uses the cached >> value (if any). > > Thanks Jim. > > Michael, I assume you'll want to take care of this patch. Let me know > if you prefer that I install it, of course, Yes, it is OK. Please install. >> Maybe there's a cleaner way to do this though; opportunistically setting >> a connection property like this seems like something there might be >> a special function for in Tramp, but I didn't see one after a bit of looking >> so this is what I went with. I've recently made some changes for home directories in the other Tramp backends. Likely, I need to revise these settings once the patch has arrived on master. > Stefan Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 15 08:11:46 2022 Received: (at 54001-done) by debbugs.gnu.org; 15 Feb 2022 13:11:46 +0000 Received: from localhost ([127.0.0.1]:43803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJxcQ-0003Fp-K1 for submit@debbugs.gnu.org; Tue, 15 Feb 2022 08:11:46 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJxcO-0003FY-Ox for 54001-done@debbugs.gnu.org; Tue, 15 Feb 2022 08:11:45 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BFE48440B41; Tue, 15 Feb 2022 08:11:38 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6016C440B0F; Tue, 15 Feb 2022 08:11:37 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1644930697; bh=ztSyxOxVYijJ+ei2D0tdA9JwKVR5AAI/f7geE/qtJxE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EjwfSu9c12sbVTH+1VVPRbnS5xevXMmP+JUQBVf0l+/pxamyeaGB+De6nIqaJI2sB Y5vtNgjDpn3RuGiu/rFL1eGhjr/HjOdODFNcH5ebGNQBKQgoyTTisucJDrNMSqhoOb 9CQ7KiciNyyoD+UfmHRHdOmwMNW/yw3OoNHNCpEc4QHmidc5nC34FSi/gty5oB/AO+ BqHywGdMho0nrWhJANdRtgdfvBvsVL2e46IjCF5FOIKhp+JaULzlWS75TnSP1myBwd vDj4AtoT6BekLYFHUS98wHcXcVYXTbbkhwYdBSrs9GQc6u3gyxgJyt+u/d9Qigg2Bs 4g7BlD59cHXsQ== Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 277E4120329; Tue, 15 Feb 2022 08:11:37 -0500 (EST) From: Stefan Monnier To: Jim Porter Subject: Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects Message-ID: References: <96603590-acc9-65d1-4086-7e2f114f9441@gmail.com> <506247fd-ed3a-f560-c8b5-1ece88cdfa76@gmail.com> Date: Tue, 15 Feb 2022 08:11:35 -0500 In-Reply-To: (Jim Porter's message of "Mon, 14 Feb 2022 13:38:58 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54001-done Cc: Daniel Mendler , 54001-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I've only lightly tested this patch, but I think it should resolve the > issue. It only sets the "home-directory" connection property when > a connection is already established. Otherwise, it just uses the cached > value (if any). Thanks, pushed to master. And closing. Daniel, feel to ping us back if the fix isn't good enough. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 15 08:26:32 2022 Received: (at 54001-done) by debbugs.gnu.org; 15 Feb 2022 13:26:32 +0000 Received: from localhost ([127.0.0.1]:43812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJxqh-0003eR-Tn for submit@debbugs.gnu.org; Tue, 15 Feb 2022 08:26:32 -0500 Received: from server.qxqx.de ([178.63.65.180]:37481 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJxqf-0003e8-Cz for 54001-done@debbugs.gnu.org; Tue, 15 Feb 2022 08:26:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PGMNwzZxYrVEgqCJfjiOmW8t4got36y0ntIKFejNyiw=; b=C1y6WIXYU5pGHekEll+S3Boapn /SH2VEPKvEW50sj13l9qc5sX5LW7fmTXYzjOccVek5DGoSrKrbbHjX5n0rt8Wrwr7bJFWYr90v2wC DPHMJ5CorjyseuxzULsgmrSfk/e9w8fwnDsHnxBKZdsbJ20mUQxyrUKPlEcoy3JqNeTY=; Message-ID: <02551bd9-53f3-3554-9180-1bbd36ae002a@daniel-mendler.de> Date: Tue, 15 Feb 2022 14:26:21 +0100 MIME-Version: 1.0 Subject: Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects Content-Language: en-US To: Stefan Monnier , Jim Porter References: <96603590-acc9-65d1-4086-7e2f114f9441@gmail.com> <506247fd-ed3a-f560-c8b5-1ece88cdfa76@gmail.com> From: Daniel Mendler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54001-done Cc: 54001-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 2/15/22 14:11, Stefan Monnier wrote: >> I've only lightly tested this patch, but I think it should resolve the >> issue. It only sets the "home-directory" connection property when >> a connection is already established. Otherwise, it just uses the cached >> value (if any). > > Thanks, pushed to master. And closing. > Daniel, feel to ping us back if the fix isn't good enough. Thanks! I will if the issue comes up again. Daniel From unknown Mon Aug 18 04:38:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 16 Mar 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator