From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 11:39:10 2022 Received: (at submit) by debbugs.gnu.org; 14 Feb 2022 16:39:10 +0000 Received: from localhost ([127.0.0.1]:42391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJeNZ-0005mg-PN for submit@debbugs.gnu.org; Mon, 14 Feb 2022 11:39:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:35476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJeNY-0005mZ-CY for submit@debbugs.gnu.org; Mon, 14 Feb 2022 11:39:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJeNX-00019I-3M for guix-patches@gnu.org; Mon, 14 Feb 2022 11:39:08 -0500 Received: from [2001:470:142:3::e] (port=35162 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJeNG-00015Z-Mm; Mon, 14 Feb 2022 11:39:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=w1/KCYavO97RCSuSAdt97IO8jmOAuLvu4IfMIlG5xRE=; b=rp8AcBCk8Y6v04 INUwPr9F77qzfsYpkUIgSY8rs6ZCoY1Q0qQ0sv7SQsapHFjGxoz8sTWMOJp6O/LMR032GPvkS/jXJ cSJeh5Ftv5gSTPnBtMmCj/TtBES+PgNPVMUWGyGBEogFVvg3M0LPwGFfMsI/K32r2GVHAxJY+ei8y zbRGnuQCRzJ58DT+8NTDe+iGWxyI7SsPVWyYiYp+zL/ocA/zogejceVXrgSPwn95IkXSRQZTBhJBD z0vM9kAVwjy0g5Ato/u/S8pDTJaS4ZZM0uHL9NslHZL4MNDqm3Q8H4zwfeF3HtZC61zuSK367inYp WEkiJIPr0FCumrKNbbfA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56750 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJeND-0003B4-Iw; Mon, 14 Feb 2022 11:38:50 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/2] Not showing upgraded/added packages in 'guix pull' Date: Mon, 14 Feb 2022 17:38:38 +0100 Message-Id: <20220214163838.1174-1-ludo@gnu.org> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! As a followup to , these patches remove the list of added/upgraded packages from the output of ‘guix pull’ (upon completion) and ‘guix pull --news’. It’s not spring yet in this hemisphere, but it looks like a spring cleanup! Ludo’. Ludovic Courtès (2): pull: '--news' no longer shows package lists. pull: No longer print upgraded/added packages upon completion. doc/guix.texi | 10 ++--- guix/scripts/pull.scm | 98 +++++++++++++++++++++++-------------------- 2 files changed, 57 insertions(+), 51 deletions(-) base-commit: 41000d16c5c1586482a76d856c3152a6b8fcce8a -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 11:41:50 2022 Received: (at 54000) by debbugs.gnu.org; 14 Feb 2022 16:41:50 +0000 Received: from localhost ([127.0.0.1]:42407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJeQA-0005sb-HU for submit@debbugs.gnu.org; Mon, 14 Feb 2022 11:41:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJeQ9-0005sL-MK for 54000@debbugs.gnu.org; Mon, 14 Feb 2022 11:41:50 -0500 Received: from [2001:470:142:3::e] (port=35200 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJeQ4-0001pW-CU; Mon, 14 Feb 2022 11:41:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=0PJ+bJpVAn05qFtaavKnZQaDClSddbCAoIccmacGIM4=; b=Pb9uHz0YhGgLx4PQYQdo 13f1X5DTz8kJYKfFkGsdiEjQb1DbpHrL7ABTfDqGQew62YzCjAOJ3uetBgn2yejPRz4fEODznm/U+ q6KfqeaVtUzWEchfjkVJwM0r2C44+KB/MFWYcmsumBDGF+yekk88HMHTFtrBfK1xH1DpQtQrBCl/i 9Ipd0gHOBmHN7mr1fppYUUzVyTL3v710iwtXal3rU3AWst7KJ/K5LfvaK9yr3sh8X7nJ1r/pewlYQ kE1AwCUVTtKY4P4ZWlopuigivQSU6DE2NJXRtIi+XcmxdJ6Qi0vdExa0Q0aVrZuk73Q4jDmo6t+uu SuEGo80amTpC2g==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56752 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJeQ2-0003TG-Tr; Mon, 14 Feb 2022 11:41:44 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 54000@debbugs.gnu.org Subject: [PATCH 2/2] pull: No longer print upgraded/added packages upon completion. Date: Mon, 14 Feb 2022 17:41:27 +0100 Message-Id: <20220214164127.1248-2-ludo@gnu.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20220214164127.1248-1-ludo@gnu.org> References: <20220214164127.1248-1-ludo@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54000 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/scripts/pull.scm (build-and-install): Remove call to 'display-profile-news' and adjust accordingly. --- guix/scripts/pull.scm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm index af1b27d7dd..f557aaf79a 100644 --- a/guix/scripts/pull.scm +++ b/guix/scripts/pull.scm @@ -454,10 +454,9 @@ (define guix-command #:hooks %channel-profile-hooks) (return - (let ((more? (list (display-profile-news profile #:concise? #t) - (display-channel-news-headlines profile)))) + (let ((more? (display-channel-news-headlines profile))) (newline) - (when (any ->bool more?) + (when more? (display-hint (G_ "Run @command{guix pull --news} to read all the news."))))) (if guix-command -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 11:42:05 2022 Received: (at 54000) by debbugs.gnu.org; 14 Feb 2022 16:42:05 +0000 Received: from localhost ([127.0.0.1]:42410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJeQO-0005tg-PU for submit@debbugs.gnu.org; Mon, 14 Feb 2022 11:42:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJeQ8-0005sJ-LA for 54000@debbugs.gnu.org; Mon, 14 Feb 2022 11:42:03 -0500 Received: from [2001:470:142:3::e] (port=35196 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJeQ2-0001pE-KV; Mon, 14 Feb 2022 11:41:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=254UCkUIsfJ5cUqPTNyF0f83wlEIhI8E98dEK8FrvEk=; b=kiUxumpmQ0xNMC BS767d3r816EkQfw4Lxiq+yfYw+r9DyMu6V3n6rFmAXHlqxx3LwV3vKMyKoOTe737EjRLdiRnhVO/ ROl9C6wA39YkW1TjkOGV3u2JRu2hwSni99/Ldozn/vY61wO1SQ/Y2mrNQVlsryoS/oTWvABaifs/C 4zbmkxTjxmig5zKpRMzazO3DKCHNAj52p3Co2z2OJanzRHeTsU9JT/7048XPXyoJKB9avoLkm7KRr wpWdQG/uGSiQb7kk5zYfPew5cGczonzLvJNOLwPsC3ETWdZ3CjkSqU3p4zNg1b3GhHY7Yd1XNPVMt 5/j+cDLfV1L1Ta4O3pJg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56752 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJeQ0-0003TG-RK; Mon, 14 Feb 2022 11:41:42 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 54000@debbugs.gnu.org Subject: [PATCH 1/2] pull: '--news' no longer shows package lists. Date: Mon, 14 Feb 2022 17:41:26 +0100 Message-Id: <20220214164127.1248-1-ludo@gnu.org> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54000 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/scripts/pull.scm (display-channel-news): Return #t when news were displayed. (display-news): Remove call to 'display-profile-news'. Print something when there were no news. (process-query): For 'display-news', call 'display-channel-news' directly. * doc/guix.texi (Invoking guix pull): Adjust accordingly. --- doc/guix.texi | 10 ++--- guix/scripts/pull.scm | 93 ++++++++++++++++++++++++------------------- 2 files changed, 55 insertions(+), 48 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index a05f073c3d..534414ab8a 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -4486,13 +4486,11 @@ information. @cindex channel news @item --news @itemx -N -Display the list of packages added or upgraded since the previous -generation, as well as, occasionally, news written by channel authors -for their users (@pxref{Channels, Writing Channel News}). +Display news written by channel authors for their users for changes made +since the previous generation (@pxref{Channels, Writing Channel News}). -The package information is the same as displayed upon @command{guix -pull} completion, but without ellipses; it is also similar to the output -of @command{guix pull -l} for the last generation (see below). +You can view that information for previous generations with +@command{guix pull -l}. @item --list-generations[=@var{pattern}] @itemx -l [@var{pattern}] diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm index 205697b3bd..af1b27d7dd 100644 --- a/guix/scripts/pull.scm +++ b/guix/scripts/pull.scm @@ -352,45 +352,48 @@ (define* (display-channel-news profile (previous (and=> (relative-generation profile -1) (cut generation-file-name profile <>)))) - "Display news about the channels of PROFILE compared to PREVIOUS." - (when previous - (let ((old-channels (profile-channels previous)) - (new-channels (profile-channels profile))) - (and (pair? old-channels) (pair? new-channels) - (begin - (match (lset-difference channel=? new-channels old-channels) - (() - #t) - (new - (let ((count (length new))) - (format (current-error-port) - (N_ " ~a new channel:~%" - " ~a new channels:~%" count) - count) - (for-each display-channel new)))) - (match (lset-difference channel=? old-channels new-channels) - (() - #t) - (removed - (let ((count (length removed))) - (format (current-error-port) - (N_ " ~a channel removed:~%" - " ~a channels removed:~%" count) - count) - (for-each display-channel removed)))) + "Display news about the channels of PROFILE compared to PREVIOUS. Return +true if news were displayed, false otherwise." + (and previous + (let ((old-channels (profile-channels previous)) + (new-channels (profile-channels profile))) + (and (pair? old-channels) (pair? new-channels) + (begin + (match (lset-difference channel=? new-channels old-channels) + (() + #t) + (new + (let ((count (length new))) + (format (current-error-port) + (N_ " ~a new channel:~%" + " ~a new channels:~%" count) + count) + (for-each display-channel new)))) + (match (lset-difference channel=? old-channels new-channels) + (() + #t) + (removed + (let ((count (length removed))) + (format (current-error-port) + (N_ " ~a channel removed:~%" + " ~a channels removed:~%" count) + count) + (for-each display-channel removed)))) - ;; Display channel-specific news for those channels that were - ;; here before and are still around afterwards. - (for-each (match-lambda - ((new old) - (display-channel-specific-news new old))) - (filter-map (lambda (new) - (define old - (find (cut channel=? new <>) - old-channels)) + ;; Display channel-specific news for those channels that were + ;; here before and are still around afterwards. + (fold (match-lambda* + (((new old) news?) + (or (display-channel-specific-news new old) + news?))) + #f + (filter-map (lambda (new) + (define old + (find (cut channel=? new <>) + old-channels)) - (and old (list new old))) - new-channels))))))) + (and old (list new old))) + new-channels))))))) (define* (display-channel-news-headlines profile) "Display the titles of news about the channels of PROFILE compared to its @@ -422,12 +425,18 @@ (define more? (any ->bool more?)))))) (define (display-news profile) - ;; Display profile news, with the understanding that this process represents - ;; the newest generation. - (display-profile-news profile - #:current-is-newer? #t) + "Display channel news for PROFILE compared to its previous generation." + (define previous + (relative-generation profile -1)) - (display-channel-news profile)) + (if previous + (unless (display-channel-news profile + (generation-file-name profile previous)) + (info (G_ "no channel news since generation ~a~%") previous) + (display-hint (G_ "Run @command{guix pull -l} to view the +news for earlier generations."))) + (leave (G_ "profile ~a does not have a previous generation~%") + profile))) (define* (build-and-install instances profile) "Build the tool from SOURCE, and install it in PROFILE. When DRY-RUN? is -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 15 08:55:40 2022 Received: (at 54000) by debbugs.gnu.org; 15 Feb 2022 13:55:40 +0000 Received: from localhost ([127.0.0.1]:43841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJyIt-0004TW-SX for submit@debbugs.gnu.org; Tue, 15 Feb 2022 08:55:40 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:2009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJyIq-0004TM-MA for 54000@debbugs.gnu.org; Tue, 15 Feb 2022 08:55:37 -0500 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4JyjKF6K6rz1DHPk; Tue, 15 Feb 2022 14:55:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4JyjKF6K6rz1DHPk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1644933330; bh=y98sAPtXjcNSiGYm+z3vxvi9ogt0CkYiJKnbvXhZLaM=; h=Subject:From:To:Date:In-Reply-To:References:From; b=LZ7fQ8jUCwYkUJQNVD+wgL+XiJA1yJ/CsU/SZr4iKAhwVhwr1hdU6hrcVmrX9knEX YtN+IDBC1obbgOcJFn/gMY7ydFV5TpadOWg6vvf0BFcTwDCs5Q9eG9xRB1iJYiSuXk PLKvc4A9kGS3VYBDU818PEfLlqnk8Ga8Hfsj8v5c= Message-ID: <13cb5b9b650f86917e44db255f2ad92d679d3226.camel@ist.tugraz.at> Subject: Re: [PATCH 0/2] Not showing upgraded/added packages in 'guix pull' From: Liliana Marie Prikler To: Ludovic =?ISO-8859-1?Q?Court=E8s?= , 54000@debbugs.gnu.org Date: Tue, 15 Feb 2022 14:55:29 +0100 In-Reply-To: <20220214163838.1174-1-ludo@gnu.org> References: <20220214163838.1174-1-ludo@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54000 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Montag, dem 14.02.2022 um 17:38 +0100 schrieb Ludovic Courtès: > Hello! > > As a followup to , these patches > remove the list of added/upgraded packages from the output of > ‘guix pull’ (upon completion) and ‘guix pull --news’. > > It’s not spring yet in this hemisphere, but it looks like a spring > cleanup! > > Ludo’. > > Ludovic Courtès (2): >   pull: '--news' no longer shows package lists. >   pull: No longer print upgraded/added packages upon completion. What if I wanted that information however? Does `guix pull --news -- details` still give it to me? I don't really want to do `guix pull -l 1d --details` instead. Cheers From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 17 05:19:14 2022 Received: (at 54000) by debbugs.gnu.org; 17 Feb 2022 10:19:14 +0000 Received: from localhost ([127.0.0.1]:50226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKdsY-00030r-1V for submit@debbugs.gnu.org; Thu, 17 Feb 2022 05:19:14 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:56304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKdsV-00030a-JO for 54000@debbugs.gnu.org; Thu, 17 Feb 2022 05:19:12 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C32588DE; Thu, 17 Feb 2022 11:19:04 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z5yyd1moYq0f; Thu, 17 Feb 2022 11:19:03 +0100 (CET) Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 481CF12E; Thu, 17 Feb 2022 11:19:03 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Liliana Marie Prikler Subject: Re: [PATCH 0/2] Not showing upgraded/added packages in 'guix pull' References: <20220214163838.1174-1-ludo@gnu.org> <13cb5b9b650f86917e44db255f2ad92d679d3226.camel@ist.tugraz.at> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?utf-8?Q?Pluvi=C3=B4se?= an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 17 Feb 2022 11:19:02 +0100 In-Reply-To: <13cb5b9b650f86917e44db255f2ad92d679d3226.camel@ist.tugraz.at> (Liliana Marie Prikler's message of "Tue, 15 Feb 2022 14:55:29 +0100") Message-ID: <87fsohpzhl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: C32588DE X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 54000 Cc: 54000@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, Liliana Marie Prikler skribis: > Am Montag, dem 14.02.2022 um 17:38 +0100 schrieb Ludovic Court=C3=A8s: >> Hello! >>=20 >> As a followup to , these patches >> remove the list of added/upgraded packages from the output of >> =E2=80=98guix pull=E2=80=99 (upon completion) and =E2=80=98guix pull --n= ews=E2=80=99. [...] >> =C2=A0 pull: '--news' no longer shows package lists. >> =C2=A0 pull: No longer print upgraded/added packages upon completion. > What if I wanted that information however? Is it an actual use case or speculation? > Does `guix pull --news -- details` still give it to me? Not with this patch, but we could do that *if* there=E2=80=99s a need. > I don't really want to do `guix pull -l 1d --details` instead. OK. So far, my impression was that this information was hardly used at all, which is why it seemed reasonable to keep it behind =E2=80=98--details --list-generations=E2=80=99. I=E2=80=99m open to supporting =E2=80=98--news --details=E2=80=99, but only= if it corresponds to a real use case. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 17 05:30:59 2022 Received: (at 54000) by debbugs.gnu.org; 17 Feb 2022 10:30:59 +0000 Received: from localhost ([127.0.0.1]:50235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKe3v-0003L3-9w for submit@debbugs.gnu.org; Thu, 17 Feb 2022 05:30:59 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:26835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKe3t-0003Ku-KS for 54000@debbugs.gnu.org; Thu, 17 Feb 2022 05:30:58 -0500 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4JzrhC046dz3wZl; Thu, 17 Feb 2022 11:30:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1645093851; bh=crwES/ijuGaHDcLVRy/F2WtByVyRZgFobbKWo2h/m60=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=HV7XOt+jARQEaMafBeO9LGE1ylb+w2P3R7yndRLGx2X4ZvQBgC6o/G6MC0tG3yZ8j 4oLCSSsUy+v5UF+TM8ejOAx8jsGsRBY1rHG30qzkA485BtIQ6DYK+Ns6zy3r3STf7h yyIW4vW4j1/HwrkRiuJ42hYZH43JNNY5JE6fStvk= Message-ID: <31aeb5561e8aad5b5d5b235ff326f145a84863e3.camel@ist.tugraz.at> Subject: Re: [PATCH 0/2] Not showing upgraded/added packages in 'guix pull' From: Liliana Marie Prikler To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Date: Thu, 17 Feb 2022 11:30:50 +0100 In-Reply-To: <87fsohpzhl.fsf@gnu.org> References: <20220214163838.1174-1-ludo@gnu.org> <13cb5b9b650f86917e44db255f2ad92d679d3226.camel@ist.tugraz.at> <87fsohpzhl.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54000 Cc: 54000@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Ludo, Am Donnerstag, dem 17.02.2022 um 11:19 +0100 schrieb Ludovic Courtès: > Hi, > > Liliana Marie Prikler skribis: > > > Am Montag, dem 14.02.2022 um 17:38 +0100 schrieb Ludovic Courtès: > > > Hello! > > > > > > As a followup to , these > > > patches > > > remove the list of added/upgraded packages from the output of > > > ‘guix pull’ (upon completion) and ‘guix pull --news’. > > [...] > > > >   pull: '--news' no longer shows package lists. > > >   pull: No longer print upgraded/added packages upon completion. > > What if I wanted that information however? > > Is it an actual use case or speculation? That's a use case. While --dry-run exists, I don't really want it to serve double duty here. If I previously guix pulled and only three new packages were added, none of which I'm interested in, I would not have to meaninglessly run further build commands like guix package or guix system. Even if the list is potentially longer, I could visually grep for a few packages I'm interested in and determine whether it'd make sense to build now or wait for a little while as I'm processing other things. > > Does `guix pull --news -- details` still give it to me? > > Not with this patch, but we could do that *if* there’s a need. > > > I don't really want to do `guix pull -l 1d --details` instead. > > OK.  So far, my impression was that this information was hardly used > at all, which is why it seemed reasonable to keep it behind ‘-- > details --list-generations’. > > I’m open to supporting ‘--news --details’, but only if it corresponds > to a real use case. In general, it doesn't have to be named ‘--news --details’, but a means of diffing two generations via the CLI -- in particular the current one to the last -- would be very welcome, because then all information we previously had would still be available quite easily, albeit no longer printed by default. Cheers From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 17 07:13:45 2022 Received: (at 54000) by debbugs.gnu.org; 17 Feb 2022 12:13:45 +0000 Received: from localhost ([127.0.0.1]:50371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKffN-0002OP-FP for submit@debbugs.gnu.org; Thu, 17 Feb 2022 07:13:45 -0500 Received: from mail-wr1-f42.google.com ([209.85.221.42]:36482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKffM-0002OC-3d for 54000@debbugs.gnu.org; Thu, 17 Feb 2022 07:13:44 -0500 Received: by mail-wr1-f42.google.com with SMTP id o24so8674007wro.3 for <54000@debbugs.gnu.org>; Thu, 17 Feb 2022 04:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=P7XCi0VaG/J7MsqtY2VvvATRtPfk7eU2BzLqIbzoCVs=; b=OLFPEhYIVYyBhxPuDmaFYqS7N1DjYdxo6W7EOcrPqgmmucxNUmglyxJUbgOo10r91d lfFryUg3WLp8fU15U19gIY8z74WnuL64CJJSgz+Y28Pgi+Vcvni9Ozl3QWwP+i5falAd n6/eIcemJKw9sXfAMItrHEPEVb8TN38TQ+dME2NlvlaA3z+jNYuuVMt60pzlrWnltT9O KkRClOF0NDUpZIBijds4rtizrSIOCK9reVsmmCQIFu1iFMd+o78XOzzVTsSFXWZnZIjm PMa5LaO8FET+cOChQldNp8piJ6hjLvIY1084louJBYj+TzeNQzUWk367BQcqcYh2au6Y qHvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=P7XCi0VaG/J7MsqtY2VvvATRtPfk7eU2BzLqIbzoCVs=; b=ciU6PxhfrBkG/Odr3/vSswdRMyWyCwMitjYmgWexb2hLloEFJK7HZj8QXi9W5b3Yp8 LMJffHHMHdg8AmS7aItJLETy8sakciSkNUdWmAZjwJ6B/SwnMxO4kkaWQcW7979xR3Bh LoTdE+D+QBSaii32njs6H3ROlUcyuUm8FVG6JecisArU0de5Nyv9hlQHK9rmni1q1VbJ +VjjjfzfBjylaJb2UNWQxlHI3nShsYz4NfDR+ANzomnoFVp+Z848m2mhQA5onE+/ZoIq qTHvrDHdaDuO3kgFyPHV53BwT6JUB4F5Stc5XCwrwIa4kab33KewlP4tXcJYLdeHJoch r+kw== X-Gm-Message-State: AOAM531AcyMiMCpP0WnCl5sMAiXt4qiobCMvxVXY8tALvS3WG/8UC2nf EXtp5dlzXQJkGitwahqywiy6RsDopos= X-Google-Smtp-Source: ABdhPJydWzz/rUDzOqv8Vdp3+bWp7+bO832Oh9lE5SPjgybbpO6bPARBTDvh19WP+z8h9jtA5B7V+g== X-Received: by 2002:a5d:6482:0:b0:1e8:330e:e442 with SMTP id o2-20020a5d6482000000b001e8330ee442mr2131953wri.107.1645100017825; Thu, 17 Feb 2022 04:13:37 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id l11sm29061399wry.77.2022.02.17.04.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 04:13:37 -0800 (PST) From: zimoun To: Liliana Marie Prikler , Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#54000] [PATCH 0/2] Not showing upgraded/added packages in 'guix pull' In-Reply-To: <31aeb5561e8aad5b5d5b235ff326f145a84863e3.camel@ist.tugraz.at> References: <20220214163838.1174-1-ludo@gnu.org> <13cb5b9b650f86917e44db255f2ad92d679d3226.camel@ist.tugraz.at> <87fsohpzhl.fsf@gnu.org> <31aeb5561e8aad5b5d5b235ff326f145a84863e3.camel@ist.tugraz.at> Date: Thu, 17 Feb 2022 13:04:03 +0100 Message-ID: <86ley94s3w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54000 Cc: 54000@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, On Thu, 17 Feb 2022 at 11:30, Liliana Marie Prikler wrote: >> Is it an actual use case or speculation? > > That's a use case. While --dry-run exists, I don't really want it to > serve double duty here. If I previously guix pulled and only three new > packages were added, none of which I'm interested in, I would not have > to meaninglessly run further build commands like guix package or guix > system. Even if the list is potentially longer, I could visually grep > for a few packages I'm interested in and determine whether it'd make > sense to build now or wait for a little while as I'm processing other > things. Stats, ~24 updates and ~13 additions per day on average (over the past year). If you pull twice a day, then yes you can read this information. But, I bet people pull once a week, at best, so it looks like more =E2=80=9Cnoise=E2=80=9C and I guess most people miss the news. About grepping, it is not straightforward. For instance, I get this:=20 --8<---------------cut here---------------start------------->8--- $ guix pull --news | grep python=20 openshadinglanguage, perl-date-range, pgcli, plfit, poweralertd, pproxy= , python-aiosignal, python-android-backup, python-asdf-astropy, python-astral, python-astropy-healpix, python-astr= oquery, python-canvasapi, python-cmarkgfm, python-cucumber-tag-expressions, python-cython-next, python-doit, pytho= n-esprima, python-executing, python-flask-assets, python-flit-core-bootstrap, python-frozenlist, pyt= hon-fs, python-geojson, python-gwcs, python-ipython-sql, python-markdownify, python-miio, python-pgspecial, = python-photutils, python-phpserialize, python-piexif, python-psycopg, python-psycopg-pool, python-pydbus, pyth= on-pyftpdlib, python-pylru, python-pyowm, python-pypdf3, python-pyrss2gen, python-pyscss, python-pysendfile, pyth= on-pystitcher, python-pytest-doctest-custom, python-pytest-metadata, python-pytest-pyd= ocstyle, python-pyvo, python-reedsolo, python-regions, python-retry, python-roundrobin, python-sarge, python-s= entry-sdk, python-setuptools-rust, python-sphinx-click, python-sphinxcontrib-apidoc, python-tomli-w, pytho= n-tweepy, python-typeguard, --8<---------------cut here---------------end--------------->8--- So I do not think the current display is adequate for grepping. Somehow, the feature you want should be separated. For instance, guix pull --updated guix pull --added guix pull --new-versions > In general, it doesn't have to be named =E2=80=98--news --details=E2=80= =99, but a means > of diffing two generations via the CLI -- in particular the current one > to the last -- would be very welcome, because then all information we > previously had would still be available quite easily, albeit no longer > printed by default. That feature is interesting but it appears to me orthogonal with the current proposal. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 17 07:52:19 2022 Received: (at 54000) by debbugs.gnu.org; 17 Feb 2022 12:52:19 +0000 Received: from localhost ([127.0.0.1]:50402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKgGg-0005fE-PQ for submit@debbugs.gnu.org; Thu, 17 Feb 2022 07:52:19 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:32259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKgGd-0005f3-6D for 54000@debbugs.gnu.org; Thu, 17 Feb 2022 07:52:17 -0500 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4JzvqH5nSPz1LZWS; Thu, 17 Feb 2022 13:52:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4JzvqH5nSPz1LZWS DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1645102332; bh=MGammU/hv4lKirHmRvR3D27Wvom2NRynIIrpqUHc1Xw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=MVIsFMOvO0kG2m1FAtiTLHw7pVp0WSUUFH9Ndf8PRGaOsNOCTmeJkKTqPQHbIgU8V 8Q629f0MyprO8Q2huUBbpREhiHN3x+L1b2AhzLj6AkzQOtXm7eB5FrGxtBRuUzuqe2 pujBxlKf3Jk5fj6Ro0l0schHryjLq315s7BycpF0= Message-ID: <041a39d537297f3d0b1e829dcde05c0939eb6ccb.camel@ist.tugraz.at> Subject: Re: [bug#54000] [PATCH 0/2] Not showing upgraded/added packages in 'guix pull' From: Liliana Marie Prikler To: zimoun , Ludovic =?ISO-8859-1?Q?Court=E8s?= Date: Thu, 17 Feb 2022 13:52:11 +0100 In-Reply-To: <86ley94s3w.fsf@gmail.com> References: <20220214163838.1174-1-ludo@gnu.org> <13cb5b9b650f86917e44db255f2ad92d679d3226.camel@ist.tugraz.at> <87fsohpzhl.fsf@gnu.org> <31aeb5561e8aad5b5d5b235ff326f145a84863e3.camel@ist.tugraz.at> <86ley94s3w.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54000 Cc: 54000@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi zimoun, Am Donnerstag, dem 17.02.2022 um 13:04 +0100 schrieb zimoun: > Hi Liliana, > > Stats, ~24 updates and ~13 additions per day on average (over the > past year).  If you pull twice a day, then yes you can read this > information. > But, I bet people pull once a week, at best, so it looks like more > “noise“ and I guess most people miss the news. For the record, that's < 150 updates and < 100 additions per week. Of course, these numbers tend to get higher as Guix grows, but for now I personally find this both manageable and helpful. Which doesn't mean I want it done by default, just that I want a way of doing it. Furthermore, news are displayed at the bottom, so if you're not interested in the noise, just don't scroll up :P Granted, if you're piping the output to a pager, that doesn't help you. > About grepping, it is not straightforward.  For instance, I get this: > > --8<---------------cut here---------------start------------->8--- > $ guix pull --news | grep python >     openshadinglanguage, perl-date-range, pgcli, plfit, poweralertd, > pproxy, python-aiosignal, python-android-backup, >     python-asdf-astropy, python-astral, python-astropy-healpix, > python-astroquery, python-canvasapi, python-cmarkgfm, >     python-cucumber-tag-expressions, python-cython-next, python-doit, > python-esprima, python-executing, >     python-flask-assets, python-flit-core-bootstrap, python- > frozenlist, python-fs, python-geojson, python-gwcs, >     python-ipython-sql, python-markdownify, python-miio, python- > pgspecial, python-photutils, python-phpserialize, >     python-piexif, python-psycopg, python-psycopg-pool, python- > pydbus, python-pyftpdlib, python-pylru, python-pyowm, >     python-pypdf3, python-pyrss2gen, python-pyscss, python- > pysendfile, python-pystitcher, >     python-pytest-doctest-custom, python-pytest-metadata, python- > pytest-pydocstyle, python-pyvo, python-reedsolo, >     python-regions, python-retry, python-roundrobin, python-sarge, > python-sentry-sdk, python-setuptools-rust, >     python-sphinx-click, python-sphinxcontrib-apidoc, python-tomli-w, > python-tweepy, python-typeguard, > --8<---------------cut here---------------end--------------->8--- > > So I do not think the current display is adequate for grepping. I agree that with certain packages that's a little harder to do than with others, but particularly with python the way to resolve this would be to grep for 'python@' > Somehow, the feature you want should be separated.  For instance, > >     guix pull --updated >     guix pull --added >     guix pull --new-versions That would perhaps help if your aim is to optimize for computation time, but I'd still prefer all changes. It also helps that we already have that code, so we only have to tell people to e.g. use --changes instead of --news if that is the thing they wanted.   W.r.t. only listing some of the changes, one could later implement options like --changes=added,removed,updated,rewritten,... > > In general, it doesn't have to be named ‘--news --details’, but a > > means of diffing two generations via the CLI -- in particular the > > current one to the last -- would be very welcome, because then all > > information we previously had would still be available quite > > easily, albeit no longer printed by default. > > That feature is interesting but it appears to me orthogonal with the > current proposal. Orthogonal in which way? In that we could implement such a feature without changing the way `guix pull' normally works and vice versa? Sure. In that we'd not be losing any information if we changed `guix pull' without providing such an option? Eh... From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 17 09:45:48 2022 Received: (at 54000) by debbugs.gnu.org; 17 Feb 2022 14:45:49 +0000 Received: from localhost ([127.0.0.1]:50532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKi2W-0008Qs-FD for submit@debbugs.gnu.org; Thu, 17 Feb 2022 09:45:48 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:47089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKi2S-0008Qc-C5 for 54000@debbugs.gnu.org; Thu, 17 Feb 2022 09:45:47 -0500 Received: by mail-wr1-f49.google.com with SMTP id x5so4604179wrg.13 for <54000@debbugs.gnu.org>; Thu, 17 Feb 2022 06:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=O9WnyN7LLXuKwvZwj5auf7yWtWQcj1a31bcJKfSARRQ=; b=NLLPcN7FWcA78Rn4rdfRRuwg7TqSgDAS1EuOVLYYPhHC6JzZ7S8aI+f2gi7I5F/fzx mvZ60Wm231EQAvC+AgYgoFM/NVuE00CRAHVGp3I3kRYpXzqXYj8pva1xN8UthW6arUmF D/VgHMjCQwga+VnY5VltHI7KBYM56oBZQ3a3Y8rtk0tb0MpyrbmyLfDKB4MkckM+ruld x8NK0lT5Ly5E7emmn9lFUXGBba8FRkUahtrXyEIbhXk8ZiiypB2vWaVu8kQt+hwuuxgI uTQL1E2voX4dpMMdaIFZEFyBP0bc//xxymRLnvAISb+qKxdIAYGKeN1GP5eAdE2QdcPo NfyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=O9WnyN7LLXuKwvZwj5auf7yWtWQcj1a31bcJKfSARRQ=; b=gu/HCzjMV6j9VSirTHYu6XDKjzY7XH5bfUTezVN05wIdgzF42W5G6VjVuUsCFKuI+m xaq8MQ2jQKpysfy0knxMSqDpcK6tgh6QO/6J7iafTrMOcqPwKMzmAJmzw932PKDqhJ1s D1xz0CbN1t79I4ZvRt+oXFWYl+HwnGOQSAqGME2aQIT9A+ji4okzPpnlRIcKwRCitjFN miW8c7G35C0qQ48nqz+yGQshik9naXuA7ZqEHv7z3/01yh2kzUxGgtUr6bbA57ihJdfS r+QizcPZFmgCVGAKBw+/bFKCHMotXIh7eovv+Br9xV5czh6UWuV177vDAkffllV9WHBV xdCA== X-Gm-Message-State: AOAM532llaHS7g77NxcemHNl6I5Us36G/61IIzjtLbOdyTqMCPNa5GKP 1SeEuI7kGGGdGrkldk1U8SR6qpApbHg= X-Google-Smtp-Source: ABdhPJyKdqCaWW6baqFHJ4BUonDgHvZ0bZ/LyZG9SvV+5d/vHKZDasE6PlrabZTWTSIP+PdD6/Dk4w== X-Received: by 2002:a05:6000:2a2:b0:1e8:cbe2:16d7 with SMTP id l2-20020a05600002a200b001e8cbe216d7mr2237123wry.351.1645109138249; Thu, 17 Feb 2022 06:45:38 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id c3sm18893574wri.109.2022.02.17.06.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 06:45:37 -0800 (PST) From: zimoun To: Liliana Marie Prikler , Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#54000] [PATCH 0/2] Not showing upgraded/added packages in 'guix pull' In-Reply-To: <041a39d537297f3d0b1e829dcde05c0939eb6ccb.camel@ist.tugraz.at> References: <20220214163838.1174-1-ludo@gnu.org> <13cb5b9b650f86917e44db255f2ad92d679d3226.camel@ist.tugraz.at> <87fsohpzhl.fsf@gnu.org> <31aeb5561e8aad5b5d5b235ff326f145a84863e3.camel@ist.tugraz.at> <86ley94s3w.fsf@gmail.com> <041a39d537297f3d0b1e829dcde05c0939eb6ccb.camel@ist.tugraz.at> Date: Thu, 17 Feb 2022 15:41:17 +0100 Message-ID: <864k4x4ktu.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54000 Cc: 54000@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, On Thu, 17 Feb 2022 at 13:52, Liliana Marie Prikler wrote: >> Stats, ~24 updates and ~13 additions per day on average (over the >> past year).=C2=A0 If you pull twice a day, then yes you can read this >> information. >> But, I bet people pull once a week, at best, so it looks like more >> =E2=80=9Cnoise=E2=80=9C and I guess most people miss the news. > > For the record, that's < 150 updates and < 100 additions per week. Of > course, these numbers tend to get higher as Guix grows, but for now I > personally find this both manageable and helpful. Which doesn't mean I > want it done by default, just that I want a way of doing it. On my poor laptop, I barely pull. Last time, more than 2 weeks ago. --8<---------------cut here---------------start------------->8--- $ guix describe Generation 76 Feb 04 2022 11:15:54 (current) guix ff093f5 repository URL: https://git.savannah.gnu.org/git/guix.git branch: master commit: ff093f5739a61e77b296feccc48d260b9bb574c0 --8<---------------cut here---------------end--------------->8--- and a typical =E2=80=98guix pull --news=E2=80=99 looks like: --8<---------------cut here---------------start------------->8--- $ time guix pull --news New in this revision: 416 new packages: alfis, [...] 877 packages upgraded: amsynth@1.12.4, [...] News for channel 'guix' New `--execute' option to `guix deploy' commit 5c13484646069064c834bbd3cd02c3bc80d94cb6 The `guix deploy' command has a new `--execute' or `-x' option, which allows you to execute a command on all the machines that your configuration file specifies, as in this example: =20=20=20=20 guix deploy deploy.scm -x -- herd restart guix-daemon =20=20=20=20 This is no substitute for full-featured tools such as pdsh but it is a useful helper. `guix style' can format package definitions commit c4fe13c294cc1e31dd8a49ce3981f603fb169e0a The recently-introduced `guix style' command can now be used to automatically format package definitions according to the Guix project's formatting guidelines. If you contribute packages to Guix or to a third-party channel, you may find it useful. =20=20=20=20 The new `--styling' option can currently be passed one of the following "styling rules": `format', to format package definitions, or `inputs', to remove labels from package inputs. Omitting `--styling' is equivalent to passing `--styling=3Dformat'; previously it was equivalent to `--styling=3Dinputs'. =20=20=20=20 Run `info "(guix) Invoking guix style"', for more info. real 0m7.796s user 0m8.131s sys 0m0.500s --8<---------------cut here---------------end--------------->8--- > Furthermore, news are displayed at the bottom, so if you're not > interested in the noise, just don't scroll up :P > Granted, if you're piping the output to a pager, that doesn't help you. First, because it is too much information, I never do it. Second, because it is really slow, I never do it. Therefore, I never read the news. Well, I read them from Git, browsing after fetching. :-) Not sure it is adequate. I barely upgrade my base system =E2=80=93 I made it work once and just use = it =E2=80=93 and instead I heavily rely on time-machine and shell. I agree with your request and I understand the need. Even, I think diffing generations can be useful. But we should keep the default as simple and fast as possible. >> Somehow, the feature you want should be separated.=C2=A0 For instance, >>=20 >> =C2=A0=C2=A0=C2=A0 guix pull --updated >> =C2=A0=C2=A0=C2=A0 guix pull --added >> =C2=A0=C2=A0=C2=A0 guix pull --new-versions > > That would perhaps help if your aim is to optimize for computation > time, but I'd still prefer all changes. It also helps that we already > have that code, so we only have to tell people to e.g. use --changes > instead of --news if that is the thing they wanted. =C2=A0 > W.r.t. only listing some of the changes, one could later implement > options like --changes=3Dadded,removed,updated,rewritten,... We agree. My point was just to say that =E2=80=98--news --details=E2=80=99 is not the= correct UI for the feature you would like because, for instance, currently =E2=80=99--details=E2=80=99 alone is equivalent to =E2=80=99--details -l=E2= =80=99. Therefore, what happens if the user only provides =E2=80=99--details=E2=80=99? The option =E2=80=99--changes=3D=E2=80=99 makes also sense and it is probab= ly a good direction; instead of =E2=80=99--news --details=E2=80=99. Well, my point is just to say that the feature you want should be separated from =E2=80=98--news=E2=80=99. :-) >> That feature is interesting but it appears to me orthogonal with the >> current proposal. > > Orthogonal in which way? In that we could implement such a feature > without changing the way `guix pull' normally works and vice versa?=20 > Sure. In that we'd not be losing any information if we changed `guix > pull' without providing such an option? Eh... Well, from my point of view, =E2=80=98guix pull -l 1d --details=E2=80=99 fi= ts the job and I miss why it would be an issue; since such display would be barely used. To be precise, the option =E2=80=99-l=E2=80=99 should accept =E2=80=99last= =E2=80=99. From my point of view, it is better to have: guix pull --news # just the last news guix pull -l last --details (better meaming encourage people to read news :-) And we could also imagine some options as =E2=80=99--details=3Dadded=E2=80= =99. Note we could also imagine to make =E2=80=98guix git log=E2=80=99 show some informa= tion. Lot of imagination. ;-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 18 04:08:53 2022 Received: (at 54000) by debbugs.gnu.org; 18 Feb 2022 09:08:53 +0000 Received: from localhost ([127.0.0.1]:53435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKzG0-0003jw-SQ for submit@debbugs.gnu.org; Fri, 18 Feb 2022 04:08:53 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:58952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKzFz-0003ji-84 for 54000@debbugs.gnu.org; Fri, 18 Feb 2022 04:08:51 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id B44CABA9; Fri, 18 Feb 2022 10:08:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1Rg-et1aoRb6; Fri, 18 Feb 2022 10:08:44 +0100 (CET) Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe]) by hera.aquilenet.fr (Postfix) with ESMTPSA id BA999A2D; Fri, 18 Feb 2022 10:08:43 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: [bug#54000] [PATCH 0/2] Not showing upgraded/added packages in 'guix pull' References: <20220214163838.1174-1-ludo@gnu.org> <13cb5b9b650f86917e44db255f2ad92d679d3226.camel@ist.tugraz.at> <87fsohpzhl.fsf@gnu.org> <31aeb5561e8aad5b5d5b235ff326f145a84863e3.camel@ist.tugraz.at> <86ley94s3w.fsf@gmail.com> <041a39d537297f3d0b1e829dcde05c0939eb6ccb.camel@ist.tugraz.at> <864k4x4ktu.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 =?utf-8?Q?Pluvi=C3=B4se?= an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 18 Feb 2022 10:08:42 +0100 In-Reply-To: <864k4x4ktu.fsf@gmail.com> (zimoun's message of "Thu, 17 Feb 2022 15:41:17 +0100") Message-ID: <87k0dslexx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: B44CABA9 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 54000 Cc: Liliana Marie Prikler , 54000@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hey comrades, hold your horses! :-) Since there=E2=80=99s a need for this, we can make =E2=80=98--details=E2=80= =99 print package lists when combined with =E2=80=98--news=E2=80=99; it doesn=E2=80=99t cost = us anything, that=E2=80=99s OK. There may be a need for more general package version diffing and such things, but we can address it separately. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 18 04:20:43 2022 Received: (at 54000) by debbugs.gnu.org; 18 Feb 2022 09:20:43 +0000 Received: from localhost ([127.0.0.1]:53461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKzRT-00042M-DR for submit@debbugs.gnu.org; Fri, 18 Feb 2022 04:20:43 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:22139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKzRQ-00042C-Hn for 54000@debbugs.gnu.org; Fri, 18 Feb 2022 04:20:41 -0500 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4K0R4j3Pprz3xcZ; Fri, 18 Feb 2022 10:20:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1645176037; bh=K7nzH9ip7J4fu8BY1e17ksw+NPTcu+U/KdbcZpb2tNE=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=oqk74eShZqGtobc/yyblU1D+BmqMPyGnLLDm6/9AZ7aG1oTMh4Y3cxKE32zL1k+K4 PB3N1eYObUSS5tQ9kOoZGQ8PZFNwrH1gI2By9ie8lHS1Jwe44VfrVJgIXSuP/nNFuG cGwWMj9/q3NSGqjO7kbQf0I/OUgF1kE4OfzhZcno= Message-ID: <3456b0651ed89758801b8b68071859f0023b5638.camel@ist.tugraz.at> Subject: Re: [bug#54000] [PATCH 0/2] Not showing upgraded/added packages in 'guix pull' From: Liliana Marie Prikler To: Ludovic =?ISO-8859-1?Q?Court=E8s?= , zimoun Date: Fri, 18 Feb 2022 10:20:36 +0100 In-Reply-To: <87k0dslexx.fsf@gnu.org> References: <20220214163838.1174-1-ludo@gnu.org> <13cb5b9b650f86917e44db255f2ad92d679d3226.camel@ist.tugraz.at> <87fsohpzhl.fsf@gnu.org> <31aeb5561e8aad5b5d5b235ff326f145a84863e3.camel@ist.tugraz.at> <86ley94s3w.fsf@gmail.com> <041a39d537297f3d0b1e829dcde05c0939eb6ccb.camel@ist.tugraz.at> <864k4x4ktu.fsf@gmail.com> <87k0dslexx.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54000 Cc: 54000@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Freitag, dem 18.02.2022 um 10:08 +0100 schrieb Ludovic Courtès: > Hey comrades, hold your horses!  :-) > > Since there’s a need for this, we can make ‘--details’ print package > lists when combined with ‘--news’; it doesn’t cost us anything, > that’s OK. Regarding the issue simon raised w.r.t. --details implying -l, I think --details should only imply listing the latest generation if -l is not specified. That way --news --details would (hopefully) work as I intended, and specifying one without the other would only print that part. On a separate note, would/should guix describe be affected by this? Its output appear currently the same as `guix pull -l $CURRENT_GENERATION', but I haven't tested this on a generation including news. My guess would be "no" as guix describe currently doesn't accept --news. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 27 17:15:37 2022 Received: (at 54000-done) by debbugs.gnu.org; 27 Feb 2022 22:15:37 +0000 Received: from localhost ([127.0.0.1]:59493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nORpJ-0001cc-5k for submit@debbugs.gnu.org; Sun, 27 Feb 2022 17:15:37 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:56152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nORpG-0001Tp-J8 for 54000-done@debbugs.gnu.org; Sun, 27 Feb 2022 17:15:35 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 128F1399; Sun, 27 Feb 2022 23:15:29 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J19hxegC7N_H; Sun, 27 Feb 2022 23:15:28 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 276B213B; Sun, 27 Feb 2022 23:15:28 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Liliana Marie Prikler Subject: Re: bug#54000: [PATCH 0/2] Not showing upgraded/added packages in 'guix pull' References: <20220214163838.1174-1-ludo@gnu.org> <13cb5b9b650f86917e44db255f2ad92d679d3226.camel@ist.tugraz.at> <87fsohpzhl.fsf@gnu.org> <31aeb5561e8aad5b5d5b235ff326f145a84863e3.camel@ist.tugraz.at> <86ley94s3w.fsf@gmail.com> <041a39d537297f3d0b1e829dcde05c0939eb6ccb.camel@ist.tugraz.at> <864k4x4ktu.fsf@gmail.com> <87k0dslexx.fsf@gnu.org> <3456b0651ed89758801b8b68071859f0023b5638.camel@ist.tugraz.at> Date: Sun, 27 Feb 2022 23:15:27 +0100 In-Reply-To: <3456b0651ed89758801b8b68071859f0023b5638.camel@ist.tugraz.at> (Liliana Marie Prikler's message of "Fri, 18 Feb 2022 10:20:36 +0100") Message-ID: <87wnhgrm68.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: 128F1399 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,debbugs.gnu.org] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 54000-done Cc: 54000-done@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, Liliana Marie Prikler skribis: > Am Freitag, dem 18.02.2022 um 10:08 +0100 schrieb Ludovic Court=C3=A8s: >> Hey comrades, hold your horses!=C2=A0 :-) >>=20 >> Since there=E2=80=99s a need for this, we can make =E2=80=98--details=E2= =80=99 print package >> lists when combined with =E2=80=98--news=E2=80=99; it doesn=E2=80=99t co= st us anything, >> that=E2=80=99s OK. > Regarding the issue simon raised w.r.t. --details implying -l, I think > --details should only imply listing the latest generation if -l is not > specified. That way --news --details would (hopefully) work as I > intended, and specifying one without the other would only print that > part. Right, I went with something like you describe: 2ddfb7b99b pull: No longer print upgraded/added packages upon completion. bc8bea1739 pull: '--news' no longer shows package lists. That is, one can run =E2=80=98guix pull -N --details=E2=80=99 and get what = you asked for. Running =E2=80=98guix pull --details=E2=80=99 alone still implies =E2= =80=98-l=E2=80=99. Let me know if anything=E2=80=99s amiss. > On a separate note, would/should guix describe be affected by this?=20 > Its output appear currently the same as `guix pull -l > $CURRENT_GENERATION', but I haven't tested this on a generation > including news. My guess would be "no" as guix describe currently > doesn't accept --news. No, =E2=80=98guix describe=E2=80=99 doesn=E2=80=99t display news, profile c= hanges, and all that. It=E2=80=99s meant to just show the raw channel info. Thanks to both of you for your feedback! Ludo=E2=80=99. From unknown Sat Aug 16 19:17:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 28 Mar 2022 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator