GNU bug report logs - #53989
29.0.50; Gnus searches broken

Previous Next

Full log

View this message in rfc822 format

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 53989 <at> debbugs.gnu.org
Subject: bug#53989: 29.0.50; Gnus searches broken
Date: Fri, 18 Feb 2022 08:01:03 -0800

On 02/18/22 03:10 AM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> Okay, it turns out that also lets us drop most of the regexp silliness
>> from the parsing stuff. Would you mind trying the attached patch and
>> confirm that it doesn't break anything? I'll try to make this the last
>> time I mess with search results parsing...
>
> Works so far for me.
>
> | +(cl-defmethod gnus-search-indexed-extract :around
> | +  ((_engine gnus-search-indexed))
> | +  (let ((ret (cl-call-next-method)))
>
> Why do you need an :around method here - why don't you just add that to
> the primary method?

Hmm... I think I was originally trying to do more in this method --
prefix removal and all that. You're right this isn't necessary.

> | +    ;; We run `expand-file-name' here in order to collapse multiple
> | +    ;; consecutive directory separators.
> | +    (cl-callf expand-file-name (car ret))
> | +    ret))
>
> If I were you I would add to the comment that mairix may return such
> multi-separator file names - else it's not clear why that collapsing is
> necessary at that point.

I think I'd rather leave it like this. We don't know if the behavior
might appear under other circumstances, and in the end the real problem
is multiple separators, not mairix.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.