GNU bug report logs - #53964
[PATCH 0/4] Build nhc98 and ghc@4 with regular dependencies

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Sat, 12 Feb 2022 21:44:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53964 <at> debbugs.gnu.org
Subject: [bug#53964] [PATCH 3/4] gnu: ghc <at> 4: Build without referring to packages in commencement.scm.
Date: Mon, 14 Feb 2022 10:35:41 +0100

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Ludovic Courtès schreef op za 12-02-2022 om 22:45 [+0100]:
>> -       (patches (list (search-patch "ghc-4.patch")))))
>> +       (patches (search-patches "ghc-4.patch"))))
>
> Looks like an unrelated change to me.  From (guix)Submitting Patches:
>
>   13. Verify that your patch contains only one set of related changes.
>      Bundling unrelated changes together makes reviewing harder and
>      slower.
>
>      Examples of unrelated changes include the addition of several
>      packages, or a package update along with fixes to that package.
>
> Perhaps this is acceptable though for the same reasons removing
> trailing #t from phases is acceptable ...

You’re right, I can make it a different patch.

Ludo’.
This bug report was last modified 3 years and 155 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.