GNU bug report logs - #53959
[PATCH] installer: Continue even if Connman cannot phone home.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53959: closed ([PATCH] installer: Continue even if Connman
 cannot phone home.)
Date: Sat, 26 Feb 2022 15:14:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 26 Feb 2022 16:13:19 +0100
with message-id <20220226151319.6pnx2ouelahwmwqf <at> pelzflorian.localdomain>
and subject line Re: [bug#53959] [PATCH] installer: Continue even if Connman cannot phone home.
has caused the debbugs.gnu.org bug report #53959,
regarding [PATCH] installer: Continue even if Connman cannot phone home.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53959: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53959
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Florian Pelz <pelzflorian <at> pelzflorian.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] installer: Continue even if Connman cannot phone home.
Date: Sat, 12 Feb 2022 15:38:32 +0100

Connman's online check is unreliable for me.

* gnu/installer/connman.scm (connman-online?): Accept if
connman state is ready instead of online.
---
 gnu/installer/connman.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/installer/connman.scm b/gnu/installer/connman.scm
index 2f33b58453..6095d99947 100644
--- a/gnu/installer/connman.scm
+++ b/gnu/installer/connman.scm
@@ -287,7 +287,7 @@ (define (connman-disconnect service)
 
 (define (connman-online?)
   (let ((state (connman-state)))
-    (eq? state 'online)))
+    (member state '(ready online))))
 
 (define (connman-connect-with-auth service password-proc)
   "Connect to the given SERVICE with the password returned by calling

base-commit: 5996aab354831d942b10253bc70217a4f2e6a247
-- 
2.34.0

[Message part 3 (message/rfc822, inline)]

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: 53959-done <at> debbugs.gnu.org
Subject: Re: [bug#53959] [PATCH] installer: Continue even if Connman cannot
 phone home.
Date: Sat, 26 Feb 2022 16:13:19 +0100

On Sat, Feb 12, 2022 at 03:38:32PM +0100, Florian Pelz wrote:
>  (define (connman-online?)
>    (let ((state (connman-state)))
> -    (eq? state 'online)))
> +    (member state '(ready online))))


Pushed to master as cc11905568065409fe46487174e1cf404291bda1
using memq instead of member.

It will take effect once the guix package is updated.

Regards,
Florian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.