Subject: bug#53959: closed (Re: [bug#53959] [PATCH] installer: Continue even if Connman cannot phone home.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 26 Feb 2022 15:14:02 +0000

Your bug report

#53959: [PATCH] installer: Continue even if Connman cannot phone home.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
53959: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53959
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#53959] [PATCH] installer: Continue even if Connman cannot phone home.
From: "pelzflorian (Florian Pelz)" <[email-masked]>
To: [email-masked]
Date: Sat, 26 Feb 2022 16:13:19 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

On Sat, Feb 12, 2022 at 03:38:32PM +0100, Florian Pelz wrote:
>  (define (connman-online?)
>    (let ((state (connman-state)))
> -    (eq? state 'online)))
> +    (member state '(ready online))))

Pushed to master as cc11905568065409fe46487174e1cf404291bda1
using memq instead of member.

It will take effect once the guix package is updated.

Regards,
Florian

Subject: [PATCH] installer: Continue even if Connman cannot phone home.
From: Florian Pelz <[email-masked]>
To: [email-masked]
Date: Sat, 12 Feb 2022 15:38:32 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Connman's online check is unreliable for me.

* gnu/installer/connman.scm (connman-online?): Accept if
connman state is ready instead of online.
---
 gnu/installer/connman.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/installer/connman.scm b/gnu/installer/connman.scm
index 2f33b58453..6095d99947 100644
--- a/gnu/installer/connman.scm
+++ b/gnu/installer/connman.scm
@@ -287,7 +287,7 @@ (define (connman-disconnect service)
 
 (define (connman-online?)
   (let ((state (connman-state)))
-    (eq? state 'online)))
+    (member state '(ready online))))
 
 (define (connman-connect-with-auth service password-proc)
   "Connect to the given SERVICE with the password returned by calling

base-commit: 5996aab354831d942b10253bc70217a4f2e6a247
-- 
2.34.0