From unknown Sun Aug 17 04:19:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#53959] [PATCH] installer: Continue even if Connman cannot phone home. Resent-From: Florian Pelz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Feb 2022 14:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53959 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53959@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16446767349244 (code B ref -1); Sat, 12 Feb 2022 14:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Feb 2022 14:38:54 +0000 Received: from localhost ([127.0.0.1]:33819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nItY6-0002P1-BR for submit@debbugs.gnu.org; Sat, 12 Feb 2022 09:38:54 -0500 Received: from lists.gnu.org ([209.51.188.17]:50410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nItY4-0002Ou-HK for submit@debbugs.gnu.org; Sat, 12 Feb 2022 09:38:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nItY3-0001U9-V4 for guix-patches@gnu.org; Sat, 12 Feb 2022 09:38:52 -0500 Received: from pelzflorian.de ([5.45.111.108]:45792 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nItY1-0006uI-IX for guix-patches@gnu.org; Sat, 12 Feb 2022 09:38:51 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 5156F360632 for ; Sat, 12 Feb 2022 15:38:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1644676726; bh=77ms4Nq9Rj+hWYtX1gW8KT3L20yeGLcib80YDsYglRg=; h=Date:From:To:Subject; b=DG5zvpQk8QZk5BZbgW10evqCt55JPkoF1mHxhwji8nVIsk1nsb00lMRTaDk3IiT6s YsGzkzH3Mtxe37Pn3U1BVkyO926Ij/Zwf/OPCVeWYE7MVpi3axmU6eLCrpG6idM8s+ 1j8wZXw2XbbAQ5PEqB5XYmtJBsx2YXm6vkeE5sXE= Date: Sat, 12 Feb 2022 15:38:32 +0100 From: Florian Pelz Message-ID: <20220212143832.emgl7r3mdqfljgpe@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=5.45.111.108; envelope-from=pelzflorian@pelzflorian.de; helo=mail.pelzflorian.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Connman's online check is unreliable for me. * gnu/installer/connman.scm (connman-online?): Accept if connman state is ready instead of online. --- gnu/installer/connman.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/installer/connman.scm b/gnu/installer/connman.scm index 2f33b58453..6095d99947 100644 --- a/gnu/installer/connman.scm +++ b/gnu/installer/connman.scm @@ -287,7 +287,7 @@ (define (connman-disconnect service) (define (connman-online?) (let ((state (connman-state))) - (eq? state 'online))) + (member state '(ready online)))) (define (connman-connect-with-auth service password-proc) "Connect to the given SERVICE with the password returned by calling base-commit: 5996aab354831d942b10253bc70217a4f2e6a247 -- 2.34.0 From unknown Sun Aug 17 04:19:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Florian Pelz Subject: bug#53959: closed (Re: [bug#53959] [PATCH] installer: Continue even if Connman cannot phone home.) Message-ID: References: <20220226151319.6pnx2ouelahwmwqf@pelzflorian.localdomain> <20220212143832.emgl7r3mdqfljgpe@pelzflorian.localdomain> X-Gnu-PR-Message: they-closed 53959 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 53959@debbugs.gnu.org Date: Sat, 26 Feb 2022 15:14:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1645888442-12792-1" This is a multi-part message in MIME format... ------------=_1645888442-12792-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #53959: [PATCH] installer: Continue even if Connman cannot phone home. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 53959@debbugs.gnu.org. --=20 53959: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D53959 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1645888442-12792-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 53959-done) by debbugs.gnu.org; 26 Feb 2022 15:13:50 +0000 Received: from localhost ([127.0.0.1]:56111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNylX-0003Jc-As for submit@debbugs.gnu.org; Sat, 26 Feb 2022 10:13:49 -0500 Received: from pelzflorian.de ([5.45.111.108]:35336 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNylS-0003JP-4v for 53959-done@debbugs.gnu.org; Sat, 26 Feb 2022 10:13:46 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id BE5E0360632 for <53959-done@debbugs.gnu.org>; Sat, 26 Feb 2022 16:13:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1645888420; bh=Ua6MXJAmS7ixidd3focfkE9fc65tHEd0h4X4IZWipt8=; h=Date:From:To:Subject:References:In-Reply-To; b=qMxJwW0BUFhqIN7xNARLN5GlYrZLPryAIG8YPIKP3iDo13DHtfzTp3lJfCT+dCSeK MvHtfsT7zrIcBOC0YLmtt+r8HCeHg5CsHgyLWKPTm4ASL5xRya7/jTIajtY+jK+JHk A30q7EPeFxPadvPRkNav3p9yEiUfUxDzMIEgw0Hg= Date: Sat, 26 Feb 2022 16:13:19 +0100 From: "pelzflorian (Florian Pelz)" To: 53959-done@debbugs.gnu.org Subject: Re: [bug#53959] [PATCH] installer: Continue even if Connman cannot phone home. Message-ID: <20220226151319.6pnx2ouelahwmwqf@pelzflorian.localdomain> References: <20220212143832.emgl7r3mdqfljgpe@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220212143832.emgl7r3mdqfljgpe@pelzflorian.localdomain> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53959-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Feb 12, 2022 at 03:38:32PM +0100, Florian Pelz wrote: > (define (connman-online?) > (let ((state (connman-state))) > - (eq? state 'online))) > + (member state '(ready online)))) Pushed to master as cc11905568065409fe46487174e1cf404291bda1 using memq instead of member. It will take effect once the guix package is updated. Regards, Florian ------------=_1645888442-12792-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Feb 2022 14:38:54 +0000 Received: from localhost ([127.0.0.1]:33819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nItY6-0002P1-BR for submit@debbugs.gnu.org; Sat, 12 Feb 2022 09:38:54 -0500 Received: from lists.gnu.org ([209.51.188.17]:50410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nItY4-0002Ou-HK for submit@debbugs.gnu.org; Sat, 12 Feb 2022 09:38:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nItY3-0001U9-V4 for guix-patches@gnu.org; Sat, 12 Feb 2022 09:38:52 -0500 Received: from pelzflorian.de ([5.45.111.108]:45792 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nItY1-0006uI-IX for guix-patches@gnu.org; Sat, 12 Feb 2022 09:38:51 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 5156F360632 for ; Sat, 12 Feb 2022 15:38:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1644676726; bh=77ms4Nq9Rj+hWYtX1gW8KT3L20yeGLcib80YDsYglRg=; h=Date:From:To:Subject; b=DG5zvpQk8QZk5BZbgW10evqCt55JPkoF1mHxhwji8nVIsk1nsb00lMRTaDk3IiT6s YsGzkzH3Mtxe37Pn3U1BVkyO926Ij/Zwf/OPCVeWYE7MVpi3axmU6eLCrpG6idM8s+ 1j8wZXw2XbbAQ5PEqB5XYmtJBsx2YXm6vkeE5sXE= Date: Sat, 12 Feb 2022 15:38:32 +0100 From: Florian Pelz To: guix-patches@gnu.org Subject: [PATCH] installer: Continue even if Connman cannot phone home. Message-ID: <20220212143832.emgl7r3mdqfljgpe@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=5.45.111.108; envelope-from=pelzflorian@pelzflorian.de; helo=mail.pelzflorian.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Connman's online check is unreliable for me. * gnu/installer/connman.scm (connman-online?): Accept if connman state is ready instead of online. --- gnu/installer/connman.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/installer/connman.scm b/gnu/installer/connman.scm index 2f33b58453..6095d99947 100644 --- a/gnu/installer/connman.scm +++ b/gnu/installer/connman.scm @@ -287,7 +287,7 @@ (define (connman-disconnect service) (define (connman-online?) (let ((state (connman-state))) - (eq? state 'online))) + (member state '(ready online)))) (define (connman-connect-with-auth service password-proc) "Connect to the given SERVICE with the password returned by calling base-commit: 5996aab354831d942b10253bc70217a4f2e6a247 -- 2.34.0 ------------=_1645888442-12792-1--