GNU bug report logs -
#53943
[PATCH] Add python-stltools
Previous Next
Reported by: Evgeny Pisemsky <evgeny <at> pisemsky.com>
Date: Fri, 11 Feb 2022 19:01:01 UTC
Severity: normal
Tags: patch
Done: Ludovic Courtès <ludo <at> gnu.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53943 in the body.
You can then email your comments to 53943 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org:
bug#53943; Package
guix-patches.
(Fri, 11 Feb 2022 19:01:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Evgeny Pisemsky <evgeny <at> pisemsky.com>:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org.
(Fri, 11 Feb 2022 19:01:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello!
The source of this package contains custom setup.py script, which does
not work with python-build-system, so I just copied files around in
package definition, and this seems worked.
However, I am not sure if it is an appropriate way of intallation.
[0001-gnu-Add-python-stltools.patch (text/x-patch, inline)]
From c6fcae5568da38a66e67947f6d20d7228923c626 Mon Sep 17 00:00:00 2001
From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
Date: Fri, 11 Feb 2022 19:55:13 +0300
Subject: [PATCH] gnu: Add python-stltools.
* gnu/packages/python-xyz.scm (python-stltools): New variable.
---
gnu/packages/python-xyz.scm | 44 +++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 41b60325d2..e72d5baed7 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -116,6 +116,7 @@
;;; Copyright © 2021 Greg Hogan <code <at> greghogan.com>
;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
;;; Copyright © 2022 Aleksandr Vityazev <avityazev <at> posteo.org>
+;;; Copyright © 2022 Evgeny Pisemsky <evgeny <at> pisemsky.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -28933,3 +28934,46 @@ (define-public python-types-dataclasses
"This packages provides a collection of library stubs for Python, with
static types.")
(license license:asl2.0)))
+
+(define-public python-stltools
+ (package
+ (name "python-stltools")
+ (version "2022.01.20")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/rsmith-nl/stltools")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1k6dhszza4lpy46qffaqx5zr70ikfqqysbacy7zabnrvz09fd4rs"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:use-setuptools? #f
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'build)
+ (replace 'install
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let ((moddir (string-append (site-packages inputs outputs) "/stltools"))
+ (bindir (string-append (assoc-ref outputs "out") "/bin")))
+ (copy-recursively "stltools" moddir)
+ (mkdir-p bindir)
+ (for-each
+ (lambda (script)
+ (let ((source (string-append script ".py"))
+ (target (string-append bindir "/" script)))
+ (copy-file source target)
+ (chmod target #o555)))
+ '("stl2pov" "stl2ps" "stl2pdf" "stlinfo")))))
+ (replace 'check
+ (lambda _
+ (invoke "py.test" "-v"))))))
+ (propagated-inputs (list python-pycairo))
+ (native-inputs (list python-pytest))
+ (home-page "https://github.com/rsmith-nl/stltools")
+ (synopsis "Tools to manipulate STL files")
+ (description "Python modules and scripts for handling
+stereolithography (STL) files.")
+ (license license:expat)))
base-commit: 6baf2177df36bc33e79f1c71198dfe04d242efb2
--
2.34.0
Information forwarded
to
guix-patches <at> gnu.org:
bug#53943; Package
guix-patches.
(Fri, 25 Feb 2022 17:52:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 53943 <at> debbugs.gnu.org (full text, mbox):
Any feedback?
Information forwarded
to
guix-patches <at> gnu.org:
bug#53943; Package
guix-patches.
(Fri, 25 Feb 2022 19:50:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 53943 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Evgeny Pisemsky schreef op vr 11-02-2022 om 22:00 [+0300]:
> + (replace 'check
> + (lambda _
> + (invoke "py.test" "-v"))))))
For cross-compilation and to make "--without-tests" work, this phase
needs to respect #:tests?, try
(replace 'check
(lambda* (#:key tests? #:allow-other-keys)
(when tests?
(invoke "py.test" "-v")))))))
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#53943; Package
guix-patches.
(Fri, 25 Feb 2022 19:52:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 53943 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Evgeny Pisemsky schreef op vr 11-02-2022 om 22:00 [+0300]:
> + `(#:use-setuptools? #f
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'build)
> + [replace the install phase]
Most of the time (but not always!), the default build and install
phases and the default of #:use-setuptools? is fine. Could you
elaborate what is the issue?
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#53943; Package
guix-patches.
(Fri, 25 Feb 2022 19:56:01 GMT)
Full text and
rfc822 format available.
Message #17 received at 53943 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Evgeny Pisemsky schreef op vr 11-02-2022 om 22:00 [+0300]:
> + (description "Python modules and scripts for handling
> +stereolithography (STL) files.")
Perhaps the description can be extended a bit? Maybe:
"This package consists of Python modules and scripts for manipulating
stereolithography (STL) files. It can convert STL files into POV-ray
meshes, PDF and PostScript. The Python modules allow for reading
and writing STL files. It supports both the text and binary forms
of STL."
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#53943; Package
guix-patches.
(Fri, 25 Feb 2022 19:59:02 GMT)
Full text and
rfc822 format available.
Message #20 received at 53943 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Maxime Devos schreef op vr 25-02-2022 om 20:51 [+0100]:
> Evgeny Pisemsky schreef op vr 11-02-2022 om 22:00 [+0300]:
> > + `(#:use-setuptools? #f
> > + #:phases
> > + (modify-phases %standard-phases
> > + (delete 'build)
> > + [replace the install phase]
>
> Most of the time (but not always!), the default build and install
> phases and the default of #:use-setuptools? is fine. Could you
> elaborate what is the issue?
Nevermind, I now see the original message you sent. Still seems
suboptimal though ...
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#53943; Package
guix-patches.
(Fri, 25 Feb 2022 20:03:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 53943 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Evgeny Pisemsky schreef op vr 11-02-2022 om 22:00 [+0300]:
> + (arguments
> + `(#:use-setuptools? #f
> + #:phases
> + (modify-phases %standard-phases
To make sure that 'stl2pov' and friends of 'python-sltools' can find
its dependencies when run outside a profile (somewhat niche but
occassionaly useful), some wrapping may be necessary (search for 'wrap-
program'). Maybe python-build-system does that automatically though
...
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#53943; Package
guix-patches.
(Mon, 28 Feb 2022 06:01:01 GMT)
Full text and
rfc822 format available.
Message #26 received at 53943 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Thank you for suggestions!
Here is the updated patch.
[0001-gnu-Add-python-stltools.patch (text/x-patch, inline)]
From 8fec01fed636b43a14230d1a4556d01e8c3cf223 Mon Sep 17 00:00:00 2001
From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
Date: Fri, 11 Feb 2022 19:55:13 +0300
Subject: [PATCH] gnu: Add python-stltools.
* gnu/packages/python-xyz.scm (python-stltools): New variable.
---
gnu/packages/python-xyz.scm | 47 +++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index c05502388e..c981ccb709 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -116,6 +116,7 @@
;;; Copyright © 2021 Greg Hogan <code <at> greghogan.com>
;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
;;; Copyright © 2022 Aleksandr Vityazev <avityazev <at> posteo.org>
+;;; Copyright © 2022 Evgeny Pisemsky <evgeny <at> pisemsky.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -29034,3 +29035,49 @@ (define-public python-types-ujson
used by type-checking tools like mypy, PyCharm, pytype etc. to check code that
uses ujson.")
(license license:asl2.0)))
+
+(define-public python-stltools
+ (package
+ (name "python-stltools")
+ (version "2022.01.20")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/rsmith-nl/stltools")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1k6dhszza4lpy46qffaqx5zr70ikfqqysbacy7zabnrvz09fd4rs"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:use-setuptools? #f
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'build)
+ (replace 'install
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let ((moddir (string-append (site-packages inputs outputs) "/stltools"))
+ (bindir (string-append (assoc-ref outputs "out") "/bin")))
+ (copy-recursively "stltools" moddir)
+ (mkdir-p bindir)
+ (for-each
+ (lambda (script)
+ (let ((source (string-append script ".py"))
+ (target (string-append bindir "/" script)))
+ (copy-file source target)
+ (chmod target #o555)))
+ '("stl2pov" "stl2ps" "stl2pdf" "stlinfo")))))
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ (invoke "py.test" "-v")))))))
+ (propagated-inputs (list python-pycairo))
+ (native-inputs (list python-pytest))
+ (home-page "https://github.com/rsmith-nl/stltools")
+ (synopsis "Python modules and scripts for handling STL files")
+ (description "This package consists of Python modules and scripts for
+manipulating stereolithography (STL) files. It can convert STL files into
+POV-ray meshes, PDF and PostScript. The Python modules allow for reading and
+writing STL files. It supports both the text and binary forms of STL.")
+ (license license:expat)))
base-commit: 61a847187d781bcecdc77fbec1fb75d1b9531e55
--
2.34.0
Reply sent
to
Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility.
(Sun, 06 Mar 2022 21:20:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Evgeny Pisemsky <evgeny <at> pisemsky.com>:
bug acknowledged by developer.
(Sun, 06 Mar 2022 21:20:02 GMT)
Full text and
rfc822 format available.
Message #31 received at 53943-done <at> debbugs.gnu.org (full text, mbox):
Hi,
Evgeny Pisemsky <evgeny <at> pisemsky.com> skribis:
>>From 8fec01fed636b43a14230d1a4556d01e8c3cf223 Mon Sep 17 00:00:00 2001
> From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
> Date: Fri, 11 Feb 2022 19:55:13 +0300
> Subject: [PATCH] gnu: Add python-stltools.
>
> * gnu/packages/python-xyz.scm (python-stltools): New variable.
Applied. Thanks you, and thanks Maxime for reviewing!
Ludo’.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Mon, 04 Apr 2022 11:24:06 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 75 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.